Re: [Spice-devel] bad id bug in glz decoder

2018-04-26 Thread Christophe Fergeau
On Thu, Apr 26, 2018 at 01:53:41AM -0400, Frediano Ziglio wrote: > > Hi Ziglio, > > > I was wondering if you have had a chance to look at the email below yet. > > > Best regards, > > Zhongqiang Huang > > Yes, weird, usually git CC people in the commit message, but see > > https://lists.freedes

Re: [Spice-devel] bad id bug in glz decoder

2018-04-25 Thread Frediano Ziglio
> Hi Ziglio, > I was wondering if you have had a chance to look at the email below yet. > Best regards, > Zhongqiang Huang Yes, weird, usually git CC people in the commit message, but see https://lists.freedesktop.org/archives/spice-devel/2018-April/043230.html this was acked and merged. C

Re: [Spice-devel] bad id bug in glz decoder

2018-04-23 Thread Usepr Xf
I found this code in glz_encoder.c in spice-server: static inline void encode_64(Encoder *encoder, uint64_t word) { encode_32(encoder, (uint32_t)(word >> 32)); encode_32(encoder, (uint32_t)(word & 0xff)); // <- is it wrong? 0xff should be deleted } On Fri, Apr 13, 2018 at

Re: [Spice-devel] bad id bug in glz decoder

2018-04-13 Thread Frediano Ziglio
> Hi all, > Sorry to be a bother. > After a long time running of glz encode&decode (approx. 4hrs), I came across > this error. > The higher bits (> 24) of the image id is truncated, which makes dist less > than id . This error seems to happen when the dist across (1<<24) Is normal that dist is

Re: [Spice-devel] bad id bug in glz decoder

2018-04-13 Thread Victor Toso
Hi, On Wed, Apr 11, 2018 at 12:28:15PM +0800, Usepr Xf wrote: > Hi all, > > Sorry to be a bother. Thanks for taking the time to report this. > After a long time running of glz encode&decode (approx. 4hrs), > I came across this error. It is windows client, correct? Could you confirm remote-view

Re: [Spice-devel] bad id bug in glz decoder

2018-04-13 Thread Usepr Xf
Hello all, I was wondering if you have had a chance to look at the e-mail below yet? It's about the wrong id problem of glz algorithm. Many thanks On Wed, Apr 11, 2018 at 12:28 PM, Usepr Xf wrote: > Hi all, > > Sorry to be a bother. > > After a long time running of glz encode&decode (approx. 4