> Some general comments:
>
> - You have this pattern where you assign a string to a global variable
> and then you assign that variable to a field instead of the string
> itself. If this really is necessary, I think the string should just be
> cast instead. I haven't been able to make gcc ge
Hey,
On Wed, Sep 12, 2012 at 05:06:44AM +0200, Søren Sandmann wrote:
> Jeremy White writes:
>
> > The following patch series remove nearly all warnings from
> > xf86-video-qxl.
>
> Some general comments:
>
> - You have this pattern where you assign a string to a global variable
> and then yo
Jeremy White writes:
> The following patch series remove nearly all warnings from
> xf86-video-qxl.
Some general comments:
- You have this pattern where you assign a string to a global variable
and then you assign that variable to a field instead of the string
itself. If this really is nece
> The following patch series remove nearly all warnings from
> xf86-video-qxl.
>
> The final one does not remove a warning, but documents the related
> code
> with a TODO as the warning appears to be correct.
>
> You still get a large number of redudant decl warnings from two xorg
> include
> fil
The following patch series remove nearly all warnings from xf86-video-qxl.
The final one does not remove a warning, but documents the related code
with a TODO as the warning appears to be correct.
You still get a large number of redudant decl warnings from two xorg include
files even with this; a
