Hey, On Wed, Sep 12, 2012 at 05:06:44AM +0200, Søren Sandmann wrote: > Jeremy White <jwh...@codeweavers.com> writes: > > > The following patch series remove nearly all warnings from > > xf86-video-qxl. > > Some general comments: > > - You have this pattern where you assign a string to a global variable > and then you assign that variable to a field instead of the string > itself. If this really is necessary, I think the string should just be > cast instead. I haven't been able to make gcc generate that warning > though. Which option did you use?
When I looked at this, this was caused by -Wcast-qual, and I tried to address it with http://lists.freedesktop.org/archives/spice-devel/2012-May/008998.html Alon ACK'ed it, but I've never pushed it :-/ In light of this patch series, we can consider this patch as an alternative if it helps. Christophe
pgpypmIpqeSRq.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
