Re: [Spice-devel] [spice-xpi PATCHv2 1/2] Handle USB-related plugin properties

2012-04-10 Thread Christophe Fergeau
On Sun, Apr 08, 2012 at 03:01:20PM +0300, Uri Lublin wrote: > On 04/04/2012 05:29 PM, Christophe Fergeau wrote: > >Next question -- which is not really a problem for now since the various > >properties are only sent once after the client has started -- is how do we > >unset a previously set filter

Re: [Spice-devel] [spice-xpi PATCHv2 1/2] Handle USB-related plugin properties

2012-04-08 Thread Uri Lublin
On 04/04/2012 05:29 PM, Christophe Fergeau wrote: Hey Uri, On Wed, Apr 04, 2012 at 12:33:17PM +0300, Uri Lublin wrote: The default is an empty string. How does the client behave with such a filter string? Refuse redir for all devices ? That's a good question, thanks for pointing this out. The

Re: [Spice-devel] [spice-xpi PATCHv2 1/2] Handle USB-related plugin properties

2012-04-04 Thread Christophe Fergeau
Hey Uri, On Wed, Apr 04, 2012 at 12:33:17PM +0300, Uri Lublin wrote: > The default is an empty string. > How does the client behave with such a filter string? Refuse redir > for all devices ? That's a good question, thanks for pointing this out. The good news is that the filter is sent using Sen

Re: [Spice-devel] [spice-xpi PATCHv2 1/2] Handle USB-related plugin properties

2012-04-04 Thread Hans de Goede
Hi, On 04/04/2012 11:33 AM, Uri Lublin wrote: On 04/04/2012 11:03 AM, Christophe Fergeau wrote: The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter method that were not wired until now. This commit propagates their value to the nsPluginInstance object and send them through

Re: [Spice-devel] [spice-xpi PATCHv2 1/2] Handle USB-related plugin properties

2012-04-04 Thread Uri Lublin
On 04/04/2012 11:03 AM, Christophe Fergeau wrote: The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter method that were not wired until now. This commit propagates their value to the nsPluginInstance object and send them through the controller socket. --- SpiceXPI/src/plugi

[Spice-devel] [spice-xpi PATCHv2 1/2] Handle USB-related plugin properties

2012-04-04 Thread Christophe Fergeau
The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter method that were not wired until now. This commit propagates their value to the nsPluginInstance object and send them through the controller socket. --- SpiceXPI/src/plugin/plugin.cpp | 18 -- SpiceXPI/src/