Re: [Spice-devel] [spice-protocol] Use gcc builtin rather than asm for memory barriers

2016-01-10 Thread Uri Lublin
On 01/08/2016 11:41 AM, Frediano Ziglio wrote: On Thu, Jan 07, 2016 at 09:35:34PM +0200, Uri Lublin wrote: On 01/06/2016 12:26 PM, Christophe Fergeau wrote: This should make things more portable. Hi Christophe, This only works for building with (not too old) gcc. It would be safer to check

Re: [Spice-devel] [spice-protocol] Use gcc builtin rather than asm for memory barriers

2016-01-08 Thread Frediano Ziglio
> > On Thu, Jan 07, 2016 at 09:35:34PM +0200, Uri Lublin wrote: > > On 01/06/2016 12:26 PM, Christophe Fergeau wrote: > > >This should make things more portable. > > > > Hi Christophe, > > > > This only works for building with (not too old) gcc. > > > > It would be safer to check that in config

Re: [Spice-devel] [spice-protocol] Use gcc builtin rather than asm for memory barriers

2016-01-08 Thread Christophe Fergeau
On Thu, Jan 07, 2016 at 09:35:34PM +0200, Uri Lublin wrote: > On 01/06/2016 12:26 PM, Christophe Fergeau wrote: > >This should make things more portable. > > Hi Christophe, > > This only works for building with (not too old) gcc. > > It would be safer to check that in configure and > add a condi

Re: [Spice-devel] [spice-protocol] Use gcc builtin rather than asm for memory barriers

2016-01-07 Thread Uri Lublin
On 01/06/2016 12:26 PM, Christophe Fergeau wrote: This should make things more portable. Hi Christophe, This only works for building with (not too old) gcc. It would be safer to check that in configure and add a conditional here. Thanks, Uri. https://bugs.freedesktop.org/show_bug.cgi?

[Spice-devel] [spice-protocol] Use gcc builtin rather than asm for memory barriers

2016-01-06 Thread Christophe Fergeau
This should make things more portable. https://bugs.freedesktop.org/show_bug.cgi?id=86997 --- spice/barrier.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/spice/barrier.h b/spice/barrier.h index 710da09..7d63721 100644 --- a/spice/barrier.h +++ b/spice/barrier.h @@ -3