Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread Uri Lublin
On 06/05/2013 07:08 PM, Uri Lublin wrote: On 06/05/2013 03:21 PM, Christophe Fergeau wrote: On Wed, Jun 05, 2013 at 01:07:16PM +0300, Uri Lublin wrote: In your example, query is "my_param=/some/path" and path points to "/some/path" within query. Some may find it confusing, and it does not fol

Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread Uri Lublin
On 06/05/2013 03:21 PM, Christophe Fergeau wrote: On Wed, Jun 05, 2013 at 01:07:16PM +0300, Uri Lublin wrote: In your example, query is "my_param=/some/path" and path points to "/some/path" within query. Some may find it confusing, and it does not follow URI syntax where path comes before query

Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread Christophe Fergeau
On Wed, Jun 05, 2013 at 02:48:54PM +0200, David Jaša wrote: > IIRC there used to be a generic parser for URIs in glib that was removed > at some point of time, didn't you think about making this code more > generic so that each and every URI-parsing glib app doesn't have to go > through these hoops

Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread David Jaša
Just for the record: path is part of hierarchical part of the uri that begins with double slash "//". Query part of the URI starts with question mark "?" and it is followed by Fragment part that starts with hash "#". So this is perfectly legal URI: spice://fqdn?param=value that contain just schem

Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread Christophe Fergeau
On Wed, Jun 05, 2013 at 01:07:16PM +0300, Uri Lublin wrote: > In your example, query is "my_param=/some/path" and path points > to "/some/path" within query. Some may find it confusing, and it does not > follow URI syntax where path comes before query (IIUC). This is not meant to move the 'path' p

Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread Uri Lublin
On 06/05/2013 11:23 AM, Christophe Fergeau wrote: On Wed, Jun 05, 2013 at 11:15:47AM +0300, Uri Lublin wrote: On 06/04/2013 05:19 PM, Christophe Fergeau wrote: When parsing an URI, spice_uri_parse currently first looks up for '/' to detect the 'path' part of the URI (http://foo.example.com/some

Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread Christophe Fergeau
On Wed, Jun 05, 2013 at 11:15:47AM +0300, Uri Lublin wrote: > On 06/04/2013 05:19 PM, Christophe Fergeau wrote: > >When parsing an URI, spice_uri_parse currently first looks up for > >'/' to detect the 'path' part of the URI > >(http://foo.example.com/some/path) and then the query part (starting >

Re: [Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-05 Thread Uri Lublin
On 06/04/2013 05:19 PM, Christophe Fergeau wrote: When parsing an URI, spice_uri_parse currently first looks up for '/' to detect the 'path' part of the URI (http://foo.example.com/some/path) and then the query part (starting with '&' is looked up). However, this does not work as expected when th

[Spice-devel] [spice-gtk 2/5] session: Lookup URI query part before path part

2013-06-04 Thread Christophe Fergeau
When parsing an URI, spice_uri_parse currently first looks up for '/' to detect the 'path' part of the URI (http://foo.example.com/some/path) and then the query part (starting with '&' is looked up). However, this does not work as expected when the host name is not followed by a path, but the query