Re: [Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-08 Thread Christophe Fergeau
On Tue, Mar 07, 2017 at 10:05:13AM -0500, Frediano Ziglio wrote: > > The answer you probably want is to "Why we do in this way instead of doing > at lower level?" > This would require a way to say "now flush data" if you don't want > to reimplement some sort of "smart" Nagle algorithm, which we ar

Re: [Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-07 Thread Frediano Ziglio
> > On Tue, Mar 07, 2017 at 12:35:35PM +, Frediano Ziglio wrote: > > Send header and reply together. > > This potentially save up to 160 bytes on the network. > > This as sending multiple chunks you can have different framing, > > specifically: > > - if you use TLS every chunk get encrypted se

Re: [Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-07 Thread Christophe Fergeau
On Tue, Mar 07, 2017 at 12:35:35PM +, Frediano Ziglio wrote: > Send header and reply together. > This potentially save up to 160 bytes on the network. > This as sending multiple chunks you can have different framing, > specifically: > - if you use TLS every chunk get encrypted separately > (r

[Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-07 Thread Frediano Ziglio
Send header and reply together. This potentially save up to 160 bytes on the network. This as sending multiple chunks you can have different framing, specifically: - if you use TLS every chunk get encrypted separately (reds-stream, currently usually 29 bytes for every chunks); - tcp settings and

Re: [Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-06 Thread Christophe Fergeau
On Mon, Mar 06, 2017 at 11:36:16AM -0500, Frediano Ziglio wrote: > > > > > On Mon, Mar 06, 2017 at 04:12:33PM +, Frediano Ziglio wrote: > > > Send header and reply together > > > > The log is missing a "Why?" > > > > Potentially to safe up to 160 bytes! And this is not worth mentioning in

Re: [Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-06 Thread Frediano Ziglio
> > On Mon, Mar 06, 2017 at 04:12:33PM +, Frediano Ziglio wrote: > > Send header and reply together > > The log is missing a "Why?" > Potentially to safe up to 160 bytes! > > > > Signed-off-by: Frediano Ziglio > > --- > > server/reds.c | 56 > > +---

Re: [Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-06 Thread Christophe Fergeau
On Mon, Mar 06, 2017 at 04:12:33PM +, Frediano Ziglio wrote: > Send header and reply together The log is missing a "Why?" > > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 56 +--- > 1 file changed, 29 insertions(+), 27 deletions

[Spice-devel] [PATCH spice-server] reds: Send link replies with less chunks

2017-03-06 Thread Frediano Ziglio
Send header and reply together Signed-off-by: Frediano Ziglio --- server/reds.c | 56 +--- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/server/reds.c b/server/reds.c index fc720a3..e94d0c4 100644 --- a/server/reds.c +++ b/ser