Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-26 Thread Christophe Fergeau
On Tue, Nov 26, 2013 at 05:32:44PM +0100, Marc-André Lureau wrote: > On Tue, Nov 26, 2013 at 5:29 PM, Christophe Fergeau > wrote: > > Getting a bit tired of having to ask multiple times the same question... > > > > Did the g_reutrn_val_if_fail trigger in some situation, if yes, is there > > ano

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-26 Thread Marc-André Lureau
On Tue, Nov 26, 2013 at 5:29 PM, Christophe Fergeau wrote: > Getting a bit tired of having to ask multiple times the same question... > Did the g_reutrn_val_if_fail trigger in some situation, if yes, is there > another place we need to fix, ... Having all the information about the No, but it wo

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-26 Thread Christophe Fergeau
On Tue, Nov 26, 2013 at 05:26:01PM +0100, Marc-André Lureau wrote: > Unless you have further concerns or alternative solutions, I am > considering this reviewed, please ack. Getting a bit tired of having to ask multiple times the same question... Did the g_reutrn_val_if_fail trigger in some situat

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-26 Thread Marc-André Lureau
Unless you have further concerns or alternative solutions, I am considering this reviewed, please ack. On Tue, Nov 26, 2013 at 12:27 PM, Marc-André Lureau wrote: > On Tue, Nov 26, 2013 at 12:24 PM, Christophe Fergeau > wrote: >> On Mon, Nov 25, 2013 at 08:41:27AM -0500, Marc-André Lureau wrote:

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-26 Thread Marc-André Lureau
On Tue, Nov 26, 2013 at 12:24 PM, Christophe Fergeau wrote: > On Mon, Nov 25, 2013 at 08:41:27AM -0500, Marc-André Lureau wrote: >> >> >> - Original Message - >> > On Mon, Nov 25, 2013 at 02:31:10PM +0100, Marc-André Lureau wrote: >> > > On Mon, Nov 25, 2013 at 1:41 PM, Christophe Fergeau

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-26 Thread Christophe Fergeau
On Mon, Nov 25, 2013 at 08:41:27AM -0500, Marc-André Lureau wrote: > > > - Original Message - > > On Mon, Nov 25, 2013 at 02:31:10PM +0100, Marc-André Lureau wrote: > > > On Mon, Nov 25, 2013 at 1:41 PM, Christophe Fergeau > > > wrote: > > > > On Mon, Nov 25, 2013 at 01:33:52PM +0100, Ma

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-25 Thread Marc-André Lureau
- Original Message - > On Mon, Nov 25, 2013 at 02:31:10PM +0100, Marc-André Lureau wrote: > > On Mon, Nov 25, 2013 at 1:41 PM, Christophe Fergeau > > wrote: > > > On Mon, Nov 25, 2013 at 01:33:52PM +0100, Marc-André Lureau wrote: > > >> Check that there is an actual stream before calling

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-25 Thread Christophe Fergeau
On Mon, Nov 25, 2013 at 02:31:10PM +0100, Marc-André Lureau wrote: > On Mon, Nov 25, 2013 at 1:41 PM, Christophe Fergeau > wrote: > > On Mon, Nov 25, 2013 at 01:33:52PM +0100, Marc-André Lureau wrote: > >> Check that there is an actual stream before calling cork(). > > > > Is it expected that we

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-25 Thread Marc-André Lureau
On Mon, Nov 25, 2013 at 1:41 PM, Christophe Fergeau wrote: > On Mon, Nov 25, 2013 at 01:33:52PM +0100, Marc-André Lureau wrote: >> Check that there is an actual stream before calling cork(). > > Is it expected that we are getting called with a non-NULL stream in the > first place? Since this is s

Re: [Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-25 Thread Christophe Fergeau
On Mon, Nov 25, 2013 at 01:33:52PM +0100, Marc-André Lureau wrote: > Check that there is an actual stream before calling cork(). Is it expected that we are getting called with a non-NULL stream in the first place? > > https://bugzilla.redhat.com/show_bug.cgi?id=1032785 > --- > gtk/spice-pulse.c

[Spice-devel] [PATCH spice-gtk] pulse: do not abort on corking no stream

2013-11-25 Thread Marc-André Lureau
Check that there is an actual stream before calling cork(). https://bugzilla.redhat.com/show_bug.cgi?id=1032785 --- gtk/spice-pulse.c | 5 - spice-common | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gtk/spice-pulse.c b/gtk/spice-pulse.c index 5e214c8..c4241d0 10