On Tue, Nov 26, 2013 at 05:32:44PM +0100, Marc-André Lureau wrote: > On Tue, Nov 26, 2013 at 5:29 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > Getting a bit tired of having to ask multiple times the same question... > > > > Did the g_reutrn_val_if_fail trigger in some situation, if yes, is there > > another place we need to fix, ... Having all the information about the > > No, but it would have been easier to catch that the problem was in > spice-gtk in the first place. > > > why/how/.. in the commit log in the first place would really help the > > review. > > > We don't have the same expectations. For me this is a trivial > pre-condition check that was there before for other caller (nothing > new).
There was no explanation either for the other patch of the patch, and this is not just for this patch. ACK for the patch with improved commit log. Christophe
pgpfRnup1bqHl.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
