Re: [Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-27 Thread Hans de Goede
Hi, On 03/27/2013 03:51 PM, Marc-André Lureau wrote: - Mensaje original - Hi, On 03/27/2013 01:57 PM, Marc-André Lureau wrote: On Wed, Mar 27, 2013 at 1:52 PM, Hans de Goede wrote: Really a function named try_keyboard_ungrab, should not touch the mouse_grab, it is as simple as tha

Re: [Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-27 Thread Marc-André Lureau
- Mensaje original - > Hi, > > On 03/27/2013 01:57 PM, Marc-André Lureau wrote: > > On Wed, Mar 27, 2013 at 1:52 PM, Hans de Goede > > wrote: > >> Really a function named try_keyboard_ungrab, should not touch the > >> mouse_grab, it is as simple as that. > > > > This argument doesn't ho

Re: [Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-27 Thread Hans de Goede
Hi, On 03/27/2013 01:57 PM, Marc-André Lureau wrote: On Wed, Mar 27, 2013 at 1:52 PM, Hans de Goede wrote: Really a function named try_keyboard_ungrab, should not touch the mouse_grab, it is as simple as that. This argument doesn't hold. If you prefer I rename it to "ungrab_keyboard_and_poin

Re: [Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-27 Thread Marc-André Lureau
On Wed, Mar 27, 2013 at 1:52 PM, Hans de Goede wrote: > Really a function named try_keyboard_ungrab, should not touch the > mouse_grab, it is as simple as that. This argument doesn't hold. If you prefer I rename it to "ungrab_keyboard_and_pointer" for example. Having only a pointer grab is a non

Re: [Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-27 Thread Hans de Goede
Hi, On 03/27/2013 01:41 PM, Marc-André Lureau wrote: On Wed, Mar 27, 2013 at 11:54 AM, Hans de Goede wrote: I would like to see the above block changed to: if (event->keyboard) { try_keyboard_ungrab(self); try_mouse_ungrab(self); } else { This should also fix th

Re: [Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-27 Thread Marc-André Lureau
On Wed, Mar 27, 2013 at 11:54 AM, Hans de Goede wrote: > I would like to see the above block changed to: > > if (event->keyboard) { > try_keyboard_ungrab(self); > try_mouse_ungrab(self); > } else { > > This should also fix the issue you're trying to fix. With the added >

Re: [Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-27 Thread Hans de Goede
Hi, On 03/26/2013 09:33 PM, Marc-André Lureau wrote: On windows, the client receives a WM_KILLFOCUS event which generates solely a keyboard grab-broken event. This event is received when pressing ctrl-alt-del (to show up the task manager), and we need to release the pointer grab and clip region

[Spice-devel] [PATCH spice-gtk] RFC: release pointer grab on grab-broken

2013-03-26 Thread Marc-André Lureau
On windows, the client receives a WM_KILLFOCUS event which generates solely a keyboard grab-broken event. This event is received when pressing ctrl-alt-del (to show up the task manager), and we need to release the pointer grab and clip region in this case for the client to be usable. This also cl