Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOSUP from setsockopt calls

2012-03-09 Thread Nahum Shalman
On 03/09/2012 11:15 AM, Daniel P. Berrange wrote: Huh. This code already avoids failure when you get ENOTSUP. You're removing the code path where the errno is *not* ENOTSUP You're right. I need to go back and figure out which error we were getting. Thank you. -Nahum _

Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOSUP from setsockopt calls

2012-03-09 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 10:39:21AM -0500, Nahum Shalman wrote: > These are the only instances in the code base where functions fail as a > result of setsockopt calls returning ENOSUP. > Those calls will always return ENOSUP when we are listening on a UNIX > socket rather than a TCP port. > We'd pre

[Spice-devel] [PATCH 1/2] server: don't fail on ENOSUP from setsockopt calls

2012-03-09 Thread Nahum Shalman
These are the only instances in the code base where functions fail as a result of setsockopt calls returning ENOSUP. Those calls will always return ENOSUP when we are listening on a UNIX socket rather than a TCP port. We'd prefer not to fail. --- server/inputs_channel.c |1 - server/spicevmc.c