On Fri, Mar 09, 2012 at 10:39:21AM -0500, Nahum Shalman wrote:
> These are the only instances in the code base where functions fail as a
> result of setsockopt calls returning ENOSUP.
> Those calls will always return ENOSUP when we are listening on a UNIX
> socket rather than a TCP port.
> We'd prefer not to fail.
Huh. This code already avoids failure when you get ENOTSUP. You're
removing the code path where the errno is *not* ENOTSUP
> server/inputs_channel.c | 1 -
> server/spicevmc.c | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/server/inputs_channel.c b/server/inputs_channel.c
> index a3f26c0..3cae408 100644
> --- a/server/inputs_channel.c
> +++ b/server/inputs_channel.c
> @@ -472,7 +472,6 @@ static int inputs_channel_config_socket(RedChannelClient
> *rcc)
> &delay_val, sizeof(delay_val)) == -1) {
> if (errno != ENOTSUP) {
> red_printf("setsockopt failed, %s", strerror(errno));
> - return FALSE;
> }
> }
>
> diff --git a/server/spicevmc.c b/server/spicevmc.c
> index 30aaf2f..2967bcd 100644
> --- a/server/spicevmc.c
> +++ b/server/spicevmc.c
> @@ -94,7 +94,6 @@ static int
> spicevmc_red_channel_client_config_socket(RedChannelClient *rcc)
> &delay_val, sizeof(delay_val)) != 0) {
> if (errno != ENOTSUP) {
> red_printf("setsockopt failed, %s", strerror(errno));
> - return FALSE;
> }
> }
> }
> --
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
