Re: [Spice-devel] Closing gitlab spice mirror

2018-07-10 Thread Yedidyah Bar David
On Tue, Jul 10, 2018 at 9:55 PM, Jonathon Jongsma wrote: > On Tue, 2018-07-10 at 18:00 +0200, Victor Toso wrote: > > Hi, > > > > Similarly to closing github spice mirror [0], I'd like to propose > > closing the gitlab.com/spice one now that we have a gitlab > > instance in gitlab.freedesktop.org

Re: [Spice-devel] [NSIS] Do not install .pdb debug files on the target system

2018-01-02 Thread Yedidyah Bar David
Adding Lev and Christophe. On Mon, Jan 1, 2018 at 10:15 AM, Yedidyah Bar David wrote: > Usually they are not needed, and needlessly take quite a lot of space on > the target system. > > Do publish them in the ISO, so that they are easily available if needed. &

Re: [Spice-devel] [nsis v3 2/2] build: Don't add .pdb debug files to the installer

2018-01-01 Thread Yedidyah Bar David
On Sun, Dec 31, 2017 at 5:00 PM, Vadim Rozenfeld wrote: > > > On 31/12/17 19:24, Yan Vugenfirer wrote: > > > > On 31 Dec 2017, at 08:55, Yedidyah Bar David wrote: > > On Fri, Dec 29, 2017 at 3:36 AM, Vadim Rozenfeld > wrote: > > > > On 29/12/17 03:3

[Spice-devel] [NSIS] Do not install .pdb debug files on the target system

2018-01-01 Thread Yedidyah Bar David
Usually they are not needed, and needlessly take quite a lot of space on the target system. Do publish them in the ISO, so that they are easily available if needed. Change-Id: I6dfa5f5e904ea63513f30f4418e58ad2654cf486 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 2 +- 1 file

Re: [Spice-devel] [nsis v3 2/2] build: Don't add .pdb debug files to the installer

2017-12-30 Thread Yedidyah Bar David
On Sun, Dec 31, 2017 at 8:55 AM, Yedidyah Bar David wrote: > On Fri, Dec 29, 2017 at 3:36 AM, Vadim Rozenfeld > wrote: > > > > > > On 29/12/17 03:31, Yan Vugenfirer wrote: > > > > > > > > On 28 Dec 2017, at 16:44, Amnon Ilan wrote: > >

Re: [Spice-devel] [nsis v3 2/2] build: Don't add .pdb debug files to the installer

2017-12-30 Thread Yedidyah Bar David
On Fri, Dec 29, 2017 at 3:36 AM, Vadim Rozenfeld wrote: > > > On 29/12/17 03:31, Yan Vugenfirer wrote: > > > > On 28 Dec 2017, at 16:44, Amnon Ilan wrote: > > > > - Original Message ----- > > From: "Lev Veyde" > To: "Yedidyah

Re: [Spice-devel] [nsis v3 2/2] build: Don't add .pdb debug files to the installer

2017-12-20 Thread Yedidyah Bar David
On Wed, Dec 20, 2017 at 4:10 PM, Frediano Ziglio wrote: >> >> On Tue, Dec 19, 2017 at 11:26:00AM -0500, Frediano Ziglio wrote: >> > > >> > > The .pdb files contain the debug information for the drivers. They >> > > increase significantly the size of the installer, so it's better not to >> > > ship

[Spice-devel] [NSIS] packaging: bump version to 4.3

2017-12-05 Thread Yedidyah Bar David
Change-Id: I1bfcf05a48d3af8226061f47d76ba64e9a16c61a Signed-off-by: Yedidyah Bar David --- ovirt-guest-tools-iso.spec.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in index 04fee49..19ed5c9 100644 --- a/ovirt

Re: [Spice-devel] [NSIS] automation: add standard ci support

2017-10-17 Thread Yedidyah Bar David
On Tue, Oct 17, 2017 at 12:30 PM, Christophe Fergeau wrote: > On Mon, Oct 16, 2017 at 05:01:14PM +0300, Yedidyah Bar David wrote: >> On Mon, Oct 16, 2017 at 4:16 PM, Yedidyah Bar David wrote: >> > On Mon, Oct 16, 2017 at 4:07 PM, Christophe Fergeau >> > wrote: >

Re: [Spice-devel] [NSIS] automation: add standard ci support

2017-10-16 Thread Yedidyah Bar David
On Mon, Oct 16, 2017 at 4:16 PM, Yedidyah Bar David wrote: > On Mon, Oct 16, 2017 at 4:07 PM, Christophe Fergeau > wrote: >> My understanding is that the short log really should be saying "oVirt CI >> support" rather than "standard CI support". > >

Re: [Spice-devel] [NSIS] automation: add standard ci support

2017-10-16 Thread Yedidyah Bar David
e automatically. > Are there any sanity > checks done on the generated packages? Not yet. All we currently have is current patch. > Or is this just testing the > build? Indeed. > > Christophe > > On Mon, Oct 16, 2017 at 03:59:27PM +0300, Yedidyah Bar David wrote: &

Re: [Spice-devel] [nsis] Properly quote path to service binaries

2017-10-16 Thread Yedidyah Bar David
Looks good to me. Minor comment below. Adding also others. On Mon, Oct 16, 2017 at 4:03 PM, Christophe Fergeau wrote: > If these paths are unquoted, and the path contains spaces (C:\Program > Files (x86)\...), this could be exploited by putting a binary with a > crafted name (C:\Program.exe), lea

[Spice-devel] [NSIS] automation: add standard oVirt CI support

2017-10-16 Thread Yedidyah Bar David
From: Sandro Bonazzola This patch was previously merged in ovirt gerrit with Change-Id Ie16cc0902c4393e62b074661a86f2f5bb9a1efc1, but removed from master branch there for review on spice-devel. For reference: https://www.ovirt.org/develop/dev-process/build-and-test-standards/ Change-Id: I042f3

[Spice-devel] [NSIS] automation: add standard ci support

2017-10-16 Thread Yedidyah Bar David
From: Sandro Bonazzola This patch was previously merged in ovirt gerrit with Change-Id Ie16cc0902c4393e62b074661a86f2f5bb9a1efc1, but removed from master branch there for review on spice-devel. Change-Id: I042f30d87b0730ae76e2c8b537e46a56cbbf65f7 Signed-off-by: Sandro Bonazzola --- automation/

[Spice-devel] [NSIS] automation: add standard ci support

2017-10-16 Thread Yedidyah Bar David
From: Sandro Bonazzola Change-Id: Ie16cc0902c4393e62b074661a86f2f5bb9a1efc1 Signed-off-by: Sandro Bonazzola --- automation/build-artifacts.packages | 15 +++ automation/build-artifacts.repos| 3 +++ automation/build-artifacts.sh | 23 +++ automation/ch

Re: [Spice-devel] [nsis] Fix driver path for win2k*

2017-01-26 Thread Yedidyah Bar David
On Thu, Jan 26, 2017 at 9:47 AM, Christophe Fergeau wrote: > On the virtio-win ISO, the win2k* drivers are in a path of the form > '2k*', while the installer is looking for them in 'w2k*', and thus > failing. > This commit fixes the various paths > > This should fix https://bugzilla.redhat.com/sho

Re: [Spice-devel] [NSIS] packaging: bump version to 4.2

2017-01-24 Thread Yedidyah Bar David
17 at 03:44:27PM +0200, Yedidyah Bar David wrote: >> Change-Id: If2403d6801e7970bf1b7b88ff271b9c0e28d2628 >> Signed-off-by: Yedidyah Bar David >> --- >> ovirt-guest-tools-iso.spec.in | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git

[Spice-devel] [NSIS] packaging: bump version to 4.2

2017-01-24 Thread Yedidyah Bar David
Change-Id: If2403d6801e7970bf1b7b88ff271b9c0e28d2628 Signed-off-by: Yedidyah Bar David --- ovirt-guest-tools-iso.spec.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in index e51dea9..04fee49 100644 --- a/ovirt

Re: [Spice-devel] [NSIS 3/3] Install virtio-rng driver

2017-01-24 Thread Yedidyah Bar David
On Tue, Jan 24, 2017 at 11:10 AM, Christophe Fergeau wrote: > On Tue, Jan 24, 2017 at 10:16:21AM +0200, Yedidyah Bar David wrote: >> Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237 >> Bug-Url: https://bugzilla.redhat.com/1398560 >> Signed-off-by: Yedidyah Bar David

Re: [Spice-devel] [NSIS] 3 patches

2017-01-24 Thread Yedidyah Bar David
On Tue, Jan 24, 2017 at 10:49 AM, Christophe Fergeau wrote: > On Tue, Jan 24, 2017 at 10:18:02AM +0200, Yedidyah Bar David wrote: >> On Mon, Jan 23, 2017 at 5:23 PM, Christophe Fergeau >> wrote: >> > Hey, >> > >> > On Mon, Jan 23, 2017 at 12:08:46PM +02

Re: [Spice-devel] [NSIS] 3 patches

2017-01-24 Thread Yedidyah Bar David
On Mon, Jan 23, 2017 at 5:23 PM, Christophe Fergeau wrote: > Hey, > > On Mon, Jan 23, 2017 at 12:08:46PM +0200, Yedidyah Bar David wrote: >> Hi all, >> >> I now posted here 3 patches. First two were posted by Christophe a few >> weeks ago, and I amended them

[Spice-devel] [NSIS 2/3] Update to latest virtio-win/vdagent releases

2017-01-24 Thread Yedidyah Bar David
From: Christophe Fergeau Change-Id: I36da80234227c610a246d33c867204241b32e536 Signed-off-by: Christophe Fergeau --- Makefile | 4 ++-- ovirt-guest-tools-iso.spec.in | 6 +++--- version.txt | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --

[Spice-devel] [NSIS 1/3] Add Windows 10 support

2017-01-24 Thread Yedidyah Bar David
From: Christophe Fergeau This requires WinVer from nsis 3.01. At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the latest one from https://www.spice-space.org/download/windows/qxl-wddm-dod/ Change-Id: I773e4b76bd896fcea074b8f32a1b0cff854841b5 Signed-off-by: Christophe Fergeau

[Spice-devel] [NSIS 3/3] Install virtio-rng driver

2017-01-24 Thread Yedidyah Bar David
Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237 Bug-Url: https://bugzilla.redhat.com/1398560 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 8 1 file changed, 8 insertions(+) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 2092edc..8d57d85 100644 --- a

Re: [Spice-devel] [NSIS 1/3] Add Windows 10 support

2017-01-23 Thread Yedidyah Bar David
On Mon, Jan 23, 2017 at 7:14 PM, Christophe Fergeau wrote: > On Mon, Jan 23, 2017 at 12:02:05PM +0200, Yedidyah Bar David wrote: >> From: Christophe Fergeau >> >> This requires WinVer from nsis 3.01. >> At the moment, the qxl-wddm-dod driver on the virtio-win ISO is

[Spice-devel] [NSIS] Install virtio-rng driver

2017-01-23 Thread Yedidyah Bar David
Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237 Bug-Url: https://bugzilla.redhat.com/1398560 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 8 1 file changed, 8 insertions(+) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 2092edc..8d57d85 100644 --- a

[Spice-devel] [NSIS] 3 patches

2017-01-23 Thread Yedidyah Bar David
Hi all, I now posted here 3 patches. First two were posted by Christophe a few weeks ago, and I amended them a bit, last is to add virtio-rng. Also pushed them to ovirt gerrit, and jenkins built successfully: http://jenkins.ovirt.org/job/ovirt-wgt_master_create-rpms-fc24-x86_64_created/14/ Also

[Spice-devel] [NSIS 1/3] Add Windows 10 support

2017-01-23 Thread Yedidyah Bar David
From: Christophe Fergeau This requires WinVer from nsis 3.01. At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the latest one from https://www.spice-space.org/download/windows/qxl-wddm-dod/ Change-Id: I773e4b76bd896fcea074b8f32a1b0cff854841b5 Signed-off-by: Christophe Fergeau

[Spice-devel] [NSIS 3/3] Install virtio-rng driver

2017-01-23 Thread Yedidyah Bar David
Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237 Bug-Url: https://bugzilla.redhat.com/1398560 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 15 +++ 1 file changed, 15 insertions(+) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 2092edc..5f212f7

[Spice-devel] [NSIS 2/3] Update to latest virtio-win/vdagent releases

2017-01-23 Thread Yedidyah Bar David
From: Christophe Fergeau Change-Id: I36da80234227c610a246d33c867204241b32e536 Signed-off-by: Christophe Fergeau --- Makefile | 4 ++-- ovirt-guest-tools-iso.spec.in | 6 +++--- version.txt | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --

Re: [Spice-devel] [NSIS] Install virtio-rng driver

2017-01-23 Thread Yedidyah Bar David
On Sun, Jan 22, 2017 at 5:22 PM, Uri Lublin wrote: > On 01/22/2017 04:07 PM, Yedidyah Bar David wrote: >> >> Bug-Url: https://bugzilla.redhat.com/1398560 >> Change-Id: Ic7bad17fd01dc3d2d9c6a4f530eff724c4ea9403 >> Signed-off-by: Yedidyah Bar David >>

Re: [Spice-devel] [NSIS] Install virtio-rng driver

2017-01-22 Thread Yedidyah Bar David
On Sun, Jan 22, 2017 at 4:07 PM, Yedidyah Bar David wrote: > Bug-Url: https://bugzilla.redhat.com/1398560 > Change-Id: Ic7bad17fd01dc3d2d9c6a4f530eff724c4ea9403 > Signed-off-by: Yedidyah Bar David > --- > win-guest-tools.nsis | 15 +++ > 1 file changed, 15 inse

[Spice-devel] [NSIS] Install virtio-rng driver

2017-01-22 Thread Yedidyah Bar David
Bug-Url: https://bugzilla.redhat.com/1398560 Change-Id: Ic7bad17fd01dc3d2d9c6a4f530eff724c4ea9403 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 15 +++ 1 file changed, 15 insertions(+) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 1951721..9a90444

Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

2016-09-05 Thread Yedidyah Bar David
On Mon, Sep 5, 2016 at 11:22 AM, Christophe Fergeau wrote: > On Sun, Sep 04, 2016 at 09:07:48AM +0300, Yedidyah Bar David wrote: >> On Fri, Sep 2, 2016 at 9:23 AM, Christophe Fergeau >> wrote: >> > Hey, >> > >> > On Thu, Sep 01, 2016 at 05:43:36PM +03

Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

2016-09-03 Thread Yedidyah Bar David
On Fri, Sep 2, 2016 at 9:23 AM, Christophe Fergeau wrote: > Hey, > > On Thu, Sep 01, 2016 at 05:43:36PM +0300, Yedidyah Bar David wrote: >> On Tue, Aug 30, 2016 at 7:26 PM, Christophe Fergeau >> wrote: >> > Hey, >> > >> > On Mon, Aug 29, 20

Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

2016-09-01 Thread Yedidyah Bar David
On Tue, Aug 30, 2016 at 7:26 PM, Christophe Fergeau wrote: > Hey, > > On Mon, Aug 29, 2016 at 03:47:44PM +0300, Yedidyah Bar David wrote: >> From: Lev Veyde >> >> This is done, so that the version will be easily visible in the >> oVirt Manager under the Appl

[Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

2016-08-29 Thread Yedidyah Bar David
From: Lev Veyde This is done, so that the version will be easily visible in the oVirt Manager under the Applications, because the oVirt Guest Agent returns only Display Names, but not the versions. Bug-Url: https://bugzilla.redhat.com/1310621 Change-Id: I10a1f1d3a9e4241ec1dd5420c1e8770ec00bc508

[Spice-devel] [NSIS] ovirt: Add missing removal of hooks base directory

2016-06-22 Thread Yedidyah Bar David
From: Vinzenz Feenstra When the directories for the hooks have been introduced, the base folder has been left over during the uninstallation. This patch adds the removal of the hooks base directory. Change-Id: Ib48d2538c92e5e761ce4803c99a85ca0de2a47a4 Signed-off-by: Vinzenz Feenstra --- win-gu

Re: [Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

2016-06-21 Thread Yedidyah Bar David
On Tue, Jun 21, 2016 at 10:24 PM, Yedidyah Bar David wrote: > On Tue, Jun 21, 2016 at 6:05 PM, Christophe Fergeau > wrote: >> Were there any changes? > > No. > >> If yes, a "Changes since v2" would be useful, if >> not, it's not strictly needed

Re: [Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

2016-06-21 Thread Yedidyah Bar David
o now hosted elsewhere? [1] https://cgit.freedesktop.org/spice/spice-nsis/ > > Christophe > > On Tue, Jun 21, 2016 at 05:26:29PM +0300, Yedidyah Bar David wrote: >> Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 >> Signed-off-by: Yedidyah Bar David >> --- >> ov

[Spice-devel] [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

2016-06-21 Thread Yedidyah Bar David
From: Vinzenz Feenstra Previously the ovirt guest agent service registration has not been removed during the uninstallation. This patch adds the removal code. Change-Id: I9e2f89b01468ea51fe64afb68a75c50eb21888c1 Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 10 ++ 1 file c

[Spice-devel] [NSIS 3/5] OVirtGuestService.exe is a File not a Directory to remove

2016-06-21 Thread Yedidyah Bar David
From: Vinzenz Feenstra Change-Id: Ie71a0164c33d41aa1945f6dfe6feb6e54d1806e1 Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index f6996a9..e03788c 100644 --- a/win-guest-tool

[Spice-devel] [NSIS 2/5] Add guest agent hooks directories

2016-06-21 Thread Yedidyah Bar David
From: Vinzenz Feenstra For the new lifecycle events hook feature of the ovirt guest agent the following directories should be installed, so it's more easy for users to know where to put their hooks. Change-Id: Ia815927a8f5e9e1adf216389fa404f80a6bf7ed7 Bug-Url: https://bugzilla.redhat.com/1347272

[Spice-devel] [NSIS 4/5] ovirt: Remove all files install by the ovirt-guest-agent

2016-06-21 Thread Yedidyah Bar David
From: Vinzenz Feenstra Previously we left behind: - default.ini - default-logger.ini - ovirt-guest-agent.ini - vcredist_x86.exe Change-Id: If625ea358d0808bbee70bff9124d4f4e083157dc Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 5 + 1 file changed, 5 insertions(+) diff --git a

[Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

2016-06-21 Thread Yedidyah Bar David
Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 Signed-off-by: Yedidyah Bar David --- ovirt-guest-tools-iso.spec.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in index c91da04..0cd6e09 100644 --- a/ovirt

Re: [Spice-devel] [NSIS] packaging: bump version to 4.1

2016-06-21 Thread Yedidyah Bar David
On Tue, Jun 21, 2016 at 1:31 PM, Christophe Fergeau wrote: > Acked-by: Christophe Fergeau OK, please merge. Thanks. > > On Tue, Jun 21, 2016 at 01:17:05PM +0300, Yedidyah Bar David wrote: >> Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 >> Signed-off-b

[Spice-devel] [NSIS] packaging: bump version to 4.1

2016-06-21 Thread Yedidyah Bar David
Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 Signed-off-by: Yedidyah Bar David --- ovirt-guest-tools-iso.spec.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in index c91da04..0cd6e09 100644 --- a/ovirt

[Spice-devel] [NSIS] Add guest agent hooks directories

2016-06-21 Thread Yedidyah Bar David
From: Vinzenz Feenstra For the new lifecycle events hook feature of the ovirt guest agent the following directories should be installed, so it's more easy for users to know where to put their hooks. Change-Id: Ia815927a8f5e9e1adf216389fa404f80a6bf7ed7 Bug-Url: https://bugzilla.redhat.com/1347272

[Spice-devel] [NSIS] Add guest agent hooks directories

2016-06-21 Thread Yedidyah Bar David
From: Vinzenz Feenstra For the new lifecycle events hook feature of the ovirt guest agent the following directories should be installed, so it's more easy for users to know where to put their hooks. Change-Id: Ia815927a8f5e9e1adf216389fa404f80a6bf7ed7 Bug-Url: https://bugzilla.redhat.com/1347272

Re: [Spice-devel] spice-xpi deprecated soon

2016-04-19 Thread Yedidyah Bar David
On Tue, Apr 19, 2016 at 5:16 PM, RK RK wrote: > Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production > environment with 250 Virtual Desktops accessed from within the office > premises. > > Our users will have thin client devices running trimmed down version of > CentOS 7 with

Re: [Spice-devel] [NSIS] packaging: bump version to 4.0

2016-03-02 Thread Yedidyah Bar David
On Wed, Mar 2, 2016 at 4:47 PM, Christophe Fergeau wrote: > Hey, > > On Wed, Feb 10, 2016 at 12:16:59PM +0200, Yedidyah Bar David wrote: >> From: Sandro Bonazzola >> >> Change-Id: I1bc61dbbaa39a6e0d5d5866065d6c12c5af51bf7 >> Signed-off-by: Sandro Bonazz

Re: [Spice-devel] [NSIS] packaging: bump version to 4.0

2016-02-10 Thread Yedidyah Bar David
On Wed, Feb 10, 2016 at 12:16 PM, Yedidyah Bar David wrote: > From: Sandro Bonazzola > > Change-Id: I1bc61dbbaa39a6e0d5d5866065d6c12c5af51bf7 > Signed-off-by: Sandro Bonazzola > --- > ovirt-guest-tools-iso.spec.in | 7 +-- > 1 file changed, 5 insertions(+), 2 deletion

[Spice-devel] [NSIS] packaging: bump version to 4.0

2016-02-10 Thread Yedidyah Bar David
EULA @@ -60,6 +60,9 @@ make %{make_common_opts} install DESTDIR="%{buildroot}" %{_datadir}/%{name} %changelog +* Wed Feb 10 2016 Sandro Bonazzola - 4.0-0 +- Bumping version to 4.0 + * Wed Nov 11 2015 Yedidyah Bar David 3.6-3 - merged into upstream git repo spice-nsis - separated Ma

Re: [Spice-devel] [NSIS] packaging: spec: avoid suffix in iso label

2016-02-09 Thread Yedidyah Bar David
On Tue, Feb 9, 2016 at 4:30 PM, Christophe Fergeau wrote: > On Tue, Feb 09, 2016 at 03:56:42PM +0200, Yedidyah Bar David wrote: >> On Tue, Feb 9, 2016 at 3:44 PM, Christophe Fergeau >> wrote: >> > On Mon, Feb 08, 2016 at 07:57:42PM +0200, Yedidyah Bar David wrote: >

Re: [Spice-devel] [NSIS] packaging: spec: avoid suffix in iso label

2016-02-09 Thread Yedidyah Bar David
On Tue, Feb 9, 2016 at 3:56 PM, Yedidyah Bar David wrote: > On Tue, Feb 9, 2016 at 3:44 PM, Christophe Fergeau > wrote: >> On Mon, Feb 08, 2016 at 07:57:42PM +0200, Yedidyah Bar David wrote: >>> From: Sandro Bonazzola >>> >>> Avoid suffix in iso lab

Re: [Spice-devel] [NSIS] packaging: spec: avoid suffix in iso label

2016-02-09 Thread Yedidyah Bar David
On Tue, Feb 9, 2016 at 3:44 PM, Christophe Fergeau wrote: > On Mon, Feb 08, 2016 at 07:57:42PM +0200, Yedidyah Bar David wrote: >> From: Sandro Bonazzola >> >> Avoid suffix in iso labeling: release number with the >> full suffix exceeds the maximum length allowed. &g

[Spice-devel] [NSIS] packaging: spec: avoid suffix in iso label

2016-02-08 Thread Yedidyah Bar David
From: Sandro Bonazzola Avoid suffix in iso labeling: release number with the full suffix exceeds the maximum length allowed. Change-Id: I8f480b8dc091051416901e3748169e2afe390229 Signed-off-by: Sandro Bonazzola --- ovirt-guest-tools-iso.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [Spice-devel] [NSIS 10/13] build: Add make dist

2015-11-25 Thread Yedidyah Bar David
On Wed, Nov 25, 2015 at 10:46 AM, Christophe Fergeau wrote: > Hi, > > On Wed, Nov 25, 2015 at 10:03:06AM +0200, Yedidyah Bar David wrote: >> On Fri, Nov 20, 2015 at 5:05 PM, Christophe Fergeau >> wrote: >> > On Thu, Nov 19, 2015 at 03:58:18PM +0100, Christophe Fe

Re: [Spice-devel] [NSIS 10/13] build: Add make dist

2015-11-25 Thread Yedidyah Bar David
On Fri, Nov 20, 2015 at 5:05 PM, Christophe Fergeau wrote: > On Thu, Nov 19, 2015 at 03:58:18PM +0100, Christophe Fergeau wrote: >> On Thu, Nov 19, 2015 at 04:48:20PM +0200, Yedidyah Bar David wrote: >> > From: Christophe Fergeau >> >> When splitting these pa

Re: [Spice-devel] ovirt-wgt - another attempt

2015-11-19 Thread Yedidyah Bar David
On Thu, Nov 19, 2015 at 5:28 PM, Christophe Fergeau wrote: > On Thu, Nov 19, 2015 at 05:05:10PM +0200, Yedidyah Bar David wrote: >> On Thu, Nov 19, 2015 at 4:03 PM, Christophe Fergeau >> wrote: >> > Hey, >> > >> > On Thu, Nov 19, 2015 at 03:13:35PM +02

Re: [Spice-devel] ovirt-wgt - another attempt

2015-11-19 Thread Yedidyah Bar David
On Thu, Nov 19, 2015 at 4:03 PM, Christophe Fergeau wrote: > Hey, > > On Thu, Nov 19, 2015 at 03:13:35PM +0200, Yedidyah Bar David wrote: >> I find more comfortable this semi-pull-requests mode of operation >> instead of posting patches to the list. Please notify if you pref

[Spice-devel] [NSIS 13/13] packaging: add ovirt jenkins automation

2015-11-19 Thread Yedidyah Bar David
Add automation scripts/conf for ovirt jenkins. Run builds on push to gerrit and on merge there. Structure defined in [1]. [1] http://www.ovirt.org/CI/Build_and_test_standards Change-Id: I209ec032794575fe0231eb53cdf8d5e0cf978e5a Signed-off-by: Yedidyah Bar David --- automation/README.md

[Spice-devel] [NSIS 05/13] packaging: add Makefile

2015-11-19 Thread Yedidyah Bar David
-installer.spec [1] and ovirt-guest-tools-iso.spec [2]. [1] https://gerrit.ovirt.org/47432 [2] https://gerrit.ovirt.org/48425 Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22 Signed-off-by: Yedidyah Bar David --- Makefile | 123 +++ win-guest

[Spice-devel] [NSIS 03/13] Allow custom installer filename and displayed name version

2015-11-19 Thread Yedidyah Bar David
7;s source code. Change-Id: Id60a990aea8e9148c0cd47dd685f9681395ac624 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index ef4cf07..23c068d 100644 --- a

[Spice-devel] [NSIS 01/13] packaging: Re-enable NSIS branding for oVirt

2015-11-19 Thread Yedidyah Bar David
From: Lev Veyde change-id was I8692e636d42f127f953f578d86c7cbe8f2bcc06a renamed due to gerrit complications Change-Id: Idb20091a41e1cae7ac6df538ee17eec38a8a714a Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/win-guest-t

[Spice-devel] [NSIS 04/13] Remove EXE_VERSION

2015-11-19 Thread Yedidyah Bar David
From: Christophe Fergeau This is only used when generating the oVirt installer as it does not want any version number to be included in the .exe filename provided on the ISO it ships. However, if someone was to ship a standalone .exe outside of an ISO, an unversioned installer executable is not w

[Spice-devel] [NSIS 08/13] build: Remove need for ISO_ROOT

2015-11-19 Thread Yedidyah Bar David
From: Christophe Fergeau We can pass directly the name of the files we want to be in the iso. Change-Id: I6c5d2ae82a23ae4ba1d0249b6aefc61ccbc5b0a6 Signed-off-by: Christophe Fergeau --- Makefile | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index

[Spice-devel] [NSIS 12/13] build: Put unversioned .exe installer in the ISO

2015-11-19 Thread Yedidyah Bar David
From: Christophe Fergeau While it makes sense to have a versioned .exe file when it's standalone, when it's on an ISO, it's more natural to have an unversioned .exe installer. This is achieved through the use of the --graft-points option to mkisofs. Change-Id: I1970348c6a72dcd44865c78d3348fc5776

[Spice-devel] [NSIS 02/13] nsis: Drop separately-packaged qxl drivers

2015-11-19 Thread Yedidyah Bar David
qxl drivers are now supplied inside virtio-win drivers package. Change-Id: Id8274f125ef7fa6b4fd76a7015958f24f2e358ea Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 1 - 1 file changed, 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 8b52e26..ef4cf07

[Spice-devel] [NSIS 11/13] build: Small make dist improvements

2015-11-19 Thread Yedidyah Bar David
From: Christophe Fergeau Use bz2 rather than gz, add version number to the output directory, and use the more portable /dev/stdin instead of /proc/self/fd/0. Change-Id: I90096405ded7eb9102818185482fa27dc4c33b72 Signed-off-by: Christophe Fergeau --- Makefile | 4 ++-- 1 file changed, 2 insertio

[Spice-devel] [NSIS 09/13] packaging: add ovirt-guest-tools-iso.spec.in

2015-11-19 Thread Yedidyah Bar David
e}' + +%prep +%setup -n %{source_base} -q + +%build +make %{make_common_opts} + +%install +make %{make_common_opts} install DESTDIR="%{buildroot}" + +%files +%{_datadir}/%{name} + +%changelog +* Wed Nov 11 2015 Yedidyah Bar David 3.6-3 +- merged into upstream git repo spice-nsis +- separ

[Spice-devel] [NSIS 07/13] build: Use longer version of mkisofs options when possible

2015-11-19 Thread Yedidyah Bar David
From: Christophe Fergeau Change-Id: I003ebdcc2b8c3778903a5b07eb02280aba4527b0 Signed-off-by: Christophe Fergeau --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5be6894..068d774 100644 --- a/Makefile +++ b/Makefile @@ -137,7 +137,7 @@ is

[Spice-devel] [NSIS 06/13] build: Add ISO generation as well as make install

2015-11-19 Thread Yedidyah Bar David
an then be consumed by the guest-tools-iso spec file. Split off from [1]. [1] https://gerrit.ovirt.org/47771 Change-Id: I294f640d95bdcec6bc0267e79c4fed244ecbc36e Signed-off-by: Christophe Fergeau Signed-off-by: Yedidyah Bar David --- Makefile | 27 ++- 1 file changed, 26

[Spice-devel] [NSIS 10/13] build: Add make dist

2015-11-19 Thread Yedidyah Bar David
From: Christophe Fergeau Some magic as we want to ship a generated .spec file in addition to the files from the git repository. Change-Id: I90d905697aa4f9092c65810467cd88dc611ed003 Signed-off-by: Christophe Fergeau --- Makefile | 4 1 file changed, 4 insertions(+) diff --git a/Makefile b

Re: [Spice-devel] ovirt-wgt - another attempt

2015-11-19 Thread Yedidyah Bar David
Hi all, Following my previous patchset, Christphe revised my changes a bit and put his suggestion in [1]. I am fine with this version, except for some minor changes to the spec file patch to adapt it to the changes in the Makefile. I find more comfortable this semi-pull-requests mode of operatio

[Spice-devel] [NSIS 4/6] packaging: add Makefile

2015-11-11 Thread Yedidyah Bar David
Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22 Signed-off-by: Sandro Bonazzola Signed-off-by: Yedidyah Bar David --- Makefile | 157 +++ win-guest-tools.nsis | 5 +- 2 files changed, 161 insertions(+), 1 deletion(-) create mode 100644 Makefile di

[Spice-devel] [NSIS 5/6] packaging: add ovirt-guest-tools-iso.spec.in

2015-11-11 Thread Yedidyah Bar David
+%setup -n spice-nsis -q + +%build +make %{make_common_opts} + +%install +make %{make_common_opts} install DESTDIR="%{buildroot}" + +%files +%{_datadir}/%{name} + +%changelog +* Wed Nov 11 2015 Yedidyah Bar David 3.6-3 +- merged into upstream git repo spice-nsis +- separated Makefile out of

[Spice-devel] [NSIS 2/6] nsis: Drop separately-packaged qxl drivers

2015-11-11 Thread Yedidyah Bar David
qxl drivers are now supplied inside virtio-win drivers package. Change-Id: Id8274f125ef7fa6b4fd76a7015958f24f2e358ea Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 1 - 1 file changed, 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 8b52e26..ef4cf07

[Spice-devel] [NSIS 3/6] Allow custom installer filename and displayed name version

2015-11-11 Thread Yedidyah Bar David
7;s source code. Change-Id: Id60a990aea8e9148c0cd47dd685f9681395ac624 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index ef4cf07..23c068d 100644 --- a

[Spice-devel] [NSIS 6/6] packaging: add ovirt jenkins automation

2015-11-11 Thread Yedidyah Bar David
Add automation scripts/conf for ovirt jenkins. Run builds on push to gerrit and on merge there. Structure defined in [1]. [1] http://www.ovirt.org/CI/Build_and_test_standards Change-Id: I209ec032794575fe0231eb53cdf8d5e0cf978e5a Signed-off-by: Yedidyah Bar David --- automation/README.md

[Spice-devel] [NSIS 1/6] packaging: Re-enable NSIS branding for oVirt

2015-11-11 Thread Yedidyah Bar David
From: Lev Veyde change-id was I8692e636d42f127f953f578d86c7cbe8f2bcc06a renamed due to gerrit complications Change-Id: Idb20091a41e1cae7ac6df538ee17eec38a8a714a Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/win-guest-t

Re: [Spice-devel] [NSIS 2/2] packaging: add Makefile, spec file, jenkins automation

2015-11-11 Thread Yedidyah Bar David
On Thu, Nov 5, 2015 at 3:45 PM, Christophe Fergeau wrote: > Hey, > > Some comments on the Makefile/.spec files > > On Mon, Oct 26, 2015 at 12:35:29PM +0200, Yedidyah Bar David wrote: >> Allow 'make dist'. >> >> Allow building the spice installer and

Re: [Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Yedidyah Bar David
On Mon, Oct 26, 2015 at 4:58 PM, Christophe Fergeau wrote: > On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote: >> Allow passing: >> >> DISPLAYED_VERSION (defaults to $VERSION): what's written to the >> registry. This is what is shown to th

[Spice-devel] [NSIS 1/3] packaging: Re-enable NSIS branding for oVirt

2015-10-26 Thread Yedidyah Bar David
From: Lev Veyde Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 3db6ba3..8b52e26 100644 --- a/win-guest-tools.nsis +++

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-26 Thread Yedidyah Bar David
On Mon, Oct 26, 2015 at 10:57 AM, Christophe Fergeau wrote: > On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote: >> If you only object to the aesthetics, and not the principle, can you please >> state what should be done to make it nice enough for you? Searching f

[Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Yedidyah Bar David
7;s source code. Change-Id: Id60a990aea8e9148c0cd47dd685f9681395ac624 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 8b52e26..4e34d2e 100644 --- a

[Spice-devel] [NSIS 2/2] packaging: add Makefile, spec file, jenkins automation

2015-10-26 Thread Yedidyah Bar David
p.exe + +%package iso +Summary: RPM wrapper for %{name} + +%description iso +A package wrapping %{name} to provide dependency features. + +%files iso +%{_datadir}/%{name}-iso + +%changelog +* Tue Oct 20 2015 Yedidyah Bar David 3.6.0-0.2 +- merged into upstream git repo spice-nsis +- separated Makefi

Re: [Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Yedidyah Bar David
On Mon, Oct 26, 2015 at 11:53 AM, Christophe Fergeau wrote: > On Sun, Oct 25, 2015 at 05:14:06PM +0200, Yedidyah Bar David wrote: >> Allow passing: >> >> DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry >> >> EXE_VERSION (default

[Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-25 Thread Yedidyah Bar David
Allow passing: DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry EXE_VERSION (defaults to -$VERSION): appended to installer filename Change-Id: Id60a990aea8e9148c0cd47dd685f9681395ac624 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 12 ++-- 1

[Spice-devel] [NSIS 2/2] packaging: add Makefile, spec file, jenkins automation

2015-10-25 Thread Yedidyah Bar David
gerrit.ovirt.org/47461 - ovirt-guest-agent Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22 Signed-off-by: Sandro Bonazzola Signed-off-by: Yedidyah Bar David --- Makefile| 101 automation/README.md| 8 +++ autom

Re: [Spice-devel] introduce ovirt-wgt - second attempt

2015-10-25 Thread Yedidyah Bar David
On Thu, Oct 22, 2015 at 8:45 AM, Yedidyah Bar David wrote: > On Wed, Oct 21, 2015 at 7:58 PM, Christophe Fergeau > wrote: >> On Tue, Oct 20, 2015 at 02:34:40PM +0300, Yedidyah Bar David wrote: >>> Hi all, >>> >>> Changes since [1]: >>> >>>

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-25 Thread Yedidyah Bar David
On Sun, Oct 25, 2015 at 11:17 AM, Lev Veyde wrote: > Hi Christophe, > > That's not the same. The installer is produced with NSIS, and I see no reason > to hide it. > > It can be run on Windows, Fedora and a plenty of other OSes, so it's > irrelevant. > I'm also not saying about giving the attrib

Re: [Spice-devel] [NSIS] packaging: add Makefile, spec file, jenkins automation

2015-10-22 Thread Yedidyah Bar David
On Thu, Oct 22, 2015 at 11:49 AM, Christophe Fergeau wrote: > On Thu, Oct 22, 2015 at 11:39:42AM +0300, Yedidyah Bar David wrote: >> On Thu, Oct 22, 2015 at 11:28 AM, Christophe Fergeau >> wrote: >> > Having smaller/more focused commits will allow to have >&g

Re: [Spice-devel] [NSIS] packaging: add Makefile, spec file, jenkins automation

2015-10-22 Thread Yedidyah Bar David
On Thu, Oct 22, 2015 at 11:28 AM, Christophe Fergeau wrote: > On Thu, Oct 22, 2015 at 08:36:49AM +0300, Yedidyah Bar David wrote: >> > >> >> Makefile| 100 >> >> >> > >> > on

Re: [Spice-devel] [NSIS 6/7] Add ovirt-related scripts

2015-10-22 Thread Yedidyah Bar David
On Thu, Oct 22, 2015 at 10:45 AM, Christophe Fergeau wrote: > On Thu, Oct 22, 2015 at 08:31:19AM +0300, Yedidyah Bar David wrote: >> On Wed, Oct 21, 2015 at 7:52 PM, Christophe Fergeau >> wrote: >> > I suspect these scripts are no longer needed? I don't see them b

Re: [Spice-devel] introduce ovirt-wgt - second attempt

2015-10-21 Thread Yedidyah Bar David
On Wed, Oct 21, 2015 at 7:58 PM, Christophe Fergeau wrote: > On Tue, Oct 20, 2015 at 02:34:40PM +0300, Yedidyah Bar David wrote: >> Hi all, >> >> Changes since [1]: >> >> - Attended (I hope) Christophe's comments from previous set >> >> -

Re: [Spice-devel] [NSIS 2/7] nsis: Install oVirt guest agent

2015-10-21 Thread Yedidyah Bar David
On Wed, Oct 21, 2015 at 7:55 PM, Christophe Fergeau wrote: > On Tue, Oct 20, 2015 at 02:35:23PM +0300, Yedidyah Bar David wrote: >> From: Christophe Fergeau >> >> Now that we are able to generate different installers for SPICE and >> oVirt, we can install the oVirt a

Re: [Spice-devel] [NSIS] packaging: add Makefile, spec file, jenkins automation

2015-10-21 Thread Yedidyah Bar David
On Wed, Oct 21, 2015 at 7:43 PM, Christophe Fergeau wrote: > On Wed, Oct 21, 2015 at 05:47:12PM +0300, Yedidyah Bar David wrote: >> Allow 'make dist'. >> >> Allow building the spice installer and building/installing the ovirt >> installer. >> >>

Re: [Spice-devel] [NSIS 6/7] Add ovirt-related scripts

2015-10-21 Thread Yedidyah Bar David
27;t mind removing it and verifying. Just not sure what's your own exact workflow. > > Christophe > > On Tue, Oct 20, 2015 at 02:35:27PM +0300, Yedidyah Bar David wrote: >> From: Christophe Fergeau >> >> Change-Id: I6bf84620dd18361274a0d9bb1d2a98011c2bc1d4 >&

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-21 Thread Yedidyah Bar David
y merged it to your own branch [1] so I thought that's not questionable. [1] http://cgit.freedesktop.org/~teuf/spice-nsis/log/?h=ovirt > > Christophe > > On Tue, Oct 20, 2015 at 02:35:24PM +0300, Yedidyah Bar David wrote: >> From: Lev Veyde >> >> Change-Id: I869

  1   2   >