The intention of those commits was to be ready for new things (wayland,
gtk4... wait, actually gtk3). That side effect was not desired...
I'm not sure whether is better to revert it completely and go back to gtk2
api.
Ack,
Pavel
If there is a bug/regression in gtk+, it'd be good to have reference
Hi,
does it work well with CI? IIRC there's a linter checking for the validity
of links.
Pavel
Dne po 14. 5. 2018 17:18 uživatel Christophe Fergeau
napsal:
> When referencing content hosted on spice-space.org, no need to use the
> full URL in our HTML pages
> (ie use /download/ instead of https
tors and then write about the result.
>
> Best regards
> Dmitry
>
> --
> *От: *"Pavel Grunt"
> *Кому: *"Victor Toso"
> *Копия: *"Dmitriy Kormulev" , "spice-devel" <
> spice-devel@lists.freedesktop.org>
> *От
Hello,
I guess in this case the problem is in the guest's desktop environment. The
auto-adjustment is implemented in Gnome and the recent KDE.
Dmitriy, you can change the environment of your centos 7 guest from Mate to
Gnome to check out if it works.
Pavel
Dne 31. 1. 2018 5:37 odp. napsal uživa
2018-01-13 11:08 GMT+01:00 Frediano Ziglio :
> This issue caused the glitches using the rectangular selection
> tool in PaintShop 6.
>
> The line was removed accidentally by "red_parse_qxl: fix throwing
> away drawables that have masks" (812b65984d286414170c6243bd3323b73a405ec3)
>
quite old
> S
2017-08-10 12:27 GMT+02:00 :
> From: Marc-André Lureau
>
> spicy is only a test UI. A proper end-user UI is provided by
> virt-viewer, vinagre or Boxes for example.
>
> spicy-stats is meant for simple measurements and tweaking during
> development, I never heard of any user. And I can't think of
2017-08-10 12:22 GMT+02:00 Marc-André Lureau :
> Hi
>
> - Original Message -
> > Hi,
> >
> > do you want to keep installing spicy-screenshot and spicy-stats? They are
> > also tools just for testing.
>
> spicy-stats indeed.
>
> spicy-screenshot may be used legitimately in scripts though.
>
Hi,
do you want to keep installing spicy-screenshot and spicy-stats? They are
also tools just for testing.
Pavel
2017-08-10 11:37 GMT+02:00 Marc-André Lureau :
> Hi
>
> - Original Message -
> > Hi,
> >
> > On Wed, Aug 09, 2017 at 10:48:58PM +0200, marcandre.lur...@redhat.com
> wrote:
>
It is available since Gtk+ 3.22
---
src/spice-widget.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index d5ebd9d..fb94e94 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -1577,6 +1577,7 @@ static gboolean key_event(GtkWidget *widget, Gd
Hi Armin,
I also build with --disable-werror on arm (raspberry & orange pi), it works
fine.
The warnings in your log comes from gstreamer's and glib's headers. The
issue is probably there :) Alternatively try ./configure --disable-gstvideo
Pavel
2017-08-03 14:52 GMT+02:00 Victor Toso :
> Hi,
>
On Thu, 2017-07-27 at 10:15 +0100, Frediano Ziglio wrote:
> RPM does not allow dash in version string.
> Replace dashes with underscores.
> This make easier to run "make dist" followed by rpmbuild.
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> con
On Fri, 2017-07-28 at 12:44 +0100, Frediano Ziglio wrote:
> Recent GitLab CI jobs are failing to run valgrind checks
> (like https://gitlab.com/spice/spice/-/jobs/25220999).
>
> This as recent distro changes cause valgrind not to find some
> symbols required to detect some GLib suppression errors.
Hi,
On Fri, 2017-07-28 at 09:15 +0200, Christophe de Dinechin wrote:
> > On 27 Jul 2017, at 17:07, Marc-André Lureau
> > wrote:
> >
> > Hi
> >
> > - Original Message -
> > > > I think we should rather find a consensus on the mailing list rather
> > > > than
> > > > avoiding the discussi
Hi,
Cool, looks good to me
I can confirm that thanks to this patch is possible to do things like:
1. make dist
2. md5sum vdagent-win-0.8.0.34-7b15.tar.xz > sources
3. fedpkg srpm
And for instance use the srpm to create a build in koji/brew/copr
On Wed, 2017-07-26 at 16:03 +0100, Fr
On Tue, 2017-06-20 at 13:10 +0200, Victor Toso wrote:
> From: leaboy
>
> The current code deadlocks when a USB error occurs, releasing the
> channel lock before the idle is called fixes this problem.
>
> More specifically when an error occurs, we queue a call to device_error
> in an idle, and sw
On Fri, 2017-07-07 at 16:26 +0200, Pavel Grunt wrote:
> Silence -Wmissing-field-initializers warnings.
Forgot to mention, it happens when building tests. My gcc --version:
gcc (GCC) 7.1.1 20170622 (Red Hat 7.1.1-3)
But I'm not sure it is specific to gcc version, a similar fix has been
splay_stream
> *st)
> /* main context */
> G_GNUC_INTERNAL
> void stream_display_frame(display_stream *st, SpiceFrame *frame,
> - uint32_t width, uint32_t height, uint8_t *data)
> + uint32_t width, uint32_t height, int stride,
On Tue, 2017-07-25 at 10:50 -0400, Frediano Ziglio wrote:
> >
> > Hi Frediano,
> >
> > On Tue, 2017-07-25 at 15:31 +0100, Frediano Ziglio wrote:
> > > Using hardware encoders/decoders is possible that the output
> > > stride of the image cannot be computed with a fixed formula
> > > (width * 4).
Hi Frediano,
On Tue, 2017-07-25 at 15:31 +0100, Frediano Ziglio wrote:
> Using hardware encoders/decoders is possible that the output
> stride of the image cannot be computed with a fixed formula
> (width * 4). GStreamer in this case should set GstVideoMeta
> information with the correct stride va
Hi Jakub,
On Fri, 2017-07-07 at 11:57 +0200, Jakub Janků wrote:
> ---
> Demo: https://youtu.be/IX49z8VbD-c
Cool!
>
> VDAgent: https://github.com/jjanku/win32-vd_agent/tree/seamless-mode
> Protocol: https://gitlab.com/xerus/spice-protocol/tree/seamless-mode
> Gtk: https://github.com/jjanku/spice-
spice_display_widget_gl_scanout is defined only when building with egl
./.libs/libspice-client-gtk-3.0.so: undefined reference to
`spice_display_widget_gl_scanout'
---
src/spice-widget-priv.h | 2 ++
src/spice-widget.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/sr
Hey,
On Thu, 2017-07-20 at 17:12 +0200, Christophe Fergeau wrote:
> Update NEWS and soname.
> ---
> NEWS | 19 +++
> configure.ac | 2 +-
> 2 files changed, 20 insertions(+), 1 deletion(-)
>
> Hey,
>
> It's high time that we have an unstable release, and I'd like to sta
To give an example for creating flatpaks depending on spice-gtk
How to build and run the flatpak:
spicy uses GNOME SDK runtime, version 3.24. The runtime provides tools
and libraries necessary to build the flatpak
$ flatpak remote-add --if-not-exists gnome
https://sdk.gnome.org/gnome.flatpakrepo
On Fri, 2017-07-21 at 10:29 +0200, Christophe Fergeau wrote:
> Hey,
>
> On Thu, Jul 20, 2017 at 10:49:48PM +0200, Pavel Grunt wrote:
> > To give example for creating flatpaks depending on spice-gtk
> >
>
> Yup, good idea, just a few minor comments:
>
> > How
To give example for creating flatpaks depending on spice-gtk
How to use to build and run the flatpak:
$ flatpak-builder spicy org.spicespace.spicy.json
$ flatpak build-export repo spicy
$ flatpak --user remote-add --no-gpg-verify --if-not-exists spice-repo repo
$ flatpak --user install spice-r
Ack
Thanks,
Pavel
On Thu, 2017-07-20 at 19:41 +0300, Uri Lublin wrote:
> Move the declaration and assignment of 'buffer' into
> the if (sample) block, where sample is not NULL.
>
> Signed-off-by: Uri Lublin
> ---
> src/channel-display-gst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 del
Victor,
it is faster to write NACK
On Thu, 2017-07-20 at 07:26 +0200, Victor Toso wrote:
> A new day, a new thread
>
> On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote:
> > GStreamer's avdec_h264 needs h264parse to be able to process H264 video
> > stre
On Wed, 2017-07-19 at 18:00 +0200, Christophe Fergeau wrote:
> On Wed, Jul 19, 2017 at 05:46:51PM +0200, Victor Toso wrote:
> > What I'm trying to stress is that we are trying to not check *specific*
> > plugins related to decode/parse a stream. We don't know what our users
> > will be using and we
On Wed, 2017-07-19 at 18:13 +0200, Victor Toso wrote:
> On Wed, Jul 19, 2017 at 06:01:43PM +0200, Pavel Grunt wrote:
> > On Wed, 2017-07-19 at 17:46 +0200, Victor Toso wrote:
> > > Hi,
> > >
> > > On Wed, Jul 19, 2017 at 05:27:43PM +0200, Pavel Grunt wrote:
On Wed, 2017-07-19 at 17:46 +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Jul 19, 2017 at 05:27:43PM +0200, Pavel Grunt wrote:
> > > Stream decoding will fail, server will know about it and sever should
> > > fallback to image compression or a different video codec
On Wed, 2017-07-19 at 16:43 +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Jul 19, 2017 at 04:25:19PM +0200, Pavel Grunt wrote:
> > On Wed, 2017-07-19 at 16:15 +0200, Victor Toso wrote:
> > > Hi,
> > >
> > > On Wed, Jul 19, 2017 at 04:01:21PM +0200, Pavel
On Wed, 2017-07-19 at 16:15 +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Jul 19, 2017 at 04:01:21PM +0200, Pavel Grunt wrote:
> > On Wed, 2017-07-19 at 15:52 +0200, Victor Toso wrote:
> > > On Wed, Jul 19, 2017 at 03:46:36PM +0200, Pavel Grunt wrote:
> > > &g
On Wed, 2017-07-19 at 15:52 +0200, Victor Toso wrote:
> On Wed, Jul 19, 2017 at 03:46:36PM +0200, Pavel Grunt wrote:
> > On Wed, 2017-07-19 at 15:40 +0200, Victor Toso wrote:
> > > On Wed, Jul 19, 2017 at 03:30:49PM +0200, Pavel Grunt wrote:
> > > > On Wed, 2017-07-
On Wed, 2017-07-19 at 15:40 +0200, Victor Toso wrote:
> On Wed, Jul 19, 2017 at 03:30:49PM +0200, Pavel Grunt wrote:
> > On Wed, 2017-07-19 at 15:23 +0200, Victor Toso wrote:
> > > Hi,
> > >
> > > On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote:
On Wed, 2017-07-19 at 15:23 +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote:
> > GStreamer's avdec_h264 needs h264parse to be able to process H264 video
> > streams. However the check for elements through GstRegistry does
GStreamer's avdec_h264 needs h264parse to be able to process H264 video
streams. However the check for elements through GstRegistry does not
take into account the possible pipeline of elements (like "h264parse !
avdec_h264").
Fix that by checking for the elements by their name.
---
src/channel-d
> > > On 14 Jul 2017, at 14:24, Pavel Grunt wrote:
> > >
> > > This also fixes the huge memore leak reported by Christophe.
> > > Steps to reproduce:
> > > 1. ./configure --disable-pulse --enable-gstaudio
> > > 2. connect to a vm streaming vid
On Mon, 2017-07-17 at 14:00 +0200, Christophe Fergeau wrote:
> spice-gtk currently requires gettext 0.19 which is a fairly recent
> release (not available in el7.3 and older, nor in ubuntu 14.04 LTS).
> They both have a gettext newer than 0.18.2, so we can require that.
>
> Requiring 0.18 or 0.18.
On Sun, 2017-07-16 at 18:47 +0300, Uri Lublin wrote:
> Although unlikely, theoretically, multiplying two 32-bit
> numbers may overflow.
>
> Found by coverity.
>
> Signed-off-by: Uri Lublin
Acked-by: Pavel Grunt
> ---
> server/red-parse-qxl.c | 2 +-
> 1 file
On Sun, 2017-07-16 at 18:47 +0300, Uri Lublin wrote:
> If qxl->descriptor.type is QUIC, red_replay_data_chunks_free
> frees qxl (data), so no need to free it again at the bottom
> of the function.
>
> Found by coverity.
>
> Signed-off-by: Uri Lublin
Acked-by: Pavel Gr
On Sun, 2017-07-16 at 18:47 +0300, Uri Lublin wrote:
> Under error: 'link' fields are being accessed, so it's
> wrong to goto error with link == NULL.
>
> Instead, return immediately.
>
> Found by coverity.
>
> Signed-off-by: Uri Lublin
Acked-by: Pavel Gr
On Fri, 2017-07-14 at 11:42 -0400, Frediano Ziglio wrote:
> >
> > On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote:
> > > Remove CxImage linking.
> > > Support Windows BMP format.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > Makefile.am | 4 +-
> > > conf
On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote:
> Remove CxImage linking.
> Support Windows BMP format.
>
> Signed-off-by: Frediano Ziglio
> ---
> Makefile.am | 4 +-
> configure.ac| 4 +-
> mingw-spice-vdagent.spec.in | 2 -
> vdagent/image.cpp
On Fri, 2017-07-14 at 13:57 +0100, Frediano Ziglio wrote:
> This will make easier to change code that handle images.
>
> Signed-off-by: Frediano Ziglio
> ---
> Makefile.am | 2 ++
> vdagent/image.cpp | 86
> +
> vdagent/image.h |
pdates the mmtime
in a way that schedules the frames to the future ((unsigned) 0 - delay) and then
gstreamer starts to queue the frames (they should be played later)
Pavel
On Fri, 2017-07-14 at 13:19 +0200, Pavel Grunt wrote:
> The fake channel has been introduced to get the audio volume by s
It is enough to update them just before the release (`make dist`)
Reported-by: Victor Toso
---
also remove a intltool leftover
---
Makefile.am | 1 -
po/Makevars | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 30f05f4..ccb81aa 100644
--- a/Ma
The fake channel has been introduced to get the audio volume by starting
the gstreamer's audio pipeline and querring its volume info (see commit
aa8d044417bbf60685f59163b874ecb4f157c3c9).
Hovewer starting the pipeline updates the mmtime as a side effect. This
may cause a (big) delay in displaying
On Thu, 2017-07-13 at 18:44 +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> The problem occurs when we call spice_playback_channel_set_delay before
> the channel had received any data setting c->last_time,
Interesting bug... setting the delay of the playback before the pl
GST_DEBUG_GRAPH_SHOW_FULL_PARAMS is available since that
---
src/channel-display-gst.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 87e472c..fcb9e25 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -297,7
On Thu, 2017-07-13 at 14:33 +0200, Victor Toso wrote:
> From: Victor Toso
>
> This patch fixes the avdec_h264 element not being present on
> gstvideo_has_codec() which get all decoder elements from GstRegistry
> and filter them on our GstCaps in order to get the ones for given
> codec.
>
> The i
On Thu, 2017-07-13 at 13:22 +0200, Victor Toso wrote:
> Hi,
>
> On Thu, Jul 13, 2017 at 01:18:14PM +0200, Pavel Grunt wrote:
> > On Thu, 2017-07-13 at 13:11 +0200, Victor Toso wrote:
> > > On Thu, Jul 13, 2017 at 01:05:31PM +0200, Pavel Grunt wrote:
> > > > GS
On Thu, 2017-07-13 at 13:11 +0200, Victor Toso wrote:
> On Thu, Jul 13, 2017 at 01:05:31PM +0200, Pavel Grunt wrote:
> > GStreamer's avdec_h264 needs h264parse to be able to process H264 video
> > streams. However the check for elements through GstRegistry forgot to
> >
GStreamer's avdec_h264 needs h264parse to be able to process H264 video
streams. However the check for elements through GstRegistry forgot to
include the parsers, thus making spice-gtk to not set the relevant cap
to inform the server about H264 decoding capability.
---
src/channel-display-gst.c |
Signed-off-by: Victor Toso
Signed-off-by: Pavel Grunt
---
po/POTFILES.in | 13 +
src/channel-main.c | 15 ++-
src/channel-port.c | 4 +++-
src/channel-usbredir.c | 8
src/giopipe.c
This reverts commit 73cd553fb0fbd213b64d72f8b4289ed8a17fc6c0.
It may be an optimization, but it complicates turning off
the capslock once it is enabled.
https://bugs.freedesktop.org/show_bug.cgi?id=101344
---
src/channel-inputs.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
Table, we have to change from
> GHashTableIter to a simple GList of keys.
>
> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1373830
> Signed-off-by: Victor Toso
Acked-by: Pavel Grunt
> ---
> src/channel-main.c | 50 ++
>
Hi,
On Mon, 2017-07-03 at 15:28 +0200, Victor Toso wrote:
> From: Victor Toso
>
> With SpiceFileTransferTask we suggest that Spice clients watch
> (signal) SpiceMainChannel::new-file-transfer so it can follow the
... so they can..
> transfer's progress till the moment it is finished.
>
> On (si
---
v2:
- Use ngettext for error messages in plural
- rebased on top of Victor's patch
---
po/POTFILES.in | 4
src/channel-main.c | 9 +++--
src/channel-port.c | 4 +++-
src/channel-usbredir.c | 2 +-
src/smartcard-manager.c| 5 +++
On Tue, 2017-07-11 at 08:12 +0100, André Rodier wrote:
> Hello Victor.
> Thank you for your prompt answer. I will see what we can do.
Hi,
you can use a tool `recordmydesktop` to record windows of an application. Take a
look at its man page, it has several examples of usage (you can give it an id o
---
src/usb-device-manager.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index bbe2391..dfac5a0 100644
--- a/src/usb-device-manager.c
+++ b/src/usb-device-manager.c
@@ -635,9 +635,9 @@ static void
spice_usb_device_man
On Tue, 2017-07-11 at 08:05 +0200, Pavel Grunt wrote:
> On Mon, 2017-07-10 at 17:57 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > Signed-off-by: Victor Toso
>
> Acked-by: Pavel Grunt
I forgot about a patch (acked) about this /o\
The comment about nge
On Mon, 2017-07-10 at 17:57 +0200, Victor Toso wrote:
> From: Victor Toso
>
> Signed-off-by: Victor Toso
Acked-by: Pavel Grunt
> ---
> src/channel-main.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/channel-main.c b/sr
On Mon, 2017-07-03 at 15:28 +0200, Victor Toso wrote:
> From: Victor Toso
>
There are more untranslated error messages in the channel-main.c related to
file-xfer (search for g_error_new)
> Signed-off-by: Victor Toso
> ---
> src/channel-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
On Thu, 2017-07-06 at 14:32 +0100, Frediano Ziglio wrote:
> This will make easier to change code that handle images.
>
> Signed-off-by: Frediano Ziglio
> ---
> Makefile.am | 2 ++
> vdagent/image.cpp | 86
> +
> vdagent/image.h |
On Fri, 2017-06-30 at 12:56 +0200, Victor Toso wrote:
> From: Victor Toso
>
> The Playbin can provide the full pipeline which reduces the
> overall maintenance in the code as we don't need to track which
> decoder can work with our stream type.
>
> We need to maintain the GstCaps per SPICE_VIDEO
On Thu, 2017-07-06 at 14:31 +0100, Frediano Ziglio wrote:
> Compiler warnings for unused static variable.
> Not for constants.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> common/vdlog.h | 8
> 1 file changed, 4 insertions(+), 4 deletions
On Thu, 2017-07-06 at 14:31 +0100, Frediano Ziglio wrote:
> The spec file cause the generation of debuginfo packages however
> the build fails as the executables are not compiled with debugging
> information.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
>
Silence -Wmissing-field-initializers warnings.
---
imo it also makes the code more readable (especially tests/session.c)
---
src/channel-display-gst.c | 3 +-
src/channel-main.c| 4 +-
src/channel-record.c | 16 +++--
src/spice-channel.c | 12 ++--
src/spice-gtk-session.c
On Fri, 2017-07-07 at 09:16 +0100, Frediano Ziglio wrote:
> Uses secure version https://www.spice-space.org.
> Avoid not secure and use same full name.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> mingw-spice-vdagent.spec.in | 2 +-
> spice-vdag
d the original repos at https://cgit.freedesktop.org/spice/
Pavel
>
> Cheers, Daniel
>
>
> On 2017-07-06 18:17, Pavel Grunt wrote:
> > Hi Daniel,
> >
> > it's been already fixed in the spice-gtk git master:
> > https://cgit.freedesktop.or
Hi Daniel,
it's been already fixed in the spice-gtk git master:
https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=a7381b0864b7e6b15e6d08f6
8e53bf3a429ab4ed
Any feedback regarding issues on non X11 system is welcome.
Thanks,
Pavel
On Thu, 2017-07-06 at 17:35 +0200, Daniel Albers wrote:
> N
On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> From: Victor Toso
>
> With this patch, we can find all the elements in the registry that are
> video decoders which can handle the predefined GstCaps.
>
> Main benefits are:
> - We don't rely on a predefined list of GstElements. We don't ne
Signed-off-by: Pavel Grunt
---
v2 per Christophe's suggestion:
use GArray as parameter
---
src/spice-channel.c | 34 --
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index b8cf19c..4c3db9d 100644
The commit babe5630d5d3242b1d186cccdd5b4d51debe78e9 forgot to update
position of the caps pointer making remote caps to not be stored.
That cause strange behavior in remote-viewer - it always opened window
for each remote display.
Signed-off-by: Victor Toso
Signed-off-by: Pavel Grunt
---
the
Signed-off-by: Pavel Grunt
---
src/spice-channel.c | 41 +
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index b8cf19c..2422811 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> From: Victor Toso
>
> On GST_MESSAGE_STREAM_START our stream is about to start and it
> seems
> a good moment to debug GStreamer pipeline if requested.
>
So this is just for the debug purpose.
> That we can do with GST_DEBUG_BIN_TO_DOT_FI
On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> From: Victor Toso
>
> The Playbin can provide the full pipeline which reduces the
> overall maintenance in the code as we don't need to track which
> decoder can work with our stream type.
>
> We need to maintain the GstCaps per SPICE_VIDEO
d codec type value was sent, spice-gtk will fail
> to
> create the decoder and any messages related to this stream-id will
> be
> ignored.
>
> Signed-off-by: Victor Toso
> Signed-off-by: Victor Toso
Acked-by: Pavel Grunt
It is a programmer error. The programmer should c
On Mon, 2017-06-26 at 06:18 -0400, Frediano Ziglio wrote:
> >
> > The widget is defined as GTK_TYPE_BOX, use GtkBox instead of
> > GtkVBox.
>
> Shouldn't you set the orientation to vertical too? I think the
> default
> is horizontal.
the object is created with the vertical orientation, see the
d
On Mon, 2017-06-26 at 06:08 -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Fri, 2017-06-23 at 11:35 -0400, Frediano Ziglio wrote:
> > > >
> > > > GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be
> > > > deprecated. Switch to GtkContainer api if possible.
> > > > ---
> > > > src/
The widget is defined as GTK_TYPE_BOX, use GtkBox instead of GtkVBox.
---
src/usb-device-widget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
index b394499..747887c 100644
--- a/src/usb-device-widget.c
+++ b/src/usb-devi
It is enough for us. Also GtkBox api has changed recently in gtk master.
---
src/usb-device-widget.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
index 747887c..e87bdff 100644
--- a/src/usb-device-widget.c
+++ b/s
Hi,
On Fri, 2017-06-23 at 11:35 -0400, Frediano Ziglio wrote:
> >
> > GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be
> > deprecated. Switch to GtkContainer api if possible.
> > ---
> > src/usb-device-widget.c | 15 ---
> > 1 file changed, 8 insertions(+), 7 deletions(-)
>
Hello,
On Sun, 2017-06-25 at 01:15 +0200, AmigAsger wrote:
> Dear Spice-Devel,
>
> I have been investigating an SSL-issue, which all of a sudden
> occured on my Arch Linux distribution (when connecting to my proxmox
> virtualization center).
>
> Something seems to break from spice-glib-0.33-3-x8
On Fri, 2017-06-23 at 11:39 -0400, Frediano Ziglio wrote:
> >
> > ---
> > src/usb-device-widget.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
> > index e87bdff..2d07468 100644
> > --- a/src/usb-device-widget.c
>
---
src/usb-device-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
index e87bdff..2d07468 100644
--- a/src/usb-device-widget.c
+++ b/src/usb-device-widget.c
@@ -208,7 +208,7 @@ static GObject *spice_usb_device_widget_co
GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be
deprecated. Switch to GtkContainer api if possible.
---
src/usb-device-widget.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
index b394499..e87bdff 10
On Fri, 2017-06-23 at 13:46 +0200, Daniel Pocock wrote:
>
> On 23/06/17 13:33, Pavel Grunt wrote:
> > On Fri, 2017-06-23 at 12:55 +0200, Daniel Pocock wrote:
> > > I recently updated a Debian system, here are the new and old
> > > versions of
> > > each pac
On Fri, 2017-06-23 at 12:55 +0200, Daniel Pocock wrote:
> I recently updated a Debian system, here are the new and old
> versions of
> each package from dpkg.log
>
> upgrade virt-viewer:amd64 1.0-1 5.0-1
> upgrade virt-manager:all 1:1.0.1-5 1:1.4.0-5
> upgrade spice-client-gtk:amd64 0.25-1+b1 0.33
From: Tomáš Bohdálek
---
v2: Be consistent with '=='/'===' in the expressions
---
display.js | 26 --
spiceconn.js | 2 ++
webm.js | 12 ++--
3 files changed, 32 insertions(+), 8 deletions(-)
diff --git a/display.js b/display.js
index 0868f91..abd5b1a 100
On Tue, 2017-06-06 at 23:23 +0200, Jakub Janků wrote:
> Log appropriate error messages when we receive
> VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED,
> VD_AGENT_FILE_XFER_STATUS_VDAGENT_NOT_CONNECTED,
> VD_AGENT_FILE_XFER_STATUS_DISABLED.
Acked-by: Pavel Grunt
Thanks,
Pavel
> ---
On Thu, 2017-06-22 at 09:22 +0300, Snir Sheriber wrote:
>
> On 06/22/2017 12:38 AM, Jeremy White wrote:
> > > > Alright, it's up on gitlab now:
> > > >https://gitlab.com/spice/x11spice
> > > >
> > > > Looks like there isn't any obvious way for me to ask to edit
> > > > the
> > > > pages; I wa
Hi, sure. I'll change it to '==='
(I think in this case it does not matter - it's comparing ints not objects,
but as you said, we should be consistent)
On Tue, Jun 20, 2017 at 10:44 PM, Jeremy White
wrote:
> Hi,
>
> One tiny niggle:
>
> On 06/08/2017 09:27 A
Avoids a critical to be logged when closing remote-viewer:
"gl_make_current: assertion 'd->egl.context_ready' failed"
---
src/spice-widget.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 139510d..c335083 100644
--- a/src/spice-
On Mon, 2017-06-19 at 10:06 -0400, Frediano Ziglio wrote:
> Question: can GDK have no X11?
chances are low but there may be a distro shipping gtk without the x11
backend
> I suppose only wayland compiled in?
or win32 or quartz (macOS).
The issue I noticed was in egl - which can work with wayland
Hi,
On Mon, 2017-06-19 at 10:05 -0400, Marc-André Lureau wrote:
> Hi,
>
> looks fine, how did you reproduce a build issue and make sure it
> fixed it?
>
I noticed an "unguarded" usage of GDK_IS_X11_DISPLAY(), so i built
gtk+ enabling only the wayland backend (and add the guards where
needed).
---
src/spice-gtk-session.c | 2 +-
src/spice-widget-egl.c | 14 +-
src/spice-widget.c | 2 +-
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
index 33db3c8..e338ce6 100644
--- a/src/spice-gtk-session.c
+++ b/src
On Mon, 2017-06-19 at 06:00 -0400, Marc-André Lureau wrote:
>
> - Original Message -
> >
> >
> > - Original Message -
> > > Avoids a critical to be logged when closing remote-viewer:
> > > "gl_make_current: assertion 'd->egl.context_ready' failed"
> >
> > ack, thanks
>
> actua
Avoids a critical to be logged when closing remote-viewer:
"gl_make_current: assertion 'd->egl.context_ready' failed"
---
src/spice-widget-egl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
index 7c21113..5951ae6 100644
--- a/src/spice-wid
ients that feature
> VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS capability.
Acked-by: Pavel Grunt
Thanks!
Pavel
> ---
> spice/vd_agent.h | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> index 2a168d0..7109ede
1 - 100 of 1683 matches
Mail list logo
