ndows/desktop/ms633516(v=vs.85).aspx
CBTProc callback hook for notifying window position and size changes
https://msdn.microsoft.com/en-us/library/windows/desktop/ms644977(v=vs.85).aspx
Thank you for an amazing year and a half working here.
Hope to see you all someday again.
Lukas Ve
bout leting the user run scripts on a VM
>> from command line, but wer could have some kind of settings, where the
>> user would choose specific command like words for specific
>> binaries/scripts in the VM beforehand.
>>
>&g
and it's better
to discuss it in the list instead of just us 3 in Brno :)
Thanks for all the responses.
--
Lukas Venhoda
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
---
Fixup
- Forgot to delete GError *err = NULL;
Changes since v3:
- changed drawing_area_
alize failed: %s", err->message);
> > +g_clear_error(&err);
> > +}
> > +}
> > +#endif
> > +
> > set_egl_enabled(display, true);
> >
> > if (d->egl.context_ready) {
> > --
>
> other than that
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
---
Changes since v3:
- changed drawing_area_realized variable to gtk_widget_get_realized()
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
---
Changes since v2:
- added drawing_area_realized variable
- only enable egl after spi
ee that the widget is realized when
> spice_display_widget_gl_scanout() is called, which would results in other
> warnings/criticals messages.
>
This could potentionally be a problem. Does spice_egl_realize_display()
require the widget to be fully realized before the c
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
Drawing_area_realize is no longer needed.
---
Changes since v1:
- changed from recursive cal
{
>use context (as current code) ...
> }
>
> perhaps would be even better to call spice_egl_init before
> set_egl_enabled
>
> > }
> > }
> >
>
> Frediano
>
I wanted to do it like that originally, but didn't want to make a second
runtime if check.
--
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
Drawing_area_realize is no longer needed.
---
Not needed for GtkGLArea, because it only suppo
VAO shouldn't be bound indefinitely.
Move glEnableVertexAttribArray and glVertexAttribPointer to init.
These settings and currently bound Vertex Buffer Object will be saved to VAO.
Unbinding VAO will set these to default (unbinding them).
Instead of calling these settings every frame, bind VAO be
support OGL 3.0?
Basically all hardware since 2006 supports OGL 3.3 and up, with most of it
skipping 3.0 - 3.2 altogether
Intel GPUs support it since Sandy Bridge, but before that they supported
only version 2.1
On Mon, Jul 18, 2016 at 10:44 AM, Lukas Venhoda wrote:
> Since spice-widget-egl alre
Since spice-widget-egl already requires Opengl 3.3,
change shader version from 130 (OGL3.0) to 330 (OGL3.3)
This change enables more advanced features in OpenGL shaders.
---
src/spice-widget-egl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/spice-widget-egl.c b/src
Hi
On Fri, Jun 24, 2016 at 5:46 PM, Victor Toso wrote:
>
> On Thu, Jun 23, 2016 at 06:05:51PM +0200, Lukas Venhoda wrote:
> > Ping for pushing
>
> Pushed the first two patches. Last one has g_mutex_init/clear pending
>
I already sent the fixed patch, with GMutex clear/
Ping for pushing
On Thu, May 26, 2016 at 1:01 PM, Victor Toso wrote:
> Hi,
>
> On Wed, May 25, 2016 at 03:51:42PM +0200, Lukáš Venhoda wrote:
> > From: Lukas Venhoda
> >
> > Try to connect to shared folder automatically on Windows.
> >
> > On each loop of
iver letter, so that we can unmap it later.
The drive shouldn't be mapped before starting the service, this is just a
safety check,
but we should still unmap it later.
--
Lukas Venhoda
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
tails if this is the
> right function)
So I tested this function, and it doesn't actually return the local name
(drive letter). It might return this on older Windows, but on the newer
ones, since drive letters are per user, it doesn't return anything.
(l
Hi
*From: *Victor Toso
*Sent: *pondělí 2. května 2016 10:30
*To: *Lukas Venhoda
*Cc: *spice-devel@lists.freedesktop.org
*Subject: *Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows:
Dismount shared folder on service stop
Hi,
On Mon, May 02, 2016 at 10:05:33AM +0200, Lukas
:
> From: Lukas Venhoda
>
> Try to connect to shared folder automatically on Windows.
>
> On each loop of run_service(), run a GTask, that waits for half a second.
> If read_thread() returns, it means, that sharing is not yet connected,
> and the map_drive task is cancelled.
>
&g
Hi
*From: *Victor Toso
*Sent: *pondělí 2. května 2016 9:08
*To: *Lukas Venhoda
*Cc: *spice-devel@lists.freedesktop.org
*Subject: *Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows:
Dismount shared folder on service stop
Hey,
Sorry, I forgot to reply to this sooner.
On Fri
Hi.
*From: *Victor Toso
*Sent: *pátek 8. dubna 2016 9:12
*To: *Lukas Venhoda
*Cc: *spice-devel@lists.freedesktop.org
*Subject: *Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows:
Dismount shared folder on service stop
> @@ -749,6 +749,7 @@ typedef enum _MapDriveE
Check whether Spice Folder is already mapped.
If yes, don't try to map another one.
---
Changes since v4:
- Moved some variables around
- Better debug message
- Fixed bug, that would cause the folder not to mount automatically
Changes since v3:
- changed function is_spice_folder_mapped to get_
Try to connect to shared folder automatically on Windows.
On each loop of run_service(), run a GTask, that waits for half a second.
If read_thread() returns, it means, that sharing is not yet connected,
and the map_drive task is cancelled.
If the map_drive task is NOT cancelled, it enumerates fre
When stopping the service, automatically disconnect shared folder on
windows. Not dismounting could lead to multiple shared folders.
---
Changes since v4:
- Dont lookup drive letter when unmapping
- Uses a service_data structure and map_drive_data structure to store
the drive_letter for
Check whether Spice Folder is already mapped.
If yes, don't try to map another one.
---
Changes since v3:
- changed function is_spice_folder_mapped to get_spice_folder_letter
- Now returns the mapped folder drive letter
- This can be used to call unmap_drive
- No need for global variab
When stopping the service, automatically disconnect shared folder on
windows. Not dismounting could lead to multiple shared folders.
---
Changes since v3:
- Better handeling of string names
- Syntax cleanup
- Remove global variable drive_letter
- Now scans for mapped drive and unmaps it
Cha
Try to connect to shared folder automatically on Windows.
On each loop of run_service(), run a GTask, that waits for 0.5s.
If sharing is disabled, read_thread will immediately return and cause the
main_loop to stop.
This in turn causes the cancellable object to be canceled and the loop stops.
If
H
On Thu, Mar 24, 2016 at 10:34 AM, Victor Toso wrote:
> Hi,
>
> On Thu, Mar 17, 2016 at 02:47:51PM +0100, Lukas Venhoda wrote:
> > When stopping the service, automatically disconnect shared folder on
> > windows. Not dismounting could lead to multiple shared folde
Hi,
On Thu, Mar 24, 2016 at 10:46 AM, Victor Toso wrote:
> Hi,
>
> On Thu, Mar 17, 2016 at 02:47:50PM +0100, Lukas Venhoda wrote:
> > Check whether Spice Folder is already mapped.
> > If yes, don't try to map another one.
>
> I have found some issue with this
Adds --no-service argument.
This runs the program normally, instead of running as Windows service.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff -
her a spice folder already exists.
Folder rename is not implemented, because it is curently not trivial,
and will require wome rewrite of the windows service.
Lukas Venhoda (7):
spice-webdavd: Safer MDNS Unregister
spice-webdavd: Hide client folder when sharing disabled
spice-webdavd-windows:
Try to connect to shared folder automatically on Windows.
On each loop of run_service(), run a GTask, that waits for 0.5s.
If sharing is disabled, read_thread will immediately return and cause the
main_loop to stop.
This in turn causes the cancellable object to be canceled and the loop stops.
If
When stopping the service, automatically disconnect shared folder on
windows. Not dismounting could lead to multiple shared folders.
---
Changes since v2:
- None
Changes since v1:
- New patch
---
spice/spice-webdavd.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/s
Shows alert on windows when CreateFile fails.
This can happen, when webdavd is run without administrator privileges.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-
After disabling sharing, remove client folder from file explorer.
Show client folder again after sharing is re-enabled.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Check whether Spice Folder is already mapped.
If yes, don't try to map another one.
---
Changes since v2:
- New patch
---
spice/spice-webdavd.c | 58 ---
1 file changed, 51 insertions(+), 7 deletions(-)
diff --git a/spice/spice-webdavd.c b/spice/sp
Hi
Answers are below
Lukáš Venhoda
*From: *Pavel Grunt
*Sent: *pátek 18. března 2016 7:21
*To: *Lukas Venhoda ; spice-devel@lists.freedesktop.org
*Subject: *Re: [Spice-devel] [phodav PATCH 5/7 v3] spice-webdavd-windows:
Automount shared folder
> +gchar drive_letter;
P: You don
Add error handling when unregistering folder from file explorer.
Move unregistering to a function.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 27 ++-
1 file changed, 22 insertions(+), 5 del
p_drive, I think you should implement the
> > function to check if there is already a mapping.
> >
> > Mapping should be always removed before starting the service.
> > It is removed when stopping the service, and automatically removed when
> > restarting Windows.
> >
>
> "always" is in the best of the worlds without any crash or force shutdown
> or manual intervention etc.. Please add a check before adding more drives.
>
> thanks
>
Ok will add the check.
--
Lukas Venhoda
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Thu, Feb 25, 2016 at 4:21 PM, Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Thu, Feb 25, 2016 at 3:19 PM, Lukas Venhoda
> wrote:
> > +static void
> > +map_drive(GTask *task,
> > + gpointer source_objec
Try to connect to shared folder automatically on Windows.
On each loop of run_service(), run a GTask, that waits for half a second.
If read_thread() returns, it means, that sharing is not yet connected,
and the map_drive task is cancelled.
If the map_drive task is NOT cancelled, it enumerates fre
When stopping the service, automatically disconnect shared folder on
windows. Not dismounting could lead to multiple shared folders.
---
Changes since v1:
- New patch
---
spice/spice-webdavd.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/spice/spice-webdavd.c b/spi
Shows alert on windows when CreateFile fails.
This can happen, when webdavd is run without administrator privileges.
---
spice/spice-webdavd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index c8fb795..b3fd1ea 100644
--- a/sp
Add error handling when unregistering folder from file explorer.
Move unregistering to a function.
---
Changes:
- Split patch into 2
---
spice/spice-webdavd.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/spice/spice-webdavd.c b/spice/spice-webda
After disabling sharing, remove client folder from file explorer.
Show client folder again after sharing is re-enabled.
---
Changes
- Split patch into 2
---
spice/spice-webdavd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index 68f3cf0..c8
Adds --no-service argument.
This runs the program normally, instead of running as Windows service.
---
spice/spice-webdavd.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index b3fd1ea..f9c5cf1 100644
--- a/spice/spice
just sit in the mailing list, until I complete the automounting itself.
Lukas Venhoda (4):
spice-webdavd: Safer MDNS Unregister
spice-webdavd: Hide client folder when sharing disabled
spice-webdavd: Alert when CreateFile fails
spice-webdavd: Option to run without service on Windows
spice/spice
Fixes color order on PowerPC when using GLZ image compression.
---
Changes since v3:
- No changes
---
src/decode-glz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/decode-glz.c b/src/decode-glz.c
index 34a7185..a5fb6c1 100644
--- a/src/decode-glz.c
+++ b/src/decode-glz.
From: Fabiano Fidêncio
---
Changes since v3:
- No changes
- Already ACKed, just resending
---
src/spice-channel.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index a2a6cb9..26b5c38 100644
--- a/src/spice-c
Save screenshot in proper endianess
xRGB on LE machine and BGRx on BE machine
---
Changes since v3:
- New patch
---
src/spicy-screenshot.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/spicy-screenshot.c b/src/spicy-screenshot.c
index d90d4e8..63666d6 100644
--- a/src/spicy-screen
From: Fabiano Fidêncio
---
Changes since v3:
- No changes
- Already ACKed, just resending
---
src/spice-channel.c | 61 -
1 file changed, 37 insertions(+), 24 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index 26b5c38.
The surface before conversion can be either LE or BE on a BE machine.
Check against both BE and LE color order on BE machine.
---
Fixed for git-am when using without patch 1/9 from this series.
Changes since v3:
- Removed alpha clearing
- The change actually broke alpha
- Added dual color or
n that happens, we don't want to byteswap, because that for some reason
causes artifacts.
Originally I thought, that there are more cases, when saved_want_original
== TRUE,
but we still want to byteswap, but as it turns out, that is not the case,
and we never want to byteswap,
when s
Hi
On Thu, Dec 17, 2015 at 11:32 AM, Lukas Venhoda wrote:
>
> I'm wondering if this could cause issues when blitting transparent
>> surfaces to a 16bpp canvas, as the canvas_get_image_internal documentation
>> mentions this as a usecase (and the only caller with wan
ert to LE (surface_format != wanted_format
will always fail),
but we can also convert from alpha to non-alpha or vice versa.
If it is LE we will only convert, if the alpha needs to be converted
(surface_format != wanted_format will fail only when alpha is different)
Hope
---
COPYING | 18 +-
common/canvas_utils.c | 2 +-
common/lines.c| 10 +-
common/log.c | 4 ++--
common/sw_canvas.c| 2 +-
5 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/COPYING b/COPYING
index 4362b49..e5ab03e 100644
---
COPYING.LIB | 18 +-
ChangeLog | 2 +-
usb-redirection-protocol.txt| 4 ++--
usbredirhost/usbredirhost.c | 4 ++--
usbredirparser/usbredirparser.c | 10 +-
usbredirparser/usbred
h ppc (both 16bpp
and 32bpp),
I think that's probably WinXP specific issue.
--
Lukas Venhoda
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
e WinXP 16bpp had it's own
weird issues.
But from what I understand, it shouldn't be an issue, because setting
want_original to TRUE
will just convert the canvas to the correct one when using
canvas_draw_alpha_blend() anyway right?
> Christophe
>
--
Lukas Venhoda
__
MPRESSION, and return TRUE at the end of
this function.
Always returning TRUE seems nicer to me, because it doesn't break the
symmetry in the switch.
--
Lukas Venhoda
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freede
Don't disconnect the display channel, when unsupported compression is
requested from the client. Not changing the compression is enough.
https://bugs.freedesktop.org/show_bug.cgi?id=92821
---
Forgot to add bug reference
Forgot to add break
Changes since v1:
- Not only for lz4, but now for all un
Don't disconnect the display channel, when unsupported compression is
requested from the client. Not changing the compression is enough.
https://bugs.freedesktop.org/show_bug.cgi?id=92821
---
Forgot to add bug reference
Changes since v1:
- Not only for lz4, but now for all unsupported compressio
Don't disconnect the display channel, when unsupported compression is
requested from the client. Not changing the compression is enough.
---
Changes since v1:
- Not only for lz4, but now for all unsupported compressions
---
server/dcc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
dif
Hi Pavel,
On Wed, Dec 16, 2015 at 3:01 PM, Pavel Grunt wrote:
> Hi Lukas,
>
> is the client disconnected?
>
If the function that handles preferred compression returns FALSE,
red_channel_client_disconnect() is called.
>
> On Wed, 2015-12-16 at 14:48 +0100, Lukas Venhod
Don't diconnect client, if lz4 is requested as a preferred compression,
but the server doesn't support it.
---
Sidenote:
Should server disconnect, when unsupported compression is requested?
FE if client sends unknown compression, and this switch goes to default.
Default could always return TRUE, ju
Fixes color order on PowerPC when using LZ image compression.
---
Changes since v3:
Changes since v2:
- No changes
Changes since v1:
- New commit
---
common/canvas_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index
The surface before conversion can be either LE or BE on a BE machine.
Check against both BE and LE color order on BE machine.
---
Changes since v3:
- Removed alpha clearing
- The change actually broke alpha
- Added dual color order checking
- On BE machines it can be both ARGB and RGBA
C
Fixes color order on PowerPC when using QUIC image compression.
---
Changes since v3:
Changes since v2:
Changes since v1:
- No changes
---
common/canvas_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 30baa22..b99f
The newly created surface can be converted, if saved_want_original
equals TRUE.
On BE machine we want to always convert, in order to properly byteswap
colors from LE order to BE order.
This is done by first creating BGRA/X surface with LE order data, and
then copying the data into a new A/XRGB su
On LE machine, color order when creating surface will always be A/XRGB.
On BE machines the color order will sometimes be ARGB and sometimes BGRA/X.
This is because we actually create the surface two times on BE machines.
Once with BE order, and then again with LE order. Copying data inbetween
thee
order data into it.
This creates a surface ith "wrong" data order.
We then create a second surface with xRGB color order and copy the data
into it, which in turn converts (byteswap) the colors into correct order.
Lukas Venhoda (9):
ppc: Always convert surface on BE machine
pixman_
Fixes color order on PowerPC when using LZ4 image compression.
---
Changes since v3:
Changes since v2:
- No changes
Changes since v1:
- New commit
---
common/canvas_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index
Fixes color order on PowerPC when using jpeg compression.
---
Changes since v3:
- None
Changes since v2:
- New commit
---
common/canvas_base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 736eacb..cc87f55 100644
--- a/
After the previous commit, spice_bitmap_try_as_pixman() can be
simplified as its #ifdef WORDS_BIGENDIAN exactly match what the
PIXMAN_LE_ constants do.
---
Changes since v3:
- None
Changes since v2:
- Improved commit msg
Changes since v1:
- New commit
---
common/pixman_utils.c | 18 +++---
When using image compression on PowerPC architecture, colors are in
wrong order ARGB -> BGRA.
This commit introduces macros, that will change the color order
according to machine endianness.
Theese macros are similar to QEMU macros in qemu-pixman.h
---
Changes since v3:
Changes since v2:
- None
---
common/canvas_utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/canvas_utils.c b/common/canvas_utils.c
index 0d1591a..789cd76 100644
--- a/common/canvas_utils.c
+++ b/common/canvas_utils.c
@@ -293,7 +293,7 @@ pixman_image_t *alloc_lz_image_surface(LzDecodeUsrDa
---
common/canvas_base.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 6f48340..6747465 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -1147,10 +1147,7 @@ static pixman_image_t
*canvas_get_image_internal(
ERY time on BE machine
(instead of checking for saved_want_original)
2. Create a new function, that converts the surface before this part of
code.
(This could end up with surface_create being called 3 times)
--
Lukas Venhoda
___
Spice-devel mail
Hi
On Mon, Oct 26, 2015 at 2:19 PM, Christophe Fergeau
wrote:
> On Thu, Oct 22, 2015 at 05:02:54PM +0200, Lukas Venhoda wrote:
> > When checking, whether we use alpha channel, we need to compare color
> > format with constant with the same byte order.
> >
> > When
ug [4]
(Download videos for better quality)
[1] http://1drv.ms/1OowwY1
[2] http://1drv.ms/1ksuatS
[3] https://bugs.freedesktop.org/attachment.cgi?id=119402
[4] https://bugs.freedesktop.org/show_bug.cgi?id=92817
Lukas Venhoda
On Wed, Nov 4, 2015 at 1:43 PM, Christophe Fergeau
wrote:
> On Wed, Nov
Self NACK
Wrong order of LE/BE macros
Should be the other way around:
#ifdef WORDS_BIGENDIAN
#define x8r8g8b8_ALPHA 0x00ffu
#else
#define x8r8g8b8_ALPHA 0xff00u
#endif
Will fix in next version, still some changes left.
On Thu, Oct 22, 2015 at 5:02 PM, Lukas Venhoda wrote
Fixes color order on PowerPC when using LZ image compression.
---
Changes since v2:
- No changes
Changes since v1:
- New commit
---
common/canvas_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 31f3cef..57b80f6 10
Fixes color order on PowerPC when using jpeg compression.
---
Changes since v2:
- New commit
---
common/canvas_base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 4c1bd2c..65b1c3f 100644
--- a/common/canvas_base.c
+++ b/
When checking, whether we use alpha channel, we need to compare color
format with constant with the same byte order.
When clearing alpha channel, we must clear in proper byte order.
---
Changes since v2:
- Added macro for proper alpha clearing
- Improved commit msg
Changes since v1:
- New comm
Fixes color order on PowerPC when using LZ4 image compression.
---
Changes since v2:
- No changes
Changes since v1:
- New commit
---
common/canvas_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 57b80f6..4c1bd2c 1
Fixes color order on PowerPC when using QUIC image compression.
---
Changes since v2:
Changes since v1:
- No changes
---
common/canvas_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 6f48340..31f3cef 100644
--- a/c
On LE machine, color order will always be ARGB.
On BE machines color order will sometimes be ARGB and sometimes BGRA.
(This is because surface is sometimes created using native byte order,
and sometimes using the network byte order, which is always LE)
This change introduces cases for BGRA color b
After the previous commit, spice_bitmap_try_as_pixman() can be
simplified as its #ifdef WORDS_BIGENDIAN exactly match what the
PIXMAN_LE_ constants do.
---
Changes since v2:
- Improved commit msg
Changes since v1:
- New commit
---
common/pixman_utils.c | 18 +++---
1 file changed, 3
When using image compression on PowerPC architecture, colors are in
wrong order ARGB -> BGRA.
This commit introduces macros, that will change the color order
according to machine endianness.
Theese macros are similar to QEMU macros in qemu-pixman.h
---
Changes since v2:
- None
Changes since v1:
os in canvas_util.c
- Cleaned up pixman-utils.h using the new macros
---
Lukas Venhoda (8):
pixman_utils: Add macros for color byte ordering
pixman_utils: Use PIXMAN_LE_ constants in spice_bitmap_try_as_pixman()
ppc: Added supprt for bigendian color byte order
ppc: Fix colors on ppc when using
Change inet_aton function to glib functions.
inet_aton only supported IPv4 addresses, and wasn't available on windows
machines. GInetAddress functions support IPv6 natively, and requires less
boilerplate code then IPv6 gettaddrinfo().
---
Changes since v2:
- Changed printf to spice_debug
Changes
Only check for address lenght, when connecting trough IP address.
It is not used, when connecting trough DNS hostname.
---
Changes since v3:
- Nothing
Changes since v2:
- Also moved variable declarations
Changes since v1:
- New patch
---
common/ssl_verify.c | 15 ---
1 file change
This is required by the new GInetAddress functions.
---
Changes since v3:
- Changed commit message
- Now cleanly applies after f7ec855af3deff18aeb43ddbf2467c565f4bf346
Changes since v2:
- New patch
---
m4/spice-deps.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/spic
On Thu, Oct 22, 2015 at 11:42 AM, Fabiano Fidêncio
wrote:
> Is there a specific reason for changing the g_debug() to printf()?
>
> >
> > -if ((addr_len == alt_ip_len)&&
> > -!memcmp(ASN1_STRING_data(name->d.iPAddress), &addr,
> addr_len)) {
> > -
Only check for address lenght, when connecting trough IP address.
It is not used, when connecting trough DNS hostname.
---
Changes since v2:
- Also moved variable declarations
Changes since v1:
- New patch
---
common/ssl_verify.c | 15 ---
1 file changed, 8 insertions(+), 7 deletion
This is required by the new IPv6 verify_hostname.
---
Changes since v2:
- New patch
---
m4/spice-deps.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
index e4b2c8d..8ef4835 100644
--- a/m4/spice-deps.m4
+++ b/m4/spice-deps.m4
@@ -155,7 +1
Change inet_aton function to glib functions.
inet_aton only supported IPv4 addresses, and wasn't available on windows
machines. GInetAddress functions support IPv6 natively, and requires less
boilerplate code then IPv6 gettaddrinfo().
---
Changes since v2:
- Now uses glib gio GInetAddress
- R
Print IP address instead of DNS, when using IP adress connection.
---
Changes since v1:
- New patch
- Wasn't changed in v1
---
common/ssl_verify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/ssl_verify.c b/common/ssl_verify.c
index 24c6e2c..72a3dd8 100644
--- a/
Only check for address lenght, when connecting trough IP address.
It is not used, when connecting trough DNS hostname.
---
Changes since v1:
- New patch
- Wasn't moved in v1
---
common/ssl_verify.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/common/ssl_veri
1 - 100 of 179 matches
Mail list logo
