}
> -if (chmod(vdagentd_socket, 0666)) {
> -syslog(LOG_CRIT, "Fatal could not change permissions on %s: %m",
> - vdagentd_socket);
> -udscs_destroy_server(server);
> -return 1;
> +
> +/* no need to set permissions on a socket that was provided by systemd */
> +if (own_socket) {
> +if (chmod(vdagentd_socket, 0666)) {
> +syslog(LOG_CRIT, "Fatal could not change permissions on %s: %m",
> + vdagentd_socket);
> +udscs_destroy_server(server);
> +return 1;
> +}
> }
>
> if (do_daemonize)
> @@ -1181,8 +1210,12 @@ int main(int argc, char *argv[])
> vdagent_virtio_port_destroy(&virtio_port);
> session_info_destroy(session_info);
> udscs_destroy_server(server);
> -if (unlink(vdagentd_socket) != 0)
> -syslog(LOG_ERR, "unlink %s: %s", vdagentd_socket, strerror(errno));
> +
> +/* leave the socket around if it was provided by systemd */
> +if (own_socket) {
> +if (unlink(vdagentd_socket) != 0)
> +syslog(LOG_ERR, "unlink %s: %s", vdagentd_socket,
> strerror(errno));
> +}
> syslog(LOG_INFO, "vdagentd quitting, returning status %d", retval);
>
> if (do_daemonize)
> --
> 2.9.4
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
tried v5.0 v4.0 and v3.0 all of them require this DLL.
> v2.0 works on XP but I am not sure it supports UsbDk, can you confirm this?
The only version with UsbDk support is the latest one (5.0).
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Sun, Mar 5, 2017 at 8:46 PM, Fabiano Fidêncio wrote:
> On Sun, Mar 5, 2017 at 3:41 PM, Frediano Ziglio wrote:
>>
>> On Sun, Mar 5, 2017 at 12:37 PM, Victor Toso wrote:
>>>
>>> Hi,
>>>
>>> On Sun, Mar 05, 2017 at 11:46:01AM +0200, Sameeh Jub
and v3.0 all of them require this DLL.
> v2.0 works on XP but I am not sure it supports UsbDk, can you confirm this?
>>
>>
>> Cheers,
>> toso
>
> Do we support Windows XP as client?
No. We do not support windows XP as client.
Gtk3 dropped Windows XP support a while ago and we dropped Gtk2
support a while ago.
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
t; [2] https://gitlab.com/xerus/ci/tree/master
I guess is worth to check the CentOS CI. It can be easily integrated
with github/gitlab.
virt-viewer already makes use of that, libvirt as well as far as I remember.
>
> Does anyone disagree with moving to gitlab and making freedesktop a
> m
On Mon, Sep 5, 2016 at 1:36 PM, Victor Toso wrote:
> Hi,
>
> On Sat, Sep 03, 2016 at 01:49:06PM +0200, Fabiano Fidêncio wrote:
>> Howdy!
>>
>> Here is a small patch series adding support to ssh-agent-forward.
>> This patch series have been tested using a usable (b
On Sat, Sep 3, 2016 at 2:29 PM, Fabiano Fidêncio wrote:
> On Sat, Sep 3, 2016 at 2:02 PM, Victor Toso wrote:
>> Hi,
>>
>> On Sat, Sep 03, 2016 at 01:49:07PM +0200, Fabiano Fidêncio wrote:
>>> ---
>>
>> Could you please include some documentation abou
On Sat, Sep 3, 2016 at 2:02 PM, Victor Toso wrote:
> Hi,
>
> On Sat, Sep 03, 2016 at 01:49:07PM +0200, Fabiano Fidêncio wrote:
>> ---
>
> Could you please include some documentation about the protocol in the
> commit log? Check webdav ~ 6e5ea8d802ac8 or port ~ f188fb7a890
For example, with qemu, a ssh channel can be created this way:
-chardev spiceport,name=org.spice-space.ssh.0,...
And redirected to a virtio port:
-device virserialport,...,name=org.spice-space.ssh.0
Signed-off-by: Fabiano Fidêncio
---
server/reds.c | 3 +++
1 file changed, 3 insertions
The update is needed in order to introduce support to the brand new
SSH_SPICE_CHANNEL.
Signed-off-by: Fabiano Fidêncio
---
spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-common b/spice-common
index 38047fb..a6e090d 16
--- a/spice-common
+++ b/spice
The update is needed in order to introduce support to the brand new
SSH_SPICE_CHANNEL.
Signed-off-by: Fabiano Fidêncio
---
spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-common b/spice-common
index 62f3024..a6e090d 16
--- a/spice-common
+++ b/spice
---
spice/enums.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/spice/enums.h b/spice/enums.h
index 1d0c2db..1d61daf 100644
--- a/spice/enums.h
+++ b/spice/enums.h
@@ -422,6 +422,7 @@ enum {
SPICE_CHANNEL_USBREDIR,
SPICE_CHANNEL_PORT,
SPICE_CHANNEL_WEBDAV,
+SPICE_CHANNEL_S
[0]: https://gitlab.com/fidencio/spice-ssh-agent
[1]: https://gitlab.com/fidencio/virt-viewer/tree/wip/ssh-agent-forward
spice-proto:
Fabiano Fidêncio (1):
Add support to ssh channel
spice/enums.h | 1 +
1 file changed, 1 insertion(+)
spice-common:
Fabiano Fidêncio (1):
Add
---
spice.proto | 4
1 file changed, 4 insertions(+)
diff --git a/spice.proto b/spice.proto
index 0bfc515..eb99742 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1423,6 +1423,9 @@ channel PortChannel : SpicevmcChannel {
channel WebDAVChannel : PortChannel {
};
+channel SshChannel : PortC
side (part of OpenSSH 7.3 release)
is quite simple, just add in the guest's ssh config file:
Host: hostname
IdentityAgent: /var/run/spice-ssh-agentd/spice-ssh-agent-sock
It will forward the agent when connecting to that specify hostname.
Signed-off-by: Fabiano Fidêncio
---
co
d(gtk_widget_get_window(GTK_WIDGET(display))) :
> NULL;
> #endif
> }
>
> --
> 2.9.2
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
ACK!
(
On Wed, Jul 27, 2016 at 12:42 PM, Fabiano Fidêncio wrote:
> On Wed, Jul 27, 2016 at 12:39 PM, Christophe Fergeau
> wrote:
>> On Wed, Jul 27, 2016 at 11:17:38AM +0200, Fabiano Fidêncio wrote:
>>> This bogus code was introduced when switching to GTask API. Seems that
&g
On Wed, Jul 27, 2016 at 12:39 PM, Christophe Fergeau
wrote:
> On Wed, Jul 27, 2016 at 11:17:38AM +0200, Fabiano Fidêncio wrote:
>> This bogus code was introduced when switching to GTask API. Seems that
>> while writing those patches I just overlooked this part and set the wrong
&g
: Fabiano Fidêncio
---
src/vmcstream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmcstream.c b/src/vmcstream.c
index c536f71..ffb1ba4 100644
--- a/src/vmcstream.c
+++ b/src/vmcstream.c
@@ -411,7 +411,7 @@ write_cb(GObject *source_object,
{
GTask *task = user_data
: Fabiano Fidêncio
---
src/vmcstream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmcstream.c b/src/vmcstream.c
index c536f71..7c7af44 100644
--- a/src/vmcstream.c
+++ b/src/vmcstream.c
@@ -411,7 +411,7 @@ write_cb(GObject *source_object,
{
GTask *task = user_data
a)")
> writer.statement("return NULL")
> writer.end_block()
>
> --
> 2.9.2
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Acked-by: Fabiano Fidêncio
spice-devel
>
You need mingw{32,64}-libxml2 installed.
In the top dir of your virt-viewer checkout, do: dnf builddep
mingw-virt-viewer.spec
It should be enough for getting all the deps you need.
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Mon, Jun 20, 2016 at 5:34 PM, Marc-André Lureau
wrote:
> Hi
>
> On Mon, Jun 20, 2016 at 5:33 PM, Marc-André Lureau
> wrote:
>> On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio
>> wrote:
>>>> gtk_widget_set_can_focus(widget, true);
>>>>
grab_sequence_new_from_string("Control_L+Alt_L");
> d->activeseq = g_new0(gboolean, d->grabseq->nkeysyms);
> d->mouse_cursor = get_blank_cursor();
> --
> 2.7.4
>
> ___
> Spice-devel mailing list
>
Bokovoy
Acked-by: Fabiano Fidêncio
---
Sending the patch to the ML for the record.
I already ACKed the patch and anyone objects I'll push it Tomorrow.
---
src/spice-channel.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-chan
lly rather wrong - it is clearly making a bogus
>> assumption that a NULL username will result in auth failure - it should
>> definitely be left upto the SASL library to decide that on the server
>> side.
>
> On the client side, you mean.
>
>>> I tried to allow NULL username here but the problem is that we need
>>> eventually to set actual username so that SPICE communication can
>>> continue. And if SASL GSSAPI module did find default credentials, we
>>> need to pick up the username from them. This is possible theoretically
>>> but all my attempts to do so caused SPICE server side to drop actual
>>> SPICE connection.
>>
>>
>> I'm not sure what failure you just remove that check, but I think we
>> need to investigate that further, as I don't think that check for
>> NULL is right.
>
> It is wrong, for sure.
>
> Hm.. I retried again with a simple patch (attached) and it worked this
> time.
Nice, I really like the patch.
You have an ACK from me and if we don't have any objections in the
next days I'll push your patch _before_ the 0.32 release.
>
> --
> / Alexander Bokovoy
Thanks for patch and best regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
e when gtk-vnc doesn't need it?
Yeah, that's part of my plan to setup the environment and dig into it
as soon as I have time for it.
>
>>
>> Please, as I'm not whether Alexander is subscribed to our mailing list or
>> not,
>> let's keep him CC'ed f
On Mon, Jun 6, 2016 at 2:51 PM, Fabiano Fidêncio wrote:
> I'm sending Alexander Bokovoy's patch as it is, also here is some notes from
> him:
>
> "I'd really like to find a way to do it with pure SASL properties so that the
> code would work for both SPNEGO and
From: Alexander Bokovoy
Support SASL GSSAPI Kerberos by discovering default credential from
default Kerberos credentials cache.
If default Kerberos credential is missing, fallback to standard method
with password and username.
Signed-of-by: Alexander Bokovoy
---
src/spice-channel.c | 61 +
I'm sending Alexander Bokovoy's patch as it is, also here is some notes from
him:
"I'd really like to find a way to do it with pure SASL properties so that the
code would work for both SPNEGO and Kerberos. SPNEGO NTLMSSP would make it
working for environments where you don't have Kerberos but what
<= (char*) end - (char*) &start->points[0]);
> start = (QXLPathSeg*)(&start->points[count]);
> }
>
> --
> 2.7.4
>
> ___
> Spice-devel mailing list
> Spice-de
mem_size2 += sizeof(SpicePathSeg) + (uint64_t) count *
> sizeof(SpicePointFix);
> spice_assert(mem_size2 <= mem_size);
>
> seg->flags = start->flags;
> --
> 2.7.4
>
> _______
> Spice-devel mailing list
On Wed, May 25, 2016 at 7:30 AM, Pavel Grunt wrote:
> As stated in the commit d2f33178c40ac51b1c8b1bf796a328631d9869c7 Glib
> applications should only include "spice-client.h".
> ---
> src/spice-file-transfer-task.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/spice-file-tra
server/glz-encode.tmpl.c | 14 +++---
> 1 file changed, 3 insertions(+), 11 deletions(-)
Patch looks good, but II didn't try to build the patch.
I'm assuming you did, you have my ACK.
Acked-by: Fabiano Fidêncio
>
> diff --git a/server/glz-encode.tmpl.c b/server/glz-encod
self);
> self->priv->pending = TRUE;
> signal:
> -g_signal_emit(self, task_signals[SIGNAL_FINISHED], 0, error);
> +g_signal_emit(self, task_signals[SIGNAL_FINISHED], 0, self->priv->error);
> }
>
>
> --
> 2.5.5
>
Acked-by: Fabiano Fidêncio
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Toso,
On Sat, May 14, 2016 at 10:05 PM, Victor Toso wrote:
> Hi,
>
> On Sat, May 14, 2016 at 06:34:41PM +0200, Fabiano Fidêncio wrote:
>> On Sat, May 14, 2016 at 5:03 PM, Victor Toso wrote:
>> > If we are in coroutine context, fallback to return in idle; Otherwise,
Toso,
On Sat, May 14, 2016 at 10:09 PM, Victor Toso wrote:
> Hi,
>
> On Sat, May 14, 2016 at 05:56:45PM +0200, Fabiano Fidêncio wrote:
>> On May 14, 2016 17:29, "Victor Toso" wrote:
>> >
>> > We are checking self->priv->error but accessing the ar
On Sat, May 14, 2016 at 5:03 PM, Victor Toso wrote:
> If we are in coroutine context, fallback to return in idle; Otherwise,
> let GTask decide if callback should be called or not.
> ---
> src/gtask-helper.h | 45 +
> 1 file changed, 45 insertions(+)
>
On May 14, 2016 17:29, "Victor Toso" wrote:
>
> We are checking self->priv->error but accessing the argument GError *
> which is NULL and leads to a segfault.
>
> Program received signal SIGSEGV, Segmentation fault.
> spice_file_transfer_task_completed (self=self@entry=0x7fffd0006f00,
error=0x0) a
On Thu, May 12, 2016 at 10:57 PM, Victor Toso wrote:
> On Thu, May 12, 2016 at 10:52:09PM +0200, Fabiano Fidêncio wrote:
>> On Thu, May 12, 2016 at 10:42 PM, Victor Toso wrote:
>> > ---
>> > src/channel-main.c | 4 +++-
>> > 1 file changed, 3 insertions(+),
;
> --
> 2.5.5
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Acked-by: Fabiano Fidêncio
Just out of curiosity, did you get it just by reading the code
iv->error) {
> +if (self->priv->error && main_priv->agent_connected) {
> VDAgentFileXferStatusMessage msg = {
> .id = self->priv->id,
> .result = error->code == G_IO_ERROR_CANCELLED ?
> --
> 2.5.5
>
> __
break;
>> > +}
>> > case VD_AGENT_FILE_XFER_STATUS:
>> > case VD_AGENT_FILE_XFER_DATA: {
>> > VDAgentFileXferStatusMessage status;
>> > @@ -1489,6 +1503,10 @@ LRESULT CALLBACK VDAgent::wnd_proc(HWND hwnd, UINT
>> > message, WPARAM wparam, LPA
On Wed, May 4, 2016 at 6:41 PM, Visarion-Mingopol Alexandru-Viorel
wrote:
> Sure :)
Pushed!
>
> On Wed, May 4, 2016 at 7:33 PM, Fabiano Fidêncio
> wrote:
>>
>> Visarion,
>>
>> On Wed, May 4, 2016 at 5:19 PM, Alexandru Visarion
>> wrote:
>> >
skip spice_get_option_group()"
Let me know if you agree that I can do the change before pushing (and
you don't need to submit a v3).
Acked-by: Fabiano Fidêncio
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
roup: (skip)
> + * spice_get_option_group:
> *
> * Gets commandline options.
> *
> --
> 2.5.5
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice
HANDLE err = CreateFile("stderr.txt", GENERIC_WRITE, 0, NULL,
>> > CREATE_ALWAYS, 0, NULL);
>> > +assert(err != INVALID_HANDLE_VALUE);
>> > +
>> > +exec(redir_out ? out : INVALID_HANDLE_VALUE,
>> > + redir_err ? err : INVALID_HANDLE_VALUE);
>> > +
>> > +CloseHandle(out);
>> > +CloseHandle(err);
>> > +
>> > +// check file output
>> > +if (redir_out) {
>> > +char *data = read_file("stdout.txt");
>> > +assert(strstr(data, stdout_line) != NULL);
>> > +}
>> > +if (redir_err) {
>> > +char *data = read_file("stderr.txt");
>> > +assert(strstr(data, stderr_line) != NULL);
>> > +}
>> > +
>> > +DeleteFile("stdout.txt");
>> > +DeleteFile("stderr.txt");
>> > +
>> > +// check console output
>> > +if (!has_console)
>> > +return;
>> > +
>> > +char *data = read_console();
>> > +fprintf(log_f, "\nconsole: %s\nstdout expected: %s\nstderr expected:
>> > %s\n", data, stdout_line, stderr_line);
>> > +if (!redir_out)
>> > +assert(strstr(data, stdout_line) != NULL);
>> > +
>> > +if (!redir_err)
>> > +assert(strstr(data, stderr_line) != NULL);
>> > +free(data);
>> > +}
>> > +
>> > +static void
>> > +all_checks(void)
>> > +{
>> > +check(TRUE, FALSE);
>> > +check(FALSE, TRUE);
>> > +check(TRUE, TRUE);
>> > +
>> > +assert(AllocConsole());
>> > +has_console = TRUE;
>> > +h_console = GetStdHandle(STD_OUTPUT_HANDLE);
>> > +fprintf(log_f, "got console handles %p %p\n", h_console,
>> > GetStdHandle(STD_ERROR_HANDLE));
>> > +
>> > +check(FALSE, FALSE);
>> > +check(TRUE, FALSE);
>> > +check(FALSE, TRUE);
>> > +check(TRUE, TRUE);
>> > +
>> > +assert(FreeConsole());
>> > +has_console = FALSE;
>> > +h_console = INVALID_HANDLE_VALUE;
>> > +}
>> > +
>> > +int WINAPI WinMain(HINSTANCE hInstance G_GNUC_UNUSED, HINSTANCE
>> > hPrevInstance G_GNUC_UNUSED,
>> > + LPSTR lpCmdLine, int nShowCmd G_GNUC_UNUSED)
>> > +{
>> > +static const char cmd_seps[] = " \t\r\n\v";
>> > +
>> > +char *argv[10], *p;
>> > +int argc = 0;
>> > +
>> > +// parse arguments
>> > +for (p = strtok(lpCmdLine, cmd_seps); p && argc < 10; p = strtok(NULL,
>> > cmd_seps))
>> > +argv[argc++] = p;
>> > +argv[argc] = NULL;
>> > +
>> > +log_f = fopen("log.txt", argc >= 1 ? "a" : "w");
>> > +assert(log_f);
>> > +setbuf(log_f, NULL);
>> > +
>> > +fprintf(log_f, "argc %d argv[0] %s \n", argc, argv[0]);
>> > +
>> > +if (argc >= 1) {
>> > +return called_test(argc, argv);
>> > +}
>> > +
>> > +// main program, call ourself with different arguments and settings
>> > +redir_method = METHOD_CREATEPROCESS;
>> > +all_checks();
>> > +
>> > +redir_method = METHOD_STDHANDLE;
>> > +all_checks();
>> > +
>> > +fprintf(log_f, "everything ok\n");
>> > +
>> > +fclose(log_f);
>> > +return 0;
>> > +}
>> > --
>> > 2.5.5
>> >
>> > ___
>> > Spice-devel mailing list
>> > Spice-devel@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
>>
>>
>> --
>> Fabiano Fidêncio
>>
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Mon, May 2, 2016 at 11:43 PM, Fabiano Fidêncio wrote:
> On Fri, Apr 29, 2016 at 4:09 PM, Frediano Ziglio wrote:
>> This patch allows remote-viewer to redirect output/error streams to
>> files.
>> Also if launched from a console program (for instance from the command
>&
UE, TRUE);
> +
> +assert(AllocConsole());
> +has_console = TRUE;
> +h_console = GetStdHandle(STD_OUTPUT_HANDLE);
> +fprintf(log_f, "got console handles %p %p\n", h_console,
> GetStdHandle(STD_ERROR_HANDLE));
> +
> +check(FALSE,
exandru-Viorel
> Telefon : 0729614060
> Best Bucuresti
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
Best Regards,
--
Fabiano Fidêncio
__
+dup2(fileno(stdout), STDOUT_FILENO);
> +}
> +if (!err_valid) {
> +freopen("CONOUT$", "w", stderr);
> +dup2(fileno(stderr), STDERR_FILENO);
> +}
> }
>
> /* Disable input method handling so that the
);
> +check(FALSE, TRUE);
> +check(TRUE, TRUE);
> +
> +assert(AllocConsole());
> +has_console = TRUE;
> +h_console = GetStdHandle(STD_OUTPUT_HANDLE);
> +fprintf(log_f, "got console handles %p %p\n", h_console,
> GetStdHandle(STD_ERROR_HANDLE
On Tue, Apr 26, 2016 at 12:29 PM, Frediano Ziglio wrote:
> ping
>
The idea is good, but didn't work according to my tests with a Win7 machine :-\
> - Original Message -
>>
>> This patch allows remote-viewer to redirect output/error streams to
>> files.
>> Also if launched from a console
On Mon, Apr 25, 2016 at 10:59 AM, Frediano Ziglio wrote:
>>
>> On Mon, Apr 4, 2016 at 9:59 AM, Fabiano Fidêncio wrote:
>> > sockaddr_un.sun_path has 108 bytes, while pipe_name has
>> > PIPE_NAME_MAX_LEN (256 bytes)
>> > ---
>> > src/cont
On Mon, Apr 25, 2016 at 11:04 AM, Frediano Ziglio wrote:
>>
>> ---
>> src/channel-main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/channel-main.c b/src/channel-main.c
>> index 4a1f58a..93537d2 100644
>> --- a/src/channel-main.c
>> +++ b/src/channel-main.c
>>
On Mon, Apr 4, 2016 at 10:21 AM, Christophe Fergeau wrote:
> On Mon, Apr 04, 2016 at 10:03:39AM +0200, Fabiano Fidêncio wrote:
>> ---
>> common/log.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/log.c b/common/log.c
On Mon, Apr 4, 2016 at 10:29 AM, Christophe Fergeau wrote:
> On Mon, Apr 04, 2016 at 10:03:34AM +0200, Fabiano Fidêncio wrote:
>> We are allocating insufficient memory for the terminating null of the
>> string.
>> ---
>> common/ssl_verify.c | 4 ++--
>> 1
On Mon, Apr 4, 2016 at 9:59 AM, Fabiano Fidêncio wrote:
> sockaddr_un.sun_path has 108 bytes, while pipe_name has
> PIPE_NAME_MAX_LEN (256 bytes)
> ---
> src/controller/test.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/controller/test.c b/src/cont
On Mon, Apr 4, 2016 at 11:08 AM, Christophe Fergeau wrote:
> Where is the mem.data use you mention? In the memcpy?
Exactly. mem.data use mentioned is in the memcpy.
>
> Christophe
>
> On Mon, Apr 04, 2016 at 09:59:50AM +0200, Fabiano Fidêncio wrote:
>> ---
>> src/
On Tue, Apr 19, 2016 at 4:11 PM, Fabiano Fidêncio wrote:
> On Tue, Apr 19, 2016 at 4:00 PM, Frediano Ziglio wrote:
>>>
>>> On Tue, Apr 19, 2016 at 3:28 PM, Pavel Grunt wrote:
>>> > Ack, I am going to push it.
>>>
>>> Do we really need this patc
ing so that the Zenkaku_Hankaku can
>> >> be passed
>> >> + * to VMs rather than being captured by Windows.
>> >> + * https://bugzilla.redhat.com/show_bug.cgi?id=1297640
>> >> + */
>> >> +ImmDisableIME(-1);
>> >> #endif
>> >>
>> >> setlocale(LC_ALL, "");
>> > ___
>> > Spice-devel mailing list
>> > Spice-devel@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
>>
>>
>> --
>> Fabiano Fidêncio
>>
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
ImmDisableIME(-1);
>> #endif
>>
>> setlocale(LC_ALL, "");
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
gent
https://scan.coverity.com/projects/virt-viewer
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Mon, Apr 4, 2016 at 10:27 AM, Victor Toso wrote:
> Hey,
>
> From coverity there are only 2 spice-gtk patches, right?
There are 4, actually. I hope I ended up submitting all of them.
> Both look good to me
> Acked-by: Victor Toso
>
> On Mon, Apr 04, 2016 at 10:02:09AM +0
len is overwritten in the match label with the value from
"ip - anchor".
---
common/lz_compress_tmpl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/common/lz_compress_tmpl.c b/common/lz_compress_tmpl.c
index 3162a96..e316c4b 100644
--- a/common/lz_compress_tmpl.c
+++ b/co
---
common/canvas_utils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/canvas_utils.c b/common/canvas_utils.c
index c5813f4..0be761a 100644
--- a/common/canvas_utils.c
+++ b/common/canvas_utils.c
@@ -109,6 +109,7 @@ static inline pixman_image_t
*__surface_create_stride(pixman_format
The loop (for (;;)) will be executed only once, so, no reason for
keeping it.
---
common/lz_compress_tmpl.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/common/lz_compress_tmpl.c b/common/lz_compress_tmpl.c
index e316c4b..0305278 100644
--- a/common/lz_c
---
common/canvas_base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index fa4d373..650422b 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -769,6 +769,7 @@ static inline SpicePalette
*canvas_get_localized_palette(CanvasBase *can
All decompress functions used after this check take into account that
encoder->palette is not NULL. So, if we already detected that the
palette is NULL, let's just return early.
---
common/lz.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/lz.c b/common/lz.c
index d1c4033..2589223 100
---
common/lines.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/lines.c b/common/lines.c
index 10ca318..e5097c4 100644
--- a/common/lines.c
+++ b/common/lines.c
@@ -412,7 +412,7 @@ miStepDash (int dist, /* distance to step */
totallen = 0;
for (i =
We are allocating insufficient memory for the terminating null of the
string.
---
common/ssl_verify.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/ssl_verify.c b/common/ssl_verify.c
index 601252e..4292ddf 100644
--- a/common/ssl_verify.c
+++ b/common/ssl_verify.c
---
common/log.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/log.c b/common/log.c
index 8d47cb6..91d3181 100644
--- a/common/log.c
+++ b/common/log.c
@@ -59,7 +59,7 @@ static GLogLevelFlags spice_log_level_to_glib(SpiceLogLevel
level)
static void spice_log_set_
---
src/spice-client-glib-usb-acl-helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/spice-client-glib-usb-acl-helper.c
b/src/spice-client-glib-usb-acl-helper.c
index c2baeda..03a0317 100644
--- a/src/spice-client-glib-usb-acl-helper.c
+++ b/src/spice-client-glib-u
---
src/controller/test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/controller/test.c b/src/controller/test.c
index 649aca5..2909b06 100644
--- a/src/controller/test.c
+++ b/src/controller/test.c
@@ -262,7 +262,7 @@ int main (int argc, char *argv[])
send_data (CO
Ouch, sorry for resending this patch :-\
My intention was to submit another series completely not related to
this one, my bad :-\
On Mon, Apr 4, 2016 at 9:59 AM, Fabiano Fidêncio wrote:
> From: Takao Fujiwara
>
> MapVirtualKey() returns the scancode of the released Zenkaku_Hankaku
Ouch, sorry for resending this patch :-\
My intention was to submit another series completely not related to
this one, my bad :-\
On Mon, Apr 4, 2016 at 9:59 AM, Fabiano Fidêncio wrote:
> In order to speed up the process I took the freedom to apply Takao's
> patches locally, reg
In order to speed up the process I took the freedom to apply Takao's
patches locally, regenerate the patches (and cover letter) and submit
them upstream using git send-email.
Please, for more info, take a look on:
https://lists.freedesktop.org/archives/spice-devel/2016-March/027878.html
Takao Fuj
sockaddr_un.sun_path has 108 bytes, while pipe_name has
PIPE_NAME_MAX_LEN (256 bytes)
---
src/controller/test.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/controller/test.c b/src/controller/test.c
index 9a45581..649aca5 100644
--- a/src/controller/test.c
+++ b/src/controller/tes
---
src/channel-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index 4a1f58a..93537d2 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -1021,9 +1021,9 @@ static void agent_msg_queue_many(SpiceMainChannel
*channel, int
From: Takao Fujiwara
MapVirtualKey() returns the scancode of the released Zenkaku_Hankaku key
but does not pressed one and modifiered one. Any cases should be sent
to use input method engines.
---
src/spice-widget-priv.h | 1 +
src/spice-widget.c | 37 +++--
On Thu, Mar 31, 2016 at 1:43 PM, Frediano Ziglio wrote:
>>
>> I noticed Linux GNOME desktop hangs up when Windows virt-viewer connects to
>> the desktop and type some specific keys on JP keyboard.
>>
>> Server: GNOME desktop and IBus in RHEL 7
>> Client virt-viewer in Windows 7 with JP 106 keyboar
From: Takao Fujiwara
Some of the keys in JP keyboard do no send WM_KEYUP and it causes
unlimited key events on Linux desktop. This sends the virtual
key release events to avoid the desktop hangup.
---
src/spice-widget.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/
From: Takao Fujiwara
Some of the keys in JP keyboard do no send WM_KEYUP and it causes
unlimited key events on Linux desktop. This sends the virtual
key release events to avoid the desktop hangup.
---
src/spice-widget.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/spice-widge
From: Takao Fujiwara
MapVirtualKey() returns the scancode of the released Zenkaku_Hankaku key
but does not pressed one and modifiered one. Any cases should be sent
to use input method engines.
---
src/spice-widget-priv.h | 1 +
src/spice-widget.c | 37 +++--
In order to speed up the process I took the freedom to apply Takao's
patches locally, regenerate the patches (and cover letter) and submit
them upstream using git send-email.
Please, for more info, take a look on:
https://lists.freedesktop.org/archives/spice-devel/2016-March/027878.html
Takao Fuj
d in 2.38 :-\
> Trying to build on 2.33 (which I was) therefore
> passes the configure tests, but fails to build.
We need either bump the dep version or add a compat file for this.
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing l
On Wed, Mar 23, 2016 at 2:45 PM, Victor Toso wrote:
> Hi,
>
> On Wed, Mar 23, 2016 at 02:32:06PM +0100, Christophe Fergeau wrote:
>> On Wed, Mar 23, 2016 at 01:04:03PM +0100, Fabiano Fidêncio wrote:
>> > gtask-helper provide methods that can easily be used for returnin
change should noticed.
Signed-off-by: Fabiano Fidêncio
---
src/Makefile.am | 2 +
src/channel-base.c | 4 +-
src/channel-main.c | 12 ++--
src/channel-usbredir.c | 12 ++--
src/gtask-helper.c | 153 +++
src
On Wed, Mar 23, 2016 at 11:34 AM, Christophe Fergeau
wrote:
> On Wed, Mar 23, 2016 at 10:48:31AM +0100, Fabiano Fidêncio wrote:
>> As noticed, GTask's heurestic for return a task in idle or immediately
>> doesn't work when using Coroutine
>
> s/heurestic/heuris
hese functions match exactly with the existing g_task_return_*
functions and the only difference is that they return in idle instead of
returning immediately.
Signed-off-by: Fabiano Fidêncio
---
m4/manywarnings.m4 | 1 -
src/Makefile.am | 2 +
src/channel-base.c
This reverts commit 7774b8c0dd85ce2bb311d8bbe1c25deb73970b6e.
The crash was fixed, but not properly. GTask shouldn't return
immediately in that scenario. Next patch brings a proper fix for the
issue.
Signed-off-by: Fabiano Fidêncio
---
src/channel-usbredir.c | 2 +-
1 file changed, 1 inse
estic (which doesn't work with Coroutine).
Fabiano Fidêncio (2):
Revert "channel-usbredir: Fix crash due to a Task returning earlier
than expected"
Introduce gtask-helper.[ch]
m4/manywarnings.m4 | 1 -
src/Makefile.am | 2 +
src/channel-base.c
ils are really important.
So, you're building spice-gtk using mingw, is it? If yes, please,
enable usbredir support in your build.
>
> best,
>
> -邮件原件-
> 发件人: Fabiano Fidêncio [mailto:fabi...@fidencio.org]
> 发送时间: 2016年3月23日 5:17
> 收件人: lichanghua
> 抄送: spice-d
Pushed, thanks!
On Tue, Mar 22, 2016 at 11:01 PM, Fabiano Fidêncio wrote:
> On Tue, Mar 22, 2016 at 10:57 PM, Marc-André Lureau
> wrote:
>> ack
>>
>> - Original Message -
>>> Seems that GTask heuristic only makes sense in a non-coroutine case.
>&g
that is completely fine for coroutine code to deal with the
>> idle explicitly.
>>
>> Signed-off-by: Fabiano Fidêncio
>> ---
>> Changes since v2, as per Marc-André review:
>> - Change the commit log
>> - Change the comment in the code
>> - No need for a _fre
Seems that GTask heuristic only makes sense in a non-coroutine case.
After opening a bug[0] on spice-gtk and a few discussions in the mailing
list, seems that is completely fine for coroutine code to deal with the
idle explicitly.
Signed-off-by: Fabiano Fidêncio
---
Changes since v2, as per Marc
___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
e a reference
to the very same bug in the code.
[0]: https://bugs.freedesktop.org/show_bug.cgi?id=94662
Signed-off-by: Fabiano Fidêncio
---
Changes since v1, as per Marc-André review:
- Use g_idle_add() instead of GSource ... which worries me a bit about the
context used when using g_idle_add(
As I still don't know if the bug is on spice-gtk or on GTask itself,
>> I've opened a bug[0] in spice-gtk's bugzilla and also made a reference
>> to the very same bug in the code.
>>
>> [0]: https://bugs.freedesktop.org/show_bug.cgi?id=94662
>>
>>
hed, thanks!
>
> On Tue, Mar 22, 2016 at 01:01:30PM +0100, Pavel Grunt wrote:
>> Ack.
>>
>> Pavel
>>
>> On Mon, 2016-03-21 at 16:02 +0100, Fabiano Fidêncio wrote:
>> > Don't try to get the cancellable from a task that is, for sure
>> > (ens
1 - 100 of 716 matches
Mail list logo
