Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Alexander Larsson
On Thu, 2012-06-14 at 12:31 +0200, Christophe Fergeau wrote: > On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > > However, that is imho a different issue than the celt051 support. A new > > release of spice client and server supporting opus does not magical

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Alexander Larsson
On Tue, 2012-06-12 at 16:33 +0200, Christophe Fergeau wrote: > On Tue, Jun 12, 2012 at 09:59:39AM -0400, Marc-André Lureau wrote: > > > > > > - Mensaje original - > > > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > > > As long as the bitstream is not frozen, we ca

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alexander Larsson
On Tue, 2012-06-12 at 14:31 +0400, Michael Tokarev wrote: > On 12.06.2012 13:15, Alexander Larsson wrote: > [] > > Its not incompatible, like I i said in my "(Well, .." part above. But > > what it means is that it will send audio as PCM instead of compressing > >

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alexander Larsson
On Tue, 2012-06-12 at 12:54 +0400, Michael Tokarev wrote: > On 12.06.2012 12:48, Alexander Larsson wrote: > > On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote: > > > >> I plan to use this patch in the upcoming Debian > >> release, codename wheezy, to g

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alexander Larsson
On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote: > I plan to use this patch in the upcoming Debian > release, codename wheezy, to get rid of celt > codec library there, since we decided celt051 is > not going to be included, but it is obviously not > a good idea to drop spice entirely. I

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-25 Thread Alexander Larsson
On Mon, 2012-05-07 at 09:28 +0300, Alon Levy wrote: > Hi, > > Currently we support multiple monitors by having: > single pci = single display channel = single client window > > The RANDR architecture doesn't lend itself to this, but on the other hand it > makes it very easy to have an alter

Re: [Spice-devel] xf86-video-qxl performance

2012-05-25 Thread Alexander Larsson
On Wed, 2012-05-23 at 15:20 -0500, Jeremy White wrote: > Also, as a crazy idea, has anyone considered implementing a pure > streaming video driver? That is, what if we had a frame buffer driver, > and then a thread that fired 29 times a second to drive a theora or vp8 > encoder, simply feeding th

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
On Thu, 2010-09-30 at 22:18 +0200, Gerd Hoffmann wrote: > On 09/30/10 20:41, Alexander Larsson wrote: > > On Thu, 2010-09-30 at 14:48 +0200, Alexander Larsson wrote: > > > >> More later... > > > > Bit more before I disappear: > > > > why do you hav

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
s some profiling though. Actually i think all GDI stuff is software only in vista, but i think they added back some acceleration in win7. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
const char *name); The name should probably just be taken from g_get_prgname() or g_get_application_name(). -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.com

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
On Thu, 2010-09-30 at 14:48 +0200, Alexander Larsson wrote: > More later... Bit more before I disappear: why do you have a spice_channel_destroy()? Its a gobject, just unref it. I don't like that you have three libs. We've learned this lesson in gnome by now: It seems that splitt

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-09-30 Thread Alexander Larsson
ls(SpiceSession *session, SpiceChannel **channels, int max); A more typical Gtk+ style call is: SpiceChannel ** spice_session_get_channels(SpiceSession *session); returning a NULL-terminated array of items. Or possibly a GList *. More later... -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

[Spice-devel] Announcing Spice 0.6.1

2010-09-29 Thread Alexander Larsson
Today we released the first bugfix update to the stable spice 0.6 series. Updated sources and windows binaries are availible at: http://spice-space.org/download.html We hope to have packages in Fedora 14 shortly. ___ Spice-devel mailing list Spice-deve

Re: [Spice-devel] [PATCH] client: port for Mac OS X

2010-09-29 Thread Alexander Larsson
On Sun, 2010-09-26 at 14:57 +0200, Attila Sukosd wrote: > Hi All, > > I finally had a bit of time to gather the changes to the spice client > in order to get it working under Mac. Good stuff. I landed some of the cleanup from this patch as: http://lists.freedesktop.org/archives/spice-devel/2010-S

Re: [Spice-devel] Replace epoll with select in X client

2010-09-29 Thread Alexander Larsson
On Wed, 2010-09-29 at 17:28 +0200, Alexander Larsson wrote: I'm commiting this part: > diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp > index 1133414..ca5f1d5 100644 > --- a/client/x11/platform.cpp > +++ b/client/x11/platform.cpp > @@ -3024,8 +3024,12

[Spice-devel] Replace epoll with select in X client

2010-09-29 Thread Alexander Larsson
The use of epoll in the client is totally overkill in terms of scalability, and its a problem for portability. The OSX port converts this to use select, but keeps some of the old complexities in the code. This new patch makes it simpler and look much more like the windows code. Review? diff --git

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model (v2)

2010-09-29 Thread Alexander Larsson
On Wed, 2010-09-29 at 14:17 +0200, Arnon Gilboa wrote: > -enable USE_XRANDR_1_2 I'm commiting this right away so we get it for 0.6.1. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-dev

Re: [Spice-devel] 0.6.1 release and cut and paste

2010-09-29 Thread Alexander Larsson
On Mon, 2010-09-27 at 16:45 +0200, Arnon Gilboa wrote: > +1 to your "0.6.1 now". what's the cons of c&p only in 0.6.2 (in a week > or 2!) ? I'm for this too, and will do a 0.6.1 release today. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.

Re: [Spice-devel] [PATCH] vd_agent: add protocol messages for clipboard/selection-owner model

2010-09-29 Thread Alexander Larsson
On Sun, 2010-09-26 at 10:27 +0200, Arnon Gilboa wrote: > Alexander Larsson wrote: > > On Wed, 2010-09-22 at 11:47 +0200, Arnon Gilboa wrote: > > > >> with the current msgs we can use multiple GRAB(type)s & REQUEST(type)s ;) > >> > > > > I d

Re: [Spice-devel] spice 6.0

2010-09-29 Thread Alexander Larsson
On Thu, 2010-09-23 at 22:46 +0200, len...@opensourcemedia.de wrote: > On 22.09.2010 15:25, Alexander Larsson wrote: > > On Wed, 2010-09-22 at 11:27 +0200, len...@opensourcemedia.de wrote: > >> On 22.09.2010 10:23, Alexander Larsson wrote: > >> Thanks for the quic

Re: [Spice-devel] [PATCH] vd_agent: add protocol messages for clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
when to add to it. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an immortal hunchbacked card sharp with a robot buddy named Sparky. She's a high-kicking hypochondriac mechanic

Re: [Spice-devel] [PATCH] client: support clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
ommon is UTF8_STRING support these days? Can we rely on all interesting apps supporting it, or should we also try to handle the older non-utf8 X text formats by doing the conversion ourselves? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
the > client? I see no reason to render in this case or keep the clipboard > available for other apps. That indeed seems a bit silly. Isn't windows waiting for you to render something though? You could just set the data to a zero size block. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [Spice-devel] [PATCH 0/5] Fix bugs found by WHQL

2010-09-22 Thread Alexander Larsson
On Tue, 2010-09-21 at 20:19 +0200, al...@redhat.com wrote: > From: Alexander Larsson > > I've been playing with an old WHQL display test running various > rendering tests to see how we stack up. During this testing > I found a bunch of crashes and leaks, fixed in this se

[Spice-devel] Dynamic and high resolutions

2010-09-22 Thread Alexander Larsson
quires changes in all of spice. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a fiendish alcoholic werewolf for

Re: [Spice-devel] [PATCH] vd_agent: add protocol messages for clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
> larger flexibility. I think this is esp. usefull when the > guest as and the client os are the same os, then > copying of all kind of things could be . Not sure about this, if we want full compatibility with same-os cut and paste we need more features anyway, like multiple formats. I thi

Re: [Spice-devel] [PATCH] vd_agent: add protocol messages for clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
h one to use (i.e. a web browser would support copy as html or copy as text, etc). I'm not sure we want to really support this, as it increases the complexity of cut and paste quite a bit, and is perhaps not as important as just getting text cut and paste working. -- =-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH] vdservice: use "com.redhat.spice.0" symbolic link as virtio-serial port path

2010-09-22 Thread Alexander Larsson
looks good. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a war-weary hunchbacked filmmaker haunted by memories of 'Nam. She's a psychot

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
break; I think you need to handle RENDERALLFORMATS too. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a s

Re: [Spice-devel] [PATCH] vdservice: replace VDAgentDataChunk with VDIChunkHeader

2010-09-22 Thread Alexander Larsson
f --git a/vds Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a jaded drug-addicted assassin who knows the secret of the alien invasion. She's a mentally unstable mute colle

Re: [Spice-devel] [PATCH] vdservice: cleanup vcprojs

2010-09-22 Thread Alexander Larsson
u: ack. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a suave playboy gangster haunted by memories of 'Nam. She's a high-kicking

Re: [Spice-devel] Spice roadmap

2010-09-22 Thread Alexander Larsson
experimental support for network tunneling, but its not enabled by default and we don't know if it is the right approach. For the others, no ETA exists, but they're all things we eventually want to have. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [Spice-devel] spice 6.0

2010-09-22 Thread Alexander Larsson
l qxl.revision=2" on the qemu command line. Sorry about this. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a globe-trotting moralistic paranormal investigator se

Re: [Spice-devel] [PATCH 00/17] Win32 driver thread safety

2010-09-21 Thread Alexander Larsson
On Tue, 2010-09-14 at 21:08 +0200, al...@redhat.com wrote: > From: Alexander Larsson Izik reviewed all of these and found no issues, and i've been running it for a while without issues, so i'm pushing it now. However, if anyone has time please do review this anyway as there is a

[Spice-devel] 0.6.1 release schedule

2010-09-20 Thread Alexander Larsson
outstanding issues we should try to get in? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an ungodly albino m

Re: [Spice-devel] set initial depth

2010-09-20 Thread Alexander Larsson
, and use whatever resolutions it would have used on any other vga card. Then when the qxl driver is loaded it can support more resolutions and depths, but which ones are used depends on how the guest os/drivers are setup. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [Spice-devel] [PATCH 02/17] Drop DevResDynamic

2010-09-20 Thread Alexander Larsson
On Tue, 2010-09-14 at 21:08 +0200, al...@redhat.com wrote: > From: Alexander Larsson > > Now that all DevRes are dynamic we can just put the data in DevRes. > --- Got an ack from izik on irc, pushing. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 01/17] Make global_res be an array of pointers and Res a pointer

2010-09-20 Thread Alexander Larsson
On Tue, 2010-09-14 at 21:08 +0200, al...@redhat.com wrote: > From: Alexander Larsson > > Instead of allocating an array of DevRes we allocate each DevRes > dynamically for each element. > > Also make PDEV->Res be a pointer instead of copying the global pdev. > This also

Re: [Spice-devel] Memory Leak on spicec

2010-09-16 Thread Alexander Larsson
On Tue, 2010-09-14 at 16:02 +0200, Alex Peter wrote: > I referred "Target is the one running the spicec client" We had a shared memory leak in the X client, but that was fixed before 0.6.0 was released. I have not personally seen any other client leaks. ___

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-16 Thread Alexander Larsson
On Tue, 2010-09-14 at 14:50 -0400, Alon Levy wrote: > - "Gerd Hoffmann" wrote: > > I don't think this is a good idea. This is just a chardev > > passthrough, > > right? If so, then we should just make it that. Name it 'chardev' or > > > > 'datapipe' or something simliar. Have a addition

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-16 Thread Alexander Larsson
On Tue, 2010-09-14 at 14:46 -0400, Alon Levy wrote: > - "Alexander Larsson" wrote: > > > On Mon, 2010-09-13 at 13:58 -0400, Alon Levy wrote: > > > --- > > > spice/enums.h | 13 + > > > 1 files changed, 13 insertions(+), 0 delet

Re: [Spice-devel] [PATCH 3/3] fix palette handling for 0.4 compat

2010-09-14 Thread Alexander Larsson
> --- ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an otherworldly Catholic dog-catcher on a mission from God. She's a sarcastic thirtysomething queen of the dead from a family of eight ol

Re: [Spice-devel] [PATCH 2/3] fix brush handling for 0.4 compat

2010-09-14 Thread Alexander Larsson
> --- ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a short-sighted native American romance novelist with a secret. She's a manipulative snooty cab driver with a flame-

Re: [Spice-devel] [PATCH 1/3] move command flags handling to the qxl parser

2010-09-14 Thread Alexander Larsson
On Tue, 2010-09-14 at 10:45 +0200, Gerd Hoffmann wrote: > Pass through command flags to the qxl parser, so we can hide all > compat bits for spice 0.4 within the qxl parser. ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander L

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-14 Thread Alexander Larsson
e_codegen.py -e spice.proto ../spice-proto/spice/enums.h -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an unconventional w

Re: [Spice-devel] [PATCH] add compat flag for 16bpp mode

2010-09-14 Thread Alexander Larsson
t; interpret these values in spice 0.4 compat mode. Add a flag to pass > on this informartion. > > Signed-off-by: Gerd Hoffmann Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, I

Re: [Spice-devel] Memory Leak on spicec

2010-09-14 Thread Alexander Larsson
nd.. Try using a tablet instead of a mouse ( -usbdevice tablet in qemu). -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an uncontrollable chivalrous waffl

Re: [Spice-devel] [PATCH xf86-video-qxl 1/2] Change default virtual size to 1920x1080

2010-09-14 Thread Alexander Larsson
egs are unused right now. (unless i'm missing something.) -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a lounge-singing crooked sorceror who hangs with the wrong crowd. She's a s

Re: [Spice-devel] Are there 64 bit Windows 7 QXL drivers?

2010-09-12 Thread Alexander Larsson
from it, set SPICE_COMMON_DIR to point to spice-protocol, then go to the qxl dir and run "build". This is all pretty standard windows driver building. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] [PATCH 00/35] *** SUBJECT HERE ***

2010-09-10 Thread Alexander Larsson
On Thu, 2010-09-09 at 19:15 +0200, al...@redhat.com wrote: > From: Alexander Larsson > > *** BLURB HERE *** Sorry. Didn't mean to send this one... -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] leaking drawables

2010-09-09 Thread Alexander Larsson
On Thu, 2010-09-09 at 09:31 +0200, Gerd Hoffmann wrote: > > There is one special thing in the release ring usage though. As you > know qxl builds up a linked lists there, where the heads are in the > ring. qxl does also store the head of the list which it currently > builds into the ring, but

Re: [Spice-devel] leaking drawables

2010-09-08 Thread Alexander Larsson
he ring. And, testing with this patch I still see the leak. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an otherworldly white trash Green Beret fleei

[Spice-devel] leaking drawables

2010-09-06 Thread Alexander Larsson
me to look into this until thursday. Maybe someone else want to take a look before then? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@g

Re: [Spice-devel] [PATCH] server: avoid creating a stream from traces more than once for the same drawable

2010-09-02 Thread Alexander Larsson
On Thu, 2010-09-02 at 15:24 +0200, Alexander Larsson wrote: > On Wed, 2010-09-01 at 12:10 +0300, Yonit Halperin wrote: > > could have caused ASSERT(!drawable->stream) in red_create_stream > > --- > > server/red_worker.c | 15 ++- > > 1 files changed,

Re: [Spice-devel] asking help to implement spice

2010-09-02 Thread Alexander Larsson
On Wed, 2010-09-01 at 11:05 +0530, mohan Doss wrote: > hello sir i am mohan dass i am doing BE final year , i like doing > project in desktop virtulization .can you help me to implement your > protocol in my project. "Implement a protocol" is a very vague term. You need to describe more what you w

Re: [Spice-devel] [PATCH] server: avoid creating a stream from traces more than once for the same drawable

2010-09-02 Thread Alexander Larsson
On Wed, 2010-09-01 at 12:10 +0300, Yonit Halperin wrote: > could have caused ASSERT(!drawable->stream) in red_create_stream > --- > server/red_worker.c | 15 ++- > 1 files changed, 10 insertions(+), 5 deletions(-) ack ___ Spice-devel mai

Re: [Spice-devel] [PATCH] spicec-x11: Fix going into a never ending loop upon xrandr event (#628573)

2010-09-02 Thread Alexander Larsson
On Thu, 2010-09-02 at 10:16 +0200, Hans de Goede wrote: > Hi, > > On 09/02/2010 09:51 AM, Alexander Larsson wrote: > > On Wed, 2010-09-01 at 20:15 +0200, Hans de Goede wrote: > >> --- > >> client/x11/platform.cpp |5 + > >> 1 f

Re: [Spice-devel] [PATCH] spicec-x11: Fix going into a never ending loop upon xrandr event (#628573)

2010-09-02 Thread Alexander Larsson
On Wed, 2010-09-01 at 20:15 +0200, Hans de Goede wrote: > --- > client/x11/platform.cpp |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp > index 8292d44..1f25a7f 100644 > --- a/client/x11/platform.cpp > +++ b/clien

[Spice-devel] Announcing Spice 0.6.0

2010-08-31 Thread Alexander Larsson
integration API. Updated sources and windows binaries are availible at: http://spice-space.org/download.html I'm currently working on updating the packages in Fedora 14. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander La

Re: [Spice-devel] [PATCH] server: red_current_add_equal - don't push a drawable to the middle of the pipe if it depends on surfaces.

2010-08-31 Thread Alexander Larsson
side. > --- Ack. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a Nobel prize-winning coffee-fuelled cat burglar haunted by memories of 'Nam. She's

Re: [Spice-devel] [PATCH] qxl parser: complete parsing of QXLCompatDrawable structs

2010-08-31 Thread Alexander Larsson
On Tue, 2010-08-31 at 11:59 +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > server/red_parse_qxl.c | 14 ++ > 1 files changed, 14 insertions(+), 0 deletions(-) Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

[Spice-devel] delay 0.6.0 to tomorrow

2010-08-30 Thread Alexander Larsson
I want to get the vdagent versioning patch in to future-proof the agent protocol, so lets delay 0.6.0 to tomorrow. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.com

Re: [Spice-devel] [PATCH] server: fix red_current_flush to flush only the surface that was given as parameter

2010-08-30 Thread Alexander Larsson
of no primary > surface, red_handle_drawable_surfaces_client_synced was buggy. > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He&

Re: [Spice-devel] [PATCH] Bump versions.

2010-08-30 Thread Alexander Larsson
ver. Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a fiendish dishevelled photographer from the 'hood. She's a pregnant bisexual femme fatale from out o

Re: [Spice-devel] [PATCH] add vd_agent announce capabilities message

2010-08-30 Thread Alexander Larsson
namically. Just assume every capability bit not sent is zero if you get a short array in the client. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's

Re: [Spice-devel] [PATCH] Add config functions.

2010-08-29 Thread Alexander Larsson
ver/spice.h | 11 +++ > 2 files changed, 38 insertions(+), 0 deletions(-) Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
ts probably ok to delay this until we need to call it from qemu. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a lonely bohemian cyborg whom everyone be

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
.v17 branch even live migration should work. At least new > qxl parses old qxl state just fine when switched into compatibility > mode. Not fully tested yet though due to some non-spice-related > migration issues. Cool. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 1/2] server: Don't send stream frames that are identical to the last one

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 10:49 +0300, Yaniv Kaul wrote: > On 2010-08-26 18:33, Yonit Halperin wrote: > > On 08/25/2010 11:49 AM, al...@redhat.com wrote: > >> From: Alexander Larsson > >> > >> This happens e.g. with the vlc player when paused, as it still draws >

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
t use offscreen surfaces, nor the new qxl pci device, and allows migration to/from spice 0.4.0 instances. It will still produce a major 2 protocol stream though, so clients must be >= 0.6.0. I don't think this is a big problem, as clients can be upgraded before a cluster in an upgrade situa

Re: [Spice-devel] [PATCH 3/5] zap dead qxl chunk code

2010-08-26 Thread Alexander Larsson
On Fri, 2010-08-27 at 08:49 +0200, Gerd Hoffmann wrote: > On 08/27/10 08:41, Alexander Larsson wrote: > > On Fri, 2010-08-27 at 00:09 +0200, Gerd Hoffmann wrote: > >> Signed-off-by: Gerd Hoffmann > >> --- > >> server/red_worker.c | 29 ---

Re: [Spice-devel] [PATCH 2/5] qxl parser: add cursor parsing

2010-08-26 Thread Alexander Larsson
On Fri, 2010-08-27 at 08:51 +0200, Gerd Hoffmann wrote: > On 08/27/10 08:38, Alexander Larsson wrote: > > On Fri, 2010-08-27 at 00:09 +0200, Gerd Hoffmann wrote: > >> > >> +red->data_size = qxl->data_size; > >> +size

Re: [Spice-devel] [PATCH 3/5] zap dead qxl chunk code

2010-08-26 Thread Alexander Larsson
nd group_id too. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a war-weary overambitious inventor on a search for his missi

Re: [Spice-devel] [PATCH 5/5] fix red_cursur_flush segfault

2010-08-26 Thread Alexander Larsson
On Fri, 2010-08-27 at 00:09 +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > server/red_worker.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexa

Re: [Spice-devel] [PATCH 4/5] zap dead typedefs

2010-08-26 Thread Alexander Larsson
uint32_t group_id); > typedef struct { > DisplayChannel *display_channel; > RedCompressBuf *bufs_head; Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.c

Re: [Spice-devel] [PATCH 3/5] zap dead qxl chunk code

2010-08-26 Thread Alexander Larsson
ions(-) Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a shy pirate firefighter on the run. She's a strong-willed African-American mechanic from a family of eight older broth

Re: [Spice-devel] [PATCH 2/5] qxl parser: add cursor parsing

2010-08-26 Thread Alexander Larsson
Ack, but this part could be more efficient. In the n_chunks > 1 case the red_linearize_chunk part will already malloc and copy the data so we don't need to do it then. We should have a linearlize_chunks variant that always copies and use that. -- =-=-=-=-=-=-

Re: [Spice-devel] [PATCH 1/5] qxl parser: complete QXL_SURFACE_CMD_CREATE parsing

2010-08-26 Thread Alexander Larsson
deletions(-) Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a globe-trotting pirate gangster on the wrong side of the law. She's a bli

Re: [Spice-devel] [PATCH 2/3] server: really wait for a surface to be destroyed, when calling destroy_surface_wait

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 17:28 +0300, Yonit Halperin wrote: > On 08/26/2010 05:25 PM, Alexander Larsson wrote: > red_push doesn't send one item at a time, but rather pushes till it > blocks (due to socket block or missing acks). So if the item is still in > the pipe, it m

Re: [Spice-devel] [PATCH 1/3] server: consider also PIPE_ITEM_UPGRADE when searching for drawables in red_clear_surface_drawables_from_pipe

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 17:00 +0300, Yonit Halperin wrote: > On 08/26/2010 04:58 PM, Alexander Larsson wrote: > > On Thu, 2010-08-26 at 12:41 +0300, Yonit Halperin wrote: > >> --- > >> server/red_worker.c | 36 +++- > >> 1

Re: [Spice-devel] [PATCH v3] spice-{vmc,vdi}: implement subtype

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 10:28 -0400, Alon Levy wrote: > v3 changes: > subtype is now a field of SpiceCharDeviceInstance > > btw, there shouldn't be a newline added before vdi_port_interface, > but I can't get git diff to admit there isn't one there. I'll make > sure there isn't one in the committed

Re: [Spice-devel] [PATCH v3] server: add subtype to SpiceCharDeviceInterface, use for vdagent

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 10:12 -0400, Alon Levy wrote: > v3 changes: > subtype now part of SpiceCharDeviceInstance, not a method of S.C.D.Interface Ack ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/li

Re: [Spice-devel] [PATCH 3/3] server: cleanups in destorying surfaces code

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 12:41 +0300, Yonit Halperin wrote: > --- > server/red_worker.c | 51 > ++- > 1 files changed, 22 insertions(+), 29 deletions(-) Ack ___ Spice-devel mailing list Spice-devel@list

Re: [Spice-devel] [PATCH 2/3] server: really wait for a surface to be destroyed, when calling destroy_surface_wait

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 12:41 +0300, Yonit Halperin wrote: > Waiting till all the pipe items that are dependent on the surface will be > sent. > This was probably the cause for freedesktop bug #29750. > --- > server/red_worker.c | 84 +- > 1 files c

Re: [Spice-devel] [PATCH 1/3] server: consider also PIPE_ITEM_UPGRADE when searching for drawables in red_clear_surface_drawables_from_pipe

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 12:41 +0300, Yonit Halperin wrote: > --- > server/red_worker.c | 36 +++- > 1 files changed, 19 insertions(+), 17 deletions(-) Don't you also need to check for ImageItems with the same surface_id?

Re: [Spice-devel] [PATCH 2/2] spice-{vmc,vdi}: implement subtype

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 04:46 -0400, Alon Levy wrote: > --- > hw/spice-vdi.c |6 ++ > hw/spice-vmc.c | 47 +++ > 2 files changed, 53 insertions(+), 0 deletions(-) > > diff --git a/hw/spice-vdi.c b/hw/spice-vdi.c > index 415932b..f5fda4d 100644 >

Re: [Spice-devel] [PATCH 1/2] spice-{vdi, vmc}: rename SpiceVDIPort* to SpiceCharDevice*

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 04:46 -0400, Alon Levy wrote: > --- > hw/spice-vdi.c | 16 > hw/spice-vmc.c | 22 +++--- > 2 files changed, 19 insertions(+), 19 deletions(-) Ack ___ Spice-devel mailing list Spice-devel@list

Re: [Spice-devel] [PATCH 1/2] server: rename SpiceVDIPort* to SpiceCharDevice*

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 04:44 -0400, Alon Levy wrote: > --- > server/reds.c | 48 +- > server/spice-experimental.h | 28 > 2 files changed, 38 insertions(+), 38 deletions(-) Ack _

Re: [Spice-devel] [PATCH 2/2] server: add subtype to SpiceCharDeviceInterface, use for vdagent

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 04:45 -0400, Alon Levy wrote: > diff --git a/server/spice-experimental.h b/server/spice-experimental.h > index e40b3ec..fd8ef67 100644 > --- a/server/spice-experimental.h > +++ b/server/spice-experimental.h > @@ -10,6 +10,7 @@ typedef struct SpiceCharDeviceState SpiceCharDevi

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 09:26 -0400, Alon Levy wrote: > - al...@redhat.com wrote: > > > From: Alexander Larsson > > > > When upgrading a cluster of machines you typically do this by > > upgrading a set of machines at a time, making the new machines run > >

Re: [Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-26 Thread Alexander Larsson
On Wed, 2010-08-25 at 11:19 -0400, Alon Levy wrote: > - "Alexander Larsson" wrote: > > > +const char* (*subtype)(SpiceCharDeviceInstance *sin); > > > > I don't think we need a callback here. Just make this a const char *. > > > > No,

Re: [Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-25 Thread Alexander Larsson
btype(const char* subtype); > +const char* spice_server_char_device_supported_subtypes(void); I think its better to have a single call that returns a strv, i.e. a NULL terminated char *[]. This can be used to handle both of these functions and is a nicer api to support. -- =-=-

Re: [Spice-devel] Fwd: [PATCH 2/3] server: fix race when data arrives from guest through vdi interface

2010-08-25 Thread Alexander Larsson
On Wed, 2010-08-25 at 06:28 -0400, Alon Levy wrote: > - Forwarded Message - > From: "Alon Levy" > To: al...@redhat.com > Sent: Sunday, August 22, 2010 10:28:37 PM (GMT+0200) Auto-Detected > Subject: [PATCH 2/3] server: fix race when data arrives from guest through > vdi interface > > The

Re: [Spice-devel] Fwd: [PATCH 1/3] server: bugfix - make vdi_port_write_retry reiterate if write_queue still not empty

2010-08-25 Thread Alexander Larsson
e if > write_queue still not empty ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a world-famous devio

Re: [Spice-devel] [PATCH] server: clean glz drawables when reseting qxl

2010-08-25 Thread Alexander Larsson
n the server. > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a lonely Republican card sharp on a mission fr

[Spice-devel] Pushed removal of STREAM_TRACE and USE_EXCLUDE_RGN

2010-08-23 Thread Alexander Larsson
hetti. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a lounge-singing chivalrous jungle king on the edge. She's a blind cat-loving stripper fleeing from

Re: [Spice-devel] [PATCH] client: disable clipboard for now (defined out)

2010-08-23 Thread Alexander Larsson
> > void Application::on_clipboard_change() Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a war-weary guitar-strumming st

Re: [Spice-devel] Fwd: [PATCH 0/8] vdagent update to virtio and clipboard, take 2

2010-08-23 Thread Alexander Larsson
nt for 0.6. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a witless neurotic assassin looking for 'the Big One.' She's a foxy foul-mouthed nun from a

Re: [Spice-devel] [PATCH] Limiting video streaming to the primary surface. freedesktop bug #28088.

2010-08-23 Thread Alexander Larsson
se.rgn); > +red_stop_streams_behind(worker, &drawable->tree_item.base.rgn); > #endif > +} The if is inside the ifdef, but the } is outside it, will not build with !STREAM_TRACE. Otherwise ack. -- =-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 7/8] Store surfaces_used in a bit-array

2010-08-23 Thread Alexander Larsson
On Sun, 2010-08-22 at 15:56 +0300, Yonit Halperin wrote: > On 08/20/2010 09:54 PM, al...@redhat.com wrote: > > From: Alexander Larsson > > > > This is smaller than a byte array, and allows us to skip full > > blocks of 32 ids in one check. > > --- > > Hi

  1   2   3   >