On Wed, 2010-08-25 at 06:28 -0400, Alon Levy wrote: > ----- Forwarded Message ----- > From: "Alon Levy" <al...@redhat.com> > To: al...@redhat.com > Sent: Sunday, August 22, 2010 10:28:37 PM (GMT+0200) Auto-Detected > Subject: [PATCH 2/3] server: fix race when data arrives from guest through > vdi interface > > The call chains that could lead to write_to_vdi_port from two threads: > > guest paste: > per cpu thread: > kvm_main_loop_cpu..vmc_have_data..spice_server_vdi_port_wakeup > ..write_to_vdi_port
Is this enough though? It seems to me that read_from_vdi_port() is not threadsafe either. It changes some state and does not seem to have any locking or anything. _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel