Untested, but looks fine.
Acked-by: Jonathon Jongsma
On Mon, 2019-02-11 at 11:54 +, Frediano Ziglio wrote:
> Instead of scanning the monitor twice (one to compute the size
> and another to build the message) use a single function to
> marshall the message.
> This also fixes big endian mach
Hi
On Mon, Feb 11, 2019 at 6:12 PM Christophe Fergeau wrote:
> I think the main objection is with making spicy too easy to install (and
> to upgrade). Once we ask someone to test a spicy flatpak and it works
> for them, we don't want them to stick to it, start requesting for
> flathub availabilit
On Mon, 2019-02-11 at 16:14 +0200, Snir Sheriber wrote:
> ---
> src/channel-display-gst.c | 39 ++---
> --
> 1 file changed, 22 insertions(+), 17 deletions(-)
>
> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> index 4272ade..c63592b 100644
> -
> > >
> > > From: Marc-André Lureau
> > >
> > > - Fix the following warnings:
> > > ./spice-gtk-sections.txt:467: warning: No declaration found for
> > > SPICE_GTK_CHECK_VERSION.
> > > ./spice-gtk-sections.txt:468: warning: No declaration found for
> > > SPICE_GTK_MAJOR_VERSION.
> > > ./spice-gt
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 0ffabebea..d0efeb782 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1612,7 +1612,7 @@ bool reds_handle_migrate_data(RedsState *reds,
MainCh
> On Mon, Feb 11, 2019 at 11:54:41AM +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/reds.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/server/reds.c b/server/reds.c
> > index c16655adf..4708be330 100644
> > --- a/server/reds
On Mon, Feb 11, 2019 at 11:54:41AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index c16655adf..4708be330 100644
> --- a/server/reds.c
> +++ b/server/
The resize_handler need to check for the existence of the message box
before computing it's size.
---
src/resize.js | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/src/resize.js b/src/resize.js
index 32282fd..c8d87d9 100644
--- a/src/resize.js
+++ b/src/r
If we round up, we may end up with a display slightly bigger than what
the window can have, thus adding scroll bars. When rounding down we
avoid this problems.
---
src/resize.js | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/resize.js b/src/resize.js
index c8d87d9.
Depending on the structure of the page, the computed mouse position was
not correct. Typically the case happend when there is no offset between
the canvas and the view area, but an offset on the view area.
The MouseEvent.offsetX and offsetY functions are now widely enough spread
to use them and av
---
src/main.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/main.js b/src/main.js
index be73828..4a37b55 100644
--- a/src/main.js
+++ b/src/main.js
@@ -56,6 +56,8 @@ import { resize_helper, handle_resize } from './resize.js';
** onagent (optional) If given, a function
Add package.json needed to publish on npmjs.
---
package.json | 21 +
1 file changed, 21 insertions(+)
create mode 100644 package.json
diff --git a/package.json b/package.json
new file mode 100644
index 000..21a8b63
--- /dev/null
+++ b/package.json
@@ -0,0 +1,21 @@
+{
+
In case the user didn't provide any password, we want to prompt him for
it. Try once and if we get an permission denied error, then ask the
password and retry to connect.
---
spice_auto.html | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/spice_auto.html b/spice_au
To add some more order to the folder, move the JS files into their own
src folder.
---
package.json| 2 +-
spice.html | 1 -
spice_auto.html | 2
The disconnect() function were not checking the existence of the file
transfer area element, leading to stop the disconnect() before its end.
---
spice.html | 4 +++-
spice_auto.html | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/spice.html b/spice.html
index b789398
---
enums.js | 7 ---
1 file changed, 7 deletions(-)
diff --git a/enums.js b/enums.js
index 9d31148..db13584 100644
--- a/enums.js
+++ b/enums.js
@@ -320,13 +320,6 @@ export var Constants = {
LZ_IMAGE_TYPE_XXXA: 10,
- QUIC_IMAGE_TYPE_INVALID : 0,
- QUIC_IMAGE_TYPE_GRAY: 1,
-
We don't want the users to rely on anything else than main.js. All the
helper functions from the other files are thus imported in main and
exported there too.
This way all the user needs to import is:
import * as SpiceHtml5 from './main.js';
---
main.js | 9 -
spice.html
Hi Jeremy, all,
Here is the series that moves everything into a module and avoid
cluttering the global namespace. This also includes some fixes for
bugs I found while integrating in a third party website.
Cédric Bosdonnat (12):
CSS: don't force the background color or inputs
Introduce ES6 mod
When forcing the background of the input fields, this makes them
unreadable for dark themed browsers.
---
spice.css | 1 -
1 file changed, 1 deletion(-)
diff --git a/spice.css b/spice.css
index ee1b2f3..4c61cb3 100644
--- a/spice.css
+++ b/spice.css
@@ -36,7 +36,6 @@ body
#login input
{
pa
On Mon, Feb 11, 2019 at 05:03:45PM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Mon, Feb 11, 2019 at 03:08:36PM +0100, Marc-André Lureau wrote:
> > I am concern about distributing spice-gtk and spicy in new forms in
> > general. The .desktop is pretty much a no-go to me. The flatpak I
> > don't
> >
> > From: Marc-André Lureau
> >
> > - Fix the following warnings:
> > ./spice-gtk-sections.txt:467: warning: No declaration found for
> > SPICE_GTK_CHECK_VERSION.
> > ./spice-gtk-sections.txt:468: warning: No declaration found for
> > SPICE_GTK_MAJOR_VERSION.
> > ./spice-gtk-sections.txt:469
On Mon, Feb 11, 2019 at 04:29:49PM +, Victor Toso wrote:
> On Mon, Feb 11, 2019 at 05:03:45PM +0100, Christophe Fergeau wrote:
> > Hey,
> >
> > On Mon, Feb 11, 2019 at 03:08:36PM +0100, Marc-André Lureau wrote:
> > > I am concern about distributing spice-gtk and spicy in new forms in
> > > gen
On Mon, Feb 11, 2019 at 3:05 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 02:46:55PM +0100, Jakub Janku wrote:
> > Hi,
> >
> > not a full review, but this is my main concern with this series:
> >
> > If you enable the new --allow-clipboard-managers property, the
> > behaviour stays th
Hey,
On Mon, Feb 11, 2019 at 03:08:36PM +0100, Marc-André Lureau wrote:
> I am concern about distributing spice-gtk and spicy in new forms in
> general. The .desktop is pretty much a no-go to me. The flatpak I
> don't really understand what we need / want it for.
I believe this is the main questi
Hi,
On Mon, Feb 11, 2019 at 03:08:36PM +0100, Marc-André Lureau wrote:
> > 1.1 MB. To avoid waste of space, the flatkpak is not generated
> > automatically but manually, that is, you have to click on this
> > 'job' in the CI to activate it; besides that, the artifact is set
> > to expire_in: 2 day
Calls the new SPICE QXL interface function spice_qxl_set_device_info to
set the hardware address of the graphics device represented by the QXL
interface (e.g. a PCI path) and the device display IDs (the IDs of the
device's monitors that belong to this QXL interface).
Also stops using the deprecate
---
src/channel-display-gst.c | 39 ++-
1 file changed, 22 insertions(+), 17 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 4272ade..c63592b 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -580,34
Hi
On Mon, Feb 11, 2019 at 2:57 PM Victor Toso wrote:
>
> On Mon, Feb 11, 2019 at 02:44:23PM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Feb 11, 2019 at 2:21 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Mon, Feb 11, 2019 at 02:06:19PM +0100, Marc-André Lureau wrote:
> > > > Hi
Hi,
On Mon, Feb 11, 2019 at 02:46:55PM +0100, Jakub Janku wrote:
> Hi,
>
> not a full review, but this is my main concern with this series:
>
> If you enable the new --allow-clipboard-managers property, the
> behaviour stays the same as it is at the moment, so you're basically
> enabling a bug i
On 2/11/19 11:20 AM, Frediano Ziglio wrote:
>> On 2/11/19 9:54 AM, Frediano Ziglio wrote:
>>> Signed-off-by: Frediano Ziglio
>>> ---
>>> server/agent-msg-filter.h | 7 +++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/server/agent-msg-filter.h b/server/agent-msg-filter.h
>>> index
On Mon, Feb 11, 2019 at 02:44:23PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Mon, Feb 11, 2019 at 2:21 PM Victor Toso wrote:
> >
> > Hi,
> >
> > On Mon, Feb 11, 2019 at 02:06:19PM +0100, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Mon, Feb 11, 2019 at 1:59 PM Victor Toso wrote:
> > > >
>
Hi,
not a full review, but this is my main concern with this series:
If you enable the new --allow-clipboard-managers property, the
behaviour stays the same as it is at the moment, so you're basically
enabling a bug in the code and it's being advertised as a feature.
This seems just wrong to me.
Hi
On Mon, Feb 11, 2019 at 2:21 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 02:06:19PM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Feb 11, 2019 at 1:59 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Mon, Feb 11, 2019 at 01:09:41PM +0100, Marc-André Lureau wrote:
>
Hi,
On Mon, Feb 11, 2019 at 02:06:19PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Mon, Feb 11, 2019 at 1:59 PM Victor Toso wrote:
> >
> > Hi,
> >
> > On Mon, Feb 11, 2019 at 01:09:41PM +0100, Marc-André Lureau wrote:
> > > > Having a virt-viewer flatpak does not mean _not_ having a
> > > > spic
> On 2/11/19 9:54 AM, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/agent-msg-filter.h | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/server/agent-msg-filter.h b/server/agent-msg-filter.h
> > index bd124eacb..5776afc1d 100644
> > --- a/server
On 2/11/19 9:54 AM, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/agent-msg-filter.h | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/server/agent-msg-filter.h b/server/agent-msg-filter.h
> index bd124eacb..5776afc1d 100644
> --- a/server/agent-msg-filter.
> On 2/11/19 9:54 AM, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/reds.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/server/reds.c b/server/reds.c
> > index c16655adf..4708be330 100644
> > --- a/server/reds.c
> > +++ b/server/re
On 2/11/19 9:54 AM, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index c16655adf..4708be330 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -1595,7 +1
On 2/11/19 9:54 AM, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> https://www.youtube.com/watch?v=Iz-8CSa9xj8
> My PRECIOU!
> Gollum! Gollum!
> ---
> server/dispatcher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/dispatcher.c b/server/di
Hi
On Mon, Feb 11, 2019 at 1:59 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 01:09:41PM +0100, Marc-André Lureau wrote:
> > > Having a virt-viewer flatpak does not mean _not_ having a
> > > spicy.flatkpak (to me); one is full featured spice client while
> > > the other a testing tool
Hi,
On Mon, Feb 11, 2019 at 01:09:41PM +0100, Marc-André Lureau wrote:
> > Having a virt-viewer flatpak does not mean _not_ having a
> > spicy.flatkpak (to me); one is full featured spice client while
> > the other a testing tool...
>
> It looks like a lot of duplication of flatpak effort. Maybe
On 2/11/19 9:54 AM, Frediano Ziglio wrote:
> This finished the work of 90ff154b36b3ab80350cb4a4d391db330bed2a76
> (cfr "Update usage of GObject private structures").
> Removes last call to g_type_class_add_private.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/smartcard-channel-client.c | 7
Hi
On Mon, Feb 11, 2019 at 1:01 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 11:17:26AM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Feb 11, 2019 at 9:55 AM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Sat, Feb 09, 2019 at 11:45:18AM +0100, Marc-André Lureau wrote:
>
Hi,
On Mon, Feb 11, 2019 at 11:17:26AM +0100, Marc-André Lureau wrote:
> Hi
>
> On Mon, Feb 11, 2019 at 9:55 AM Victor Toso wrote:
> >
> > Hi,
> >
> > On Sat, Feb 09, 2019 at 11:45:18AM +0100, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Fri, Feb 8, 2019 at 7:32 PM Victor Toso wrote:
> > >
This was added in bd8771adbcf3ff34d14333cf874191e8d105f612.
There's no reason to not use reds function instead.
MainDispatcher needs to listen in the main thread that is the
one provided by reds_core_* functions.
Signed-off-by: Frediano Ziglio
---
server/main-dispatcher.c | 29 ++
Not much related beside second and third one.
Frediano Ziglio (8):
smartcard-channel-client: Update usage of GObject private structures
reds: Factor out a function to marshall VDAgentGraphicsDeviceInfo
message
test-stream-device: Check monitor ID messages
reds: Fix typo in comment
di
Signed-off-by: Frediano Ziglio
---
https://www.youtube.com/watch?v=Iz-8CSa9xj8
My PRECIOU!
Gollum! Gollum!
---
server/dispatcher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index c598ed7fc..ce487f632 100644
--- a/server/dispa
Signed-off-by: Frediano Ziglio
---
server/tests/test-stream-device.c | 52 +++
1 file changed, 52 insertions(+)
diff --git a/server/tests/test-stream-device.c
b/server/tests/test-stream-device.c
index f1707d2f8..cb3a1a4ff 100644
--- a/server/tests/test-stream-device.
Most of the time result is set to AGENT_MSG_FILTER_OK, set at
the beginning and change if necessary.
Signed-off-by: Frediano Ziglio
---
server/agent-msg-filter.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter
This finished the work of 90ff154b36b3ab80350cb4a4d391db330bed2a76
(cfr "Update usage of GObject private structures").
Removes last call to g_type_class_add_private.
Signed-off-by: Frediano Ziglio
---
server/smartcard-channel-client.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Signed-off-by: Frediano Ziglio
---
server/agent-msg-filter.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/server/agent-msg-filter.h b/server/agent-msg-filter.h
index bd124eacb..5776afc1d 100644
--- a/server/agent-msg-filter.h
+++ b/server/agent-msg-filter.h
@@ -33,11 +33,18 @@ typed
Instead of scanning the monitor twice (one to compute the size
and another to build the message) use a single function to
marshall the message.
This also fixes big endian machines (which are not supported).
Marshall function is exported to make easier to test (see following
patch).
Signed-off-by:
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index c16655adf..4708be330 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1595,7 +1595,7 @@ bool reds_handle_migrate_data(RedsState *reds,
MainCh
> > Hi
> > On Fri, Feb 8, 2019 at 12:35 PM Victor Toso wrote:
> > >
> > > On Fri, Feb 08, 2019 at 06:11:29AM -0500, Frediano Ziglio wrote:
> > > > >
> > > > > New functions and macros have been added in glib 2.38 to better
> > > > > handle
> > > > > this case.
> > > > >
> > > > > https://gitlab.gn
Hi,
On Mon, Feb 11, 2019 at 06:39:09AM -0500, Frediano Ziglio wrote:
> > Hi,
> >
> > On Sat, Feb 09, 2019 at 11:49:35AM +0100, Marc-André Lureau wrote:
> > > On Tue, Jan 22, 2019 at 9:51 PM Jonathon Jongsma
> > > wrote:
> > > > I do not always update my laptop to the latest release
> > > > immed
> Hi,
>
> On Sat, Feb 09, 2019 at 11:49:35AM +0100, Marc-André Lureau wrote:
> > On Tue, Jan 22, 2019 at 9:51 PM Jonathon Jongsma
> > wrote:
> > > I do not always update my laptop to the latest release
> > > immediately. For example, I'm still running Fedora 28 on my
> > > laptop at the moment, w
On Mon, Feb 11, 2019 at 11:19:02AM +0100, Jakub Janku wrote:
> On Mon, Feb 11, 2019 at 10:30 AM Victor Toso wrote:
> >
> > Hi,
> >
> > On Mon, Feb 11, 2019 at 10:12:42AM +0100, Jakub Janku wrote:
> > > ping?
> >
> > Should be fixed by:
>
> You can double-check with James to be sure, but I don't t
Hi
On Mon, Feb 11, 2019 at 10:08 AM Victor Toso wrote:
>
> Hi,
>
> On Sat, Feb 09, 2019 at 11:49:35AM +0100, Marc-André Lureau wrote:
> > On Tue, Jan 22, 2019 at 9:51 PM Jonathon Jongsma
> > wrote:
> > > I do not always update my laptop to the latest release
> > > immediately. For example, I'm
> Hi
> On Fri, Feb 8, 2019 at 12:35 PM Victor Toso wrote:
> >
> > On Fri, Feb 08, 2019 at 06:11:29AM -0500, Frediano Ziglio wrote:
> > > >
> > > > New functions and macros have been added in glib 2.38 to better handle
> > > > this case.
> > > >
> > > > https://gitlab.gnome.org/GNOME/glib/blob/c8de
On Mon, Feb 11, 2019 at 10:30 AM Victor Toso wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 10:12:42AM +0100, Jakub Janku wrote:
> > ping?
>
> Should be fixed by:
You can double-check with James to be sure, but I don't think that's true.
If you look at the logs ( https://termbin.com/40un ), there's
Hi
On Mon, Feb 11, 2019 at 9:55 AM Victor Toso wrote:
>
> Hi,
>
> On Sat, Feb 09, 2019 at 11:45:18AM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Fri, Feb 8, 2019 at 7:32 PM Victor Toso wrote:
> > >
> > > From: Victor Toso
> > >
> > > Hi,
> > >
> > > Trying to improve and integrate flatpak
Discard unneeded GUDev simulation and use persistent libusb
device pointer in SpiceUsbDevice on Windows as we do on Linux.
This removes significant part of differences between Linux and
Windows code. GUDevClient in win-usb-dev.c now maintains list
of libusb_device pointers and passes new and remov
Hi,
On Mon, Feb 11, 2019 at 10:12:42AM +0100, Jakub Janku wrote:
> ping?
Should be fixed by:
commit 214f8fd969127c41a7d53def196118ee0549a411
Author: Jakub Janků
Date: Sun Jan 27 18:14:20 2019 +0100
clipboard: don't request targets without owner on X11
On X11, if the owner in GdkEven
ping?
On Mon, Jan 28, 2019 at 10:29 AM Jakub Janku wrote:
>
> Hi,
>
> I tried to fix this bug in a less radical way, but my patch unfortunately did
> not cover all the cases.
>
> I obtained some logs from James Harvey which make the situation clearer - it
> can be found here:
> https://termbin.
Hi,
On Sat, Feb 09, 2019 at 11:49:35AM +0100, Marc-André Lureau wrote:
> On Tue, Jan 22, 2019 at 9:51 PM Jonathon Jongsma wrote:
> > I do not always update my laptop to the latest release
> > immediately. For example, I'm still running Fedora 28 on my
> > laptop at the moment, which
>
> Wouldn't
Hi,
On Sat, Feb 09, 2019 at 11:45:18AM +0100, Marc-André Lureau wrote:
> Hi
>
> On Fri, Feb 8, 2019 at 7:32 PM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > Hi,
> >
> > Trying to improve and integrate flatpak for spicy together with
> > gitlab-ci. I hope the changes here makes sense to y
66 matches
Mail list logo
