Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-04-11 Thread Eduardo Lima (Etrunko)
On 11/04/18 12:30, Frediano Ziglio wrote: >> >> On 11/04/18 08:27, Frediano Ziglio wrote: +# +# global C defines +# +spice_server_global_cflags = [#'-std=c99', # fails compiling spice-common/bitops.h + '-fvisibility=hidden', +

Re: [Spice-devel] [spice-server 1/2] cursor: Delay release of QXL guest cursor resources

2018-04-11 Thread Frediano Ziglio
> > There's an implicit API/ABI contract between QEMU and SPICE that SPICE > will keep the guest QXL resources alive as long as QEMU can hold a > pointer to them. This implicit contract was broken in 1c6e7cf7 "Release > cursor as soon as possible", causing crashes at migration time. > While the pr

Re: [Spice-devel] [spice-server 2/2] cursor: Rename cursor_marshall to red_marshall_cursor_command

2018-04-11 Thread Frediano Ziglio
> > The name is more consistent with red_marshall_cursor_init. > --- > server/cursor-channel.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Why command (so red_marshall_cursor) ? The item is RED_PIPE_ITEM_TYPE_CURSOR. > diff --git a/server/cursor-channel.c b/server/cursor-

[Spice-devel] [spice-server 1/2] cursor: Delay release of QXL guest cursor resources

2018-04-11 Thread Christophe Fergeau
There's an implicit API/ABI contract between QEMU and SPICE that SPICE will keep the guest QXL resources alive as long as QEMU can hold a pointer to them. This implicit contract was broken in 1c6e7cf7 "Release cursor as soon as possible", causing crashes at migration time. While the proper fix woul

[Spice-devel] [spice-server 2/2] cursor: Rename cursor_marshall to red_marshall_cursor_command

2018-04-11 Thread Christophe Fergeau
The name is more consistent with red_marshall_cursor_init. --- server/cursor-channel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index 522261e3f..a549c5fe0 100644 --- a/server/cursor-channel.c +++ b/server/cursor-c

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-04-11 Thread Frediano Ziglio
> > On 11/04/18 08:27, Frediano Ziglio wrote: > >> +# > >> +# global C defines > >> +# > >> +spice_server_global_cflags = [#'-std=c99', # fails compiling > >> spice-common/bitops.h > >> + '-fvisibility=hidden', > >> + '-DSPICE_SERVER_INTERN

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-04-11 Thread Eduardo Lima (Etrunko)
On 11/04/18 08:27, Frediano Ziglio wrote: >> +# >> +# global C defines >> +# >> +spice_server_global_cflags = [#'-std=c99', # fails compiling >> spice-common/bitops.h >> + '-fvisibility=hidden', >> + '-DSPICE_SERVER_INTERNAL', >> +

Re: [Spice-devel] [PATCH spice-server v2] stream-channel: Implements monitors_config

2018-04-11 Thread Frediano Ziglio
ping > > Although not necessary for a single monitor DisplayChannel implementation > this make the DisplayChannels more coherent from the client > point of view. > > Signed-off-by: Frediano Ziglio > --- > server/stream-channel.c | 35 --- > 1 file changed, 32 in

Re: [Spice-devel] [spice-gtk v1 04/11] channel-display: use GHashTable to keep stream's structure

2018-04-11 Thread Victor Toso
Hi, On Tue, Apr 10, 2018 at 07:46:46PM +0300, Uri Lublin wrote: > On 04/10/2018 02:58 PM, Victor Toso wrote: > > On Mon, Apr 09, 2018 at 02:14:15PM +0300, Uri Lublin wrote: > > > Some thoughts: > > > 1. It make sense to make it 64 on the server side. > > > > Why? Just so we can alloc a power of t

Re: [Spice-devel] [PATCH spice-server 0/3] Flush interface and TCP_CORK

2018-04-11 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > more than 2 years old now > > > > > > > > These patches try to add interface to support flush interface. > > > This interface could help improving bandwidth usage reducing bytes > > > sent through network. > > > The TCP_CORK is one possible usage of the l

Re: [Spice-devel] [PATCH spice-common 0/3] Fix some possible overflows in client

2018-04-11 Thread Frediano Ziglio
ping > > This fix https://bugzilla.redhat.com/show_bug.cgi?id=1501200. > > Frediano Ziglio (3): > Fix integer overflows computing sizes > Write a small test to test possible crash > Avoid integer overflow computing image sizes > > python_modules/demarshal.py | 52 ++--

Re: [Spice-devel] [PATCH spice-server] spice-char: Add some documentation to SpiceCharDeviceInterface

2018-04-11 Thread Frediano Ziglio
> > > On 23 Mar 2018, at 17:20, Frediano Ziglio wrote: > > > >> > >> Thank you for that. Looks good after two minor grammatical fixes. > >> > >>> On 22 Mar 2018, at 11:12, Frediano Ziglio wrote: > >>> > >>> Signed-off-by: Frediano Ziglio > >>> --- > >>> server/spice-char.h | 21

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-04-11 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) > --- > docs/manual/meson.build | 21 + > docs/meson.build | 16 > meson.build | 175 > meson_options.txt | 39 > server/meson.build| 2

Re: [Spice-devel] Gitlab - 2018!

2018-04-11 Thread Victor Toso
Hi, On Thu, Apr 05, 2018 at 11:33:16AM +0200, Victor Toso wrote: > Hi, > > So, no bug migration at this point. Repos can be done as soon as > team sign up for Gitlab. If you have ssh access already, just go > to link [0], add your username and request for a password in > 'Forgot your password' -

Re: [Spice-devel] [PATCH spice-common] Remove extra self parameter from member function

2018-04-11 Thread Frediano Ziglio
> > When testing out some experimental protocol changes, I managed to > trigger the following error: > > GEN generated_client_demarshallers.c > Traceback (most recent call last): > File "../../../spice-common/spice_codegen.py", line 267, in > demarshal.write_protocol_parser(writer,

[Spice-devel] bad id bug in glz decoder

2018-04-11 Thread Usepr Xf
Hi all, Sorry to be a bother. After a long time running of glz encode&decode (approx. 4hrs), I came across this error. The higher bits (> 24) of the image id is truncated, which makes *dist* less than *id*. This error seems to happen when the *dist* across *(1<<24)* Can you help me solve this

Re: [Spice-devel] [PATCH spice-common] Remove extra self parameter from member function

2018-04-11 Thread Lukáš Hrázký
On Tue, 2018-04-10 at 16:29 -0500, Jonathon Jongsma wrote: > When testing out some experimental protocol changes, I managed to > trigger the following error: > > GEN generated_client_demarshallers.c > Traceback (most recent call last): > File "../../../spice-common/spice_codegen.py", line

Re: [Spice-devel] help!!!

2018-04-11 Thread Snir Sheriber
On 04/11/2018 05:12 AM, molo wrote: hi?? ?0?2 ?0?2 thx for your letter in reply. ?0?2 ?0?2 1??some picture attached that you can not see?0?2 may be forbidden?? because i am in China??within the Great Wall ?? Not this time , i can see it ;)?0?2 try to access the folder as Victor mentioned-?0