Re: [Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-23 Thread Frediano Ziglio
> > On Fri, 2018-03-23 at 11:56 -0400, Frediano Ziglio wrote: > > > > > > > On 23 Mar 2018, at 15:57, Lukáš Hrázký wrote: > > > > > > > > From: Lukáš Hrázký > > > > > > > > The name 'com.redhat.stream.0' is too generic and in no way denotes it > > > > belongs to SPICE. It is preferred to have

Re: [Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 11:56 -0400, Frediano Ziglio wrote: > > > > > On 23 Mar 2018, at 15:57, Lukáš Hrázký wrote: > > > > > > From: Lukáš Hrázký > > > > > > The name 'com.redhat.stream.0' is too generic and in no way denotes it > > > belongs to SPICE. It is preferred to have the project's doma

Re: [Spice-devel] [PATCH spice-server] spice-char: Add some documentation to SpiceCharDeviceInterface

2018-03-23 Thread Frediano Ziglio
> > Thank you for that. Looks good after two minor grammatical fixes. > > > On 22 Mar 2018, at 11:12, Frediano Ziglio wrote: > > > > Signed-off-by: Frediano Ziglio > > --- > > server/spice-char.h | 21 + > > 1 file changed, 21 insertions(+) > > > > diff --git a/server/spice

Re: [Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 11:50 -0400, Frediano Ziglio wrote: > > > > On Fri, 2018-03-23 at 13:05 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > This change addresses three issues related to plugin version checking: > > > > > > 1. It is possible for plugins to b

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 12:00 -0400, Frediano Ziglio wrote: > > On Fri, 2018-03-23 at 14:22 +0100, Christophe de Dinechin wrote: > > > > On 23 Mar 2018, at 13:52, Lukáš Hrázký wrote: > > > > > > > > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote: > > > > > > On 23 Mar 2018, at 13:3

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Frediano Ziglio
> On Fri, 2018-03-23 at 14:22 +0100, Christophe de Dinechin wrote: > > > On 23 Mar 2018, at 13:52, Lukáš Hrázký wrote: > > > > > > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote: > > > > > On 23 Mar 2018, at 13:36, Lukáš Hrázký wrote: > > > > > > > > > > On Fri, 2018-03-23 at 1

Re: [Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-23 Thread Frediano Ziglio
> > > On 23 Mar 2018, at 15:57, Lukáš Hrázký wrote: > > > > From: Lukáš Hrázký > > > > The name 'com.redhat.stream.0' is too generic and in no way denotes it > > belongs to SPICE. It is preferred to have the project's domain in the > > name and Red Hat doesn't own the project. Rename it to > >

Re: [Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-23 Thread Frediano Ziglio
> > On Fri, 2018-03-23 at 13:05 +0100, Christophe de Dinechin wrote: > > From: Christophe de Dinechin > > > > This change addresses three issues related to plugin version checking: > > > > 1. It is possible for plugins to bypass version checking or do it wrong > >(as a matter of fact, the m

Re: [Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-23 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > This change addresses three issues related to plugin version checking: > > 1. It is possible for plugins to bypass version checking or do it wrong >(as a matter of fact, the mjpeg fallback sets a bad example) > > 2. The current plugin version check viol

Re: [Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-23 Thread Christophe de Dinechin
> On 23 Mar 2018, at 15:57, Lukáš Hrázký wrote: > > From: Lukáš Hrázký > > The name 'com.redhat.stream.0' is too generic and in no way denotes it > belongs to SPICE. It is preferred to have the project's domain in the > name and Red Hat doesn't own the project. Rename it to > org.spice-space.

Re: [Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-23 Thread Frediano Ziglio
> > From: Lukáš Hrázký > > The name 'com.redhat.stream.0' is too generic and in no way denotes it > belongs to SPICE. It is preferred to have the project's domain in the > name and Red Hat doesn't own the project. Rename it to > org.spice-space.stream.0. > > Signed-off-by: Lukáš Hrázký > --- >

Re: [Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 15:57 +0100, Lukáš Hrázký wrote: > From: Lukáš Hrázký (Noted the apparently wrong email, I'll fix it locally) > The name 'com.redhat.stream.0' is too generic and in no way denotes it > belongs to SPICE. It is preferred to have the project's domain in the > name and Red Hat

[Spice-devel] [PATCH spice v2] rename the virtio port for streaming

2018-03-23 Thread Lukáš Hrázký
Changes since v1: - changed the name to "org.spice-space.stream.0" - added a patch for the SPICE server -- 2.16.2 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-streaming-agent v2 1/1] rename the virtio port to org.spice-space.stream.0

2018-03-23 Thread Lukáš Hrázký
The name 'com.redhat.stream.0' is too generic and in no way denotes it belongs to SPICE. It is preferred to have the project's domain in the name and Red Hat doesn't own the project. Rename it to org.spice-space.stream.0. Signed-off-by: Lukáš Hrázký --- README | 12 +

[Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

2018-03-23 Thread Lukáš Hrázký
From: Lukáš Hrázký The name 'com.redhat.stream.0' is too generic and in no way denotes it belongs to SPICE. It is preferred to have the project's domain in the name and Red Hat doesn't own the project. Rename it to org.spice-space.stream.0. Signed-off-by: Lukáš Hrázký --- server/reds.c

Re: [Spice-devel] [PATCH RFC] Support for building with Meson

2018-03-23 Thread Eduardo Lima (Etrunko)
On 22/03/18 14:18, Eduardo Lima (Etrunko) wrote: > Here is the result of work in progress with replacing autotools with > Meson. I am sending the patches on the ML for easier visualization, but > if you want to try it, I would really recommend pulling from my gitlab > repositories, e.g.: > > $ g

Re: [Spice-devel] [PATCH RFC] Support for building with Meson

2018-03-23 Thread Eduardo Lima (Etrunko)
On 23/03/18 07:58, Daniel P. Berrangé wrote: > On Fri, Mar 23, 2018 at 11:51:41AM +0100, Christophe de Dinechin wrote: >> Hi Eduardo, >> >> >> Thanks for sharing. >> >> Out of curiosity, I understand why you want to add Meson, but why remove >> autotools right away? > > Note in particular that th

Re: [Spice-devel] [PATCH RFC] Support for building with Meson

2018-03-23 Thread Eduardo Lima (Etrunko)
On 23/03/18 07:51, Christophe de Dinechin wrote: > Hi Eduardo, > > > Thanks for sharing. > > Out of curiosity, I understand why you want to add Meson, but why remove > autotools right away? > > In my c3d build branch, I made sure both make and autotools could coexist. > I knew it was going

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 14:22 +0100, Christophe de Dinechin wrote: > > On 23 Mar 2018, at 13:52, Lukáš Hrázký wrote: > > > > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote: > > > > On 23 Mar 2018, at 13:36, Lukáš Hrázký wrote: > > > > > > > > On Fri, 2018-03-23 at 12:00 +0100, Ch

Re: [Spice-devel] [PATCH vdagent v3 1/2] vdagent: add new vdagent_clipboard_*() interface

2018-03-23 Thread Victor Toso
Hi, On Thu, Mar 01, 2018 at 11:13:59AM +0100, Jakub Janků wrote: > From: Jakub Janků > > Introduce new functions to handle clipboard, > add new files clipboard.[ch] > > This is only a preparatory patch for > following GTK+ clipboard implementation. Acked-by: Victor Toso I plan to push this e

Re: [Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 13:05 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > This change addresses three issues related to plugin version checking: > > 1. It is possible for plugins to bypass version checking or do it wrong >(as a matter of fact, the mjpeg fallback set

Re: [Spice-devel] [PATCH spice-server] spice-char: Add some documentation to SpiceCharDeviceInterface

2018-03-23 Thread Christophe de Dinechin
Thank you for that. Looks good after two minor grammatical fixes. > On 22 Mar 2018, at 11:12, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- > server/spice-char.h | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/server/spice-char.h b/server/spice-

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 02:22:23PM +0100, Christophe de Dinechin wrote: > > > > On 23 Mar 2018, at 13:52, Lukáš Hrázký wrote: > > > > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote: > >>> On 23 Mar 2018, at 13:36, Lukáš Hrázký wrote: > >>> > >>> On Fri, 2018-03-23 at 12:00 +0

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Christophe de Dinechin
> On 23 Mar 2018, at 13:52, Lukáš Hrázký wrote: > > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote: >>> On 23 Mar 2018, at 13:36, Lukáš Hrázký wrote: >>> >>> On Fri, 2018-03-23 at 12:00 +0100, Christophe de Dinechin wrote: > On 22 Mar 2018, at 14:13, Lukáš Hrázký wrote:

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote: > > On 23 Mar 2018, at 13:36, Lukáš Hrázký wrote: > > > > On Fri, 2018-03-23 at 12:00 +0100, Christophe de Dinechin wrote: > > > > On 22 Mar 2018, at 14:13, Lukáš Hrázký wrote: > > > > > > > > The name "com.redhat.stream.0" is too

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Victor Toso
On Fri, Mar 23, 2018 at 01:30:31PM +0100, Lukáš Hrázký wrote: > On Thu, 2018-03-22 at 10:30 -0400, Frediano Ziglio wrote: > > > > > > The name "com.redhat.stream.0" is too generic and in no way denotes it > > > belongs to SPICE. > > > > > > > Maybe following webdav name (org.spice-space.webdav.0

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Christophe de Dinechin
> On 23 Mar 2018, at 13:36, Lukáš Hrázký wrote: > > On Fri, 2018-03-23 at 12:00 +0100, Christophe de Dinechin wrote: >>> On 22 Mar 2018, at 14:13, Lukáš Hrázký wrote: >>> >>> The name "com.redhat.stream.0" is too generic and in no way denotes it >>> belongs to SPICE. >> >> This also would ne

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Lukáš Hrázký
On Fri, 2018-03-23 at 12:00 +0100, Christophe de Dinechin wrote: > > On 22 Mar 2018, at 14:13, Lukáš Hrázký wrote: > > > > The name "com.redhat.stream.0" is too generic and in no way denotes it > > belongs to SPICE. > > This also would need to be sync’d with libvirt and virt-manager, no? I’ve no

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Lukáš Hrázký
On Thu, 2018-03-22 at 10:30 -0400, Frediano Ziglio wrote: > > > > The name "com.redhat.stream.0" is too generic and in no way denotes it > > belongs to SPICE. > > > > Maybe following webdav name (org.spice-space.webdav.0) we should use > org.spice-space.stream.0 ? I'm fine with either... Who el

[Spice-devel] [PATCH 1/2] Ensure that plugins cannot bypass version check

2018-03-23 Thread Christophe de Dinechin
From: Christophe de Dinechin This change addresses three issues related to plugin version checking: 1. It is possible for plugins to bypass version checking or do it wrong (as a matter of fact, the mjpeg fallback sets a bad example) 2. The current plugin version check violates the C++ ODR, i

[Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-23 Thread Christophe de Dinechin
From: Christophe de Dinechin Ensure that plugin version checking cannot be bypassed. Implement version checking without violating the C++ ODR. Improve ABI version numbering when incompatibilites are detected post-release. Add macro to make it easier to generate the ABI interface. Christophe de D

[Spice-devel] [PATCH 2/2] Add a macro to deal with the boilerplate of writing a streaming agent plugin

2018-03-23 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- include/spice-streaming-agent/plugin.hpp | 8 1 file changed, 8 insertions(+) diff --git a/include/spice-streaming-agent/plugin.hpp b/include/spice-streaming-agent/plugin.hpp index 0ec5040..b01cd82 100644 --- a/in

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Christophe de Dinechin
> On 22 Mar 2018, at 14:13, Lukáš Hrázký wrote: > > The name "com.redhat.stream.0" is too generic and in no way denotes it > belongs to SPICE. This also would need to be sync’d with libvirt and virt-manager, no? I’ve not checked how Boxes does it.

Re: [Spice-devel] [PATCH RFC] Support for building with Meson

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 11:51:41AM +0100, Christophe de Dinechin wrote: > Hi Eduardo, > > > Thanks for sharing. > > Out of curiosity, I understand why you want to add Meson, but why remove > autotools right away? Note in particular that this will make it impossible to build on a RHEL-7 platfor

Re: [Spice-devel] [PATCH RFC] Support for building with Meson

2018-03-23 Thread Christophe de Dinechin
Hi Eduardo, Thanks for sharing. Out of curiosity, I understand why you want to add Meson, but why remove autotools right away? In my c3d build branch, I made sure both make and autotools could coexist. > ddd@ptitpuce[c3d-build] spice> make help > Specific top-level target: > make gitclean

Re: [Spice-devel] [spice-vdagnet (linux) PATCH] x11-randr: do not assume each output has ncrtc=1

2018-03-23 Thread Victor Toso
Hi, On Tue, Mar 20, 2018 at 05:24:42PM +0200, Uri Lublin wrote: > This was true for virtual graphic cards, but not true for > device-assigned graphic cards. > For example NVIDIA M2000 has 8. > > Still we currently pick only a single crtc for each output > (but looping over them to find an active