[Spice-devel] [PATCH usbredir v3] usbredirserver: reject empty vendorid in cmd line

2017-11-28 Thread Chen Hanxiao
From: Chen Hanxiao Vendor ID is not a valid ID [1] But we could pass it from cmd: usbredirserver :abcd Which will get a vendor ID. or usbredirserver :87abcd will get an ID > 0x This patch will check this senario. [1]: http://www.linux-usb.org/usb.ids Signed-off-by: C

Re: [Spice-devel] [PATCH usbredir v2.1] usbredirserver: reject empty vendorid in cmd line

2017-11-28 Thread Chen Hanxiao
At 2017-11-28 21:16:15, "Frediano Ziglio" wrote: >> >> From: Chen Hanxiao >> >> Vendor ID is not a valid ID [1] >> But we could pass it from cmd: >> usbredirserver :abcd >> Which will cause a vendor id. >> >> This patch will check this senario. >> >> [1]: http://www.linux-usb.o

Re: [Spice-devel] [PATCH usbredir v2.1] usbredirserver: reject empty vendorid in cmd line

2017-11-28 Thread Frediano Ziglio
> > From: Chen Hanxiao > > Vendor ID is not a valid ID [1] > But we could pass it from cmd: > usbredirserver :abcd > Which will cause a vendor id. > > This patch will check this senario. > > [1]: http://www.linux-usb.org/usb.ids > > Signed-off-by: Chen Hanxiao > --- > v2.1: > f

[Spice-devel] [PATCH usbredir v2.1] usbredirserver: reject empty vendorid in cmd line

2017-11-28 Thread Chen Hanxiao
From: Chen Hanxiao Vendor ID is not a valid ID [1] But we could pass it from cmd: usbredirserver :abcd Which will cause a vendor id. This patch will check this senario. [1]: http://www.linux-usb.org/usb.ids Signed-off-by: Chen Hanxiao --- v2.1: fix a copy-paste error v2: add r

Re: [Spice-devel] [PATCH usbredir v2] usbredirserver: reject empty vendorid in cmd line

2017-11-28 Thread Chen Hanxiao
At 2017-11-28 19:38:10, "Frediano Ziglio" wrote: >> >> From: Chen Hanxiao >> >> Vendor ID is not a valid ID [1] >> But we could pass it from cmd: >> usbredirserver :abcd >> Which will cause a vendor id. >> Also check the range of them. >> >> This patch will check this senario. >>

Re: [Spice-devel] where to get the qxl device datasheet

2017-11-28 Thread Frediano Ziglio
> Hi guys > > I want to study the SPICE protocol. But i didn't find the datasheet of QXL > device on www.spice-space.org . Can anyone tell where to find it? Thanks. > > -- > best regards > yang Sorry for late reply. There's no official single documentation. There are some documents (.odt) under

Re: [Spice-devel] [PATCH usbredir v2] usbredirserver: reject empty vendorid in cmd line

2017-11-28 Thread Frediano Ziglio
> > From: Chen Hanxiao > > Vendor ID is not a valid ID [1] > But we could pass it from cmd: > usbredirserver :abcd > Which will cause a vendor id. > Also check the range of them. > > This patch will check this senario. > > [1]: http://www.linux-usb.org/usb.ids > > Signed-off-by: C

[Spice-devel] [PATCH spice-server] mjpeg-encoder: Fix some typos

2017-11-28 Thread Frediano Ziglio
unexected -> unexpected esitimation -> estimation Signed-off-by: Frediano Ziglio --- server/mjpeg-encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c index cb70ab1b..d4b5c6fc 100644 --- a/server/mjpeg-encoder.c +++ b

[Spice-devel] [PATCH usbredir v2] usbredirserver: reject empty vendorid in cmd line

2017-11-28 Thread Chen Hanxiao
From: Chen Hanxiao Vendor ID is not a valid ID [1] But we could pass it from cmd: usbredirserver :abcd Which will cause a vendor id. Also check the range of them. This patch will check this senario. [1]: http://www.linux-usb.org/usb.ids Signed-off-by: Chen Hanxiao --- v2: add ra

Re: [Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Chen Hanxiao
At 2017-11-28 19:11:23, "Frediano Ziglio" wrote: >> >> At 2017-11-28 18:49:54, "Frediano Ziglio" wrote: >> >> >> >> At 2017-11-28 18:27:54, "Frediano Ziglio" wrote: >> >> >> >> >> >> From: Chen Hanxiao >> >> >> >> >> >> Vendor ID is not a valid ID [1] >> >> >> But we could pass it fr

Re: [Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Frediano Ziglio
> > At 2017-11-28 18:49:54, "Frediano Ziglio" wrote: > >> > >> At 2017-11-28 18:27:54, "Frediano Ziglio" wrote: > >> >> > >> >> From: Chen Hanxiao > >> >> > >> >> Vendor ID is not a valid ID [1] > >> >> But we could pass it from cmd: > >> >> usbredirserver :abcd > >> >>or > >> >>

Re: [Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Chen Hanxiao
At 2017-11-28 18:49:54, "Frediano Ziglio" wrote: >> >> At 2017-11-28 18:27:54, "Frediano Ziglio" wrote: >> >> >> >> From: Chen Hanxiao >> >> >> >> Vendor ID is not a valid ID [1] >> >> But we could pass it from cmd: >> >> usbredirserver :abcd >> >>or >> >> usbredirserver :a

Re: [Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Frediano Ziglio
> > > > At 2017-11-28 18:27:54, "Frediano Ziglio" wrote: > > >> > > >> From: Chen Hanxiao > > >> > > >> Vendor ID is not a valid ID [1] > > >> But we could pass it from cmd: > > >> usbredirserver :abcd > > >>or > > >> usbredirserver :abcd > > >> > > >> Which will pass a

Re: [Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Frediano Ziglio
> > At 2017-11-28 18:27:54, "Frediano Ziglio" wrote: > >> > >> From: Chen Hanxiao > >> > >> Vendor ID is not a valid ID [1] > >> But we could pass it from cmd: > >> usbredirserver :abcd > >>or > >> usbredirserver :abcd > >> > >> Which will pass a vendor id to usbredirser

Re: [Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Chen Hanxiao
At 2017-11-28 18:27:54, "Frediano Ziglio" wrote: >> >> From: Chen Hanxiao >> >> Vendor ID is not a valid ID [1] >> But we could pass it from cmd: >> usbredirserver :abcd >>or >> usbredirserver :abcd >> >> Which will pass a vendor id to usbredirserver. >> >> This patch w

[Spice-devel] [PATCH spice-common] proto: Add some documentation to stream_report message

2017-11-28 Thread Frediano Ziglio
Most of the documentation is extracted from notes in spice-server code and comments. Signed-off-by: Frediano Ziglio --- spice.proto | 12 1 file changed, 12 insertions(+) diff --git a/spice.proto b/spice.proto index ea37225..c1e7b95 100644 --- a/spice.proto +++ b/spice.proto @@ -99

Re: [Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Frediano Ziglio
> > From: Chen Hanxiao > > Vendor ID is not a valid ID [1] > But we could pass it from cmd: > usbredirserver :abcd >or > usbredirserver :abcd > > Which will pass a vendor id to usbredirserver. > > This patch will check this senario. > > [1]: http://www.linux-usb.org/usb.

[Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

2017-11-28 Thread Chen Hanxiao
From: Chen Hanxiao Vendor ID is not a valid ID [1] But we could pass it from cmd: usbredirserver :abcd or usbredirserver :abcd Which will pass a vendor id to usbredirserver. This patch will check this senario. [1]: http://www.linux-usb.org/usb.ids Signed-off-by: Chen Hanx

Re: [Spice-devel] [PATCH usbredir v2] usbredirserver: don't show logs after a failure open

2017-11-28 Thread Frediano Ziglio
> > From: Chen Hanxiao > > If we did't open a USB device successfully, > don't try to show that USB device info logs. > > Signed-off-by: Chen Hanxiao Acked-by: Frediano Ziglio > --- > v2: modified the wrong title > > usbredirserver/usbredirserver.c | 3 +-- > 1 file changed, 1 insertion(+

Re: [Spice-devel] [PATCH spice-server] ci: Detect if code compile with SASL disabled

2017-11-28 Thread Snir Sheriber
On 11/28/2017 09:57 AM, Snir Sheriber wrote: On 11/27/2017 01:40 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Results athttps://gitlab.com/freddy77/spice/-/jobs/42033559. diff --git a/.gitlab-c