At 2017-11-28 18:49:54, "Frediano Ziglio" <fzig...@redhat.com> wrote:
>>
>> At 2017-11-28 18:27:54, "Frediano Ziglio" <fzig...@redhat.com> wrote:
>> >>
>> >> From: Chen Hanxiao <chenhanx...@gmail.com>
>> >>
>> >> Vendor ID 0000 is not a valid ID [1]
>> >> But we could pass it from cmd:
>> >> usbredirserver :abcd
>> >> or
>> >> usbredirserver 0000:abcd
>> >>
>> >> Which will pass a 0000 vendor id to usbredirserver.
[snip]
>> >
>> >Maybe you want something like
>> >
>> > if (*endptr != ':' || usbvendor <= 0 || usbvendor > 0xffff) {
>> >
>> >similar for usbproduct.
>>
>> We don't need to check for usbvendor <0, for we don't have long options for
>> usbvendor:usbproduct.
>> So I don't know how to pass a negative value to it.
>>
>
>Well, try "81234567:-123" :-)
As:
https://github.com/chenhanxiao/usbredir/blob/master/usbredirserver/usbredirserver.c#L246-L249
It will fail at:
if (*endptr != '-') { //may get ':' here
Regards,
- Chen
>
>>
>> The check for <= 0xffff looks reasonable.
>>
>> Regards,
>> - Chen
>
>Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
