Hi Tomáš,
Teeny nit - your subject line implies that there are 2 more patches to
come. I'm guessing the subject line is in error, not that there are
missing patches. Is that right?
Some thoughts on the license, and an ack, below.
> diff --git a/spice_auto.html b/spice_auto.html
> index 2f04fc9
Hi Tomáš,
This is logically two patches, not one. Could you split them?
Further comments inline.
On 09/14/2017 04:34 AM, Tomáš Bohdálek wrote:
> This already uses the added function sendCtrlAltDel().
> ---
> inputs.js | 9 ++---
> spice_auto.html | 1 +
> 2 files changed, 7 insertion
Hi Tomáš,
This patch looks correct to me, although I have not yet had a chance to
run it through vp9 encoding.
So ack to this patch :-).
Cheers,
Jeremy
On 09/12/2017 02:43 AM, Tomáš Bohdálek wrote:
> ---
> display.js | 27 +--
> spiceconn.js | 2 ++
> webm.js |
Hi Tomáš,
On 09/07/2017 02:18 AM, Tomáš Bohdálek wrote:
> ---
> display.js | 16
> enums.js| 10 ++
> spicemsg.js | 24
> 3 files changed, 50 insertions(+)
>
> diff --git a/display.js b/display.js
> index 60c79b4..0868f91 100644
> --- a/disp
Hi Tomáš,
Just as an aside, this work is greatly appreciated, and broadly quite
nice; please take my nit picking as a compliment and my attempt to help.
And I only have one nit on this one:
On 09/07/2017 02:18 AM, Tomáš Bohdálek wrote:
> ---
> display.js | 16
> enums.js|
Hi Tomáš,
On 09/07/2017 02:18 AM, Tomáš Bohdálek wrote:
> This will be used in other commits.
> ---
> spiceconn.js | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/spiceconn.js b/spiceconn.js
> index 33e7388..78d5820 100644
> --- a/spiceconn.js
> +++ b/spiceconn.js
>
Hi Tomáš,
On 09/06/2017 03:52 AM, Tomáš Bohdálek wrote:
> ---
> main.js | 15 +++
> spice.html | 5 +
> spice_auto.html | 5 +
> 3 files changed, 25 insertions(+)
>
> diff --git a/main.js b/main.js
> index 0237f0e..447177b 100644
> --- a/main.js
> +++ b/main.j
Hi Tomáš,
On 09/06/2017 03:52 AM, Tomáš Bohdálek wrote:
> ---
> enums.js| 12 ++--
> main.js | 16 +++-
> spicemsg.js | 4
> 3 files changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/enums.js b/enums.js
> index d5a9003..7154595 100644
> --- a/enums.js
>
>
> On Fri, Sep 15, 2017 at 08:32:47AM -0400, Marc-André Lureau wrote:
> > Please send the patches to the spice-devel@lists.freedesktop.org mailing
> > list
>
> Thank you; here they go again.
>
> > - Original Message -
> > > please find two trivial patches against 0.12.13 attached
> > >
On Fri, Sep 15, 2017 at 08:32:47AM -0400, Marc-André Lureau wrote:
> Please send the patches to the spice-devel@lists.freedesktop.org mailing list
Thank you; here they go again.
> - Original Message -
> > please find two trivial patches against 0.12.13 attached
> > that (1) introduce one
Hi,
I've recently developed a set of gobject bindings for spice-server. The
code is available here:
https://github.com/mjayfrancis/SpiceServerGLib
This parallels SpiceClientGLib to allow language bindings to easily control
server instances.
The API coverage is by no means yet complete, but wh
>
> > On 15 Sep 2017, at 10:43, Frediano Ziglio wrote:
> >
> >>
> >>> On 14 Sep 2017, at 17:55, Frediano Ziglio wrote:
> >>>
>
> Wasn’t there a discussion about also renaming the function? I believe
> “pending_send” is a symptom, not the reason for disconnecting.
>
> >>>
> On 15 Sep 2017, at 10:43, Frediano Ziglio wrote:
>
>>
>>> On 14 Sep 2017, at 17:55, Frediano Ziglio wrote:
>>>
Wasn’t there a discussion about also renaming the function? I believe
“pending_send” is a symptom, not the reason for disconnecting.
Christophe
>>
>
> On Fri, Sep 15, 2017 at 06:10:03AM -0400, Frediano Ziglio wrote:
> > >
> > > On Fri, Sep 15, 2017 at 10:04:45AM +0100, Frediano Ziglio wrote:
> > > > This was proposed by Christophe De Dinechin for coherence with
> > > > a patch in reds_stat tool to find statistic files.
> > > > Allows to sea
On Fri, Sep 15, 2017 at 06:10:03AM -0400, Frediano Ziglio wrote:
> >
> > On Fri, Sep 15, 2017 at 10:04:45AM +0100, Frediano Ziglio wrote:
> > > This was proposed by Christophe De Dinechin for coherence with
> > > a patch in reds_stat tool to find statistic files.
> > > Allows to search such files
>
> On Fri, Sep 15, 2017 at 10:04:45AM +0100, Frediano Ziglio wrote:
> > This was proposed by Christophe De Dinechin for coherence with
> > a patch in reds_stat tool to find statistic files.
> > Allows to search such files using a shell pattern (allows to
> > be used by functions like glob or fnma
On Fri, Sep 15, 2017 at 10:04:45AM +0100, Frediano Ziglio wrote:
> This was proposed by Christophe De Dinechin for coherence with
> a patch in reds_stat tool to find statistic files.
> Allows to search such files using a shell pattern (allows to
> be used by functions like glob or fnmatch).
Is thi
This was proposed by Christophe De Dinechin for coherence with
a patch in reds_stat tool to find statistic files.
Allows to search such files using a shell pattern (allows to
be used by functions like glob or fnmatch).
Signed-off-by: Frediano Ziglio
---
spice/stats.h | 1 +
1 file changed, 1 ins
>
> > On 14 Sep 2017, at 17:55, Frediano Ziglio wrote:
> >
> >>
> >> Wasn’t there a discussion about also renaming the function? I believe
> >> “pending_send” is a symptom, not the reason for disconnecting.
> >>
> >> Christophe
> >>
> >
> > The discussion was on red_channel_wait_all_sent, we
19 matches
Mail list logo
