[Spice-devel] [PATCH spice-server 6/6] README: Add missing optional dependencies

Signed-off-by: Frediano Ziglio --- README | 4 1 file changed, 4 insertions(+) diff --git a/README b/README index cb64b74d..65e0231b 100644 --- a/README +++ b/README @@ -38,6 +38,10 @@ functionality Cyrus-SASL libcacard >= 0.1.2 (Smartcard support) +CELT

[Spice-devel] [PATCH spice-server 2/6] README: Update link to GIT

Really minor change, just use canonical URL using secure HTTP instead of normal one. Signed-off-by: Frediano Ziglio --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 0fd6f071..2b44b4ce 100644 --- a/README +++ b/README @@ -65,7 +65,7 @@ be report

[Spice-devel] [PATCH spice-server 1/6] README: Update required protocol version

Signed-off-by: Frediano Ziglio --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 45fbe89c..0fd6f071 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ Or to install into a private user specific location The following mandatory dependencies are r

[Spice-devel] [PATCH spice-server 4/6] README: Remove OpenGL dependency

OpenGL dependency was removed by Marc-André Lureau in 2015 (0dc98956). Signed-off-by: Frediano Ziglio --- README | 1 - 1 file changed, 1 deletion(-) diff --git a/README b/README index d7d5d317..8d6edffb 100644 --- a/README +++ b/README @@ -37,7 +37,6 @@ build SPICE The following optional depe

[Spice-devel] [PATCH spice-server 5/6] README: Fix minor dependency

Cyrus-SASL is not mandatory Signed-off-by: Frediano Ziglio --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 8d6edffb..cb64b74d 100644 --- a/README +++ b/README @@ -32,11 +32,11 @@ build SPICE OpenSSL libjpeg zlib -Cyrus-SASL

[Spice-devel] [PATCH spice-server 3/6] README: Remove obsolete GUI dependencies

Remove old dependencies used by obsolete client code. This code was removed from the git repository by Christophe Fergeau in 2014 (18769714). Signed-off-by: Frediano Ziglio --- README | 4 1 file changed, 4 deletions(-) diff --git a/README b/README index 2b44b4ce..d7d5d317 100644 --- a/REA

Re: [Spice-devel] [PATCH spice-server] RFC README: Add LZ4 dependency

On Thu, 2017-07-27 at 14:25 +0100, Frediano Ziglio wrote: > Maybe other dependencies should be reviewed too. > Like SASL not mandatory or GE Gui (what is it?), OpenGL, Xorg. Mmm, it looks like that was supposed to be "CE GUI" (not "GE"), which was something that was apparently used by the old obs

Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

> > > > On 27 Jul 2017, at 17:00, Victor Toso wrote: > > > > Hi, > > > > On Thu, Jul 27, 2017 at 04:28:59PM +0200, Christophe de Dinechin wrote: > >> > >>> On 27 Jul 2017, at 16:04, Christophe Fergeau wrote: > >>> > >>> On Thu, Jul 27, 2017 at 03:29:11PM +0200, Christophe de Dinechin wrote:

Re: [Spice-devel] Survey of repository preferences

> > Hi > > - Original Message - > > > I think we should rather find a consensus on the mailing list rather than > > > avoiding the discussion. > > > > “Avoiding the discussion" sounds like a cheap and unjustified shot. Please > > discuss. > > You are the one making proposal, you should

Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

> On 27 Jul 2017, at 17:00, Victor Toso wrote: > > Hi, > > On Thu, Jul 27, 2017 at 04:28:59PM +0200, Christophe de Dinechin wrote: >> >>> On 27 Jul 2017, at 16:04, Christophe Fergeau wrote: >>> >>> On Thu, Jul 27, 2017 at 03:29:11PM +0200, Christophe de Dinechin wrote: > On 27 Jul

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Try to sum up the initial problem was patches/series tracking So far there are 3 proposal 1) PR/MR (GitLab/GitHub style) 2) patchew 3a) shared git repository 3b) links to external git repositories 1) PR surely can trace the status of series and is ready to use with small initial setup. Not cle

Re: [Spice-devel] Survey of repository preferences

Hi - Original Message - > > I think we should rather find a consensus on the mailing list rather than > > avoiding the discussion. > > “Avoiding the discussion" sounds like a cheap and unjustified shot. Please > discuss. You are the one making proposal, you should come up with rationale.

Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

On Thu, Jul 27, 2017 at 04:28:59PM +0200, Christophe de Dinechin wrote: > > > On 27 Jul 2017, at 16:04, Christophe Fergeau wrote: > > > > On Thu, Jul 27, 2017 at 03:29:11PM +0200, Christophe de Dinechin wrote: > >> > >>> On 27 Jul 2017, at 15:25, Frediano Ziglio wrote: > >>> > >>> Signed-off-

Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

Hi, On Thu, Jul 27, 2017 at 04:28:59PM +0200, Christophe de Dinechin wrote: > > > On 27 Jul 2017, at 16:04, Christophe Fergeau wrote: > > > > On Thu, Jul 27, 2017 at 03:29:11PM +0200, Christophe de Dinechin wrote: > >> > >>> On 27 Jul 2017, at 15:25, Frediano Ziglio wrote: > >>> > >>> Signed

Re: [Spice-devel] Survey of repository preferences

> On 27 Jul 2017, at 16:49, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> Following the recent discussions about pull requests, merge requests and >> marsupilamis, I’ve put together a small Google form at >> https://goo.gl/forms/bE3UON0zH30sGrg13 to capture the team pre

Re: [Spice-devel] Survey of repository preferences

Hi - Original Message - > Following the recent discussions about pull requests, merge requests and > marsupilamis, I’ve put together a small Google form at > https://goo.gl/forms/bE3UON0zH30sGrg13 to capture the team preferences. I’ve > used multiple-choice answers on purpose, so that we e

Re: [Spice-devel] Survey of repository preferences

> On 27 Jul 2017, at 16:40, Frediano Ziglio wrote: > >> >> Following the recent discussions about pull requests, merge requests and >> marsupilamis, I’ve put together a small Google form at >> https://goo.gl/forms/bE3UON0zH30sGrg13 to capture the team preferences. I’ve >> used multiple-choice a

Re: [Spice-devel] Survey of repository preferences

> > Following the recent discussions about pull requests, merge requests and > marsupilamis, I’ve put together a small Google form at > https://goo.gl/forms/bE3UON0zH30sGrg13 to capture the team preferences. I’ve > used multiple-choice answers on purpose, so that we end up with actionable > number

[Spice-devel] Survey of repository preferences

Following the recent discussions about pull requests, merge requests and marsupilamis, I’ve put together a small Google form at https://goo.gl/forms/bE3UON0zH30sGrg13 to capture the team preferences. I’ve used multiple-choice answers on purpose, so that we end up with actionable numbers. For a

Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

> On 27 Jul 2017, at 16:04, Christophe Fergeau wrote: > > On Thu, Jul 27, 2017 at 03:29:11PM +0200, Christophe de Dinechin wrote: >> >>> On 27 Jul 2017, at 15:25, Frediano Ziglio wrote: >>> >>> Signed-off-by: Frediano Ziglio >>> --- >>> README | 2 +- >>> 1 file changed, 1 insertion(+), 1 del

[Spice-devel] Form regarding preferences for repo layout

I've invited you to fill out the following form: Reorganizing Spice repositories To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSelX_VxzoO64ruoBN1rAbkVQWcyLrJNvBS_vVF_fK09p43x3w/viewform?c=0&w=1&includes_info_params=true&usp=mail_form_link Following the recent discussion on repo

Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

On Thu, Jul 27, 2017 at 03:29:11PM +0200, Christophe de Dinechin wrote: > > > On 27 Jul 2017, at 15:25, Frediano Ziglio wrote: > > > > Signed-off-by: Frediano Ziglio > > --- > > README | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README b/README > > index 45fbe

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

On Thu, Jul 27, 2017 at 03:24:52PM +0200, Christophe de Dinechin wrote: > Here is a recent example. For the work on the streaming agent, I recently > ran into a compilation error because spice-prootocol was not the “right one” > for the code being reviewed, which was IIRC in the spice server. It tu

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 27, 2017 at 03:00:27PM +0200, Christophe de Dinechin wrote: > No, that’s not correct (at least for me). The review itself can happen over > mail, > what I find inefficient is: > > a) to get the list of things to review, and > b) to get a working version of the code after patching >

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 15:27, Frediano Ziglio wrote: > > On 27 Jul 2017, at 15:07, Frediano Ziglio wrote: > > On 27 Jul 2017, at 12:39, Christophe Fergeau wrote: > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote:

Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

> On 27 Jul 2017, at 15:25, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index 45fbe89c..0fd6f071 100644 > --- a/README > +++ b/README > @@ -27,7 +27,7 @@ Or to install into a

Re: [Spice-devel] [PATCH spice-server] README: Fix typo (dependancies -> dependencies)

> On 27 Jul 2017, at 15:25, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- > README | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/README b/README > index dea43444..45fbe89c 100644 > --- a/README > +++ b/README > @@ -24,7 +24,7 @@ Or to install into

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On 27 Jul 2017, at 15:07, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > On 27 Jul 2017, at 12:39, Christophe Fergeau < cferg...@redhat.com > > > > > wrote: > > > > > > > > > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > > > > > > > > > > On Mon, Jul 24,

[Spice-devel] [PATCH spice-server] RFC README: Add LZ4 dependency

Maybe other dependencies should be reviewed too. Like SASL not mandatory or GE Gui (what is it?), OpenGL, Xorg. Signed-off-by: Frediano Ziglio --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index 0fd6f071..e0e758f0 100644 --- a/README +++ b/README @@ -43,6 +43,7 @

[Spice-devel] [PATCH spice-server] README: Fix typo (dependancies -> dependencies)

Signed-off-by: Frediano Ziglio --- README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index dea43444..45fbe89c 100644 --- a/README +++ b/README @@ -24,7 +24,7 @@ Or to install into a private user specific location make make install -The followin

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> On 27 Jul 2017, at 14:28, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> >>> On 26 Jul 2017, at 11:23, Marc-André Lureau >>> wrote: >>> >>> Hi >>> >>> - Original Message - Now, any objection to 1. Recommending that we use git URLs in patches

[Spice-devel] [PATCH spice-server] README: Update required protocol version

Signed-off-by: Frediano Ziglio --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 45fbe89c..0fd6f071 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ Or to install into a private user specific location The following mandatory dependencies are r

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 15:07, Frediano Ziglio wrote: > > On 27 Jul 2017, at 12:39, Christophe Fergeau > wrote: > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > Not really familiar wit

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On 27 Jul 2017, at 12:39, Christophe Fergeau < cferg...@redhat.com > wrote: > > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > > > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > > > > > Not really familiar with GitLab merge requests but on GitH

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 12:53, Daniel P. Berrange wrote: > > On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote: >> On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: >>> On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: Not really familiar with GitLab

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 12:39, Christophe Fergeau wrote: > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: >> On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: >>> Not really familiar with GitLab merge requests but on GitHub they >>> remain open till closed so this wou

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Hi - Original Message - > > > > > > Imho, we could benefit using a system tracking patch series state from > > > > the > > > > mailing list, such as patchew. But it would probably need some work to > > > > fit > > > > Spice needs. > > > > > > We would benefit from that, yes. But that’s a

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> > Hi > > - Original Message - > > > > > On 26 Jul 2017, at 11:23, Marc-André Lureau > > > wrote: > > > > > > Hi > > > > > > - Original Message - > > >> Now, any objection to > > >> > > >> 1. Recommending that we use git URLs in patches? > > > > > > If that may help, but as

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

Hi, On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote: > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > Not really familiar with GitLab merge requests but on GitHub they > > > remain open till

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Hi - Original Message - > > > On 26 Jul 2017, at 11:23, Marc-André Lureau > > wrote: > > > > Hi > > > > - Original Message - > >> Now, any objection to > >> > >> 1. Recommending that we use git URLs in patches? > > > > If that may help, but as Christophe said, this may be ove

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote: > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > Not really familiar with GitLab merge requests but on GitHub they > > > remain open till clos

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > Not really familiar with GitLab merge requests but on GitHub they > > remain open till closed so this would help with old ones. > > The big change on moving to full PR

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

Hey, On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Fri, Jul 21, 2017 at 06:41:01AM -0400, Frediano Ziglio wrote: > > > > > > > > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > > > > Beside that I wonder why I had to wait 8 months for

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

On Thu, Jul 27, 2017 at 10:13:47AM +0200, Christophe de Dinechin wrote: > > On 26 Jul 2017, at 11:23, Marc-André Lureau > wrote: > > > > Hi > > > > - Original Message - > >> Now, any objection to > >> > >> 1. Recommending that we use git URLs in patches? > > > > If that may help, but as

Re: [Spice-devel] [vdagent-win PATCH 1/2] Update git.mk file

For the series: Acked-by: Christophe Fergeau On Thu, Jul 27, 2017 at 10:16:10AM +0100, Frediano Ziglio wrote: > This sync git.mk file with https://github.com/behdad/git.mk. > New version is able to create ignore files that take into account > some files currently ignored (like vdagent/.deps dire

[Spice-devel] [vdagent-win PATCH 2/2] Ignore auxiliary build files

This allows git.mk to include some missing files to ignore. Signed-off-by: Frediano Ziglio --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 7fafb8b..62640f2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -142,6 +142,6 @@ BUILT_SOU

[Spice-devel] [vdagent-win PATCH 1/2] Update git.mk file

This sync git.mk file with https://github.com/behdad/git.mk. New version is able to create ignore files that take into account some files currently ignored (like vdagent/.deps directory). Signed-off-by: Frediano Ziglio --- git.mk | 284 +++-

[Spice-devel] [vdagent-win PATCH v2] Do not use dash in rpm version

RPM does not allow dash in version string. Replace dashes with underscores. This make easier to run "make dist" followed by rpmbuild. Signed-off-by: Frediano Ziglio --- configure.ac| 2 ++ mingw-spice-vdagent.spec.in | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) C

Re: [Spice-devel] [vdagent-win PATCH] Do not use dash in rpm version

> On 26 Jul 2017, at 17:03, Frediano Ziglio wrote: > > RPM does not allow dash in version string. > Remove everything after the dash (which should be the "dirty" > git version). > This make easier to run "make dist" followed by rpmbuild. > > Signed-off-by: Frediano Ziglio > --- > configure.ac

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> On 26 Jul 2017, at 12:19, Frediano Ziglio wrote: > >>> >>> On 25 Jul 2017, at 19:37, Christophe Fergeau wrote: >>> >>> On Tue, Jul 25, 2017 at 02:26:36PM +0200, Christophe de Dinechin wrote: >>> As long as contributor keep pinging or resending his series, this is >>> already the cas

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> On 26 Jul 2017, at 11:23, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> Now, any objection to >> >> 1. Recommending that we use git URLs in patches? > > If that may help, but as Christophe said, this may be overkill for small > series. Let's not make it a rule. >

[Spice-devel] Announcing spice 0.13.90 release

Hey everyone, At long last, a new spice-server unstable release. This one however aims at being a release candidate, with the first 0.14 stable releases coming in a month or so. Any testing you can do is welcome, and if you find any bugs/regressions compared to 0.12, please report them in our bugz