On 06/22/2017 12:38 AM, Jeremy White wrote:
Alright, it's up on gitlab now:
https://gitlab.com/spice/x11spice
Looks like there isn't any obvious way for me to ask to edit the
pages; I was going to point to this link as a release file:
https://gitlab.com/spice/x11spice/repository/archive.
>> Alright, it's up on gitlab now:
>> https://gitlab.com/spice/x11spice
>>
>> Looks like there isn't any obvious way for me to ask to edit the
>> pages; I was going to point to this link as a release file:
>> https://gitlab.com/spice/x11spice/repository/archive.tar.bz2?ref=v1.1
> Thanks!
>
> T
Make sure format is a string and not a pointer.
Signed-off-by: Frediano Ziglio
---
common/log.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/common/log.h b/common/log.h
index ed701ca..c6d260c 100644
--- a/common/log.h
+++ b/common/log.h
@@ -62,23 +62,23 @@ void
As we decided to not use GLib domains do not allow the usage of
this obsolete macro to use different logging domains.
Will be replaced by some different categorization.
Signed-off-by: Frediano Ziglio
---
common/log.c | 17 +
common/log.h | 25 -
>
> On 06/21/2017 10:41 AM, Christophe Fergeau wrote:
> > On Tue, Jun 20, 2017 at 08:39:44PM +0300, Uri Lublin wrote:
> >> On 06/20/2017 04:52 PM, Frediano Ziglio wrote:
> >>> memmove already deal with any alignment so there's no
> >>> reason to have row byte pointer cast to uint32_t.
> >>
> >> Hi
On 06/21/2017 10:41 AM, Christophe Fergeau wrote:
On Tue, Jun 20, 2017 at 08:39:44PM +0300, Uri Lublin wrote:
On 06/20/2017 04:52 PM, Frediano Ziglio wrote:
memmove already deal with any alignment so there's no
reason to have row byte pointer cast to uint32_t.
Hi Frediano,
I think the code h
On 06/21/2017 01:13 PM, Frediano Ziglio wrote:
- Original Message -
From: "Uri Lublin"
To: "Frediano Ziglio" , spice-devel@lists.freedesktop.org
Sent: Tuesday, June 20, 2017 6:39:44 PM
Subject: Re: [Spice-devel] [PATCH spice-common] canvas-base: Do not attempt
useless cast on stride
Hi, sure. I'll change it to '==='
(I think in this case it does not matter - it's comparing ints not objects,
but as you said, we should be consistent)
On Tue, Jun 20, 2017 at 10:44 PM, Jeremy White
wrote:
> Hi,
>
> One tiny niggle:
>
> On 06/08/2017 09:27 AM, Pavel Grunt wrote:
> > @@ -606,7 +
Acked-by: Christophe Fergeau
On Wed, Jun 21, 2017 at 10:40:23AM +0100, Frediano Ziglio wrote:
> memmove already deal with any alignment so there's no
> reason to have row byte pointer cast to uint32_t.
> This also remove the confusing "dest" terminology used. The image
> is aligned in place so t
- Original Message -
> From: "Uri Lublin"
> To: "Frediano Ziglio" , spice-devel@lists.freedesktop.org
> Sent: Tuesday, June 20, 2017 6:39:44 PM
> Subject: Re: [Spice-devel] [PATCH spice-common] canvas-base: Do not attempt
> useless cast on stride adjustment
>
> On 06/20/2017 04:52 PM,
memmove already deal with any alignment so there's no
reason to have row byte pointer cast to uint32_t.
This also remove the confusing "dest" terminology used. The image
is aligned in place so the image bits are used for both destination
and source.
Signed-off-by: Frediano Ziglio
---
common/canv
On Tue, Jun 20, 2017 at 08:39:44PM +0300, Uri Lublin wrote:
> On 06/20/2017 04:52 PM, Frediano Ziglio wrote:
> > memmove already deal with any alignment so there's no
> > reason to have row byte pointer cast to uint32_t.
>
> Hi Frediano,
>
> I think the code has no problem with memmove itself, bu
Hey,
On Tue, Jun 20, 2017 at 02:52:56PM +0100, Frediano Ziglio wrote:
> memmove already deal with any alignment so there's no
> reason to have row byte pointer cast to uint32_t.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/canvas_base.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 dele
13 matches
Mail list logo
