Hey,
On Tue, Mar 07, 2017 at 10:42:09AM -0500, Frediano Ziglio wrote:
> > Hi,
> >
> > On Tue, Feb 28, 2017 at 11:18:15AM +0100, Victor Toso wrote:
> > > Hi,
> > >
> > > On Tue, Feb 28, 2017 at 04:56:54AM -0500, Frediano Ziglio wrote:
> > > > >
> > > > > From: Victor Toso
> > > > >
> > > > > Hi
The code that manages pending QXL Drawable operations is fairly complex
and difficult to understand. This is an attempt to start documenting
that code to save time when we have to work on this code in the future.
---
server/display-channel.c | 80
s
This is a particularly opaque part of the code for managing pending
Drawable operations. This patch adds documentation atempting to explain
these functions.
---
server/display-channel.c | 174 +++
1 file changed, 174 insertions(+)
diff --git a/server/di
These are the patches that haven't been merged yet. The first patch is fairly
straightforward and has only a couple minor changes from the previous review.
The second patch has some improvements as well, even though nobody really
reviewed it last time. It still contains a lot of open questions (usu
Hi,
On Wed, Mar 08, 2017 at 07:21:15PM +0100, Christophe de Dinechin wrote:
> I have several errors like this:
>
> spice-channel.c:1923:12: error: cast from 'uint8_t *' (aka 'unsigned char *')
> to
> 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1
> to
> 4 [-W
Hi
- Original Message -
>
> > On 8 Mar 2017, at 19:17, Marc-André Lureau wrote:
> >
> > Hi
> >
> > - Original Message -
> >> In the configure.ac, the default for vala is “no”. But if I build without
> >> it,
> >> I get:
> >>
> >> make[4]: Entering directory
> >> `/Users/ddd/Wo
I'd like to add that the connection is via wi-fi (54Mbps).
Is it enough for spice videos?
thanks a lot.
2017-03-08 19:14 GMT+01:00 Oscar Segarra :
> Hi,
>
> Youtuve videos from virt-manager (locally) has an acceptable bejaviour...
> but If I try to connect from the LAN, the behaviour is not acc
> On 8 Mar 2017, at 19:17, Marc-André Lureau wrote:
>
> Hi
>
> - Original Message -
>> In the configure.ac, the default for vala is “no”. But if I build without it,
>> I get:
>>
>> make[4]: Entering directory `/Users/ddd/Work/spice/spice-gtk/src/controller'
>>
>> *** Error: missing v
I have several errors like this:
spice-channel.c:1923:12: error: cast from 'uint8_t *' (aka 'unsigned char *') to
'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to
4 [-Werror,-Wcast-align]
...(uint32_t *)((uint8_t *)c->peer_msg +
GUINT32_FROM_LE(c->peer_msg-
Hi
- Original Message -
> In the configure.ac, the default for vala is “no”. But if I build without it,
> I get:
>
> make[4]: Entering directory `/Users/ddd/Work/spice/spice-gtk/src/controller'
>
> *** Error: missing valac!
> *** You must run autogen.sh or configure --enable-vala
>
Hi,
Youtuve videos from virt-manager (locally) has an acceptable bejaviour...
but If I try to connect from the LAN, the behaviour is not acceptable...
the sound goes much faster than the image.
I have increased the video memory up to 64MB but I have not experienced any
improvement.
Is there any
In the configure.ac, the default for vala is “no”. But if I build without it, I
get:
make[4]: Entering directory `/Users/ddd/Work/spice/spice-gtk/src/controller'
*** Error: missing valac!
*** You must run autogen.sh or configure --enable-vala
Is it possible to build spice-gtk without valac?
---
Here's some additional documentation on multiple monitors. I have a few open
questions about the driver memory stuff.
multiple-monitors.rst | 201 ++
1 file changed, 201 insertions(+)
create mode 100644 multiple-monitors.rst
diff --git a/multi
On Tue, Mar 07, 2017 at 03:52:50PM +, Frediano Ziglio wrote:
> This reverts commit c3d237075b994fe67e58f2b3164cb579e6f4.
>
> When you call gst_buffer_add_video_meta_full GStreamer assumes
> that buffer is contiguous. This results usually in some pixel
> shifts in the video. The pixel shift
On Tue, Mar 07, 2017 at 10:05:13AM -0500, Frediano Ziglio wrote:
>
> The answer you probably want is to "Why we do in this way instead of doing
> at lower level?"
> This would require a way to say "now flush data" if you don't want
> to reimplement some sort of "smart" Nagle algorithm, which we ar
I intend to send
https://cgit.freedesktop.org/~teuf/spice/commit/?h=vfuncs&id=b393b04acbdb43
real soon now (need to test it), which is much more extensive than what
is done in this patch, do you mind postponing/dropping this version?
That consideration aside, this patch looks good to me.
Christop
This new function removes one place outside of RedsStream which needs to
access RedsStream::socket
---
server/reds-stream.c | 26 ++
server/reds-stream.h | 1 +
server/reds.c| 26 +-
3 files changed, 28 insertions(+), 25 deletions(-)
diff -
This new function removes one place outside of RedsStream which needs to
access RedsStream::socket
---
server/reds-stream.c | 17 +
server/reds-stream.h | 1 +
server/reds.c| 21 +++--
3 files changed, 25 insertions(+), 14 deletions(-)
diff --git a/server/
The code to enable/disable on a TCP socket is duplicated in multiple
places in the code base, this commit replaces this duplicated code with
a helper in RedsStream.
---
This patch has already been sent a few times with various variations around
bool/gboolean/true/TRUE. I'd like to stick with thing
On Wed, Mar 08, 2017 at 11:27:56AM +, Frediano Ziglio wrote:
> config_socket is configuring the client stream socket.
> As is responsibility of RedChannelClient to handle the stream
> it make more sense to have the function in this object.
Looks good to me,
Acked-by: Christophe Fergeau
>
>
Avoid usage of not initialized statistic node.
This happened for DisplayChannel which was initializing
statistics in the object constructor.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 4 +++-
server/cursor-channel.h | 5 +++--
server/display-channel.c | 4 +++-
server/disp
The default memset(0) on the node does not init it correctly.
Do so to avoid other nodes/counters appended to unwanted nodes.
This is due to INVALID_STAT_REF being ~0. We could not change
this value easily as this is used as ABI for the statistics file.
Signed-off-by: Frediano Ziglio
---
server/
On Wed, Mar 08, 2017 at 07:20:26AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Mar 07, 2017 at 04:56:00PM +, Frediano Ziglio wrote:
> > > Verify stuff are freed correctly (like TLS context).
> > > The different PKI file required are generated with
> > > base values (localhost and rsa 1024).
>
> On Tue, Mar 07, 2017 at 04:56:00PM +, Frediano Ziglio wrote:
> > Verify stuff are freed correctly (like TLS context).
> > The different PKI file required are generated with
> > base values (localhost and rsa 1024).
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/tests/Makefile
>
> On Tue, Mar 07, 2017 at 04:41:53PM +, Frediano Ziglio wrote:
> > Add and remove some vmc device to check for leaking.
> > These combination assure that currently implemented type
> > of devices (webdav, usb and generic) are checked.
>
> In general, I think having a test case in test-leaks
On Tue, Mar 07, 2017 at 04:56:00PM +, Frediano Ziglio wrote:
> Verify stuff are freed correctly (like TLS context).
> The different PKI file required are generated with
> base values (localhost and rsa 1024).
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/Makefile.am | 1 +
On Tue, Mar 07, 2017 at 04:41:53PM +, Frediano Ziglio wrote:
> Add and remove some vmc device to check for leaking.
> These combination assure that currently implemented type
> of devices (webdav, usb and generic) are checked.
In general, I think having a test case in test-leaks should be our
Signed-off-by: Frediano Ziglio
---
server/common-graphics-channel.c | 4 ++--
server/common-graphics-channel.h | 2 +-
server/dcc.c | 4 ++--
server/red-channel-client.c | 6 +++---
server/red-channel-client.h | 2 +-
server/sound.c | 4 ++--
6 file
config_socket is configuring the client stream socket.
As is responsibility of RedChannelClient to handle the stream
it make more sense to have the function in this object.
Signed-off-by: Frediano Ziglio
---
server/common-graphics-channel.c | 6 ++
server/common-graphics-channel.h | 2 +-
On Wed, Mar 08, 2017 at 10:56:03AM +, Frediano Ziglio wrote:
> config_socket is configuring the client stream socket.
> As is responsibility of RedChannelClient to handle the stream
> it make more sense to have the function in this object.
Please split off the bool changes.
Christophe
>
> S
config_socket is configuring the client stream socket.
As is responsibility of RedChannelClient to handle the stream
it make more sense to have the function in this object.
Signed-off-by: Frediano Ziglio
---
server/common-graphics-channel.c | 8 +++-
server/common-graphics-channel.h | 2 +-
31 matches
Mail list logo
