On Thu, 2 Mar 2017, Frediano Ziglio wrote:
[...]
> Before I forgot this.
>
> Looks like GStreamer when you call gst_buffer_add_video_meta_full
> assume that buffer is contiguous. The 8 pixel shift (more or less)
> you can see are artifacts due to how the guest send the frames but
> basically are b
Hi,
In my environment I have a W10 guest running on a centos 7 KVM host.
I have installed the following QXL Video driver:
[image: Imágenes integradas 1]
But when I try to see (on LAN) a youtube video, it doesn't play smoothly,
even video and sound stops for a while and continues a little bit la
I'm trying to decide if there's any benefit to splitting this out from
the other patch. I'm leaning toward squashing them.
On Thu, 2017-03-02 at 11:34 +, Frediano Ziglio wrote:
> The previous patch join correctly the commands however if there
> are no more commands the command joined is delaye
On Thu, 2017-03-02 at 11:34 +, Frediano Ziglio wrote:
> Due to the way RHEL7 works the images came out from guest using
> multiple
> commands. This increase the commands to the client and cause the
> video code to create and handle multiple streams creating some
> visual glitches.
> This patch
On Thu, 2017-03-02 at 11:34 +, Frediano Ziglio wrote:
> These 2 patches attempt to join images split by RHEL7 graphic
> stack (Mesa) decreasing commands handled by spice-server.
>
> You can see the difference between the 2 video:
> - https://www.youtube.com/watch?v=OarV6zUmUdg (before)
> - htt
This reverts commit c3d237075b994fe67e58f2b3164cb579e6f4.
---
server/gstreamer-encoder.c | 26 ++
1 file changed, 6 insertions(+), 20 deletions(-)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index 991eb51..df54cad 100644
--- a/server/gstreamer-
---
src/channel-usbredir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index fef62ce..318adf1 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
@@ -282,7 +282,7 @@ void
spice_usbredir_channel_set_context(SpiceU
---
spice.proto | 4
1 file changed, 4 insertions(+)
diff --git a/spice.proto b/spice.proto
index e841272..3cad253 100644
--- a/spice.proto
+++ b/spice.proto
@@ -188,6 +188,8 @@ channel BaseChannel {
Data list; /* the msg body is SpiceSubMessageList */
+CompressedData compressed
Assuming LZ4 capabilities could handle both LZ4 stream message
and regular LZ4 compressed message
---
spice/enums.h| 1 +
spice/protocol.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/spice/enums.h b/spice/enums.h
index a931497..136813c 100644
--- a/spice/enums.h
+++ b/spice/enums.h
@
If channel number is included in the CHANNEL_COMPRESS environment
variable, LZ4 compression will be applied on the channel messages
if possible.
First LZ4 stream compression is trying to be applied, if message
size is too large, regular LZ4 compression is applied, in stream
compression mode messag
---
spice/enums.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/spice/enums.h b/spice/enums.h
index 0074b0f..a931497 100644
--- a/spice/enums.h
+++ b/spice/enums.h
@@ -436,6 +436,7 @@ enum {
SPICE_MSG_DISCONNECTING,
SPICE_MSG_NOTIFY,
SPICE_MSG_LIST,
+SPICE_MSG_COMPRESSED
If LZ4 lib exists, handle LZ4 compressed & stream compressed
messages in any channel
In stream compression mode decompressed messages are being saved
sequentially in a pre-allocated buffer which will be utilized
by the decompression mechanism in the following decompressions
Update spice-common
--
If LZ4 lib exists, handle LZ4 compressed & stream compressed
messages in any channel
In stream compression mode decompressed messages are being saved
sequentially in a pre-allocated buffer which will be utilized
by the decompression mechanism in the following decompressions
Update spice-common
--
---
server/spicevmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/spicevmc.c b/server/spicevmc.c
index abb0b52..074a8cf 100644
--- a/server/spicevmc.c
+++ b/server/spicevmc.c
@@ -207,7 +207,7 @@ red_vmc_channel_constructed(GObject *object)
stat_init_counter(&sel
If channel number is included in the CHANNEL_COMPRESS environment
variable, LZ4 compression will be applied on the channel messages
if possible.
First LZ4 stream compression is trying to be applied, if message
size is too large, regular LZ4 compression is applied, in stream
compression mode messag
This series of patches allows compression of messages over
selected spice channels
Few notes:
*Currently lz4 stream and regular compression are in use for small and large
messages accordingly. packets are being sent in common msg type that was added,
and it utilize previous compressed message str
>
> On Fri, 24 Feb 2017, Francois Gouget wrote:
>
> > On Fri, 24 Feb 2017, Christophe de Dinechin wrote:
> > [...]
> > > Looking at the patch, I wonder why we pass an offset and a stride from
> > > different sources (offset is from the source, but stride is from the
> > > bitmap)? Shouldn’t we us
Hi,
First of all, thank you all for the quick answers.
The cut off message was my fault, sorry about that.
I am trying to understand this:
Lets say I am connected to a win/lnx guest though remote-viewer and my
remote-viewer is a window with the dimensions 1440x900, so:
When I resize the windo
Looks fine to me, with potential changes from TYPE_RED_ to RED_TYPE_
due to changes in previous patches.
Acked-by: Jonathon Jongsma
On Thu, 2017-03-02 at 12:30 +, Frediano Ziglio wrote:
> For each channel there are two set of capabilities, one
> for the common ones and one for the specific
Acked-by: Jonathon Jongsma
On Thu, 2017-03-02 at 15:28 +, Frediano Ziglio wrote:
> Allows to use recording function for multiple purposes.
> This will allow to register multiple screen VM or recording
> additional stuff like sound.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-wor
>
> Looks fine to me, with potential changes from TYPE_RED_ to RED_TYPE_
> due to changes in previous patches.
>
> Acked-by: Jonathon Jongsma
>
Done (both)
Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedes
Allows to use recording function for multiple purposes.
This will allow to register multiple screen VM or recording
additional stuff like sound.
Signed-off-by: Frediano Ziglio
---
server/red-worker.c | 6 +-
server/reds-private.h | 2 ++
server/reds.c | 18 ++
ser
On Thu, Mar 02, 2017 at 10:15:15AM -0500, Frediano Ziglio wrote:
> > Not really a big fan of having this kind of functions because we use
> > stack-allocated struct rather than just allocating a new struct. This
> > function should only be used on non-initialized RedChannelCapabilities
> > (this wi
On Thu, 2017-03-02 at 16:04 +0100, Christophe Fergeau wrote:
> On Thu, Mar 02, 2017 at 09:55:46AM -0500, Frediano Ziglio wrote:
> > > > +/* GObject type that can be used to box RedChannelCapabilities
> > > > */
> > > > +extern GType red_channel_capabilities_type;
> > > > +#define TYPE_RED_CHANNEL_C
>
> On Thu, Mar 02, 2017 at 12:30:26PM +, Frediano Ziglio wrote:
> > diff --git a/server/red-worker.c b/server/red-worker.c
> > index 8735cd1..fbb7070 100644
> > --- a/server/red-worker.c
> > +++ b/server/red-worker.c
> > @@ -736,7 +736,7 @@ static void handle_dev_display_connect(void *opaque,
On Thu, 2017-03-02 at 10:38 +, Frediano Ziglio wrote:
> Allows to use recording function for multiple purposes.
> This will allow to register multiple screen VM or recording
> additional stuff like sound.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 6 +-
> server/
On Thu, 2017-03-02 at 03:58 -0300, Thiago Nascimento Araujo wrote:
> Hello,
>
> Is there a way to send a spice message, connect to pipe, or any other
> method to contact vdservice/vdagent to create/simulate a resize to an
> arbitrary resolution or full screen effect caused by remote-viewer?
>
> A
Acked-by: Jonathon Jongsma
On Thu, 2017-03-02 at 10:38 +, Frediano Ziglio wrote:
> Allows to share the recording object.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl.c | 19 ++-
> server/red-record-qxl.h | 3 ++-
> server/red-worker.c | 2 +-
> 3
Acked-by: Jonathon Jongsma
On Thu, 2017-03-02 at 10:38 +, Frediano Ziglio wrote:
> The synchronization code is required to avoid mixing writing
> from multiple threads.
> Following patches will add this feature.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl.c | 18 +
On Thu, Mar 02, 2017 at 12:30:26PM +, Frediano Ziglio wrote:
> diff --git a/server/red-worker.c b/server/red-worker.c
> index 8735cd1..fbb7070 100644
> --- a/server/red-worker.c
> +++ b/server/red-worker.c
> @@ -736,7 +736,7 @@ static void handle_dev_display_connect(void *opaque, void
> *paylo
On Thu, Mar 02, 2017 at 09:55:46AM -0500, Frediano Ziglio wrote:
> > > +/* GObject type that can be used to box RedChannelCapabilities */
> > > +extern GType red_channel_capabilities_type;
> > > +#define TYPE_RED_CHANNEL_CAPABILITIES red_channel_capabilities_type
> >
> > RED_TYPE_CHANNEL_CAPABILIT
>
> From: Victor Toso
>
> [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE
>
> This message provides a list of video codecs based on client's order
> of preference.
>
> We duplicate the video codecs array from reds.c and sort it using the
> order of codecs as reference.
>
> This message will
>
> On Thu, Mar 02, 2017 at 12:30:25PM +, Frediano Ziglio wrote:
> > Add function to initialize and destroy this type.
> > Add GType type for boxing it.
> > These changes a in preparation for next patch.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/Makefile.am|
On Thu, Mar 02, 2017 at 12:30:25PM +, Frediano Ziglio wrote:
> Add function to initialize and destroy this type.
> Add GType type for boxing it.
> These changes a in preparation for next patch.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/Makefile.am| 2 ++
> server/red
>
> On Thu, Mar 02, 2017 at 01:50:03PM +, Frediano Ziglio wrote:
> > Instead of disabling the code use the compatibility functions.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/tests/test-codecs-parsing.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >
On Thu, Mar 02, 2017 at 01:50:03PM +, Frediano Ziglio wrote:
> Instead of disabling the code use the compatibility functions.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/test-codecs-parsing.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/t
On Thu, Mar 02, 2017 at 01:50:02PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/glib-compat.h | 8
> server/tests/test-codecs-parsing.c | 6 +-
> server/tests/test-leaks.c | 7 +--
> server/tests/test-options.c|
On Thu, Mar 02, 2017 at 01:50:01PM +, Frediano Ziglio wrote:
> Allow to reuse this code in other tests.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/glib-compat.h| 9
> server/tests/Makefile.am| 1 +
> server/tests/test-glib-compat.c | 112
> +++
Acked-by: Christophe Fergeau
On Tue, Feb 28, 2017 at 12:21:49PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> And avoid single line if plus comment
>
> Signed-off-by: Victor Toso
> ---
> src/spice-channel.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git
On Thu, Mar 02, 2017 at 03:08:11PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> Although this is likely to be a single loop iteration based on the
> implementation of g_coroutine_socket_wait(), using goto to reiterate
> in the code should be avoided based on spice style recommendation.
>
>
From: Victor Toso
Although this is likely to be a single loop iteration based on the
implementation of g_coroutine_socket_wait(), using goto to reiterate
in the code should be avoided based on spice style recommendation.
This also make it easier to add follow up changes that can increase
the loo
On Wed, 2017-03-01 at 10:21 +0100, Christian Rilke wrote:
> Hi,
>
> first think i have to say is THANK YOU! Spice is the best think
> happened to the qmeu community since we need graphical consoles.
>
> I just have a short question about multiple console feature. I read
> that is still experime
Hi,
On Thu, Mar 02, 2017 at 02:28:37PM +0100, Christophe Fergeau wrote:
> On Thu, Mar 02, 2017 at 02:05:21PM +0100, Victor Toso wrote:
> > > and the while (TRUE) is equally odd if you ask me (mostly because you
> > > said it would loop at most once anyway).
> >
> > The iteration should happen only
On Thu, 2017-03-02 at 10:07 +, Daniel P. Berrange wrote:
> Consume the keymaps.csv file from a git submodule instead of having
> a private copy. This makes it easier to ensure all users of the
> keymap
> (libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a
> consistent
> set of data.
>
Signed-off-by: Frediano Ziglio
---
server/glib-compat.h | 8
server/tests/test-codecs-parsing.c | 6 +-
server/tests/test-leaks.c | 7 +--
server/tests/test-options.c| 7 +--
server/tests/test-stat-file.c | 10 +-
5 files change
Instead of disabling the code use the compatibility functions.
Signed-off-by: Frediano Ziglio
---
server/tests/test-codecs-parsing.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/tests/test-codecs-parsing.c
b/server/tests/test-codecs-parsing.c
index 571d8ab..8
Allow to reuse this code in other tests.
Signed-off-by: Frediano Ziglio
---
server/glib-compat.h| 9
server/tests/Makefile.am| 1 +
server/tests/test-glib-compat.c | 112
server/tests/test-vdagent.c | 92 +
Hi,
On Thu, Mar 02, 2017 at 02:05:06PM +0100, Pavel Grunt wrote:
> It helps when testing whether the guest resizes to requested resolution
Yes it does, LGTM
Acked-by: Victor Toso
> ---
> tools/spicy.c | 62
> +++
> 1 file changed, 62 ins
On Thu, Mar 02, 2017 at 02:05:21PM +0100, Victor Toso wrote:
> > and the while (TRUE) is equally odd if you ask me (mostly because you
> > said it would loop at most once anyway).
>
> The iteration should happen only once because g_coroutine_socket_wait()
> does wait G_IO_IN/G_IO_OUT. Its very unl
Hi,
On Thu, Mar 02, 2017 at 01:35:32PM +0100, Christophe Fergeau wrote:
> The code is preexisting
Hm, so I should avoid reworking code that does not fit in newer
style or standards?
> it's arguably error handling
Agreed
> and the while (TRUE) is equally odd if you ask me (mostly because you
>
It helps when testing whether the guest resizes to requested resolution
---
tools/spicy.c | 62 +++
1 file changed, 62 insertions(+)
diff --git a/tools/spicy.c b/tools/spicy.c
index ce6b40b..c47e208 100644
--- a/tools/spicy.c
+++ b/tools/spi
On Thu, Mar 02, 2017 at 11:46:34AM +0100, Victor Toso wrote:
> Hi,
>
> Thanks for taking a look :)
>
> On Thu, Mar 02, 2017 at 10:59:12AM +0100, Christophe Fergeau wrote:
> > On Thu, Mar 02, 2017 at 10:23:45AM +0100, Victor Toso wrote:
> > > Hi,
> > >
> > > On Tue, Feb 28, 2017 at 12:21:45PM +010
For each channel there are two set of capabilities, one
for the common ones and one for the specific ones.
A single set were almost always passed using 2 arguments,
a number of elements and an array but then before using
these were converted to a GArray.
Use a single structure (already available) t
Add function to initialize and destroy this type.
Add GType type for boxing it.
These changes a in preparation for next patch.
Signed-off-by: Frediano Ziglio
---
server/Makefile.am| 2 ++
server/red-channel-capabilities.c | 68 +++
server/red-
This patchset attempt to pass capabilities using a single
RedChannelCapabilities (already existing) structure.
Changes since v3:
- revert some indentation;
- define and use a TYPE_RED_CHANNEL_CAPABILITIES;
- minor style changes.
Changes since v2:
- merge GArray and RedChannelCapabilites usage;
-
These properties are not read and code is broken (the content of
the array would be uninitialized).
Signed-off-by: Frediano Ziglio
Acked-by: Christophe Fergeau
---
server/red-channel-client.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/server/red-ch
On Thu, Mar 02, 2017 at 07:08:08AM -0500, Frediano Ziglio wrote:
> Does it actually make sense the if?
> Maybe free is enough, if the pointer is valid is supposed to
> came from a malloc.
Ah right, wanted to tell to drop the if(), but then forgot :)
Christophe
signature.asc
Description: PGP sig
On Thu, Mar 02, 2017 at 07:03:55AM -0500, Frediano Ziglio wrote:
> I used TYPE_RED_CHANNEL_CAPABILITIES define, seems more consistent with
> other code and keep the "RedChannel" together.
I disagree, RedChannel is for example RED_TYPE_CHANNEL, not
TYPE_RED_CHANNEL.
The way I see it is that 'red' (
On Thu, Mar 02, 2017 at 09:16:11AM +, Frediano Ziglio wrote:
> For each channel there are two set of capabilities, one
> for the common ones and one for the specific ones.
> A single set were almost always passed using 2 arguments,
> a number of elements and an array but then before using
> the
>
> On Thu, Mar 02, 2017 at 09:16:10AM +, Frediano Ziglio wrote:
> > Add function to initialize and destroy this type.
> > Add GObject type for boxing it.
>
> Nit: I would not call 'GObject type' a GType/GBoxed GObject.
>
>
> > These changes a in preparation for next patch.
> >
> > Signed-
>
> On Thu, Mar 02, 2017 at 09:16:10AM +, Frediano Ziglio wrote:
> > Add function to initialize and destroy this type.
> > Add GObject type for boxing it.
>
> Nit: I would not call 'GObject type' a GType/GBoxed GObject.
>
>
> > These changes a in preparation for next patch.
> >
> > Signed-
On Thu, Mar 02, 2017 at 09:16:10AM +, Frediano Ziglio wrote:
> Add function to initialize and destroy this type.
> Add GObject type for boxing it.
Nit: I would not call 'GObject type' a GType/GBoxed GObject.
> These changes a in preparation for next patch.
>
> Signed-off-by: Frediano Ziglio
I'd merge that with the next commit.
On Thu, Mar 02, 2017 at 09:16:09AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/Makefile.am| 2 ++
> server/red-channel-capabilities.c | 22 ++
> server/red-channel-capabilities.h | 36
On Thu, Mar 02, 2017 at 09:16:08AM +, Frediano Ziglio wrote:
> These properties are not read and code is broken (you would get
> uninitialized values).
Acked-by: Christophe Fergeau
(maybe the more specific "the content of the array would be uninitialized"
rather than "you would get uninitial
Acked-by: Christophe Fergeau
On Thu, Mar 02, 2017 at 09:16:07AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> I don't consider this patch really specific to this set
Yup, definitely not.
> ---
> server/red-channel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --
These 2 patches attempt to join images split by RHEL7 graphic
stack (Mesa) decreasing commands handled by spice-server.
You can see the difference between the 2 video:
- https://www.youtube.com/watch?v=OarV6zUmUdg (before)
- https://www.youtube.com/watch?v=5fTdCCbFeCg (after)
These video are reali
The previous patch join correctly the commands however if there
are no more commands the command joined is delayed till new
commands arrive. This patch introduce a timeout (currently 10 ms)
after the command is executed.
Signed-off-by: Frediano Ziglio
---
server/display-channel-private.h | 4 ++
Due to the way RHEL7 works the images came out from guest using multiple
commands. This increase the commands to the client and cause the
video code to create and handle multiple streams creating some
visual glitches.
This patch attempt to detect and join the multiple commands to
avoid these issues
>
> I'd just squash this one in the previous patch (if you think it's
> needed, with a note in the commit log that the added
> basic_event_loop_destroy() addition allows to see that this leak is
> gone). But feel free to keep it separate if you think it's best.
>
> Acked-by: Christophe Fergeau
>
I'd just squash this one in the previous patch (if you think it's
needed, with a note in the commit log that the added
basic_event_loop_destroy() addition allows to see that this leak is
gone). But feel free to keep it separate if you think it's best.
Acked-by: Christophe Fergeau
Christophe
On
Acked-by: Christophe Fergeau
On Wed, Mar 01, 2017 at 05:09:54PM +, Frediano Ziglio wrote:
> Watch was added but never removed.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/main-dispatcher.c | 20
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git
Hi,
On Thu, Mar 02, 2017 at 10:49:24AM +0100, Pavel Grunt wrote:
> It helps when testing whether the guest resizes to requested resolution
>
> Also it gives spicy a basic multimonitor support
1-) IMHO we should enable multi monitor elsewhere
2-) The switch should keep the state of the resizing bo
Hi,
Thanks for taking a look :)
On Thu, Mar 02, 2017 at 10:59:12AM +0100, Christophe Fergeau wrote:
> On Thu, Mar 02, 2017 at 10:23:45AM +0100, Victor Toso wrote:
> > Hi,
> >
> > On Tue, Feb 28, 2017 at 12:21:45PM +0100, Victor Toso wrote:
> > > From: Victor Toso
> > >
> > > Hi,
> > >
> > > v2->
On Wed, Mar 01, 2017 at 11:54:20AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Feb 28, 2017 at 03:20:09PM +, Frediano Ziglio wrote:
> > > Cursor resources (basically the shape of it) was retained till
> > > it was used however it was copied so there were no reason to not release
> > > this r
Allows to use recording function for multiple purposes.
This will allow to register multiple screen VM or recording
additional stuff like sound.
Signed-off-by: Frediano Ziglio
---
server/red-worker.c | 6 +-
server/reds-private.h | 2 ++
server/reds.c | 17 +
serv
Allows to share the recording object.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 19 ++-
server/red-record-qxl.h | 3 ++-
server/red-worker.c | 2 +-
3 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/server/red-record-qxl.c b/server/red-recor
The synchronization code is required to avoid mixing writing
from multiple threads.
Following patches will add this feature.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/server/red-record-qxl.c
Hi,
On Thu, Mar 02, 2017 at 10:48:23AM +0100, Christophe Fergeau wrote:
> missing log..
Sorry, I've improved it in the v3 (sending it with the other related
patches as well)
>
> Christophe
>
> On Thu, Mar 02, 2017 at 10:45:15AM +0100, Victor Toso wrote:
> > From: Victor Toso
> >
> > Signed-off
From: Victor Toso
So we can still check the agent status while mouse is in server mode.
Signed-off-by: Victor Toso
---
tools/spicy.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/tools/spicy.c b/tools/spicy.c
index ce6b40b..112312c 100644
--- a/tools/spic
From: Victor Toso
By using stream-video-codec-type property, we can display which
video-codec is being used.
Signed-off-by: Victor Toso
---
tools/spicy.c | 43 +--
1 file changed, 41 insertions(+), 2 deletions(-)
diff --git a/tools/spicy.c b/tools/spicy
From: Victor Toso
This is a per channel-display property that stores and notifies the
video-codec type being used if a stream is being used or 0 if there is
no ongoing stream.
Signed-off-by: Victor Toso
---
src/channel-display.c | 29 +
1 file changed, 29 insertions
From: Victor Toso
Hi,
The main idea is to be able to easily see the video-codec changing.
Spicy uses thes new property and set the information in its status label.
v1->v3:
* (1/3) Don't need to use #defines in the string messages (Jonathon)
* (1/3) Improve commit log
Victor Toso (3):
spicy:
On Thu, Mar 02, 2017 at 07:59:42AM +0100, Pavel Grunt wrote:
> On Mon, 2017-02-27 at 10:44 +, Daniel P. Berrange wrote:
> > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote:
> > > Hello Daniel,
> > >
> > > On Mon, 2017-02-27 at 10:25 +, Daniel P. Berrange wrote:
> > > > Consume
Consume the keymaps.csv file from a git submodule instead of having
a private copy. This makes it easier to ensure all users of the keymap
(libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a consistent
set of data.
Signed-off-by: Daniel P. Berrange
---
Changed in v4:
- Use correct su
On Thu, Mar 02, 2017 at 08:16:15AM +0100, Pavel Grunt wrote:
> On Thu, 2017-03-02 at 07:59 +0100, Pavel Grunt wrote:
> > On Mon, 2017-02-27 at 10:44 +, Daniel P. Berrange wrote:
> > > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote:
> > > > Hello Daniel,
> > > >
> > > > On Mon, 201
On Thu, Mar 02, 2017 at 08:16:15AM +0100, Pavel Grunt wrote:
> On Thu, 2017-03-02 at 07:59 +0100, Pavel Grunt wrote:
> > On Mon, 2017-02-27 at 10:44 +, Daniel P. Berrange wrote:
> > > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote:
> > > > Hello Daniel,
> > > >
> > > > On Mon, 201
On Thu, Mar 02, 2017 at 10:23:45AM +0100, Victor Toso wrote:
> Hi,
>
> On Tue, Feb 28, 2017 at 12:21:45PM +0100, Victor Toso wrote:
> > From: Victor Toso
> >
> > Hi,
> >
> > v2->v3:
> > * Breaking spice_channel_read_wire() into smaller changes. (teuf)
> >
> > v2:
> > https://lists.freedesktop
It helps when testing whether the guest resizes to requested resolution
Also it gives spicy a basic multimonitor support
---
tools/spicy.c | 72 +++
1 file changed, 72 insertions(+)
diff --git a/tools/spicy.c b/tools/spicy.c
index ce6b40b..
missing log..
Christophe
On Thu, Mar 02, 2017 at 10:45:15AM +0100, Victor Toso wrote:
> From: Victor Toso
>
> Signed-off-by: Victor Toso
> ---
> tools/spicy.c | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/tools/spicy.c b/tools/spicy.c
> index ce6b4
From: Victor Toso
Signed-off-by: Victor Toso
---
tools/spicy.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/tools/spicy.c b/tools/spicy.c
index ce6b40b..112312c 100644
--- a/tools/spicy.c
+++ b/tools/spicy.c
@@ -182,23 +182,25 @@ static int ask_user(GtkWi
Hi,
On Thu, Mar 02, 2017 at 10:32:30AM +0100, Pavel Grunt wrote:
> Actually I sent a patch for it few months ago ;)
> https://github.com/xerus/spice-gtk/commit/2fbf5aaed4adec593a5e89e93d3b
> 286b98816419
Yay, mind to rebase and send again?
signature.asc
Description: PGP signature
__
On Thu, 2017-03-02 at 10:18 +0100, Victor Toso wrote:
> Oi Thiago,
>
> On Thu, Mar 02, 2017 at 03:58:34AM -0300, Thiago Nascimento Araujo
> wrote:
> > Hello,
> >
> > Is there a way to send a spice message, connect to pipe, or any
> > other
> > method to contact vdservice/vdagent to create/simulat
Hi,
On Tue, Feb 28, 2017 at 12:21:45PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> Hi,
>
> v2->v3:
> * Breaking spice_channel_read_wire() into smaller changes. (teuf)
>
> v2:
> https://lists.freedesktop.org/archives/spice-devel/2017-February/035455.html
> v1:
> https://lists.freedeskto
Oi Thiago,
On Thu, Mar 02, 2017 at 03:58:34AM -0300, Thiago Nascimento Araujo wrote:
> Hello,
>
> Is there a way to send a spice message, connect to pipe, or any other
> method to contact vdservice/vdagent to create/simulate a resize to an
> arbitrary resolution or full screen effect caused by rem
This patchset attempt to pass capabilities using a single
RedChannelCapabilities (already existing) structure.
Changes since v2:
- merge GArray and RedChannelCapabilites usage;
- split removing reading capability properties;
- move object to separate files.
Changes since v1:
- use RedChannelCapab
Signed-off-by: Frediano Ziglio
---
server/Makefile.am| 2 ++
server/red-channel-capabilities.c | 22 ++
server/red-channel-capabilities.h | 36
server/red-channel.h | 8 +---
4 files changed, 61 insertions
For each channel there are two set of capabilities, one
for the common ones and one for the specific ones.
A single set were almost always passed using 2 arguments,
a number of elements and an array but then before using
these were converted to a GArray.
Use a single structure (already available) t
Add function to initialize and destroy this type.
Add GObject type for boxing it.
These changes a in preparation for next patch.
Signed-off-by: Frediano Ziglio
---
server/red-channel-capabilities.c | 55 +++
server/red-channel-capabilities.h | 16 +++-
Signed-off-by: Frediano Ziglio
---
I don't consider this patch really specific to this set
---
server/red-channel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/red-channel.c b/server/red-channel.c
index 67a570d..8fe0d33 100644
--- a/server/red-channel.c
+++ b/server/red-channel.c
@@
These properties are not read and code is broken (you would get
uninitialized values).
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/server/red-channel-client.c b/server/red-channel-client.
100 matches
Mail list logo
