On Thu, Mar 02, 2017 at 07:03:55AM -0500, Frediano Ziglio wrote: > I used TYPE_RED_CHANNEL_CAPABILITIES define, seems more consistent with > other code and keep the "RedChannel" together.
I disagree, RedChannel is for example RED_TYPE_CHANNEL, not TYPE_RED_CHANNEL. The way I see it is that 'red' (and sometimes 'reds' or 'spice') is our namespace, just like 'g' is glib's namespace. So just like we have G_TYPE_OBJECT, we should use RED_TYPE_XXX We happen to have various objects with no namespace (sndchannel, ...), in this case the types are indeed TYPE_XXX. I would not encourage types without the red namespace, but TYPE_RED is definitely not correct. Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
