Re: [Spice-devel] [PATCH spice-server] stream: Remove region leak

Acked-by: Jonathon Jongsma On Tue, 2017-02-28 at 16:30 +, Frediano Ziglio wrote: > clip_in_draw_dest was not freed correctly. > > Signed-off-by: Frediano Ziglio > --- >  server/stream.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/server/stream.c b/server/stream.c > index e2cd6

Re: [Spice-devel] [PATCH spice-server v2] display-channel: Clean more stuff on finalize

Acked-by: Jonathon Jongsma On Tue, 2017-02-28 at 17:03 +, Frediano Ziglio wrote: > Release surfaces, cache and monitor configurations. > > Signed-off-by: Frediano Ziglio > --- >  server/display-channel.c | 3 +++ >  1 file changed, 3 insertions(+) > > Changes from v1: > - remove some cosmet

Re: [Spice-devel] Multi-head Spice

On Tue, 2017-02-28 at 16:19 +0100, Christophe de Dinechin wrote: > > On 28 Feb 2017, at 15:37, Jonathon Jongsma > > wrote: > > > > On Tue, 2017-02-28 at 10:29 +0100, Christophe de Dinechin wrote: > > > > On 27 Feb 2017, at 23:18, Jonathon Jongsma > > > > > > > > wrote: > > > > > > > > On Mon, 2

Re: [Spice-devel] [PATCH spice-server 1a/3] red-channel: Use directly a GArray to pass capabilities

On Tue, Feb 28, 2017 at 12:14:25PM -0500, Frediano Ziglio wrote: > > > > On Tue, Feb 28, 2017 at 09:43:33AM +, Frediano Ziglio wrote: > > > Capabilities where almost always passed using 2 arguments, > > > a number of elements and an array but then before using > > > these were converted to a G

Re: [Spice-devel] [PATCH spice-protocol 2/2] agent: Add macro for clearing capability

> > On Tue, 2017-02-28 at 09:29 -0500, Frediano Ziglio wrote: > > > > > > Related: > > > https://bugzilla.redhat.com/show_bug.cgi?id=1373725 > > > --- > > >  spice/vd_agent.h | 3 +++ > > >  1 file changed, 3 insertions(+) > > > > > > diff --git a/spice/vd_agent.h b/spice/vd_agent.h > > > index a

Re: [Spice-devel] [PATCH spice-server 1a/3] red-channel: Use directly a GArray to pass capabilities

> > On Tue, Feb 28, 2017 at 09:43:33AM +, Frediano Ziglio wrote: > > Capabilities where almost always passed using 2 arguments, > > a number of elements and an array but then before using > > these were converted to a GArray. > > Converting to GArray much earlier allows to easily pass > > the

[Spice-devel] [PATCH spice-server v2] display-channel: Clean more stuff on finalize

Release surfaces, cache and monitor configurations. Signed-off-by: Frediano Ziglio --- server/display-channel.c | 3 +++ 1 file changed, 3 insertions(+) Changes from v1: - remove some cosmetic changes to reduce the patch. diff --git a/server/display-channel.c b/server/display-channel.c index 2

Re: [Spice-devel] [spice-server] display-channel: Make monitors_config_new() static

> > It's only used in display-channel.c > > Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio There are also: - glz_enc_dictionary_reset - red_channel_any_blocked - red_channel_no_item_being_sent - red_client_get_channel - reds_stream_write This mainly bring some optimization due t

[Spice-devel] [PATCH spice-server] stream: Remove region leak

clip_in_draw_dest was not freed correctly. Signed-off-by: Frediano Ziglio --- server/stream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/stream.c b/server/stream.c index e2cd66e..9d9ec1d 100644 --- a/server/stream.c +++ b/server/stream.c @@ -316,6 +316,7 @@ static void attach_str

Re: [Spice-devel] [PATCH spice-server] display-channel: Clean more stuff on finalize

On Tue, Feb 28, 2017 at 03:42:17PM +, Frediano Ziglio wrote: > Release surfaces, cache and monitor configurations. > > Signed-off-by: Frediano Ziglio > --- > server/display-channel.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/server/display-channel.c b

[Spice-devel] [spice-server] display-channel: Make monitors_config_new() static

It's only used in display-channel.c Signed-off-by: Christophe Fergeau --- server/display-channel.c | 2 +- server/display-channel.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 288969c..5581b9a 100644 --- a/server

Re: [Spice-devel] [PATCH spice-server 3/3] red-channel: Move alloc_recv_buf and release_recv_buf to RedChannelClient

On Tue, Feb 28, 2017 at 09:43:35AM +, Frediano Ziglio wrote: > These vfuncs are more appropriate in RedChannelClient. > The buffer they allocated are related to the client stream > which is managed directly by RedChannelClient. > > Signed-off-by: Frediano Ziglio > --- > Looking at the patch (

[Spice-devel] [PATCH spice-server] display-channel: Clean more stuff on finalize

Release surfaces, cache and monitor configurations. Signed-off-by: Frediano Ziglio --- server/display-channel.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 288969c..60947fc 100644 --- a/server/display-chan

[Spice-devel] [PATCH spice-server] Release cursor as soon as possible

Cursor resources (basically the shape of it) was retained till it was used however it was copied so there were no reason to not release this resource. Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 14 -- server/cursor-channel.h | 4 ++-- server/red-par

Re: [Spice-devel] [PATCH spice-common] region: Avoid possible memory corruption

> > Ack, > Pavel > > btw Has pixman some api documentation ? > I didn't find much, had to look at the sources. This function is not called much apparently (mainly in streaming code) but I'm quite surprised it didn't trigger something worst than a leak! Looks like Valgrind got too slow recently.

Re: [Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

On Tue, Feb 28, 2017 at 09:34:48AM -0500, Frediano Ziglio wrote: > Just to be clear: > > "reds: Check that we do not free the wrong agent device > > Do not assume the device passed is the one currently working > but check for it and refuse to free the current one avoiding > possible double free o

Re: [Spice-devel] [PATCH spice-common] region: Avoid possible memory corruption

Ack, Pavel btw Has pixman some api documentation ? On Tue, 2017-02-28 at 14:53 +, Frediano Ziglio wrote: > pixman_region32_copy assume that destination (first argument) > is initialized and can use a pointer inside based on different > conditions. > As intersection is not initialized this can

Re: [Spice-devel] [PATCH spice-server 1a/3] red-channel: Use directly a GArray to pass capabilities

On Tue, Feb 28, 2017 at 09:43:33AM +, Frediano Ziglio wrote: > Capabilities where almost always passed using 2 arguments, > a number of elements and an array but then before using > these were converted to a GArray. > Converting to GArray much earlier allows to easily pass > the capabilities ar

Re: [Spice-devel] [spice-gtk] squash-me: pointer might be null

thanks! On Tue, 2017-02-28 at 15:44 +0100, Victor Toso wrote: > From: Victor Toso > > Ack with this > > Signed-off-by: Victor Toso > --- >  src/spice-widget.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > index 1e69129..9a7e

Re: [Spice-devel] [PATCH spice-protocol 2/2] agent: Add macro for clearing capability

On Tue, 2017-02-28 at 09:29 -0500, Frediano Ziglio wrote: > > > > Related: > > https://bugzilla.redhat.com/show_bug.cgi?id=1373725 > > --- > >  spice/vd_agent.h | 3 +++ > >  1 file changed, 3 insertions(+) > > > > diff --git a/spice/vd_agent.h b/spice/vd_agent.h > > index ac22498..3b1f183 100644

[Spice-devel] [PATCH spice-common] region: Avoid possible memory corruption

pixman_region32_copy assume that destination (first argument) is initialized and can use a pointer inside based on different conditions. As intersection is not initialized this can cause different memory problems. This resulted in memory leak detection from address sanitizer. Signed-off-by: Fredia

[Spice-devel] [spice-gtk] squash-me: pointer might be null

From: Victor Toso Ack with this Signed-off-by: Victor Toso --- src/spice-widget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 1e69129..9a7ea56 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -1074,7 +1074,7 @@ st

[Spice-devel] [spice-gtk] squash-me: pointer might be null

From: Victor Toso Ack with this Signed-off-by: Victor Toso --- src/spice-widget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 1e69129..9a7ea56 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -1074,7 +1074,7 @@ st

Re: [Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

Just to be clear: "reds: Check that we do not free the wrong agent device Do not assume the device passed is the one currently working but check for it and refuse to free the current one avoiding possible double free of the device." (was not clear to me if you meant the subject or message) Fred

Re: [Spice-devel] [PATCH spice-protocol 2/2] agent: Add macro for clearing capability

> > Related: > https://bugzilla.redhat.com/show_bug.cgi?id=1373725 > --- > spice/vd_agent.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/spice/vd_agent.h b/spice/vd_agent.h > index ac22498..3b1f183 100644 > --- a/spice/vd_agent.h > +++ b/spice/vd_agent.h > @@ -269,6 +269,9 @@ type

[Spice-devel] [PATCH spice-gtk] spice-display: Check validity of cursor before unref

Since 62f9144d6c5ac06cd76b76176644622c43c08541 the mouse cursor is created when the widget is realized. The unref must be prevented. The issue can happen when connecting using remote-viewer to a multimonitor VM. --- src/spice-widget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for reporting availability of agent features

Hi, On Tue, Feb 28, 2017 at 02:58:58PM +0100, Pavel Grunt wrote: > Some agent features can be disabled on the server: > * Copy & Paste > * File transfer > > Add the agent capability to inform about disabled file transfer. > > Related: > https://bugzilla.redhat.com/show_bug.cgi?id=1373725 I di

[Spice-devel] [PATCH spice-protocol 2/2] agent: Add macro for clearing capability

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1373725 --- spice/vd_agent.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/spice/vd_agent.h b/spice/vd_agent.h index ac22498..3b1f183 100644 --- a/spice/vd_agent.h +++ b/spice/vd_agent.h @@ -269,6 +269,9 @@ typedef struct SPICE_ATTR_PAC

[Spice-devel] [PATCH spice-protocol 1/2] Add support for reporting availability of agent features

Some agent features can be disabled on the server: * Copy & Paste * File transfer Add the agent capability to inform about disabled file transfer. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1373725 --- spice/vd_agent.h | 1 + 1 file changed, 1 insertion(+) diff --git a/spice/vd_agen

Re: [Spice-devel] [spice-server v5 4/5] Change some spice_printerr() to spice_debug()

On Tue, Feb 28, 2017 at 02:42:31PM +0100, Pavel Grunt wrote: > On Tue, 2017-02-28 at 13:21 +0100, Christophe Fergeau wrote: > > Some debug messages were using spice_printerr(), which should be > > limited > > to actual errors. > > You are right, but I miss the benefit of this patch > ... I was ab

Re: [Spice-devel] [PATCH spice-server] sound: Avoid unused IOV_MAX definition

ack On Tue, 2017-02-28 at 05:00 -0500, Frediano Ziglio wrote: > Ping > > - Original Message - > > From: "Frediano Ziglio" > > To: "Pavel Grunt" > > Cc: spice-devel@lists.freedesktop.org > > Sent: Wednesday, February 15, 2017 1:23:35 PM > > Subject: Re: [Spice-devel] [PATCH spice-server]

Re: [Spice-devel] [spice v1] syntax-check: Fix missing AUTHORS

On Tue, Feb 28, 2017 at 02:37:25PM +0100, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- > AUTHORS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/AUTHORS b/AUTHORS > index 2b0fe24..99f6c18 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -28,6 +28,7 @@ Patches

Re: [Spice-devel] [spice-server v5 4/5] Change some spice_printerr() to spice_debug()

On Tue, 2017-02-28 at 13:21 +0100, Christophe Fergeau wrote: > Some debug messages were using spice_printerr(), which should be > limited > to actual errors. You are right, but I miss the benefit of this patch ... I like some of these - "agent start", the net test... It is quite convenient to have

[Spice-devel] [spice v1] syntax-check: Fix missing AUTHORS

From: Victor Toso Signed-off-by: Victor Toso --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 2b0fe24..99f6c18 100644 --- a/AUTHORS +++ b/AUTHORS @@ -28,6 +28,7 @@ Patches also contributed by 소병철 Cédric Bosdonnat Christian Ruppert +Ch

Re: [Spice-devel] [PATCH spice-server] Remove reds_stream_set_info_flag

Acked-by: Christophe Fergeau On Tue, Feb 28, 2017 at 10:09:56AM +, Frediano Ziglio wrote: > Encapsulate into reds_stream_set_channel. > > Signed-off-by: Frediano Ziglio > --- > server/reds-stream.c | 11 +++ > server/reds-stream.h | 1 - > server/reds.c| 3 --- > 3 files

Re: [Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

I think I'd adjust the shortlog a little bit "Check that we do not free ...", as I initially thought this was fixing an actual bug rather than being a robustness improvement. Hopefully we don't hit this situation, as this would be fairly bad ;) Acked-by: Christophe Fergeau Christophe On Tue,

[Spice-devel] [spice-server v5 4/5] Change some spice_printerr() to spice_debug()

Some debug messages were using spice_printerr(), which should be limited to actual errors. Signed-off-by: Christophe Fergeau --- server/inputs-channel.c | 4 ++-- server/main-channel-client.c | 28 ++-- server/main-channel.c| 10 +- server/red-channe

Re: [Spice-devel] [PATCH spice-server 1/6] spicevmc: Use spice_new instead of spice_malloc

On Tue, Feb 28, 2017 at 05:22:26AM -0500, Frediano Ziglio wrote: > Ping Acked-by: Christophe Fergeau > > - Original Message - > > From: "Frediano Ziglio" > > To: u...@redhat.com > > Cc: spice-devel@lists.freedesktop.org > > Sent: Thursday, January 26, 2017 2:43:37 PM > > Subject: Re: [

[Spice-devel] [spice-server v5 0/5] Better test-vdagent test case

Another iteration on this series, first 3 patches were ack'ed, I changed patch 4/5 from spice_debug("") to spice_debug(NULL) as otherwise this was causing warnings (but I agree that a good followup patch would be to remove most of these). I added older glib fallbacks to patch 5, though I'm not ful

[Spice-devel] [spice-server v5 1/5] test: Add test_destroy()

This allows to chain several test cases by using test_new()/test_destroy(). Signed-off-by: Christophe Fergeau Acked-by: Pavel Grunt --- server/tests/test-display-base.c | 7 +++ server/tests/test-display-base.h | 1 + 2 files changed, 8 insertions(+) diff --git a/server/tests/test-display-

[Spice-devel] [spice-server v5 2/5] reds: Close sockets when using spice_server_destroy()

Currently, the network sockets opened by reds_init_net() are not closed on destruction, in other words they are leaked. Signed-off-by: Christophe Fergeau Acked-by: Pavel Grunt --- server/reds.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/

[Spice-devel] [spice-server v5 3/5] Use spice_debug rather than spice_info in library code

Using spice_info() gets in the way of tests using g_test_expect_message() as all the messages emitted using a non-debug log level must be listed as expected, otherwise we get a critical about an expected message not having been logged. Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio

[Spice-devel] [spice-server v5 5/5] test-vdagent: Make test case more useful

This switches the test to using the GTest API, and add several tests related to https://bugzilla.redhat.com/show_bug.cgi?id=1411194 This uses some API not available in glib 2.28, so this checks we have a new enough glib before building this test, and disables warnings when using too new glib API w

Re: [Spice-devel] [PATCH spice-server] reds: Check link header magic without waiting for the whole header

Hey, On Tue, Feb 28, 2017 at 10:58:47AM +, Frediano Ziglio wrote: > This allows the connection to early fail in case initial bytes > are not correct. > This allows for instance VNC client to graceful fail connecting > to a spice-server. This happens easily as the two protocols > share the same

Re: [Spice-devel] Multi-head Spice

On Tue, 2017-02-28 at 10:44 +0100, Christophe de Dinechin wrote: > > On 28 Feb 2017, at 10:15, Pavel Grunt wrote: > > > > Hi, > > > > On Tue, 2017-02-28 at 11:01 +0200, Snir Sheriber wrote: > > > Hi, > > > > > > On 02/28/2017 09:58 AM, Christophe Fergeau wrote: > > > > On Mon, Feb 27, 2017 at 0

[Spice-devel] [spice-gtk v3 6/6] spice_channel_flush_wire: make it similar to _read_wire()

From: Victor Toso * By making spice_channel_flush_wire() similar to spice_channel_read_wire() where we keep the possible context switch of g_coroutine_socket_wait() in the end of loop and dealing with the return of the _flush_wire_nonblocking() case by case. Related: https://bugs.freedeskt

[Spice-devel] [spice-gtk v3 0/6] spice-channel: read/flush wire functions

From: Victor Toso Hi, v2->v3: * Breaking spice_channel_read_wire() into smaller changes. (teuf) v2: https://lists.freedesktop.org/archives/spice-devel/2017-February/035455.html v1: https://lists.freedesktop.org/archives/spice-devel/2017-February/035446.html Cheers, Victor Toso (6): spice-ch

[Spice-devel] [spice-gtk v3 5/6] spice_channel_read_wire: return earlier whenever is possible

From: Victor Toso Moving all the checks leading to early returns first and let the situation where we are waiting for data availability to be dealt in the end as this is the only situation that makes we iterate in the loop. Related: https://bugs.freedesktop.org/show_bug.cgi?id=96598 Signed-off-b

[Spice-devel] [spice-gtk v3 1/6] spice-channel: move out non blocking logic of _read_wire()

From: Victor Toso This patch introduces spice_channel_read_wire_nonblocking() helper without changing any logic. Related: https://bugs.freedesktop.org/show_bug.cgi?id=96598 Signed-off-by: Victor Toso Acked-by: Christophe Fergeau --- src/spice-channel.c | 45 ++-

[Spice-devel] [spice-gtk v3 3/6] spice_channel_read_wire: prefer while(TRUE) instead of goto

From: Victor Toso Although this should be a single loop iteration [based on the implementation of g_coroutine_socket_wait()], using goto to reiterate in the code should be avoided. This patch changes: * The reread label with a while(TRUE); * The goto keyword with continue; All other changes a

[Spice-devel] [spice-gtk v3 4/6] spice_channel_read_wire: move variables to internal scope

From: Victor Toso And avoid single line if plus comment Signed-off-by: Victor Toso --- src/spice-channel.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/spice-channel.c b/src/spice-channel.c index f2d1b8a..c2e8a01 100644 --- a/src/spice-channel.c +++ b/src/sp

[Spice-devel] [spice-gtk v3 2/6] spice-channel: move out non blocking logic of _flush_wire()

From: Victor Toso This patch introduces spice_channel_flush_wire_nonblocking() helper without changing any logic. Related: https://bugs.freedesktop.org/show_bug.cgi?id=96598 Signed-off-by: Victor Toso Acked-by: Christophe Fergeau --- src/spice-channel.c | 73 ++

[Spice-devel] [PATCH spice-server] reds: Check link header magic without waiting for the whole header

This allows the connection to early fail in case initial bytes are not correct. This allows for instance VNC client to graceful fail connecting to a spice-server. This happens easily as the two protocols share the same range of ports. This resolves rhbz#1416692. Signed-off-by: Frediano Ziglio Te

[Spice-devel] [spice v10] dcc: handle preferred video codec message

From: Victor Toso [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE This message provides a list of video codecs based on client's order of preference. We duplicate the video codecs array from reds.c and sort it using the order of codecs as reference. This message will not change an ongoing st

[Spice-devel] [PATCH spice-server v2] record: Allocate recording file globally from reds.c

Allows to use recording function for multiple purposes. This will allow to register multiple screen VM or recording additional stuff like sound. The mutex code added to red-record-qxl.c is required to avoid mixing writing from multiple threads. Signed-off-by: Frediano Ziglio --- server/red-recor

Re: [Spice-devel] Multi-head Spice

On 02/28/2017 11:41 AM, Christophe de Dinechin wrote: On 28 Feb 2017, at 08:58, Christophe Fergeau > wrote: On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: I tried to setup a mult

[Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

Do not assume the device passed is the one currently working but check for it and refuse to free the current one avoiding possible double free of the device. Signed-off-by: Frediano Ziglio --- server/reds.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/reds.c b

Re: [Spice-devel] [PATCH spice-server 1/6] spicevmc: Use spice_new instead of spice_malloc

Ping - Original Message - > From: "Frediano Ziglio" > To: u...@redhat.com > Cc: spice-devel@lists.freedesktop.org > Sent: Thursday, January 26, 2017 2:43:37 PM > Subject: Re: [Spice-devel] [PATCH spice-server 1/6] spicevmc: Use spice_new > instead of spice_malloc > > > > > On 01/26/201

Re: [Spice-devel] [spice (stable)] Resending volume value on migration

Hi, On Tue, Feb 28, 2017 at 04:56:54AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Hi, > > > > This patch is actually an improvement of an old patch [0]. It fixes > > rhbz#1425443 > > here. I'm sending this for stable branch only as we might have a better way > > to > > do

[Spice-devel] [PATCH spice-server] Remove reds_stream_set_info_flag

Encapsulate into reds_stream_set_channel. Signed-off-by: Frediano Ziglio --- server/reds-stream.c | 11 +++ server/reds-stream.h | 1 - server/reds.c| 3 --- 3 files changed, 3 insertions(+), 12 deletions(-) This is a first patch attempting to remove spice dependencies from Re

Re: [Spice-devel] Multi-head Spice

On Tue, 2017-02-28 at 10:24 +0100, Christophe Fergeau wrote: > On Tue, Feb 28, 2017 at 10:19:50AM +0100, Pavel Grunt wrote: > > On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: > > > I tried to setup a multi-head guest, but I’m having trouble > > > getting > > > multiple displays to

Re: [Spice-devel] [PATCH spice-server] sound: Avoid unused IOV_MAX definition

Ping - Original Message - > From: "Frediano Ziglio" > To: "Pavel Grunt" > Cc: spice-devel@lists.freedesktop.org > Sent: Wednesday, February 15, 2017 1:23:35 PM > Subject: Re: [Spice-devel] [PATCH spice-server] sound: Avoid unused IOV_MAX > definition > > > > > Hi, > > > > On Wed, 201

Re: [Spice-devel] [spice (stable)] Resending volume value on migration

> > From: Victor Toso > > Hi, > > This patch is actually an improvement of an old patch [0]. It fixes > rhbz#1425443 > here. I'm sending this for stable branch only as we might have a better way > to > do it on the current master as a lot has been improved. > > [0] https://lists.freedesktop.or

Re: [Spice-devel] OT: Remove X == TRUE tests for non-boolean values

> ... > > > over 1 mostly empty surfaces. There will be one extra indirection > > > when > > > accessing the surface_client_lossy region, but x86_64 became pretty darn > > > good at chasing pointers like that thanks to C++ vtables ;-) > > > > > Last sentence is a bit cryptic I think :-) >

Re: [Spice-devel] Multi-head Spice

> On 28 Feb 2017, at 10:15, Pavel Grunt wrote: > > Hi, > > On Tue, 2017-02-28 at 11:01 +0200, Snir Sheriber wrote: >> Hi, >> >> On 02/28/2017 09:58 AM, Christophe Fergeau wrote: >>> On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: On Mon, 2017-02-27 at 17:53 +0100, Christ

[Spice-devel] [PATCH spice-server 3/3] red-channel: Move alloc_recv_buf and release_recv_buf to RedChannelClient

These vfuncs are more appropriate in RedChannelClient. The buffer they allocated are related to the client stream which is managed directly by RedChannelClient. Signed-off-by: Frediano Ziglio --- Looking at the patch (mostly spicevmc.c) looks not great as you have to have a new class but I think

[Spice-devel] [PATCH spice-server 0/3] Move alloc_recv_buf and release_recv_buf to RedChannelClient

The purpose of these patches is to move the 2 mentioned vfuncs from RedChannel to RedChannelClient. This was discussed previously. The reasons are that the function works on stuff related to client (network buffer for the client stream) and having into RedChannel make easier to to some wrong assump

Re: [Spice-devel] Multi-head Spice

> On 28 Feb 2017, at 10:01, Snir Sheriber wrote: > > Hi, > > On 02/28/2017 09:58 AM, Christophe Fergeau wrote: >> On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: >>> On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: I tried to setup a multi-head guest, but

[Spice-devel] [PATCH spice-server 1b/3] Introduce CommonGraphicsChannelClient

This prepare for the next patch. As network buffer should be specific to the specific RedChannelClient we should have one. Signed-off-by: Frediano Ziglio --- server/common-graphics-channel.c | 12 server/common-graphics-channel.h | 32 server/cursor-

[Spice-devel] [PATCH spice-server 1a/3] red-channel: Use directly a GArray to pass capabilities

Capabilities where almost always passed using 2 arguments, a number of elements and an array but then before using these were converted to a GArray. Converting to GArray much earlier allows to easily pass the capabilities around. Signed-off-by: Frediano Ziglio --- I don't know if is worth definin

Re: [Spice-devel] Multi-head Spice

> On 28 Feb 2017, at 08:58, Christophe Fergeau wrote: > > On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: >> On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: >>> I tried to setup a multi-head guest, but I’m having trouble getting >>> multiple displays to work co

Re: [Spice-devel] Multi-head Spice

On Tue, Feb 28, 2017 at 10:19:50AM +0100, Pavel Grunt wrote: > On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: > > I tried to setup a multi-head guest, but I’m having trouble getting > > multiple displays to work correctly > > > > For Jonathon, the part that I had trouble with was

Re: [Spice-devel] Multi-head Spice

> On 27 Feb 2017, at 23:18, Jonathon Jongsma wrote: > > On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: >> I tried to setup a multi-head guest, but I’m having trouble getting >> multiple displays to work correctly >> >> For Jonathon, the part that I had trouble with was adding

Re: [Spice-devel] Multi-head Spice

On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: > I tried to setup a multi-head guest, but I’m having trouble getting > multiple displays to work correctly > > For Jonathon, the part that I had trouble with was adding “heads = > ‘4’" to the video / QXL configuration. I don’t see i

Re: [Spice-devel] Multi-head Spice

Hi, On Tue, 2017-02-28 at 11:01 +0200, Snir Sheriber wrote: > Hi, > > On 02/28/2017 09:58 AM, Christophe Fergeau wrote: > > On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: > > > On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: > > > > I tried to setup a multi-hea

Re: [Spice-devel] Multi-head Spice

Hi, On 02/28/2017 09:58 AM, Christophe Fergeau wrote: On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: I tried to setup a multi-head guest, but I’m having trouble getting multiple displays to work correctly For