Re: [Spice-devel] Multi-head Spice

On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: > On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: > > I tried to setup a multi-head guest, but I’m having trouble getting > > multiple displays to work correctly > > > > For Jonathon, the part that I had trouble wit

Re: [Spice-devel] How to config video and image compression?

Not locally, the guest run in server A. I remote control the guest from my laptop. Regards, John 2017-02-28 0:22 GMT+08:00 Uri Lublin : > On 02/27/2017 04:01 AM, John Y. wrote: > >> I'm sorry that I misled you. >> The guest OS is windows 7 so that I cannot use virgl. >> I got the configuration

Re: [Spice-devel] Multi-head Spice

On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: > I tried to setup a multi-head guest, but I’m having trouble getting > multiple displays to work correctly > > For Jonathon, the part that I had trouble with was adding “heads = > ‘4’" to the video / QXL configuration. I don’t see i

Re: [Spice-devel] keymap detection under XWayland broken again ?

On Mon, Feb 27, 2017 at 02:37:37PM +0100, Christophe Fergeau wrote: > On Mon, Feb 27, 2017 at 01:13:25PM +, Daniel P. Berrange wrote: > > A long while back, Pavel learnt that under XWayland we needed to > > use XkbGetMap instead of XkbGetKeyboard: > > > > commit 95e322a6bbc29dc9c28724fb80706

[Spice-devel] Multi-head Spice

I tried to setup a multi-head guest, but I’m having trouble getting multiple displays to work correctly For Jonathon, the part that I had trouble with was adding “heads = ‘4’" to the video / QXL configuration. I don’t see it documented in https://www.spice-space.org/spice-user-manual.html#_mult

Re: [Spice-devel] [PATCH] Remove X == TRUE tests for non-boolean values

> On 27 Feb 2017, at 17:10, Frediano Ziglio wrote: > > On 27 Feb 2017, at 13:12, Christophe Fergeau > wrote: > > On Mon, Feb 27, 2017 at 06:58:47AM -0500, Frediano Ziglio wrote: > > Using X == TRUE is fragile, since the input value is a uint8_t. It would be > surpr

Re: [Spice-devel] How to config video and image compression?

On 02/27/2017 04:01 AM, John Y. wrote: I'm sorry that I misled you. The guest OS is windows 7 so that I cannot use virgl. I got the configuration from libvirt.org and I don't know which configuration will work for me, so I pasted all in the mail. Do you mean the default conf

Re: [Spice-devel] [PATCH] Remove X == TRUE tests for non-boolean values

> > On 27 Feb 2017, at 13:12, Christophe Fergeau < cferg...@redhat.com > wrote: > > > On Mon, Feb 27, 2017 at 06:58:47AM -0500, Frediano Ziglio wrote: > > > > > Using X == TRUE is fragile, since the input value is a uint8_t. It > > > > would > > > > be > > > > > > > > > > surprising if the v

Re: [Spice-devel] [PATCH] Remove X == TRUE tests for non-boolean values

> On 27 Feb 2017, at 13:12, Christophe Fergeau wrote: > > On Mon, Feb 27, 2017 at 06:58:47AM -0500, Frediano Ziglio wrote: >>> >>> Using X == TRUE is fragile, since the input value is a uint8_t. It would be >>> surprising if the value was set to 2 or 0xFF and the test failed. >>> >>> Signed-of

[Spice-devel] [spice (stable)] sound: do not change volume or mute state on migration

From: Victor Toso On migration, we are resending the current volume and mute state in the Guest. If the client user has change its master volume in the guest it might change the client application volume too and the volume jump (increase or decrease) might happen on migration. This patch is a co

[Spice-devel] [spice (stable)] Resending volume value on migration

From: Victor Toso Hi, This patch is actually an improvement of an old patch [0]. It fixes rhbz#1425443 here. I'm sending this for stable branch only as we might have a better way to do it on the current master as a lot has been improved. [0] https://lists.freedesktop.org/archives/spice-devel/20

Re: [Spice-devel] keymap detection under XWayland broken again ?

On Mon, Feb 27, 2017 at 01:13:25PM +, Daniel P. Berrange wrote: > A long while back, Pavel learnt that under XWayland we needed to > use XkbGetMap instead of XkbGetKeyboard: > > commit 95e322a6bbc29dc9c28724fb80706464e276b89f > Author: Pavel Grunt > Date: Fri Feb 20 16:19:50 2015 +010

Re: [Spice-devel] keymap detection under XWayland broken again ?

On Mon, Feb 27, 2017 at 02:24:16PM +0100, Pavel Grunt wrote: > On Mon, 2017-02-27 at 13:13 +, Daniel P. Berrange wrote: > > A long while back, Pavel learnt that under XWayland we needed to > > use XkbGetMap instead of XkbGetKeyboard: > > > >   commit 95e322a6bbc29dc9c28724fb80706464e276b89f >

Re: [Spice-devel] keymap detection under XWayland broken again ?

On Mon, 2017-02-27 at 13:13 +, Daniel P. Berrange wrote: > A long while back, Pavel learnt that under XWayland we needed to > use XkbGetMap instead of XkbGetKeyboard: > >   commit 95e322a6bbc29dc9c28724fb80706464e276b89f >   Author: Pavel Grunt >   Date:   Fri Feb 20 16:19:50 2015 +0100 > >

Re: [Spice-devel] [spice v9] dcc: handle preferred video codec message

Hi, On Mon, Feb 27, 2017 at 08:06:30AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE > > > > This message provides a list of video codecs based on client's order > > of preference. > > > > We duplicate the video codecs array

[Spice-devel] keymap detection under XWayland broken again ?

A long while back, Pavel learnt that under XWayland we needed to use XkbGetMap instead of XkbGetKeyboard: commit 95e322a6bbc29dc9c28724fb80706464e276b89f Author: Pavel Grunt Date: Fri Feb 20 16:19:50 2015 +0100 vncdisplaykeymap: Use XkbGetMap and XkbGetNames instead of XkbGetKeyboard

Re: [Spice-devel] [spice v9] dcc: handle preferred video codec message

> > From: Victor Toso > > [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE > > This message provides a list of video codecs based on client's order > of preference. > > We duplicate the video codecs array from reds.c and sort it using the > order of codecs as reference. > > This message will

Re: [Spice-devel] [PATCH spice-server v2] reds-stream: Introduce reds_stream_set_no_delay() helper

On Mon, Feb 27, 2017 at 01:42:37PM +0100, Christophe Fergeau wrote: > On Mon, Feb 27, 2017 at 12:35:15PM +, Frediano Ziglio wrote: > > From: Christophe Fergeau > > > > The code to enable/disable on a TCP socket is duplicated in multiple > > places in the code base, this commit replaces this d

Re: [Spice-devel] [PATCH spice-server v2] reds-stream: Introduce reds_stream_set_no_delay() helper

On Mon, Feb 27, 2017 at 12:35:15PM +, Frediano Ziglio wrote: > From: Christophe Fergeau > > The code to enable/disable on a TCP socket is duplicated in multiple > places in the code base, this commit replaces this duplicated code with > a helper in RedsStream. > --- > server/common-graphics-

[Spice-devel] [PATCH spice-server v2] reds-stream: Introduce reds_stream_set_no_delay() helper

From: Christophe Fergeau The code to enable/disable on a TCP socket is duplicated in multiple places in the code base, this commit replaces this duplicated code with a helper in RedsStream. --- server/common-graphics-channel.c | 15 +++ server/red-channel-client.c | 17 ++---

Re: [Spice-devel] [PATCH spice-server v2] style: Change boolean style convention

Acked-by: Christophe Fergeau On Mon, Feb 27, 2017 at 12:21:15PM +, Frediano Ziglio wrote: > Following > https://lists.freedesktop.org/archives/spice-devel/2017-February/035800.html > , the consensus was to use 'bool' rather than 'gboolean', and to use > true/false rather than TRUE/FALSE. New

[Spice-devel] [PATCH spice-server v2] style: Change boolean style convention

Following https://lists.freedesktop.org/archives/spice-devel/2017-February/035800.html , the consensus was to use 'bool' rather than 'gboolean', and to use true/false rather than TRUE/FALSE. New code should attempt to follow the new style. Signed-off-by: Frediano Ziglio --- docs/spice_style.txt

Re: [Spice-devel] [PATCH spice-server] style: Specify boolean style convention

On Mon, Feb 27, 2017 at 07:04:30AM -0500, Frediano Ziglio wrote: > > > > On Mon, Feb 27, 2017 at 06:36:18AM -0500, Frediano Ziglio wrote: > > > What about: > > > > > > "style: Change boolean style convention > > > > > > Was agreed to use C99 syntax for boolean. > > > New code should attempt to f

Re: [Spice-devel] [PATCH] Remove X == TRUE tests for non-boolean values

On Mon, Feb 27, 2017 at 06:58:47AM -0500, Frediano Ziglio wrote: > > > > Using X == TRUE is fragile, since the input value is a uint8_t. It would be > > surprising if the value was set to 2 or 0xFF and the test failed. > > > > Signed-off-by: Christophe de Dinechin > > Acked-by: Frediano Ziglio

Re: [Spice-devel] [spice-server v4 5/5] Change some spice_printerr() to spice_debug()

On Wed, Feb 15, 2017 at 06:45:21AM -0500, Frediano Ziglio wrote: > > > > Some debug messages were using spice_printerr(), which should be limited > > to actual errors. > > > > Signed-off-by: Christophe Fergeau > > --- > > server/inputs-channel.c | 4 ++-- > > server/main-channel-client.c

Re: [Spice-devel] [PATCH spice-server] style: Specify boolean style convention

> > On Mon, Feb 27, 2017 at 06:36:18AM -0500, Frediano Ziglio wrote: > > What about: > > > > "style: Change boolean style convention > > > > Was agreed to use C99 syntax for boolean. > > New code should attempt to follow the new style." > > "Following > https://lists.freedesktop.org/archives/sp

Re: [Spice-devel] [PATCH] Remove X == TRUE tests for non-boolean values

> > Using X == TRUE is fragile, since the input value is a uint8_t. It would be > surprising if the value was set to 2 or 0xFF and the test failed. > > Signed-off-by: Christophe de Dinechin Acked-by: Frediano Ziglio > --- > server/dcc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletion

Re: [Spice-devel] [spice-server v4 5/5] Change some spice_printerr() to spice_debug()

On Mon, Feb 27, 2017 at 12:44:27PM +0100, Christophe Fergeau wrote: > On Mon, Feb 27, 2017 at 06:39:14AM -0500, Frediano Ziglio wrote: > > > > > > On Wed, Feb 15, 2017 at 11:24:37AM -0500, Frediano Ziglio wrote: > > > > > > > > > > > > > > > > On 15 Feb 2017, at 12:45, Frediano Ziglio > > > >

[Spice-devel] [PATCH] Remove X == TRUE tests for non-boolean values

Using X == TRUE is fragile, since the input value is a uint8_t. It would be surprising if the value was set to 2 or 0xFF and the test failed. Signed-off-by: Christophe de Dinechin --- server/dcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/dcc.c b/server/dcc.c

Re: [Spice-devel] [spice-server v4 5/5] Change some spice_printerr() to spice_debug()

On Mon, Feb 27, 2017 at 06:39:14AM -0500, Frediano Ziglio wrote: > > > > On Wed, Feb 15, 2017 at 11:24:37AM -0500, Frediano Ziglio wrote: > > > > > > > > > > > > > On 15 Feb 2017, at 12:45, Frediano Ziglio wrote: > > > > > > > > > >> @@ -134,7 +134,7 @@ static void > > > > >> red_qxl_display_m

Re: [Spice-devel] [PATCH spice-server] style: Specify boolean style convention

On Mon, Feb 27, 2017 at 06:36:18AM -0500, Frediano Ziglio wrote: > What about: > > "style: Change boolean style convention > > Was agreed to use C99 syntax for boolean. > New code should attempt to follow the new style." "Following https://lists.freedesktop.org/archives/spice-devel/2017-February

Re: [Spice-devel] [PATCH spice-server] style: Group together indentation sections

Acked-by: Christophe Fergeau On Thu, Feb 23, 2017 at 05:37:53PM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > docs/spice_style.txt | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/docs/spice_style.txt b/docs/spice_style.txt > in

Re: [Spice-devel] [spice-server v4 5/5] Change some spice_printerr() to spice_debug()

> > On Wed, Feb 15, 2017 at 11:24:37AM -0500, Frediano Ziglio wrote: > > > > > > > > > > On 15 Feb 2017, at 12:45, Frediano Ziglio wrote: > > > > > > > >> @@ -134,7 +134,7 @@ static void > > > >> red_qxl_display_migrate(RedChannelClient > > > >> *rcc) > > > >> } > > > >> g_object_get(c

Re: [Spice-devel] [PATCH spice-server] style: Specify boolean style convention

What about: "style: Change boolean style convention Was agreed to use C99 syntax for boolean. New code should attempt to follow the new style." Frediano > > Maybe add a note that this *changes* existing conventions. > Not sure it's worth doing a global s/TRUE/true though. > Looks good to me. >

Re: [Spice-devel] [spice-server v4 5/5] Change some spice_printerr() to spice_debug()

On Wed, Feb 15, 2017 at 11:24:37AM -0500, Frediano Ziglio wrote: > > > > > > > On 15 Feb 2017, at 12:45, Frediano Ziglio wrote: > > > > > >> @@ -134,7 +134,7 @@ static void red_qxl_display_migrate(RedChannelClient > > >> *rcc) > > >> } > > >> g_object_get(channel, "channel-type", &type,

Re: [Spice-devel] [PATCH spice-server] style: Specify boolean style convention

Maybe add a note that this *changes* existing conventions. Not sure it's worth doing a global s/TRUE/true though. Looks good to me. Christophe On Thu, Feb 23, 2017 at 05:37:52PM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > docs/spice_style.txt | 12 ++-- > 1 f

Re: [Spice-devel] [PATCH spice-server 3/4] reds-stream: Introduce reds_stream_set_no_delay() helper

So what is the verdict here? Is everyone fine with keeping consistency within reds-stream.[ch] which use bool and TRUE/FALSE, or do you want something different? Christophe On Wed, Feb 15, 2017 at 04:04:16PM +0100, Christophe Fergeau wrote: > On Wed, Feb 15, 2017 at 03:23:36PM +0100, Pavel Grunt

Re: [Spice-devel] [spice-gtk v1 0/7] clipboard_get_targets() on spice-gtk-session.c

Hi, On Wed, Feb 22, 2017 at 02:11:05PM +0100, Victor Toso wrote: > From: Victor Toso > > Hi, > > Minor changes that I was doing while playing with clipboard. > The first one seems important the others might be somewhat an > improvement or not. Let me know ;) > > Cheers, > > Victor Toso (7): > g

Re: [Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote: > Hello Daniel, > > On Mon, 2017-02-27 at 10:25 +, Daniel P. Berrange wrote: > > Consume the keymaps.csv file from a git submodule instead of having > > a private copy. This makes it easier to ensure all users of the > > keymap > > (

Re: [Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

Hello Daniel, On Mon, 2017-02-27 at 10:25 +, Daniel P. Berrange wrote: > Consume the keymaps.csv file from a git submodule instead of having > a private copy. This makes it easier to ensure all users of the > keymap > (libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a > consistent >

[Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

Consume the keymaps.csv file from a git submodule instead of having a private copy. This makes it easier to ensure all users of the keymap (libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a consistent set of data. Signed-off-by: Daniel P. Berrange --- Changed in v3: - Fix makefile ru

[Spice-devel] [spice v9] dcc: handle preferred video codec message

From: Victor Toso [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE This message provides a list of video codecs based on client's order of preference. We duplicate the video codecs array from reds.c and sort it using the order of codecs as reference. This message will not change an ongoing st

[Spice-devel] [spice v9] Preferred video codec message (27 Feb)

From: Victor Toso Hi, Finally a new version with rework from previous iteration. To test it easily, I'm using this branch [0] that introduces a streaming information in spicy tool (no streaming it sets to None, with vp8 stream it sets it to "vp8", and so on) [0] https://gitlab.com/victortoso/s

Re: [Spice-devel] [client] spicy: Spicy uses GTK+ and must link with it

On Mon, 27 Feb 2017, Christophe Fergeau wrote: > On Mon, Feb 27, 2017 at 09:19:15AM +0100, Christophe Fergeau wrote: > > However, spicy-stats uses glib/gobject, and does not explicitly link > > with it either, I would have expected something like the patch below, but > > this can actually be done

Re: [Spice-devel] [client] spicy: Spicy uses GTK+ and must link with it

On Mon, Feb 27, 2017 at 09:25:35AM +0100, Victor Toso wrote: > Hi, > > On Mon, Feb 27, 2017 at 09:19:15AM +0100, Christophe Fergeau wrote: > > On Fri, Feb 24, 2017 at 12:23:23PM +0100, Francois Gouget wrote: > > > This avoids having the linker complain that gtk_toggle_action_get_type() > > > or so

Re: [Spice-devel] [client] spicy-stats: spicy-stats uses libgobject so link with it

On Fri, Feb 24, 2017 at 12:26:42PM +0100, Francois Gouget wrote: > This avoids having the linker complain that g_signal_connect_data() or > some other GObject API is undefined. Acked-by: Christophe Fergeau > > Signed-off-by: Francois Gouget > --- > tools/Makefile.am | 1 + > 1 file changed, 1

Re: [Spice-devel] [client] spicy: Spicy uses GTK+ and must link with it

On Mon, Feb 27, 2017 at 09:19:15AM +0100, Christophe Fergeau wrote: > However, spicy-stats uses glib/gobject, and does not explicitly link > with it either, I would have expected something like the patch below, but > this can actually be done on top of your patch. Ah, never mind, just saw your oth

Re: [Spice-devel] [client] spicy: Spicy uses GTK+ and must link with it

Hi, On Mon, Feb 27, 2017 at 09:19:15AM +0100, Christophe Fergeau wrote: > On Fri, Feb 24, 2017 at 12:23:23PM +0100, Francois Gouget wrote: > > This avoids having the linker complain that gtk_toggle_action_get_type() > > or some other GTK+ API is undefined. > > This kind of issues are indeed seen o

Re: [Spice-devel] [client] spicy: Spicy uses GTK+ and must link with it

On Fri, Feb 24, 2017 at 12:23:23PM +0100, Francois Gouget wrote: > This avoids having the linker complain that gtk_toggle_action_get_type() > or some other GTK+ API is undefined. This kind of issues are indeed seen on some distros, and not others. I believe this is what is described on https://wik