Re: [Spice-devel] [PATCH spice-gtk] util: Remove unused GError parameter

Note: Would be nice to mention in the commit log from which functions the error parameter is removed. Christophe On Thu, Sep 01, 2016 at 04:39:42PM +0200, Pavel Grunt wrote: > --- > src/spice-gtk-session.c | 22 ++ > src/spice-util-priv.h | 4 ++-- > src/spice-util.c

Re: [Spice-devel] [PATCH 02/10] Move RedChannelClient to separate file

On Thu, Sep 01, 2016 at 01:54:13PM -0500, Jonathon Jongsma wrote: > > > > diff --git a/server/red-channel.c b/server/red-channel.c > > > index bf290b1..03338aa 100644 > > > --- a/server/red-channel.c > > > +++ b/server/red-channel.c > > > @@ -2179,11 +707,7 @@ void > > > red_client_semi_seamless_m

Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

Hey, On Thu, Sep 01, 2016 at 05:43:36PM +0300, Yedidyah Bar David wrote: > On Tue, Aug 30, 2016 at 7:26 PM, Christophe Fergeau > wrote: > > Hey, > > > > On Mon, Aug 29, 2016 at 03:47:44PM +0300, Yedidyah Bar David wrote: > >> From: Lev Veyde > >> > >> This is done, so that the version will be e

Re: [Spice-devel] [PATCH 04/10] Generate GTypes for spice-server enums

On Thu, Sep 01, 2016 at 05:05:32PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-09-01 at 16:42 +0200, Christophe Fergeau wrote: > > On Wed, Aug 31, 2016 at 11:54:40AM -0500, Jonathon Jongsma wrote: > > > > > > --- > > >  server/Makefile.am | 31 +++ > > >  1 file change

Re: [Spice-devel] [PATCH 04/10] Generate GTypes for spice-server enums

On Thu, 2016-09-01 at 10:47 +0200, Victor Toso wrote: > Hi, > > On Wed, Aug 31, 2016 at 11:54:40AM -0500, Jonathon Jongsma wrote: > > > > --- > >  server/Makefile.am | 31 +++ > >  1 file changed, 31 insertions(+) > > > > diff --git a/server/Makefile.am b/server/Makefi

Re: [Spice-devel] [PATCH 04/10] Generate GTypes for spice-server enums

On Thu, 2016-09-01 at 16:42 +0200, Christophe Fergeau wrote: > On Wed, Aug 31, 2016 at 11:54:40AM -0500, Jonathon Jongsma wrote: > > > > --- > >  server/Makefile.am | 31 +++ > >  1 file changed, 31 insertions(+) > > > > diff --git a/server/Makefile.am b/server/Makefile

Re: [Spice-devel] [PATCH 02/10] Move RedChannelClient to separate file

On Thu, 2016-09-01 at 17:45 +0200, Christophe Fergeau wrote: > On Wed, Aug 31, 2016 at 11:54:38AM -0500, Jonathon Jongsma wrote: > > > > Reduce direct access to RedChannelClient, and get ready to convert > > to > > GObject. > > --- [snip] > > diff --git a/server/red-channel-client.c b/server/red

Re: [Spice-devel] [PATCH spice-gtk] util: Remove unused GError parameter

Hi - Original Message - > On Thu, 2016-09-01 at 16:39 +0200, Pavel Grunt wrote: > > --- > >  src/spice-gtk-session.c | 22 ++ > >  src/spice-util-priv.h   |  4 ++-- > >  src/spice-util.c| 28 > >  tests/util.c| 14 -

Re: [Spice-devel] [PATCH spice-gtk] util: Remove unused GError parameter

On Thu, 2016-09-01 at 16:39 +0200, Pavel Grunt wrote: > --- >  src/spice-gtk-session.c | 22 ++ >  src/spice-util-priv.h   |  4 ++-- >  src/spice-util.c| 28 >  tests/util.c| 14 -- >  4 files changed, 16 insertions(+), 5

Re: [Spice-devel] [PATCH 00/14] Miscellaneous patches

On Thu, 2016-09-01 at 13:00 +0100, Frediano Ziglio wrote: > This set contains small fixes, const/static changes > and other style changes. > > Frediano Ziglio (14): >   Remove small possible buffer overflow >   Fix include syntax >   Make DisplayMode setter methods const >   Do not print function

Re: [Spice-devel] [PATCH 02/10] Move RedChannelClient to separate file

On Wed, Aug 31, 2016 at 11:54:38AM -0500, Jonathon Jongsma wrote: > Reduce direct access to RedChannelClient, and get ready to convert to > GObject. > --- > server/Makefile.am |2 + > server/cursor-channel.c|2 + > server/dcc-private.h |1 + > server/input

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

> > On 1 Sep 2016, at 18:08 PM, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > On 1 Sep 2016, at 17:27 PM, Christophe Fergeau < cferg...@redhat.com > > > > > wrote: > > > > > > > > > > On Thu, Sep 01, 2016 at 05:11:06PM +0300, Dmitry Fleytman wrote: > > > > > > > > > > > Does thi

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

> On 1 Sep 2016, at 18:08 PM, Frediano Ziglio wrote: > >>> >>> On 1 Sep 2016, at 17:27 PM, Christophe Fergeau wrote: >>> >>> On Thu, Sep 01, 2016 at 05:11:06PM +0300, Dmitry Fleytman wrote: Does this answer your questions? >>> >>> I think what Frediano is after is a public Daynix-

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

> > > On 1 Sep 2016, at 17:27 PM, Christophe Fergeau wrote: > > > > On Thu, Sep 01, 2016 at 05:11:06PM +0300, Dmitry Fleytman wrote: > >> > >> Does this answer your questions? > > > > I think what Frediano is after is a public Daynix-maintained git > > repository with the patches you are sendi

Re: [Spice-devel] [PATCH 10/10] Rename RCC_TO_DCC() to DISPLAY_CHANNEL_CLIENT()

Hi, On Thu, Sep 01, 2016 at 11:00:00AM -0400, Frediano Ziglio wrote: > > > > On Thu, 2016-09-01 at 12:50 +0200, Victor Toso wrote: > > > Hi, > > > > > > On Thu, Sep 01, 2016 at 06:26:18AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > > > > > > Prepare for port to GObject > > > >

Re: [Spice-devel] [PATCH 10/14] Make CCD::load_api throw exception by its own

On Thu, Sep 01, 2016 at 10:58:39AM -0400, Frediano Ziglio wrote: > > > > s/by its own/on its own/ > > > > On Thu, Sep 01, 2016 at 01:00:52PM +0100, Frediano Ziglio wrote: > > > Avoid to use two way to handle errors. > > > > "two different ways" > > > > Acked-by: Christophe Fergeau > > > > >

Re: [Spice-devel] [PATCH 09/14] Fails CCD initialisation if get_config_buffers detect WDDM is not present

> On Thu, Sep 01, 2016 at 01:00:51PM +0100, Frediano Ziglio wrote: > > There's no point continuing without WDDM as CCD cannot work without it. > > > > Signed-off-by: Frediano Ziglio > > --- > > vdagent/display_configuration.cpp | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/

Re: [Spice-devel] [PATCH 10/10] Rename RCC_TO_DCC() to DISPLAY_CHANNEL_CLIENT()

> > On Thu, 2016-09-01 at 12:50 +0200, Victor Toso wrote: > > Hi, > > > > On Thu, Sep 01, 2016 at 06:26:18AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > > Prepare for port to GObject > > > > > > Honestly I prefer the old name. > > > DISPLAY_CHANNEL_CLIENT looks like you can conv

Re: [Spice-devel] [PATCH 10/14] Make CCD::load_api throw exception by its own

> > s/by its own/on its own/ > > On Thu, Sep 01, 2016 at 01:00:52PM +0100, Frediano Ziglio wrote: > > Avoid to use two way to handle errors. > > "two different ways" > > Acked-by: Christophe Fergeau > Fixed these typos after sending v3. If I understood you removed the ack in a later comment

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

> On 1 Sep 2016, at 17:27 PM, Christophe Fergeau wrote: > > On Thu, Sep 01, 2016 at 05:11:06PM +0300, Dmitry Fleytman wrote: >> >> Does this answer your questions? > > I think what Frediano is after is a public Daynix-maintained git > repository with the patches you are sending applied, as it'

[Spice-devel] [PATCH v3 3/5] Make CCD::load_api throw exception by its own

Avoid to use two way to handle errors. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 19 +++ vdagent/display_configuration.h | 2 +- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_co

[Spice-devel] [PATCH v3 4/5] Get D3DKMTOpenAdapterFromDeviceName and D3DKMTOpenAdapterFromDeviceName independently

There's no reason why we can't use one if the other is not present Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp in

[Spice-devel] [PATCH v3 1/5] Do not print function calling vd_printf

vd_printf already print the current function Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 57 +++ 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp i

[Spice-devel] [PATCH v3 2/5] Fails CCD initialisation if get_config_buffers detect WDDM is not present

There's no point continuing without WDDM as CCD cannot work without it. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 4 1 file changed, 4 insertions(+) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp index 2fa7089..29a1030 10064

[Spice-devel] [PATCH v3 5/5] Use a single class for every escape command

Do not use two classes one for XPDM and the other for WDDM. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 80 --- vdagent/display_configuration.h | 17 + 2 files changed, 49 insertions(+), 48 deletions(-) diff --git a/vdagen

[Spice-devel] [PATCH v3 0/5] Miscellaneous patches

This set contains small fixes and other style changes. Changes since v3: - merge acked patches; - more calls added to "Do not print function calling vd_printf". Frediano Ziglio (5): Do not print function calling vd_printf Fails CCD initialisation if get_config_buffers detect WDDM is not p

Re: [Spice-devel] [PATCH 04/10] Generate GTypes for spice-server enums

On Wed, Aug 31, 2016 at 11:54:40AM -0500, Jonathon Jongsma wrote: > --- > server/Makefile.am | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/server/Makefile.am b/server/Makefile.am > index 968829a..771b33f 100644 > --- a/server/Makefile.am > +++ b/server/

Re: [Spice-devel] [PATCH 09/14] Fails CCD initialisation if get_config_buffers detect WDDM is not present

On Thu, Sep 01, 2016 at 01:00:51PM +0100, Frediano Ziglio wrote: > There's no point continuing without WDDM as CCD cannot work without it. > > Signed-off-by: Frediano Ziglio > --- > vdagent/display_configuration.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/vdagent/display_co

Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

On Tue, Aug 30, 2016 at 7:26 PM, Christophe Fergeau wrote: > Hey, > > On Mon, Aug 29, 2016 at 03:47:44PM +0300, Yedidyah Bar David wrote: >> From: Lev Veyde >> >> This is done, so that the version will be easily visible in the >> oVirt Manager under the Applications, because the oVirt Guest Agent

[Spice-devel] [PATCH spice-gtk] util: Remove unused GError parameter

--- src/spice-gtk-session.c | 22 ++ src/spice-util-priv.h | 4 ++-- src/spice-util.c| 28 tests/util.c| 14 -- 4 files changed, 16 insertions(+), 52 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-g

Re: [Spice-devel] [PATCH 12/14] Use a single class for every escape command

On Thu, Sep 01, 2016 at 01:00:54PM +0100, Frediano Ziglio wrote: > Do not use two classes one for XPDM and the other for WDDM. > > Signed-off-by: Frediano Ziglio > --- > vdagent/display_configuration.cpp | 76 > +-- > vdagent/display_configuration.h | 17 ++

Re: [Spice-devel] [PATCH 10/10] Rename RCC_TO_DCC() to DISPLAY_CHANNEL_CLIENT()

On Thu, 2016-09-01 at 12:50 +0200, Victor Toso wrote: > Hi, > > On Thu, Sep 01, 2016 at 06:26:18AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > Prepare for port to GObject > > > > Honestly I prefer the old name. > > DISPLAY_CHANNEL_CLIENT looks like you can convert anything to a > > Dis

Re: [Spice-devel] [PATCH 00/14] Miscellaneous patches

Except for patches 9 to 12: Acked-by: Christophe Fergeau Hopefully Dmitry/Sameeh will be able to review these 4 remaining patches: > Fails CCD initialisation if get_config_buffers detect WDDM is not > present > Make CCD::load_api throw exception by its own > Get D3DKMTOpenAdapterFromD

Re: [Spice-devel] [PATCH 09/14] Fails CCD initialisation if get_config_buffers detect WDDM is not present

On Thu, Sep 01, 2016 at 01:00:51PM +0100, Frediano Ziglio wrote: > There's no point continuing without WDDM as CCD cannot work without it. > > Signed-off-by: Frediano Ziglio > --- > vdagent/display_configuration.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/vdagent/display_co

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

On Thu, Sep 01, 2016 at 05:11:06PM +0300, Dmitry Fleytman wrote: > > Does this answer your questions? I think what Frediano is after is a public Daynix-maintained git repository with the patches you are sending applied, as it's not always easy to git am these big series (CR/LR differences, not al

Re: [Spice-devel] [PATCH 10/14] Make CCD::load_api throw exception by its own

s/by its own/on its own/ On Thu, Sep 01, 2016 at 01:00:52PM +0100, Frediano Ziglio wrote: > Avoid to use two way to handle errors. "two different ways" Acked-by: Christophe Fergeau > > Signed-off-by: Frediano Ziglio > --- > vdagent/display_configuration.cpp | 19 +++ > vdage

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

Hi Frediano, A thought we already agreed on this before: https://github.com/vrozenfe/qxl-dod - outdated, no new commits will go there https://gitlab.com/spice/qxl-wddm-dod - the new main one - we expect that our patch

[Spice-devel] [spice-gtk v2] clipboard: Return early on fixup_clipboard_text errors()

5c8f400 "clipboard: Add clipboard_atom_to_vdagent_type helper" mistakenly removed some early returns when text conversion fails for some reason. This commit readds it. --- Maybe this... Not really convinced. An alternative would be to g_strdup(text) when we don't convert, but that's a fairly useles

Re: [Spice-devel] [spice-gtk] clipboard: Return early on fixup_clipboard_text errors()

On Thu, Sep 01, 2016 at 03:41:38PM +0200, Christophe Fergeau wrote: > On Thu, Sep 01, 2016 at 01:57:16PM +0200, Pavel Grunt wrote: > > Hi, > > > > On Thu, 2016-09-01 at 13:11 +0200, Christophe Fergeau wrote: > > > 5c8f400 "clipboard: Add clipboard_atom_to_vdagent_type helper" > > > mistakenly remo

Re: [Spice-devel] [PATCH spice-gtk] Translate file transfer error messages

On Thu, 2016-09-01 at 09:33 +0200, Christophe Fergeau wrote: > On Wed, Aug 31, 2016 at 03:36:04PM -0500, Jonathon Jongsma wrote: > > > > If we are to ever display error messages to a user in a UI, they > > need to > > be translated. > > --- > >  po/POTFILES.in | 1 + > >  src/channel-main.c | 5

Re: [Spice-devel] [spice-gtk] clipboard: Return early on fixup_clipboard_text errors()

On Thu, Sep 01, 2016 at 01:57:16PM +0200, Pavel Grunt wrote: > Hi, > > On Thu, 2016-09-01 at 13:11 +0200, Christophe Fergeau wrote: > > 5c8f400 "clipboard: Add clipboard_atom_to_vdagent_type helper" > > mistakenly removed some early returns when text conversion fails for > > some reason. This comm

Re: [Spice-devel] [client 1/2] streaming: Send a special stream report to signal streaming errors

On Thu, Aug 11, 2016 at 01:04:09PM +0200, Francois Gouget wrote: > Servers that recognize this special report then stop streaming (sending > regular screen updates instead) while older ones essentially ignore it. > > Signed-off-by: Francois Gouget > --- > > This patchset is based on Victor Toso

Re: [Spice-devel] [client 1/2] streaming: Send a special stream report to signal streaming errors

On Thu, Aug 11, 2016 at 01:04:09PM +0200, Francois Gouget wrote: > Servers that recognize this special report then stop streaming (sending > regular screen updates instead) while older ones essentially ignore it. > > Signed-off-by: Francois Gouget > --- > > This patchset is based on Victor Toso

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

Hi, sorry for the latency. However there are some base problems on these patches. One big one it's the repository. As this is not public once we ack the patches where are you putting them? Just changing the comment on the private branch? Actually there are multiple repositories public: 1- ht

Re: [Spice-devel] [client 2/2 v2] streaming: Don't crash if the stream creation fails

On Mon, Aug 08, 2016 at 06:00:23PM +0200, Francois Gouget wrote: > > For reference the crash happened in display_handle_stream_data() when > calling trying to queue the frame because video_decoder is NULL (same > sort of issue as on the server with video_encoder). > > st->video_decoder->que

[Spice-devel] [PATCH v2] Use a single class for every escape command

Do not use two classes one for XPDM and the other for WDDM. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 80 --- vdagent/display_configuration.h | 17 + 2 files changed, 49 insertions(+), 48 deletions(-) Changes since v1: -

Re: [Spice-devel] [PATCH 09/10] Add DisplayChannelClientPrivate and CursorChannelPrivate structs

> > Hi, > > On Wed, Aug 31, 2016 at 11:54:45AM -0500, Jonathon Jongsma wrote: > > These need to be introduced at the same time since cache-item.tmpl.c > > assumes that both of these classes will have a cache in the same place: > > either within the channel client struct itself or (now) within a p

Re: [Spice-devel] [PATCH v5] Add ioctls structures to qxl_windows.h

As it's used only by the driver I would prefer defined just in the driver. Frediano - Original Message - > From: "Sameeh Jubran" > To: "Frediano Ziglio" > Cc: "Spice List" , "Dmitry Fleytman" > > Sent: Thursday, September 1, 2016 12:58:26 PM > Subject: Re: [PATCH v5] Add ioctls stru

[Spice-devel] [PATCH 04/14] Do not print function calling vd_printf

vd_printf already print the current function Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp index 79ea3b4..86f7f7b 100644 --- a/vda

[Spice-devel] [PATCH 05/14] Make session_events static and const

Signed-off-by: Frediano Ziglio --- vdservice/vdservice.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index d2bedaa..2d7b5b9 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -233,7 +233,7 @@ bool VDSer

[Spice-devel] [PATCH 02/14] Fix include syntax

Signed-off-by: Frediano Ziglio --- vdagent/display_setting.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vdagent/display_setting.cpp b/vdagent/display_setting.cpp index a2ada04..25a248e 100644 --- a/vdagent/display_setting.cpp +++ b/vdagent/display_setting.cpp @@ -19,9 +

[Spice-devel] [PATCH 10/14] Make CCD::load_api throw exception by its own

Avoid to use two way to handle errors. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 19 +++ vdagent/display_configuration.h | 2 +- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_co

[Spice-devel] [PATCH 08/14] Make some members constant

Signed-off-by: Frediano Ziglio --- vdagent/vdagent.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index aa1a3cc..d4f0d45 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -106,9 +106,9 @@ private: sta

[Spice-devel] [PATCH 11/14] Get D3DKMTOpenAdapterFromDeviceName and D3DKMTOpenAdapterFromDeviceName independently

There's no reason why we can't use one if the other is not present Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp in

[Spice-devel] [PATCH 13/14] Use std::vector for agent capabilities

Signed-off-by: Frediano Ziglio --- vdagent/vdagent.cpp | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index d4f0d45..45f2c68 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -27,6 +27,7 @

[Spice-devel] [PATCH 00/14] Miscellaneous patches

This set contains small fixes, const/static changes and other style changes. Frediano Ziglio (14): Remove small possible buffer overflow Fix include syntax Make DisplayMode setter methods const Do not print function calling vd_printf Make session_events static and const Reuse SPICE_N_E

[Spice-devel] [PATCH 14/14] Use simpler classes for mutex handling

Signed-off-by: Frediano Ziglio --- common/vdcommon.h | 39 +++ vdagent/desktop_layout.cpp | 1 - vdagent/desktop_layout.h | 4 ++-- vdagent/vdagent.cpp| 17 + vdservice/vdservice.cpp| 11 +++ 5 files changed, 45

[Spice-devel] [PATCH 09/14] Fails CCD initialisation if get_config_buffers detect WDDM is not present

There's no point continuing without WDDM as CCD cannot work without it. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 4 1 file changed, 4 insertions(+) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp index 86f7f7b..5aed7be 10064

[Spice-devel] [PATCH 07/14] Make static and constant some lookup arrays

Make clipboard_formats and image_types static and constant. Signed-off-by: Frediano Ziglio --- vdagent/vdagent.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index ded6221..aa1a3cc 100644 --- a/vdagent/vdagent.cpp ++

[Spice-devel] [PATCH 06/14] Reuse SPICE_N_ELEMENTS macro

Signed-off-by: Frediano Ziglio --- vdagent/vdagent.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index cde29e6..ded6221 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -52,7 +52,7 @@ VDClipboardFormat clipboard_

[Spice-devel] [PATCH 01/14] Remove small possible buffer overflow

wcsncpy requires number of characters, not bytes. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp index c0d6342..79ea3b4 100644 --- a/

[Spice-devel] [PATCH 12/14] Use a single class for every escape command

Do not use two classes one for XPDM and the other for WDDM. Signed-off-by: Frediano Ziglio --- vdagent/display_configuration.cpp | 76 +-- vdagent/display_configuration.h | 17 + 2 files changed, 49 insertions(+), 44 deletions(-) diff --git a/vdagen

[Spice-devel] [PATCH 03/14] Make DisplayMode setter methods const

Signed-off-by: Frediano Ziglio --- vdagent/desktop_layout.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vdagent/desktop_layout.h b/vdagent/desktop_layout.h index fd6af76..34bec0d 100644 --- a/vdagent/desktop_layout.h +++ b/vdagent/desktop_layout.h @@ -34,12 +3

Re: [Spice-devel] [PATCH v5] Add ioctls structures to qxl_windows.h

On Thu, Sep 1, 2016 at 2:50 PM, Frediano Ziglio wrote: > > > > This patch defines the structures of ioctls that are used between > > win-vdagent and the qxl-wddm-dod driver. > > > > ??? > > didn't we decide to remove this? > > Yes, but this is still used in the driver to determine the ioctl. > F

Re: [Spice-devel] [spice-gtk] clipboard: Return early on fixup_clipboard_text errors()

Hi, On Thu, 2016-09-01 at 13:11 +0200, Christophe Fergeau wrote: > 5c8f400 "clipboard: Add clipboard_atom_to_vdagent_type helper" > mistakenly removed some early returns when text conversion fails for > some reason. This commit readds it. > --- >  src/spice-gtk-session.c | 3 +++ >  1 file changed,

Re: [Spice-devel] [PATCH v5] Add ioctls structures to qxl_windows.h

> > This patch defines the structures of ioctls that are used between > win-vdagent and the qxl-wddm-dod driver. > ??? didn't we decide to remove this? Frediano > Signed-off-by: Sameeh Jubran > --- > spice/qxl_windows.h | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > >

Re: [Spice-devel] [PATCH VDAgent-win v11] Implementing WDDM interface to support multiple monitors and arbitrary resolution

> > The Direct3D 9 API operates on either the Windows XP display driver > model (XPDM) or the Windows Vista display driver model (WDDM), depending > on the operating system installed. > > This patch implements the WDDM interface while using the CCD API to do > so. Moreover it introduces multiple

[Spice-devel] [PATCH VDAgent-win v11] Implementing WDDM interface to support multiple monitors and arbitrary resolution

The Direct3D 9 API operates on either the Windows XP display driver model (XPDM) or the Windows Vista display driver model (WDDM), depending on the operating system installed. This patch implements the WDDM interface while using the CCD API to do so. Moreover it introduces multiple monitors suppor

[Spice-devel] [PATCH VDAgent-win v11] Adding multiple monitors and arbitrary resolution for Windows 10

Diffrences from previous patches: * Redefiened ioctl structures to match v7 as requested by Frediano. Should be applied along with this patch: https://lists.freedesktop.org/archives/spice-devel/2016-September/031609.html Sameeh Jubran (1): Implementing WDDM interface to support multiple monitor

[Spice-devel] [PATCH v5] Add ioctls structures to qxl_windows.h

This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h index bc2ceff..8

Re: [Spice-devel] [PATCH 09/10] Add DisplayChannelClientPrivate and CursorChannelPrivate structs

Hi, On Wed, Aug 31, 2016 at 11:54:45AM -0500, Jonathon Jongsma wrote: > These need to be introduced at the same time since cache-item.tmpl.c > assumes that both of these classes will have a cache in the same place: > either within the channel client struct itself or (now) within a priv > struct ow

[Spice-devel] [spice-gtk] clipboard: Return early on fixup_clipboard_text errors()

5c8f400 "clipboard: Add clipboard_atom_to_vdagent_type helper" mistakenly removed some early returns when text conversion fails for some reason. This commit readds it. --- src/spice-gtk-session.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session

Re: [Spice-devel] [spice-gtk v2 1/2] clipboard: Add fixup_clipboard_text helper

On Thu, Sep 01, 2016 at 12:23:12PM +0300, Uri Lublin wrote: > If an error occur, conv=NULL but selection_notify is called. > Arg yes, and I noticed your email after pushing /o\ Christophe signature.asc Description: PGP signature ___ Spice-devel maili

Re: [Spice-devel] [spice 2/3] server: Use SPICE_GNUC_DEPRECATED to avoid a dependency on glib.h

On Thu, Aug 11, 2016 at 04:30:47PM +0200, Francois Gouget wrote: > spice-server.h cannot include glib.h because it is a public header and > is used by projects that do not use GLib. Commit log is quite misleading imo. Not really interesting to explain you are doing this to paper over a totally di

Re: [Spice-devel] [PATCH 10/10] Rename RCC_TO_DCC() to DISPLAY_CHANNEL_CLIENT()

Hi, On Thu, Sep 01, 2016 at 06:26:18AM -0400, Frediano Ziglio wrote: > > > > Prepare for port to GObject > > Honestly I prefer the old name. > DISPLAY_CHANNEL_CLIENT looks like you can convert anything to a > DisplayChannelClient, > I would expect a NULL check for every conversion. > > Fredian

Re: [Spice-devel] [protocol 1/3] macros: Improve the SPICE_GNUC_DEPRECATED* macros

On Thu, Aug 11, 2016 at 04:30:44PM +0200, Francois Gouget wrote: > If the user specifically requests access to the deprecated APIs by > defining the SPICE_DEPRECATED macro, then turn off the > SPICE_GNUC_DEPRECATED* warnings. Ok, that's one thing > Also automatically use G_GNUC_DEPRECATED if avai

Re: [Spice-devel] [protocol 0/3] Fixing the *_DEPRECATED set of macros

On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote: > > The following patch broke compilation of xf86-video-qxl: > > commit b41220b1441b8adea6db9a98e9da1b43a8f426bb > Author: Christophe Fergeau > Date: Thu Mar 5 15:28:22 2015 +0100 > > Mark unused public API methods/code as d

Re: [Spice-devel] [PATCH spice-gtk 2/2] file-transfer: Add guards to public functions

On Thu, Sep 01, 2016 at 11:33:14AM +0200, Pavel Grunt wrote: > --- > src/spice-file-transfer-task.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/spice-file-transfer-task.c b/src/spice-file-transfer-task.c > index 96aef9f..e3fbcc7 100644 > --- a/src/spice-file-transfer-task.c

Re: [Spice-devel] [PATCH 10/10] Rename RCC_TO_DCC() to DISPLAY_CHANNEL_CLIENT()

> > Prepare for port to GObject Honestly I prefer the old name. DISPLAY_CHANNEL_CLIENT looks like you can convert anything to a DisplayChannelClient, I would expect a NULL check for every conversion. Frediano > --- > server/dcc-send.c| 86 > ---

Re: [Spice-devel] [PATCH 08/10] Add RedChannelClientPrivate struct

Hi, On Wed, Aug 31, 2016 at 11:54:44AM -0500, Jonathon Jongsma wrote: > Encapsulate private data and prepare for port to GObject > --- > server/Makefile.am | 1 + > server/cursor-channel.c | 3 +- > server/dcc-send.c | 12 +- > server/dcc.c

[Spice-devel] [PATCH] fixup! Move CursorChannelClient to separate file

Fix Makefile indentation. Avoid exposing client stuff if not needed. --- server/Makefile.am | 4 ++-- server/cursor-channel-client.c | 1 + server/cursor-channel-client.h | 6 -- server/cursor-channel.c| 1 + server/cursor-channel.h| 9 +++-- server/red-worker.c

[Spice-devel] [PATCH spice-gtk 2/2] file-transfer: Add guards to public functions

--- src/spice-file-transfer-task.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/spice-file-transfer-task.c b/src/spice-file-transfer-task.c index 96aef9f..e3fbcc7 100644 --- a/src/spice-file-transfer-task.c +++ b/src/spice-file-transfer-task.c @@ -503,6 +503,8 @@ gboolean spice_f

[Spice-devel] [PATCH spice-gtk 1/2] file-transfer: Add documentation for public functions

--- doc/reference/spice-gtk-sections.txt | 2 ++ src/spice-file-transfer-task.c | 45 ++-- 2 files changed, 35 insertions(+), 12 deletions(-) diff --git a/doc/reference/spice-gtk-sections.txt b/doc/reference/spice-gtk-sections.txt index df58297..386e737 100

Re: [Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

On Thu, Sep 01, 2016 at 11:22:52AM +0200, Victor Toso wrote: > Hi, > > On Wed, Aug 31, 2016 at 11:54:41AM -0500, Jonathon Jongsma wrote: > > Prepare to port to GObject by encapsulating all private data > > If I'm not mistaken, the private struct now will leak while > SmartCardChannelClient is not a

Re: [Spice-devel] [spice-gtk v2 1/2] clipboard: Add fixup_clipboard_text helper

On 08/31/2016 03:55 PM, Christophe Fergeau wrote: This makes clipboard_received_cb a bit shorter, and will be useful in the next commit. --- src/spice-gtk-session.c | 69 +++-- 1 file changed, 44 insertions(+), 25 deletions(-) diff --git a/src/spice-g

Re: [Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

Hi, On Wed, Aug 31, 2016 at 11:54:41AM -0500, Jonathon Jongsma wrote: > Prepare to port to GObject by encapsulating all private data If I'm not mistaken, the private struct now will leak while SmartCardChannelClient is not a GObject with its finalize/dispose. If that is the case, might point it o

Re: [Spice-devel] [PATCH 04/10] Generate GTypes for spice-server enums

Hi, On Wed, Aug 31, 2016 at 11:54:40AM -0500, Jonathon Jongsma wrote: > --- > server/Makefile.am | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/server/Makefile.am b/server/Makefile.am > index 968829a..771b33f 100644 > --- a/server/Makefile.am > +++ b/se

Re: [Spice-devel] [spice-gtk v2 1/2] clipboard: Add fixup_clipboard_text helper

Ack both patches Pavel On Wed, 2016-08-31 at 14:55 +0200, Christophe Fergeau wrote: > This makes clipboard_received_cb a bit shorter, and will be useful > in the next commit. > --- >  src/spice-gtk-session.c | 69 +++- > - >  1 file changed, 44 insertion

Re: [Spice-devel] [PATCH 03/10] Move CursorChannelClient to separate file

Hi, On Wed, Aug 31, 2016 at 11:54:39AM -0500, Jonathon Jongsma wrote: > --- > server/Makefile.am | 2 + > server/cursor-channel-client.c | 118 > + > server/cursor-channel-client.h | 50 + > server/cursor-channel.c|

Re: [Spice-devel] [PATCH spice-gtk] Translate file transfer error messages

On Wed, Aug 31, 2016 at 03:36:04PM -0500, Jonathon Jongsma wrote: > If we are to ever display error messages to a user in a UI, they need to > be translated. > --- > po/POTFILES.in | 1 + > src/channel-main.c | 5 +++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/po/PO

Re: [Spice-devel] [PATCH spice-gtk] Translate file transfer error messages

Acked-by: Christophe Fergeau On Wed, Aug 31, 2016 at 03:36:04PM -0500, Jonathon Jongsma wrote: > If we are to ever display error messages to a user in a UI, they need to > be translated. > --- > po/POTFILES.in | 1 + > src/channel-main.c | 5 +++-- > 2 files changed, 4 insertions(+), 2 dele