On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote:
> spice-gtk used to have x11/shm backend, now it's only cairo
>
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> src/spice-widget-cairo.c | 8
> src/spice-widget-priv.h | 8
> src/spice-widget.c
On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote:
> When the display is not yet realized, spice_display_widget_gl_scanout()
> will fail because the egl context is not ready. The display is never
> marked ready because the egl.image (and egl.scanout) is not set, and
> some clients, such as
On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> src/channel-display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/channel-display.c b/src/channel-display.c
> index a301e67..3ee515
On Wed, May 25, 2016 at 7:30 AM, Pavel Grunt wrote:
> As stated in the commit d2f33178c40ac51b1c8b1bf796a328631d9869c7 Glib
> applications should only include "spice-client.h".
> ---
> src/spice-file-transfer-task.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/spice-file-tra
---
doc/reference/spice-gtk-sections.txt | 4 ++--
src/channel-main.c | 24
src/spice-file-transfer-task.h | 23 ---
3 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/doc/reference/spice-gtk-sections.txt
b/doc/re
As stated in the commit d2f33178c40ac51b1c8b1bf796a328631d9869c7 Glib
applications should only include "spice-client.h".
---
src/spice-file-transfer-task.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/spice-file-transfer-task.h b/src/spice-file-transfer-task.h
index 18dc509..fba13
On Sun, 2016-05-22 at 04:02 -0400, Frediano Ziglio wrote:
> >
> > Remove the custom FOREACH_DCC macro and use the more generic
> > FOREACH_CLIENT macro and use it for all channels.
> > ---
> > server/display-channel.c | 20 ++--
> > server/display-channel.h | 9 -
> > ser
Oops. one minor problem. Typo in commit log: clean -> clear
On Tue, 2016-05-24 at 15:09 -0500, Jonathon Jongsma wrote:
> OK. But this is a pretty odd struct...
>
> Acked-by: Jonathon Jongsma
>
>
>
> On Tue, 2016-05-24 at 15:55 +0100, Frediano Ziglio wrote:
> > This reduce a bit the structure
ack
- Original Message -
> GDK_GRAB_BROKEN is not GdkGrabStatus value, but GdkEventType
> ---
> src/spice-widget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index cbca5dc..e337321 100644
> --- a/src/spice-widget.c
>
GDK_GRAB_BROKEN is not GdkGrabStatus value, but GdkEventType
---
src/spice-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index cbca5dc..e337321 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -934,7 +934,7 @@ static
OK. But this is a pretty odd struct...
Acked-by: Jonathon Jongsma
On Tue, 2016-05-24 at 15:55 +0100, Frediano Ziglio wrote:
> This reduce a bit the structure size and make clean that
> the field is used only when the item is a cache item.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/ca
Acked-by: Jonathon Jongsma
On Tue, 2016-05-24 at 15:55 +0100, Frediano Ziglio wrote:
> The id type is already uint64_t, no need to cast using some low
> level casts.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 2 +-
> server/dcc-send.c | 2 +-
> 2 files changed,
Acked-by: Jonathon Jongsma
On Tue, 2016-05-24 at 15:55 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/cache-item.tmpl.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/server/cache-item.tmpl.c b/server/cache-item.tmpl.c
> index 9a9181c..2e6f5ca 100644
Weird. I thought I remembered doing something similar to this in the past but I
must be misremembering...
Acked-by: Jonathon Jongsma
On Tue, 2016-05-24 at 15:55 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/cache-item.h | 1 -
> server/cache-item.tmpl.c |
Hi
- Original Message -
> On Mo, 2016-05-23 at 16:03 +0200, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, May 23, 2016 at 3:52 PM, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > Resuming to work on this after 2.6 freeze break ...
> > >
> > >> I have done some more testing and sent a seri
spice-gtk used to have x11/shm backend, now it's only cairo
Signed-off-by: Marc-André Lureau
---
src/spice-widget-cairo.c | 8
src/spice-widget-priv.h | 8
src/spice-widget.c | 27 +--
3 files changed, 21 insertions(+), 22 deletions(-)
diff --g
When the display is not yet realized, spice_display_widget_gl_scanout()
will fail because the egl context is not ready. The display is never
marked ready because the egl.image (and egl.scanout) is not set, and
some clients, such as virt-viewer will not realize the widget until the
display is ready.
Group canvas related data to a sub-structure.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-cairo.c | 40 +++--
src/spice-widget-priv.h | 17 ++---
src/spice-widget.c | 65 +---
3 files changed, 64 inserti
Fix regression from commit 3539ac6212d506128bd38aad032e0363e78cb4f6.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-egl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
index c60765c..1557fdc 100644
--- a/src/spice-widget-egl.c
+++ b/sr
Signed-off-by: Marc-André Lureau
---
src/channel-display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/channel-display.c b/src/channel-display.c
index a301e67..3ee515b 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -724,19 +724,19 @@ static voi
since display_channel_print_stats is now static, the compiler complains
when RED_WORKER_STAT is undefined since this function is not used:
../../server/display-channel.c:853:13: error: 'display_channel_print_stats'
defined but not used [-Werror=unused-function]
To fix, don't define the funct
On Fri, 13 May 2016, Christophe Fergeau wrote:
[...]
> Yeah, the only reason for these questions is to know whether a malicious
> client could trigger misbehaviour in this part of the code by sending us
> some unexpected data. I agree when all is good, this does not make
> sense/should not happen,
Include spice-common headers for types that are used directly in the
RedCharDevice header.
---
These includes are not currently needed -- they get pulled in by the
red-channel.h include. But if we decide in the future to remove the
red-channel.h include here and use forward declarations (e.g. to re
>
> Fixes lz decompression crash:
> https://bugzilla.redhat.com/show_bug.cgi?id=1285469
>
> Christophe Fergeau (5):
> Remove 2 unused vfuncs from client_marshallers.h
> tests: Fix glib version check
> log: Clamp SPICE_DEBUG_LEVEL if it's too high
> log: Use SPICE_CONSTRUCT
ack series
- Original Message -
> Mainly to include the fix for the lz decompression crash:
> https://bugzilla.redhat.com/show_bug.cgi?id=1285469
>
> Pavel Grunt (2):
> Update .mailmap
> Update spice-common submodule
>
> .mailmap | 11 +--
> spice-common | 2 +-
> 2 fil
Fixes lz decompression crash:
https://bugzilla.redhat.com/show_bug.cgi?id=1285469
Christophe Fergeau (5):
Remove 2 unused vfuncs from client_marshallers.h
tests: Fix glib version check
log: Clamp SPICE_DEBUG_LEVEL if it's too high
log: Use SPICE_CONSTRUCTOR_FUNC
log:
Mainly to include the fix for the lz decompression crash:
https://bugzilla.redhat.com/show_bug.cgi?id=1285469
Pavel Grunt (2):
Update .mailmap
Update spice-common submodule
.mailmap | 11 +--
spice-common | 2 +-
2 files changed, 10 insertions(+), 3 deletions(-)
--
2.8.3
---
.mailmap | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/.mailmap b/.mailmap
index f7fdf30..5893260 100644
--- a/.mailmap
+++ b/.mailmap
@@ -3,6 +3,13 @@
-
+Marc-André Lureau
+
Tiziano Müller
-Dietmar Maurer
\ No newline at end of file
+Dietmar
Since recent version of GCC allow multiple typedefs of the same name as
long as it refers to the same type, we can avoid some of the
typedef/header issues if we just decide to require a version of gcc that
allows this behavior. This is also valid according ot the C11 standard.
I don't know exactly
>
> It's only necessary to include red-pipe-item.h
> ---
> server/cache-item.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/server/cache-item.h b/server/cache-item.h
> index d14e9a3..f13a69a 100644
> --- a/server/cache-item.h
> +++ b/server/cache-item.h
> @@ -19,8 +
It's only necessary to include red-pipe-item.h
---
server/cache-item.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/server/cache-item.h b/server/cache-item.h
index d14e9a3..f13a69a 100644
--- a/server/cache-item.h
+++ b/server/cache-item.h
@@ -19,8 +19,7 @@
# define CACHE
>
> This was mispelt in a static function name.
> ---
> src/channel-main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/channel-main.c b/src/channel-main.c
> index dec5d73..94ece97 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -274,7 +274
>
> ---
> server/cache-item.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/server/cache-item.h b/server/cache-item.h
> index d14e9a3..82cfe26 100644
> --- a/server/cache-item.h
> +++ b/server/cache-item.h
> @@ -20,8 +20,6 @@
>
> #include
>
> -#include "red-channel.h"
> -
> ty
>
> Instead of using the full 'struct AgentMsgFilter', use the typedef name
> ---
> server/agent-msg-filter.c | 6 +++---
> server/agent-msg-filter.h | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c
> index 25ed
On 05/24/2016 12:19 AM, Jonathon Jongsma wrote:
On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote:
On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
/* FIXME: move back to display-channel.h (once structs are private) */
typedef struct Drawable Drawable;
-typedef struct Displa
This after typedef discussions.
This version moved Drawable into a separate file.
Signed-off-by: Frediano Ziglio
---
server/Makefile.am | 1 +
server/dcc-encoders.c| 2 +-
server/dcc-encoders.h| 1 +
server/dcc.h | 8 --
server/display-channel.h | 39 ++
This was mispelt in a static function name.
---
src/channel-main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index dec5d73..94ece97 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -274,7 +274,7 @@ static gboolean t
---
server/cache-item.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/server/cache-item.h b/server/cache-item.h
index d14e9a3..82cfe26 100644
--- a/server/cache-item.h
+++ b/server/cache-item.h
@@ -20,8 +20,6 @@
#include
-#include "red-channel.h"
-
typedef struct RedCacheItem RedCach
Instead of using the full 'struct AgentMsgFilter', use the typedef name
---
server/agent-msg-filter.c | 6 +++---
server/agent-msg-filter.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c
index 25edfd9..3e5b225 100644
On Tue, 2016-05-24 at 10:44 -0400, Frediano Ziglio wrote:
> >
> > On Tue, May 24, 2016 at 10:52:59AM +0100, Frediano Ziglio wrote:
> > > This was proposed by Christophe as improvement over some typesafe
> > > patches.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > server/char-device
This after typedef discussions
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.h| 33 ++---
server/dcc.h | 20 +++-
server/display-channel.h | 2 ++
server/image-cache.h | 6 ++
server/stream.h | 41 +++
The id type is already uint64_t, no need to cast using some low
level casts.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 2 +-
server/dcc-send.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/cursor-channel.c b/server/cursor-channel.c
index b
This reduce a bit the structure size and make clean that
the field is used only when the item is a cache item.
Signed-off-by: Frediano Ziglio
---
server/cache-item.h | 2 +-
server/cache-item.tmpl.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/cache-item.h
Change the structure to make clear the usage of the fields in the
two phases of RedCacheItem life (cache then invalidation pipe item).
Other minor changes and cleanups.
Frediano Ziglio (4):
Remove not necessary inval_type from RedCacheItem
Move RedCacheItem size field inside cache_data union
Signed-off-by: Frediano Ziglio
---
server/cache-item.h | 1 -
server/cache-item.tmpl.c | 4
server/cursor-channel.c | 2 +-
server/dcc-send.c| 2 +-
4 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/server/cache-item.h b/server/cache-item.h
index d14e9a3..864b163 1
Signed-off-by: Frediano Ziglio
---
server/cache-item.tmpl.c | 4
1 file changed, 4 deletions(-)
diff --git a/server/cache-item.tmpl.c b/server/cache-item.tmpl.c
index 9a9181c..2e6f5ca 100644
--- a/server/cache-item.tmpl.c
+++ b/server/cache-item.tmpl.c
@@ -44,8 +44,6 @@
#endif
-#define
>
> On Tue, May 24, 2016 at 10:52:59AM +0100, Frediano Ziglio wrote:
> > This was proposed by Christophe as improvement over some typesafe
> > patches.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/char-device.c | 2 +-
> > server/cursor-channel.c | 6 +++---
> > serv
On Tue, 2016-05-24 at 12:08 +0200, Christophe Fergeau wrote:
> On Mon, May 23, 2016 at 04:19:02PM -0500, Jonathon Jongsma wrote:
> >
> > So, I chatted (very briefly) with Frediano about this on IRC after sending
> > this
> > email and I thought we should gauge opinions on options here.
> >
> > Th
On Mo, 2016-05-23 at 16:03 +0200, Marc-André Lureau wrote:
> Hi
>
> On Mon, May 23, 2016 at 3:52 PM, Gerd Hoffmann wrote:
> > Hi,
> >
> > Resuming to work on this after 2.6 freeze break ...
> >
> >> I have done some more testing and sent a series for spice-gtk fixing
> >> display with gl scanou
On Tue, May 24, 2016 at 10:52:59AM +0100, Frediano Ziglio wrote:
> This was proposed by Christophe as improvement over some typesafe
> patches.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/char-device.c | 2 +-
> server/cursor-channel.c | 6 +++---
> server/dcc-encoders.c
On Tue, May 24, 2016 at 04:58:36AM -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Mon, 2016-05-23 at 16:19 -0500, Jonathon Jongsma wrote:
> > > On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote:
> > > > On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
> > > >
> > > > > >
>
> On Tue, May 24, 2016 at 10:52:58AM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/dcc.c | 2 +-
> > server/display-channel.c | 8 +---
> > server/display-channel.h | 2 --
> > server/red-parse-qxl.c | 2 +-
> > server/red-parse-qxl.h |
On Tue, May 24, 2016 at 10:52:58AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc.c | 2 +-
> server/display-channel.c | 8 +---
> server/display-channel.h | 2 --
> server/red-parse-qxl.c | 2 +-
> server/red-parse-qxl.h | 1 -
> server/stre
With some simple steps I simplified the internal loop of this
function
* convert to infinite loop
/* dpi contains a sublist of dcc's, ordered the same */
while (worker_ring_item) {
dcc = SPICE_CONTAINEROF(worker_ring_item, DisplayChannelClient,
On Mon, May 23, 2016 at 04:19:02PM -0500, Jonathon Jongsma wrote:
>
> So, I chatted (very briefly) with Frediano about this on IRC after sending
> this
> email and I thought we should gauge opinions on options here.
>
> This typedef stuff really does make refactoring more difficult. When we move
>
> >
> > Hi,
> >
> > On Mon, 2016-05-23 at 16:19 -0500, Jonathon Jongsma wrote:
> > > On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote:
> > > > On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
> > > >
> > > > > > /* FIXME: move back to display-channel.h (once structs are
> >
This was proposed by Christophe as improvement over some typesafe
patches.
Signed-off-by: Frediano Ziglio
---
server/char-device.c | 2 +-
server/cursor-channel.c | 6 +++---
server/dcc-encoders.c| 2 +-
server/dcc-send.c| 14 +++---
server/dcc.c
Signed-off-by: Frediano Ziglio
---
server/dcc.c | 2 +-
server/display-channel.c | 8 +---
server/display-channel.h | 2 --
server/red-parse-qxl.c | 2 +-
server/red-parse-qxl.h | 1 -
server/stream.c | 4 ++--
server/stream.h | 1 -
7 files changed, 9 insert
The dimensions sent by the remote end are redundant and should not be
trusted.
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 40 +++-
src/channel-display-mjpeg.c | 25 +
src/channel-display-priv.h | 3 +--
src/chann
They are only supposed to be changed when receiving the relevant server
message.
Signed-off-by: Francois Gouget
---
src/channel-display-priv.h | 2 +-
src/channel-display.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/channel-display-priv.h b/src/channel-disp
On Tue, May 24, 2016 at 05:30:26AM -0400, Marc-André Lureau wrote:
> > > +- learn GStreamer as a backend for mjpeg, vp8 & h264 decoding
> >
> > "learn" ? I'd use "add GStreamer..."
>
> Ok
>
> Is there anything else to add regarding gstreamer support? I haven't looked
> in details recently.
I d
Hi
- Original Message -
> Hey,
>
> On Mon, May 23, 2016 at 07:09:16PM +0200, Marc-André Lureau wrote:
> > Signed-off-by: Marc-André Lureau
> > ---
> >
> > Hi,
> >
> > It would be nice to release spice-gtk 0.32 with all the fixes for
> > virgl. Is there any known regression left or some
Hi,
On Tue, May 24, 2016 at 11:09:34AM +0200, Christophe Fergeau wrote:
> Hey,
>
> On Mon, May 23, 2016 at 07:09:16PM +0200, Marc-André Lureau wrote:
> > Signed-off-by: Marc-André Lureau
> > ---
> >
> > Hi,
> >
> > It would be nice to release spice-gtk 0.32 with all the fixes for
> > virgl. Is th
Hey,
On Mon, May 23, 2016 at 07:09:16PM +0200, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
>
> Hi,
>
> It would be nice to release spice-gtk 0.32 with all the fixes for
> virgl. Is there any known regression left or something good enough to
> include before a release?
I t
>
> Hi,
>
> On Mon, 2016-05-23 at 16:19 -0500, Jonathon Jongsma wrote:
> > On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote:
> > > On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
> > >
> > > > > /* FIXME: move back to display-channel.h (once structs are private)
> > > > > */
65 matches
Mail list logo
