Re: [Spice-devel] [PATCH] gtask-helper: include functions to check coroutine context

2016-05-14 Thread Fabiano Fidêncio
Toso, On Sat, May 14, 2016 at 10:05 PM, Victor Toso wrote: > Hi, > > On Sat, May 14, 2016 at 06:34:41PM +0200, Fabiano Fidêncio wrote: >> On Sat, May 14, 2016 at 5:03 PM, Victor Toso wrote: >> > If we are in coroutine context, fallback to return in idle; Otherwise, >> > let GTask decide if callb

Re: [Spice-devel] [spice-gtk v2] file-xfer: fix segfault on agent disconnection

2016-05-14 Thread Fabiano Fidêncio
Toso, On Sat, May 14, 2016 at 10:09 PM, Victor Toso wrote: > Hi, > > On Sat, May 14, 2016 at 05:56:45PM +0200, Fabiano Fidêncio wrote: >> On May 14, 2016 17:29, "Victor Toso" wrote: >> > >> > We are checking self->priv->error but accessing the argument GError * >> > which is NULL and leads to a

Re: [Spice-devel] [spice-gtk v2] file-xfer: fix segfault on agent disconnection

2016-05-14 Thread Victor Toso
Hi, On Sat, May 14, 2016 at 05:56:45PM +0200, Fabiano Fidêncio wrote: > On May 14, 2016 17:29, "Victor Toso" wrote: > > > > We are checking self->priv->error but accessing the argument GError * > > which is NULL and leads to a segfault. > > > > Program received signal SIGSEGV, Segmentation fault.

Re: [Spice-devel] [PATCH] gtask-helper: include functions to check coroutine context

2016-05-14 Thread Victor Toso
Hi, On Sat, May 14, 2016 at 06:34:41PM +0200, Fabiano Fidêncio wrote: > On Sat, May 14, 2016 at 5:03 PM, Victor Toso wrote: > > If we are in coroutine context, fallback to return in idle; Otherwise, > > let GTask decide if callback should be called or not. > > --- > > src/gtask-helper.h | 45 +++

Re: [Spice-devel] [PATCH] gtask-helper: include functions to check coroutine context

2016-05-14 Thread Fabiano Fidêncio
On Sat, May 14, 2016 at 5:03 PM, Victor Toso wrote: > If we are in coroutine context, fallback to return in idle; Otherwise, > let GTask decide if callback should be called or not. > --- > src/gtask-helper.h | 45 + > 1 file changed, 45 insertions(+) >

Re: [Spice-devel] [spice-gtk v2] file-xfer: fix segfault on agent disconnection

2016-05-14 Thread Fabiano Fidêncio
On May 14, 2016 17:29, "Victor Toso" wrote: > > We are checking self->priv->error but accessing the argument GError * > which is NULL and leads to a segfault. > > Program received signal SIGSEGV, Segmentation fault. > spice_file_transfer_task_completed (self=self@entry=0x7fffd0006f00, error=0x0) a

[Spice-devel] [spice-gtk v2] file-xfer: fix segfault on agent disconnection

2016-05-14 Thread Victor Toso
We are checking self->priv->error but accessing the argument GError * which is NULL and leads to a segfault. Program received signal SIGSEGV, Segmentation fault. spice_file_transfer_task_completed (self=self@entry=0x7fffd0006f00, error=0x0) at channel-main.c:2963 2963VDAgentFileXferSt

[Spice-devel] [PATCH] gtask-helper: include functions to check coroutine context

2016-05-14 Thread Victor Toso
If we are in coroutine context, fallback to return in idle; Otherwise, let GTask decide if callback should be called or not. --- src/gtask-helper.h | 45 + 1 file changed, 45 insertions(+) diff --git a/src/gtask-helper.h b/src/gtask-helper.h index 81c04

[Spice-devel] Fwd: paste client clipboard selection to guest

2016-05-14 Thread Alex Roithman
-- Forwarded message -- From: Alex Roithman Date: 13 May 2016 at 22:13 Subject: Re: [Spice-devel] paste client clipboard selection to guest To: Christophe Fergeau Yes, in remote-viewer and virt-manager copy/paste works. I try to implement spice viewer using spice-client-glib-2.