It was used to notify the (deprecated) auto-clipboard property of
the SpiceDisplay everytime the SpiceGtkSession emits its auto-clipboard
notify.
The commit 70a00b8fcc2ca85d3601f6ac4895f906f9032e77 removed the property
from SpiceDisplay causing a runtime warning:
GLib-GObject-WARNING **: g_object
> ---
> server/red-qxl.c| 2 +-
> server/red-qxl.h| 1 +
> server/red-worker.c | 8
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/server/red-qxl.c b/server/red-qxl.c
> index 2b618f0..0f608db 100644
> --- a/server/red-qxl.c
> +++ b/server/red-qxl.c
> @@ -63,7
Hi Eric,
This is great; thanks for taking the time to put this together.
Could I ask a few favors, though? This version did not apply to the git
tip for me. I think a few corrections Christophe made recently keep
your utils.js change from applying.
Additionally, if you could keep the spice.htm
On 03/16/2016 10:46 AM, Pavel Grunt wrote:
> It was used to notify the (deprecated) auto-clipboard property of
> the SpiceDisplay everytime the SpiceGtkSession emits its auto-clipboard
> notify.
>
> The commit 70a00b8fcc2ca85d3601f6ac4895f906f9032e77 removed the property
> from SpiceDisplay causin
On Wed, 2016-03-16 at 11:27 +0100, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Mar 15, 2016 at 02:31:03PM -0500, Jonathon Jongsma wrote:
> > +#ifndef USE_POLKIT
> > +static void
> > +_open_device_async_cb(GTask *task,
> > + gpointer object,
> > + gpointer
While testing the video streaming I ran into a number of issues caused
by Xspice's audio playback. So I investigated those and found fixes
which gives this patch series.
This patch set is totally independent from the video streaming series.
That said it does help test video streaming special c
>
> Hi,
>
> On Mon, Feb 29, 2016 at 10:36:53AM +, Frediano Ziglio wrote:
> > Allow to define functions executed at program/shared object initialization
> > or close.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > common/macros.h | 22 ++
> > 1 file changed, 22 inser
Adds --no-service argument.
This runs the program normally, instead of running as Windows service.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff -
On 03/16/2016 10:46 AM, Pavel Grunt wrote:
> ---
> It's A Kind of Magic
> ---
> src/spicy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/spicy.c b/src/spicy.c
> index 12ae653..a3f357a 100644
> --- a/src/spicy.c
> +++ b/src/spicy.c
> @@ -738,7 +738,7 @@ static const
On Mon, 2016-03-14 at 18:10 +0100, Christophe Fergeau wrote:
> ---
> server/red-qxl.h| 1 +
> server/red-worker.c | 8
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/server/red-qxl.h b/server/red-qxl.h
> index f58d42b..7287740 100644
> --- a/server/red-qxl.h
> ++
Dependency since 8693e7d3f7de1ff102082212fa6e35fb1a252ef7
Remove glib-compat files and most of GLIB_CHECK_VERSION guards
---
doc/reference/Makefile.am | 1 -
po/POTFILES.skip | 1 -
src/Makefile.am| 5 --
src/channel-cursor.c
On Wed, 2016-03-16 at 17:16 -0300, Eduardo Lima (Etrunko) wrote:
> On 03/16/2016 10:46 AM, Pavel Grunt wrote:
> >
> > ---
> > It's A Kind of Magic
> > ---
> > src/spicy.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/spicy.c b/src/spicy.c
> > index 12ae653..a
Dependency since f9a1aad85fcc76dd76c454b51fbce5e07c9b145f
Remove unneeded GTK_CHECK_VERSION guards
---
src/gtk-compat.h| 2 --
src/spicy.c | 16
src/usb-device-widget.c | 9 -
3 files changed, 27 deletions(-)
diff --git a/src/gtk-compat.h b/src/gtk-
This is hopefully the final automounting patch series.
Includes small bug fixes, that I found when working on windows shared folder
auto mounting
Theese were already ACKed, but weren't pushed yet.
Automounting now supports unmounting, mouting to a free drive letter,
and checking, whether a spice
Try to connect to shared folder automatically on Windows.
On each loop of run_service(), run a GTask, that waits for 0.5s.
If sharing is disabled, read_thread will immediately return and cause the
main_loop to stop.
This in turn causes the cancellable object to be canceled and the loop stops.
If
It is not glib specific and it is only used in spice-uri
---
src/glib-compat.c | 31 ---
src/glib-compat.h | 4
src/spice-uri.c | 29 +
3 files changed, 29 insertions(+), 35 deletions(-)
diff --git a/src/glib-compat.c b/src/glib-comp
Seems I got behind on mailing list messages again and reviewed an previous
version of this patch after it was already acked... Sorry for the noise.
On Thu, 2016-03-17 at 12:28 -0400, Frediano Ziglio wrote:
> > ---
> > server/red-qxl.c| 2 +-
> > server/red-qxl.h| 1 +
> > server/red-wo
On Thu, Mar 17, 2016 at 11:19:32AM +0100, Pavel Grunt wrote:
> g_cancellable_cancel() and g_clear_object() can handle it
Acked-by: Victor Toso
> ---
> src/spice-client-glib-usb-acl-helper.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/spice-client-glib-usb-a
Hey Francois,
> @@ -361,14 +366,23 @@ static void start_watching(qxl_screen_t *qxl)
> }
> }
>
> +/* a helper for read_from_fifos() */
> static void wall_ticker(void *opaque)
> {
> qxl_screen_t *qxl = opaque;
> struct audio_data *data = qxl->playback_opaque;
>
> -data->wal
Acked-by: Jonathon Jongsma
On Mon, 2016-03-14 at 18:10 +0100, Christophe Fergeau wrote:
> It's always called at the same time as red_channel_register_client_cbs()
> and the data is used by the callbacks, so we can pass the data as an
> argument to red_channel_register_client_cbs().
> ---
> serve
When stopping the service, automatically disconnect shared folder on
windows. Not dismounting could lead to multiple shared folders.
---
Changes since v2:
- None
Changes since v1:
- New patch
---
spice/spice-webdavd.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/s
Hi,
On Thu, Mar 17, 2016 at 11:30:21AM +0100, Victor Toso wrote:
> Hi,
>
> On Thu, Mar 17, 2016 at 11:19:34AM +0100, Pavel Grunt wrote:
> > It is not glib specific and it is only used in spice-uri
> True but I bet string utils in glib and handle this too.
> Could you include a FIXME somewhere ?
Shows alert on windows when CreateFile fails.
This can happen, when webdavd is run without administrator privileges.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-
Hi,
On Mon, Feb 29, 2016 at 10:36:53AM +, Frediano Ziglio wrote:
> Allow to define functions executed at program/shared object initialization
> or close.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/macros.h | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --gi
---
src/spice-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-util.c b/src/spice-util.c
index fd97ee7..d2bcfbf 100644
--- a/src/spice-util.c
+++ b/src/spice-util.c
@@ -47,7 +47,7 @@ static void spice_util_enable_debug_messages(void)
if (!doms) {
g
Simply keep reading from the fifos in reasonably sized chunks.
Signed-off-by: Francois Gouget
---
src/spiceqxl_audio.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/src/spiceqxl_audio.c b/src/spiceqxl_audio.c
index eba9b10..122dd95 100
>
> On Wed, 2016-03-16 at 11:52 -0400, Frediano Ziglio wrote:
> > >
> > >
> > > Hi,
> > >
> > > On Mon, Feb 29, 2016 at 10:36:53AM +, Frediano Ziglio wrote:
> > > >
> > > > Allow to define functions executed at program/shared object
> > > > initialization
> > > > or close.
> > > >
> > > >
>
> On Tue, Mar 15, 2016 at 05:25:09PM -0400, Frediano Ziglio wrote:
> > >
> > > This seems to make more sense this way, QXLInstance is the 'main' object
> > > with QXLState being its private data. External users then use QXLInstance
> > > rather than passing a pointer to the private data to red-
---
It's A Kind of Magic
---
src/spicy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spicy.c b/src/spicy.c
index 12ae653..a3f357a 100644
--- a/src/spicy.c
+++ b/src/spicy.c
@@ -738,7 +738,7 @@ static const GtkToggleActionEntry tentries[] = {
.callback= G_CA
After disabling sharing, remove client folder from file explorer.
Show client folder again after sharing is re-enabled.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
I've pushed this patch and the ref/unref patch
On Wed, 2016-03-16 at 15:40 -0500, Jonathon Jongsma wrote:
> Acked-by: Jonathon Jongsma
>
> thanks for the documentation.
>
>
> On Mon, 2016-03-14 at 17:50 +0100, Francois Gouget wrote:
> > Signed-off-by: Francois Gouget
> > ---
> >
> > More ar
can_feed() depends on the time and thus could return false in
process_fifos(), causing it to stop reading from the fifos, and then
true in watch_or_wait() so that the wall_timer would not be set, but
the fifos would not be watched either because they already contain
data to process. The audio playb
Acked-by: Jonathon Jongsma
On Mon, 2016-03-14 at 17:46 +0100, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
> server/sound.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index 1aa3a74..03d88eb 100644
> ---
On Wed, 2016-03-16 at 11:52 -0400, Frediano Ziglio wrote:
> >
> >
> > Hi,
> >
> > On Mon, Feb 29, 2016 at 10:36:53AM +, Frediano Ziglio wrote:
> > >
> > > Allow to define functions executed at program/shared object
> > > initialization
> > > or close.
> > >
> > > Signed-off-by: Frediano Zi
Add red_qxl_ methods wrapping the QXLInterface vfuncs. This allows to
remove most of the qxl_get_interface() use outside of red-qxl.c
---
server/cursor-channel.c | 2 +-
server/display-channel.c | 4 +--
server/red-qxl.c | 78 +++-
server/red-
On Tue, Mar 15, 2016 at 05:25:09PM -0400, Frediano Ziglio wrote:
> >
> > This seems to make more sense this way, QXLInstance is the 'main' object
> > with QXLState being its private data. External users then use QXLInstance
> > rather than passing a pointer to the private data to red-qxl.h methods
---
server/red-qxl.c| 2 +-
server/red-qxl.h| 1 +
server/red-worker.c | 8
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index 2b618f0..0f608db 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -63,7 +63,7 @@ struct QXLSt
On Wed, Mar 16, 2016 at 10:54 PM, Jonathon Jongsma wrote:
> Updated proposal:
>
> --- a/src/channel-usbredir.c
> +++ b/src/channel-usbredir.c
> @@ -368,16 +368,19 @@ _open_device_async_cb(GTask *task,
> spice_usbredir_channel_lock(channel);
>
> if (!spice_usbredir_channel_open_device(cha
On Fri, 2016-03-18 at 07:21 +0100, Pavel Grunt wrote:
> Hi Lukas,
>
> On Thu, 2016-03-17 at 14:47 +0100, Lukas Venhoda wrote:
> >
> > Try to connect to shared folder automatically on Windows.
> >
> > On each loop of run_service(), run a GTask, that waits for 0.5s.
> > If sharing is disabled, rea
This lets the client free the audio resources when they are not needed.
This matches QEMU's behavior.
As a side benefit it stops the client's mm-time from being stuck (due
to the audio backend's delay updates being applied to the mm-time of
the last audio message, that is the channel's creation) wh
In Windows or Linux guest os with qxl video card, when some window, button or
label call frequently update, the remote spice client will display error
background . The window, button or label will draw background with the desktop
image.Start the qemu with SPICE_DEBUG_LEVEL, the vm log show l
So, after adding the g_task_return_boolean back to _open_device_async_cb(), I
noticed that since g_task_return_error() can potentially complete the task
immediately (rather than in an idle handler done previously), we may be
executing the GAsyncReadyCallback while the channel is locked. Currently,
On Wed, 2016-03-16 at 23:01 +0100, Fabiano Fidêncio wrote:
> On Wed, Mar 16, 2016 at 10:54 PM, Jonathon Jongsma
> wrote:
> > Updated proposal:
> >
> > --- a/src/channel-usbredir.c
> > +++ b/src/channel-usbredir.c
> > @@ -368,16 +368,19 @@ _open_device_async_cb(GTask *task,
> > spice_usbredir
Hello, Christophe
The host os is redhat 7, qemu and spice is installed with redhat image. The
QXL driver is too installed with guest os redhat 6.5.
I just encountered the problem with matlab, maybe other applications not
trigger the update_area fuction?
>On Thu, Mar 17, 2016 at 02:05:30PM +0800,
On Wed, 2016-03-16 at 10:41 -0500, Jonathon Jongsma wrote:
> So, after adding the g_task_return_boolean back to _open_device_async_cb(), I
> noticed that since g_task_return_error() can potentially complete the task
> immediately (rather than in an idle handler done previously), we may be
> executi
On Mon, 2016-03-14 at 18:10 +0100, Christophe Fergeau wrote:
> Add red_qxl_ methods wrapping the QXLInterface vfuncs. This allows to
> remove most of the qxl_get_interface() use outside of red-qxl.c
> ---
> server/cursor-channel.c | 2 +-
> server/display-channel.c | 4 +--
> server/red-qxl.c
Check whether Spice Folder is already mapped.
If yes, don't try to map another one.
---
Changes since v2:
- New patch
---
spice/spice-webdavd.c | 58 ---
1 file changed, 51 insertions(+), 7 deletions(-)
diff --git a/spice/spice-webdavd.c b/spice/sp
Hello
El 15/03/16 a las 10:39, Jean-Marie Perron escribió:
Hi,
I posed thequestion Ovirt-users.
I was told to ask the question here.
Is it planned a development of WDDM driver for Windows 10 fully
support with SPICE ?
Thanks,
Jean-Marie
While there is no official driver, there is an ex
Hi,
On Thu, Mar 17, 2016 at 11:19:34AM +0100, Pavel Grunt wrote:
> It is not glib specific and it is only used in spice-uri
True but I bet string utils in glib and handle this too.
Could you include a FIXME somewhere ?
Acked-by: Victor Toso
> ---
> src/glib-compat.c | 31 --
Hi
Answers are below
Lukáš Venhoda
*From: *Pavel Grunt
*Sent: *pátek 18. března 2016 7:21
*To: *Lukas Venhoda ; spice-devel@lists.freedesktop.org
*Subject: *Re: [Spice-devel] [phodav PATCH 5/7 v3] spice-webdavd-windows:
Automount shared folder
> +gchar drive_letter;
P: You don't need
Hi
On Fri, Mar 18, 2016 at 2:17 PM, Gerd Hoffmann wrote:
> Ping Marc? Any comment on this?
Could you send a rebased series, for the patches that lead to the
issue? I assume "render DisplaySurface via opengl" patch?
--
Marc-André Lureau
___
Spice-de
Hey Francois,
On 03/18/2016 09:31 AM, Francois Gouget wrote:
>
> While testing the video streaming I ran into a number of issues caused
> by Xspice's audio playback. So I investigated those and found fixes
> which gives this patch series.
>
> This patch set is totally independent from the vide
Add error handling when unregistering folder from file explorer.
Move unregistering to a function.
Acked-by: Marc-André Lureau
---
Changes since v2:
- None
Changes since v1:
- Split patch into 2
---
spice/spice-webdavd.c | 27 ++-
1 file changed, 22 insertions(+), 5 del
Hi Javier,
Thank you very much.
It works.
Jean-Marie
De : Spice-devel [mailto:spice-devel-boun...@lists.freedesktop.org] De la part
de Javier Celaya
Envoyé : mercredi 16 mars 2016 13:20
À : spice-devel@lists.freedesktop.org; de...@flexvdi.com
Objet : Re: [Spice-devel] SPICE WDDM driver Windows
Hi,
On Fri, 2016-03-18 at 08:53 +0100, Lukas Venhoda wrote:
> Hi
>
> Answers are below
>
> Lukáš Venhoda
>
> From: Pavel Grunt
> Sent: pátek 18. března 2016 7:21
> To: Lukas Venhoda; spice-devel@lists.freedesktop.org
> Subject: Re: [Spice-devel] [phodav PATCH 5/7 v3] spice-webdavd-
> windows:
Gentle(wo)men,
I have spent time to fix the keyboard layout in spice-html5. I went to the
conclusion the keyboard layout cannot be configured on client (html5) side as
Xorg receives key code it interpretes. What ever the key face the user has
typed (A or Q) Xorg will map to the character depend
56 matches
Mail list logo
