Re: [Spice-devel] [PATCH] record: save real time during recording

2016-02-04 Thread Pavel Grunt
On Thu, 2016-02-04 at 16:10 +, Frediano Ziglio wrote: > Instead of using CPU time use a timer depending on real times. > Currently that time in the record log is not used. > However if we want to reproduce problems with stream would be useful > to have real times instead. Yes, it makes sense T

Re: [Spice-devel] [PATCH v9 00/24] Add GStreamer support for video streaming

2016-02-04 Thread Baurzhan Konurbayev
Hi, guys! I couldn't find the updated patchset. Francois said he has pushed to github, I tried to find it in https://github.com/fgouget/ There were no related commits. Can you, please, suggest the correct link? Thanks. On 02/05/2016 10:27 AM, Francois Gouget wrote: On Thu, 28 Jan 2016, Pave

Re: [Spice-devel] [PATCH v9 00/24] Add GStreamer support for video streaming

2016-02-04 Thread Francois Gouget
On Thu, 28 Jan 2016, Pavel Grunt wrote: [...] > I can provide a recording without the warning: > http://people.freedesktop.org/~pgrunt/rhel6_gstreamer_record.spice.xz > > It seems that gstreamer has problem when the stream dimensions changes. > I notice that before the server hangs the target-bitr

[Spice-devel] [PATCH v4 3/5] build-sys: check for epoxy-egl support

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau The following code requires epoxy with egl support. Check for pkg-config and egl headers. Signed-off-by: Marc-André Lureau --- configure.ac | 25 + 1 file changed, 25 insertions(+) diff --git a/configure.ac b/configure.ac index 0beec7c..d59d6d6

[Spice-devel] [PATCH v4 4/5] glib: add local GL scanout support

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau Add spice-glib support for gl scanout messages. A note about SpiceGlScanout: it is struct with scanout details, registered as a boxed type, with associated gl-scanout property. That way, it doesn't need a seperate signal for change notification and the current scanout can

[Spice-devel] [PATCH v4 2/5] Add spice_channel_unix_read_fd()

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau Utility function used in the messages with socket ancillary fd. Signed-off-by: Marc-André Lureau --- src/spice-channel-priv.h | 3 +++ src/spice-channel.c | 68 2 files changed, 71 insertions(+) diff --git a/src/sp

[Spice-devel] [PATCH v4 5/5] gtk: add spice-widget GL scanout support

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with bare-egl doesn't seem trivial). Using GtkGLArea is left for a future series, since SpiceDisplay widget is a GtkDrawingArea and can

[Spice-devel] [PATCH v4 1/5] build-sys: bump to spice-protocol 0.12.11

2016-02-04 Thread Marc-André Lureau
Needed for GL messages Signed-off-by: Marc-André Lureau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 38db8b5..0beec7c 100644 --- a/configure.ac +++ b/configure.ac @@ -70,7 +70,7 @@ AC_CHECK_LIBM AC_SUBST(LIBM) AC_CONFI

[Spice-devel] [PATCH v4 0/5] Add OpenGL scanout drawing

2016-02-04 Thread Marc-André Lureau
The following series implements the x11 client-side support for local-only shared OpenGL scanout rendering. The implementation doesn't rely on gtkglarea since: - it's quite recent (3.16 while rhel7 is currently 3.14) - using gtkglarea isn't possible without either uncovenient API changes (new wi

Re: [Spice-devel] [PATCH v3 0/5] Add OpenGL scanout drawing

2016-02-04 Thread Marc-André Lureau
oops, something went wrong with the rebase, I'll resend. On Fri, Feb 5, 2016 at 12:29 AM, Marc-André Lureau wrote: > The following series implements the x11 client-side support for > local-only shared OpenGL scanout rendering. > > The implementation doesn't rely on gtkglarea since: > - it's quite

[Spice-devel] [PATCH v3 5/5] gtk: add spice-widget GL scanout support

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with bare-egl doesn't seem trivial). Using GtkGLArea is left for a future series, since SpiceDisplay widget is a GtkDrawingArea and can

[Spice-devel] [PATCH v3 2/5] Add spice_channel_unix_read_fd()

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau Utility function used in the messages with socket ancillary fd. Signed-off-by: Marc-André Lureau --- src/spice-channel-priv.h | 3 +++ src/spice-channel.c | 68 2 files changed, 71 insertions(+) diff --git a/src/sp

[Spice-devel] [PATCH v3 0/5] Add OpenGL scanout drawing

2016-02-04 Thread Marc-André Lureau
The following series implements the x11 client-side support for local-only shared OpenGL scanout rendering. The implementation doesn't rely on gtkglarea since: - it's quite recent (3.16 while rhel7 is currently 3.14) - using gtkglarea isn't possible without either uncovenient API changes (new wi

[Spice-devel] [PATCH v3 1/5] build-sys: bump to spice-protocol 0.12.11

2016-02-04 Thread Marc-André Lureau
Needed for GL messages Signed-off-by: Marc-André Lureau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 38db8b5..0beec7c 100644 --- a/configure.ac +++ b/configure.ac @@ -70,7 +70,7 @@ AC_CHECK_LIBM AC_SUBST(LIBM) AC_CONFI

[Spice-devel] [PATCH v3 4/5] glib: add local GL scanout support

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau Add spice-glib support for gl scanout messages. A note about SpiceGlScanout: it is struct with scanout details, registered as a boxed type, with associated gl-scanout property. That way, it doesn't need a seperate signal for change notification and the current scanout can

[Spice-devel] [PATCH v3 3/5] build-sys: check for epoxy-egl support

2016-02-04 Thread Marc-André Lureau
From: Marc-André Lureau The following code requires epoxy with egl support. Check for pkg-config and egl headers. Signed-off-by: Marc-André Lureau --- configure.ac | 25 + 1 file changed, 25 insertions(+) diff --git a/configure.ac b/configure.ac index 0beec7c..d59d6d6

Re: [Spice-devel] [PATCH v6 08/10] usbdk: Load hide rules for auto-redirected devices

2016-02-04 Thread Jonathon Jongsma
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote: > Hide rules order UsbDk to avoid showing specific USB > devices to Windows PnP manager. > > Spice-gtk loads hide rules for devices that should be > automatically redirected on connection to prevent Windows > from showing "New Hardware Foun

Re: [Spice-devel] [PATCH v6 07/10] win-usbredir: Only match USB devices by VID:PID when WinUsb used

2016-02-04 Thread Jonathon Jongsma
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote: > In other cases match devices by BUS:ADDR. > > Signed-off-by: Dmitry Fleytman > --- > src/usb-device-manager.c | 78 +-- > - > 1 file changed, 40 insertions(+), 38 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH v6 03/10] Add SpiceUsbDeviceManager parameter to device comparison functions

2016-02-04 Thread Jonathon Jongsma
It doesn't seem that these new parameters are used until patch #7, unless I missed something. So I'd re-order the patch series so that this comes right before it's used (or even merge them together?). Acked-by: Jonathon Jongsma On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote: > From: C

Re: [Spice-devel] [PATCH v6 05/10] win-usbredir: Introduce UsbDk wrapper

2016-02-04 Thread Jonathon Jongsma
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote: > From: Kirill Moizik > > Introduce UsbDk API definitions and binding code. I would appreciate a bit more justification in the commit log about why we're using this approach of dynamically loading and wrapping usbdk rather than linking to

Re: [Spice-devel] [PATCH 1/5] common: constify some declarations

2016-02-04 Thread Uri Lublin
On 01/27/2016 06:09 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- common/log.c| 2 +- common/marshaller.c | 7 +-- common/marshaller.h | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/common/log.c b/common/log.c index 607aa82..a9bbebc 100644

Re: [Spice-devel] [PATCH] channel: fix typo in comment

2016-02-04 Thread Victor Toso
On Thu, Feb 04, 2016 at 04:01:31PM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso > --- > server/red-channel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red-channel.c b/server/red-channel.c > index fdd85b9..4bc2faa 100

[Spice-devel] [PATCH] record: save real time during recording

2016-02-04 Thread Frediano Ziglio
Instead of using CPU time use a timer depending on real times. Currently that time in the record log is not used. However if we want to reproduce problems with stream would be useful to have real times instead. Signed-off-by: Frediano Ziglio --- server/red-worker.c | 4 ++-- 1 file changed, 2 in

Re: [Spice-devel] [PATCH] reds: constification

2016-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 04:03:10PM +, Frediano Ziglio wrote: > Make version_string a constant. > Also there is no need to have a pointer but declare the buffer as static > > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Spice-devel] [PATCH] reds: constification

2016-02-04 Thread Frediano Ziglio
Make version_string a constant. Also there is no need to have a pointer but declare the buffer as static Signed-off-by: Frediano Ziglio --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index edbdaad..4225847 100644 --- a/server/r

[Spice-devel] [PATCH] channel: fix typo in comment

2016-02-04 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/red-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-channel.c b/server/red-channel.c index fdd85b9..4bc2faa 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -1506,7 +1506,7 @@ static void red_channe

Re: [Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

2016-02-04 Thread Javier Celaya
Hi El 04/02/16 a las 15:12, Fabio Fantoni escribió: Il 04/02/2016 13:31, Javier Celaya ha scritto: This patch set adds support for dynamic resolution changes with the WDDM driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld with some improvements: - It detects both the XDDM

[Spice-devel] [PATCH 10/18] Remove use of global 'reds' from VDIReadBuf functions

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Add a new 'state' property to VDIReadBuf so that we can refer back to the VDIPortState struct from the readbuf functions. --- server/reds-private.h | 7 +-- server/reds.c | 35 +-- 2 files changed, 22 insertions(+), 20 deletions

[Spice-devel] [PATCH 14/18] spice_server_kbd_leds: don't use global 'reds'

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Store a reference to the RedsState server in the keyboard state struct --- server/inputs-channel.c | 14 +++--- server/inputs-channel.h | 1 + server/reds.c | 1 + 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/server/inputs-channel.c b

[Spice-devel] [PATCH 11/18] char-device: use local 'reds' variable

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Store a reference to the server in the SpiceCharDeviceState struct and use that rather than the global 'reds' variable --- server/char-device.c | 34 +++--- server/char-device.h | 1 + server/reds.c| 1 + server/smartcard.c | 1 + s

[Spice-devel] [PATCH 00/18] Backported some patches from refactory branches (4th Feb)

2016-02-04 Thread Frediano Ziglio
Changes: - merged some patches; - added other patches to list. Jonathon Jongsma (18): Change spice_server_set_ticket() to use local 'reds' spice_server_add_interface: use local 'reds' variable Store 'renderers' as GArray in RedsState Rename vdi_port_read_buf_get() to match convention Mov

[Spice-devel] [PATCH 03/18] Store 'renderers' as GArray in RedsState

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Acked-by: Frediano Ziglio --- server/display-channel.c | 13 +++-- server/display-channel.h | 3 +-- server/reds-private.h| 1 + server/reds.c| 22 +- server/reds.h| 5 ++--- 5 files changed, 24 insertions(+), 20

[Spice-devel] [PATCH 17/18] Add RedsState arg to spicevmc_device_connect|disconnect()

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/char-device.h | 6 -- server/reds.c| 8 server/spicevmc.c| 5 +++-- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/server/char-device.h b/server/char-device.h index a6315b0..3f81d13 100644 --- a/server/char-device.h +++

[Spice-devel] [PATCH 08/18] Add RedsState arg to reds_handle_channel_event()

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/main-dispatcher.c | 2 +- server/reds.c| 2 +- server/reds.h| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c index 132a693..777a44f 100644 --- a/server/main-dispatc

[Spice-devel] [PATCH 01/18] Change spice_server_set_ticket() to use local 'reds'

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Rather than using global 'reds' variable --- server/reds.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index edbdaad..60be869 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3581,13 +3581,11 @@ SPICE_GNUC_VISIBLE

[Spice-devel] [PATCH 13/18] RedsState: use local variables in more places

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Various functions were still using the global 'reds' variable rather than the local argument of type RedsState --- server/reds.c | 68 +-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/server/reds.c

[Spice-devel] [PATCH 18/18] Add RedsState arg to activate_modifiers_watch()

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/inputs-channel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/inputs-channel.c b/server/inputs-channel.c index 38b23df..f47a586 100644 --- a/server/inputs-channel.c +++ b/server/inputs-channel.c @@ -192,7 +192,7 @@ static void

[Spice-devel] [PATCH 07/18] Add RedsState member to RedLinkInfo

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma This allows us to use local 'reds' variables in all of the various async callbacks rather than using the global 'reds' variable. --- server/reds.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 7b884

[Spice-devel] [PATCH 06/18] Add RedsState arg to reds_init_client_[ssl_]connection()

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/reds.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/server/reds.c b/server/reds.c index 6467c7e..7b8848a 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2265,7 +2265,7 @@ static void reds_handle_ssl_accept(int fd, int even

[Spice-devel] [PATCH 12/18] Add reference to server in RedClient

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Allows client methods to not use global 'reds' variable --- server/red-channel.c | 5 +++-- server/red-channel.h | 3 ++- server/reds.c| 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 1ca85b1..

[Spice-devel] [PATCH 02/18] spice_server_add_interface: use local 'reds' variable

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Prefer local argument variable over global 'reds' variable --- server/reds.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index 60be869..4c2ac37 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3145,13 +3145,11 @

[Spice-devel] [PATCH 05/18] Move 'core' into RedsState struct

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Also add reds_get_core_interface() accessor for external use. --- server/char-device.c| 32 --- server/inputs-channel.c | 7 --- server/main-channel.c | 13 +++-- server/reds-private.h | 2 ++ server/reds-stream.c| 12 +

[Spice-devel] [PATCH 15/18] Store a reference to RedsState in RedsMigTargetClient

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma This allows RedsMigTargetClient methods to use local variables rather than the global 'reds' variable --- server/reds-private.h | 1 + server/reds.c | 12 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/server/reds-private.h b/server/re

[Spice-devel] [PATCH 09/18] Add RedsState arg to all stat functions

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/dcc-send.c| 6 +++--- server/display-channel.c | 12 ++-- server/main-channel.c| 2 +- server/red-channel.c | 4 ++-- server/red-worker.c | 12 ++-- server/reds.c| 22 +++--- server/reds.h

[Spice-devel] [PATCH 16/18] Add RedsState arg to red_on_main_agent_tokens()

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/main-channel.c | 2 +- server/reds.c | 2 +- server/reds.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/main-channel.c b/server/main-channel.c index a70c605..8b1d7d4 100644 --- a/server/main-channel.c +++ b/server

[Spice-devel] [PATCH 04/18] Rename vdi_port_read_buf_get() to match convention

2016-02-04 Thread Frediano Ziglio
From: Jonathon Jongsma Since this is technically a RedsState method, name it as such. --- server/reds.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index 4ad8b0f..bff64d6 100644 --- a/server/reds.c +++ b/server/reds.c @@ -174,7 +174,7

Re: [Spice-devel] [PATCH v3 8/9] Handle GL_DRAW messages

2016-02-04 Thread Frediano Ziglio
> > Create an async, and marshall the GL_DRAW message. Count number of > clients, and wait until gl_draw_async_count is 0 to complete the async. > The count is going to be updated in the following patch when the client > is done with the draw. > > Signed-off-by: Marc-André Lureau > --- > server

Re: [Spice-devel] [PATCH v3 5/9] Add new spice-gl stubs API

2016-02-04 Thread Frediano Ziglio
> > - spice_gl_scanout() to take the current scanout > > - spice_gl_draw_async() to draw the scanout, is like other Spice async > functions, it takes a cookie and will return in the > QXLInterface.async_complete() > > Two new fields are also added to QXLState, in order to save the current >

Re: [Spice-devel] [PATCH v3 8/9] Handle GL_DRAW messages

2016-02-04 Thread Frediano Ziglio
> > Create an async, and marshall the GL_DRAW message. Count number of > clients, and wait until gl_draw_async_count is 0 to complete the async. > The count is going to be updated in the following patch when the client > is done with the draw. > > Signed-off-by: Marc-André Lureau > --- > server

[Spice-devel] Add lz4 support in qemu parameters

2016-02-04 Thread Fabio Fantoni
Hi, lz4 support in qemu parameters is still missed. I'm actually using the patch posted long time ago by Javier Celaya with only the small version check fix (spice>=0.12.6 instead of >=0.12.7): https://github.com/Fantu/qemu/commit/e66e58053cea9f0aff71c9d9b8b822e40f5ba266 Tested and working. Origina

Re: [Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

2016-02-04 Thread Fabio Fantoni
Il 04/02/2016 13:31, Javier Celaya ha scritto: > This patch set adds support for dynamic resolution changes with the WDDM > driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld > with some improvements: > > - It detects both the XDDM driver and the WDDM driver, and uses the > co

[Spice-devel] [phodav PATCH 3/4] spice-webdavd: Alert when CreateFile fails

2016-02-04 Thread Lukas Venhoda
Shows alert on windows when CreateFile fails. This can happen, when webdavd is run without administrator privileges. --- spice/spice-webdavd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c index c8fb795..b3fd1ea 100644 --- a/sp

[Spice-devel] [phodav PATCH 1/4] spice-webdavd: Safer MDNS Unregister

2016-02-04 Thread Lukas Venhoda
Add error handling when unregistering folder from file explorer. Move unregistering to a function. --- Changes: - Split patch into 2 --- spice/spice-webdavd.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/spice/spice-webdavd.c b/spice/spice-webda

[Spice-devel] [phodav PATCH 2/4] spice-webdavd: Hide client folder when sharing disabled

2016-02-04 Thread Lukas Venhoda
After disabling sharing, remove client folder from file explorer. Show client folder again after sharing is re-enabled. --- Changes - Split patch into 2 --- spice/spice-webdavd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c index 68f3cf0..c8

[Spice-devel] [phodav PATCH 4/4] spice-webdavd: Option to run without service on Windows

2016-02-04 Thread Lukas Venhoda
Adds --no-service argument. This runs the program normally, instead of running as Windows service. --- spice/spice-webdavd.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c index b3fd1ea..f9c5cf1 100644 --- a/spice/spice

[Spice-devel] [phodav PATCH 0/4] phodav automounting pre-patch

2016-02-04 Thread Lukas Venhoda
Small bugs, that I found when working on windows shared folder auto mounting Theese patches were already ACKed by elmarco, but since the last one (the big one) wasn't ACKed, the patches weren't pushed. There's work to be done on automounting itself, but theese patches would just sit in the mailin

[Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

2016-02-04 Thread Javier Celaya
This patch set adds support for dynamic resolution changes with the WDDM driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld with some improvements: - It detects both the XDDM driver and the WDDM driver, and uses the correct API. - It detects if the client is trying to set the

[Spice-devel] [vd-agent-win32 2/2] Use CCD API to update the WDDM display modes.

2016-02-04 Thread Javier Celaya
When a new custom display mode is added, the current WDDM driver notifies a disconnection and reconnection of the virtual monitor to force Windows to update the display modes. This produces an ugly effect, keeping the screen black for up to some seconds and usually not repainting it afterwards. Th

[Spice-devel] [vd-agent-win32 1/2] Detect and use the new WDDM driver

2016-02-04 Thread Javier Celaya
When setting a new desktop resolution, detect whether the XDDM or the WDDM driver is loaded, and use the correct API. This patch is based on the one by Vadim Rozenfeld, with some improvements: - Valid for both the XDDM and the WDDM drivers. - Avoids flickering when the target resolution is the cur

Re: [Spice-devel] [PATCH 12/18] Move ssl_parameters to RedsState struct

2016-02-04 Thread Frediano Ziglio
> > From: Jonathon Jongsma > > Removing more global variables > --- > server/reds-private.h | 11 + > server/reds.c | 65 > ++- > 2 files changed, 39 insertions(+), 37 deletions(-) > > diff --git a/server/reds-private.h b/server/

Re: [Spice-devel] [PATCH v2] Move agent_mouse to RedsState struct

2016-02-04 Thread Pavel Grunt
On Wed, 2016-02-03 at 15:07 -0600, Jonathon Jongsma wrote: > Required adding a RedsState arg to reds_get_agent_mouse() Acked-by: Pavel Grunt > --- >  server/inputs-channel.c |  8 >  server/reds-private.h   |  2 ++ >  server/reds.c   | 10 +- >  server/reds.h   |  2

Re: [Spice-devel] [PATCH v2] Move streaming_video to RedsState struct

2016-02-04 Thread Pavel Grunt
On Wed, 2016-02-03 at 15:10 -0600, Jonathon Jongsma wrote: > Also requires adding reds_get_streaming_video() accessor so that > other > files can check this value. Acked-by: Pavel Grunt Thanks, Pavel > --- > >  - Changed back to assert > >  server/red-dispatcher.c | 7 --- >  server/red-wor

Re: [Spice-devel] [PATCH v2] Move agent_mouse to RedsState struct

2016-02-04 Thread Frediano Ziglio
> > Required adding a RedsState arg to reds_get_agent_mouse() > --- > server/inputs-channel.c | 8 > server/reds-private.h | 2 ++ > server/reds.c | 10 +- > server/reds.h | 2 +- > 4 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/serv

Re: [Spice-devel] [PATCH v2] Move streaming_video to RedsState struct

2016-02-04 Thread Frediano Ziglio
> > Also requires adding reds_get_streaming_video() accessor so that other > files can check this value. > --- > > - Changed back to assert > > server/red-dispatcher.c | 7 --- > server/red-worker.c | 2 +- > server/reds-private.h | 1 + > server/reds.c | 9 +++-- > ser