On Thu, 2016-02-04 at 16:10 +, Frediano Ziglio wrote:
> Instead of using CPU time use a timer depending on real times.
> Currently that time in the record log is not used.
> However if we want to reproduce problems with stream would be useful
> to have real times instead.
Yes, it makes sense
T
Hi, guys!
I couldn't find the updated patchset.
Francois said he has pushed to github, I tried to find it in
https://github.com/fgouget/
There were no related commits.
Can you, please, suggest the correct link?
Thanks.
On 02/05/2016 10:27 AM, Francois Gouget wrote:
On Thu, 28 Jan 2016, Pave
On Thu, 28 Jan 2016, Pavel Grunt wrote:
[...]
> I can provide a recording without the warning:
> http://people.freedesktop.org/~pgrunt/rhel6_gstreamer_record.spice.xz
>
> It seems that gstreamer has problem when the stream dimensions changes.
> I notice that before the server hangs the target-bitr
From: Marc-André Lureau
The following code requires epoxy with egl support. Check for pkg-config
and egl headers.
Signed-off-by: Marc-André Lureau
---
configure.ac | 25 +
1 file changed, 25 insertions(+)
diff --git a/configure.ac b/configure.ac
index 0beec7c..d59d6d6
From: Marc-André Lureau
Add spice-glib support for gl scanout messages.
A note about SpiceGlScanout: it is struct with scanout details,
registered as a boxed type, with associated gl-scanout property. That
way, it doesn't need a seperate signal for change notification and the
current scanout can
From: Marc-André Lureau
Utility function used in the messages with socket ancillary fd.
Signed-off-by: Marc-André Lureau
---
src/spice-channel-priv.h | 3 +++
src/spice-channel.c | 68
2 files changed, 71 insertions(+)
diff --git a/src/sp
From: Marc-André Lureau
Hook to spice-glib events to show the GL scanout.
The opengl context is created with egl, and is currently
x11-only (supporting wayland with bare-egl doesn't seem trivial).
Using GtkGLArea is left for a future series, since SpiceDisplay widget
is a GtkDrawingArea and can
Needed for GL messages
Signed-off-by: Marc-André Lureau
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 38db8b5..0beec7c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,7 +70,7 @@ AC_CHECK_LIBM
AC_SUBST(LIBM)
AC_CONFI
The following series implements the x11 client-side support for
local-only shared OpenGL scanout rendering.
The implementation doesn't rely on gtkglarea since:
- it's quite recent (3.16 while rhel7 is currently 3.14)
- using gtkglarea isn't possible without either uncovenient API
changes (new wi
oops, something went wrong with the rebase, I'll resend.
On Fri, Feb 5, 2016 at 12:29 AM, Marc-André Lureau
wrote:
> The following series implements the x11 client-side support for
> local-only shared OpenGL scanout rendering.
>
> The implementation doesn't rely on gtkglarea since:
> - it's quite
From: Marc-André Lureau
Hook to spice-glib events to show the GL scanout.
The opengl context is created with egl, and is currently
x11-only (supporting wayland with bare-egl doesn't seem trivial).
Using GtkGLArea is left for a future series, since SpiceDisplay widget
is a GtkDrawingArea and can
From: Marc-André Lureau
Utility function used in the messages with socket ancillary fd.
Signed-off-by: Marc-André Lureau
---
src/spice-channel-priv.h | 3 +++
src/spice-channel.c | 68
2 files changed, 71 insertions(+)
diff --git a/src/sp
The following series implements the x11 client-side support for
local-only shared OpenGL scanout rendering.
The implementation doesn't rely on gtkglarea since:
- it's quite recent (3.16 while rhel7 is currently 3.14)
- using gtkglarea isn't possible without either uncovenient API
changes (new wi
Needed for GL messages
Signed-off-by: Marc-André Lureau
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 38db8b5..0beec7c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,7 +70,7 @@ AC_CHECK_LIBM
AC_SUBST(LIBM)
AC_CONFI
From: Marc-André Lureau
Add spice-glib support for gl scanout messages.
A note about SpiceGlScanout: it is struct with scanout details,
registered as a boxed type, with associated gl-scanout property. That
way, it doesn't need a seperate signal for change notification and the
current scanout can
From: Marc-André Lureau
The following code requires epoxy with egl support. Check for pkg-config
and egl headers.
Signed-off-by: Marc-André Lureau
---
configure.ac | 25 +
1 file changed, 25 insertions(+)
diff --git a/configure.ac b/configure.ac
index 0beec7c..d59d6d6
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote:
> Hide rules order UsbDk to avoid showing specific USB
> devices to Windows PnP manager.
>
> Spice-gtk loads hide rules for devices that should be
> automatically redirected on connection to prevent Windows
> from showing "New Hardware Foun
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote:
> In other cases match devices by BUS:ADDR.
>
> Signed-off-by: Dmitry Fleytman
> ---
> src/usb-device-manager.c | 78 +--
> -
> 1 file changed, 40 insertions(+), 38 deletions(-)
>
> diff --git
It doesn't seem that these new parameters are used until patch #7, unless I
missed something. So I'd re-order the patch series so that this comes right
before it's used (or even merge them together?).
Acked-by: Jonathon Jongsma
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote:
> From: C
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote:
> From: Kirill Moizik
>
> Introduce UsbDk API definitions and binding code.
I would appreciate a bit more justification in the commit log about why we're
using this approach of dynamically loading and wrapping usbdk rather than
linking to
On 01/27/2016 06:09 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
common/log.c| 2 +-
common/marshaller.c | 7 +--
common/marshaller.h | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/common/log.c b/common/log.c
index 607aa82..a9bbebc 100644
On Thu, Feb 04, 2016 at 04:01:31PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> server/red-channel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/red-channel.c b/server/red-channel.c
> index fdd85b9..4bc2faa 100
Instead of using CPU time use a timer depending on real times.
Currently that time in the record log is not used.
However if we want to reproduce problems with stream would be useful
to have real times instead.
Signed-off-by: Frediano Ziglio
---
server/red-worker.c | 4 ++--
1 file changed, 2 in
On Thu, Feb 04, 2016 at 04:03:10PM +, Frediano Ziglio wrote:
> Make version_string a constant.
> Also there is no need to have a pointer but declare the buffer as static
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Make version_string a constant.
Also there is no need to have a pointer but declare the buffer as static
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index edbdaad..4225847 100644
--- a/server/r
Signed-off-by: Frediano Ziglio
---
server/red-channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-channel.c b/server/red-channel.c
index fdd85b9..4bc2faa 100644
--- a/server/red-channel.c
+++ b/server/red-channel.c
@@ -1506,7 +1506,7 @@ static void
red_channe
Hi
El 04/02/16 a las 15:12, Fabio Fantoni escribió:
Il 04/02/2016 13:31, Javier Celaya ha scritto:
This patch set adds support for dynamic resolution changes with the WDDM
driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld
with some improvements:
- It detects both the XDDM
From: Jonathon Jongsma
Add a new 'state' property to VDIReadBuf so that we can refer back to
the VDIPortState struct from the readbuf functions.
---
server/reds-private.h | 7 +--
server/reds.c | 35 +--
2 files changed, 22 insertions(+), 20 deletions
From: Jonathon Jongsma
Store a reference to the RedsState server in the keyboard state struct
---
server/inputs-channel.c | 14 +++---
server/inputs-channel.h | 1 +
server/reds.c | 1 +
3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/server/inputs-channel.c b
From: Jonathon Jongsma
Store a reference to the server in the SpiceCharDeviceState struct and
use that rather than the global 'reds' variable
---
server/char-device.c | 34 +++---
server/char-device.h | 1 +
server/reds.c| 1 +
server/smartcard.c | 1 +
s
Changes:
- merged some patches;
- added other patches to list.
Jonathon Jongsma (18):
Change spice_server_set_ticket() to use local 'reds'
spice_server_add_interface: use local 'reds' variable
Store 'renderers' as GArray in RedsState
Rename vdi_port_read_buf_get() to match convention
Mov
From: Jonathon Jongsma
Acked-by: Frediano Ziglio
---
server/display-channel.c | 13 +++--
server/display-channel.h | 3 +--
server/reds-private.h| 1 +
server/reds.c| 22 +-
server/reds.h| 5 ++---
5 files changed, 24 insertions(+), 20
From: Jonathon Jongsma
---
server/char-device.h | 6 --
server/reds.c| 8
server/spicevmc.c| 5 +++--
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/server/char-device.h b/server/char-device.h
index a6315b0..3f81d13 100644
--- a/server/char-device.h
+++
From: Jonathon Jongsma
---
server/main-dispatcher.c | 2 +-
server/reds.c| 2 +-
server/reds.h| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c
index 132a693..777a44f 100644
--- a/server/main-dispatc
From: Jonathon Jongsma
Rather than using global 'reds' variable
---
server/reds.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index edbdaad..60be869 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3581,13 +3581,11 @@ SPICE_GNUC_VISIBLE
From: Jonathon Jongsma
Various functions were still using the global 'reds' variable rather
than the local argument of type RedsState
---
server/reds.c | 68 +--
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git a/server/reds.c
From: Jonathon Jongsma
---
server/inputs-channel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/inputs-channel.c b/server/inputs-channel.c
index 38b23df..f47a586 100644
--- a/server/inputs-channel.c
+++ b/server/inputs-channel.c
@@ -192,7 +192,7 @@ static void
From: Jonathon Jongsma
This allows us to use local 'reds' variables in all of the various async
callbacks rather than using the global 'reds' variable.
---
server/reds.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 7b884
From: Jonathon Jongsma
---
server/reds.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 6467c7e..7b8848a 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2265,7 +2265,7 @@ static void reds_handle_ssl_accept(int fd, int even
From: Jonathon Jongsma
Allows client methods to not use global 'reds' variable
---
server/red-channel.c | 5 +++--
server/red-channel.h | 3 ++-
server/reds.c| 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/server/red-channel.c b/server/red-channel.c
index 1ca85b1..
From: Jonathon Jongsma
Prefer local argument variable over global 'reds' variable
---
server/reds.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 60be869..4c2ac37 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3145,13 +3145,11 @
From: Jonathon Jongsma
Also add reds_get_core_interface() accessor for external use.
---
server/char-device.c| 32 ---
server/inputs-channel.c | 7 ---
server/main-channel.c | 13 +++--
server/reds-private.h | 2 ++
server/reds-stream.c| 12 +
From: Jonathon Jongsma
This allows RedsMigTargetClient methods to use local variables rather
than the global 'reds' variable
---
server/reds-private.h | 1 +
server/reds.c | 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/server/reds-private.h b/server/re
From: Jonathon Jongsma
---
server/dcc-send.c| 6 +++---
server/display-channel.c | 12 ++--
server/main-channel.c| 2 +-
server/red-channel.c | 4 ++--
server/red-worker.c | 12 ++--
server/reds.c| 22 +++---
server/reds.h
From: Jonathon Jongsma
---
server/main-channel.c | 2 +-
server/reds.c | 2 +-
server/reds.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/main-channel.c b/server/main-channel.c
index a70c605..8b1d7d4 100644
--- a/server/main-channel.c
+++ b/server
From: Jonathon Jongsma
Since this is technically a RedsState method, name it as such.
---
server/reds.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 4ad8b0f..bff64d6 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -174,7 +174,7
>
> Create an async, and marshall the GL_DRAW message. Count number of
> clients, and wait until gl_draw_async_count is 0 to complete the async.
> The count is going to be updated in the following patch when the client
> is done with the draw.
>
> Signed-off-by: Marc-André Lureau
> ---
> server
>
> - spice_gl_scanout() to take the current scanout
>
> - spice_gl_draw_async() to draw the scanout, is like other Spice async
> functions, it takes a cookie and will return in the
> QXLInterface.async_complete()
>
> Two new fields are also added to QXLState, in order to save the current
>
>
> Create an async, and marshall the GL_DRAW message. Count number of
> clients, and wait until gl_draw_async_count is 0 to complete the async.
> The count is going to be updated in the following patch when the client
> is done with the draw.
>
> Signed-off-by: Marc-André Lureau
> ---
> server
Hi, lz4 support in qemu parameters is still missed.
I'm actually using the patch posted long time ago by Javier Celaya with
only the small version check fix (spice>=0.12.6 instead of >=0.12.7):
https://github.com/Fantu/qemu/commit/e66e58053cea9f0aff71c9d9b8b822e40f5ba266
Tested and working.
Origina
Il 04/02/2016 13:31, Javier Celaya ha scritto:
> This patch set adds support for dynamic resolution changes with the WDDM
> driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld
> with some improvements:
>
> - It detects both the XDDM driver and the WDDM driver, and uses the
> co
Shows alert on windows when CreateFile fails.
This can happen, when webdavd is run without administrator privileges.
---
spice/spice-webdavd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index c8fb795..b3fd1ea 100644
--- a/sp
Add error handling when unregistering folder from file explorer.
Move unregistering to a function.
---
Changes:
- Split patch into 2
---
spice/spice-webdavd.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/spice/spice-webdavd.c b/spice/spice-webda
After disabling sharing, remove client folder from file explorer.
Show client folder again after sharing is re-enabled.
---
Changes
- Split patch into 2
---
spice/spice-webdavd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index 68f3cf0..c8
Adds --no-service argument.
This runs the program normally, instead of running as Windows service.
---
spice/spice-webdavd.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index b3fd1ea..f9c5cf1 100644
--- a/spice/spice
Small bugs, that I found when working on windows shared folder auto mounting
Theese patches were already ACKed by elmarco, but since the last one
(the big one) wasn't ACKed, the patches weren't pushed.
There's work to be done on automounting itself, but theese patches would
just sit in the mailin
This patch set adds support for dynamic resolution changes with the WDDM
driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld
with some improvements:
- It detects both the XDDM driver and the WDDM driver, and uses the
correct API.
- It detects if the client is trying to set the
When a new custom display mode is added, the current WDDM driver notifies
a disconnection and reconnection of the virtual monitor to force Windows
to update the display modes. This produces an ugly effect, keeping the
screen black for up to some seconds and usually not repainting it
afterwards.
Th
When setting a new desktop resolution, detect whether the XDDM or the
WDDM driver is loaded, and use the correct API.
This patch is based on the one by Vadim Rozenfeld, with some
improvements:
- Valid for both the XDDM and the WDDM drivers.
- Avoids flickering when the target resolution is the cur
>
> From: Jonathon Jongsma
>
> Removing more global variables
> ---
> server/reds-private.h | 11 +
> server/reds.c | 65
> ++-
> 2 files changed, 39 insertions(+), 37 deletions(-)
>
> diff --git a/server/reds-private.h b/server/
On Wed, 2016-02-03 at 15:07 -0600, Jonathon Jongsma wrote:
> Required adding a RedsState arg to reds_get_agent_mouse()
Acked-by: Pavel Grunt
> ---
> server/inputs-channel.c | 8
> server/reds-private.h | 2 ++
> server/reds.c | 10 +-
> server/reds.h | 2
On Wed, 2016-02-03 at 15:10 -0600, Jonathon Jongsma wrote:
> Also requires adding reds_get_streaming_video() accessor so that
> other
> files can check this value.
Acked-by: Pavel Grunt
Thanks,
Pavel
> ---
>
> - Changed back to assert
>
> server/red-dispatcher.c | 7 ---
> server/red-wor
>
> Required adding a RedsState arg to reds_get_agent_mouse()
> ---
> server/inputs-channel.c | 8
> server/reds-private.h | 2 ++
> server/reds.c | 10 +-
> server/reds.h | 2 +-
> 4 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/serv
>
> Also requires adding reds_get_streaming_video() accessor so that other
> files can check this value.
> ---
>
> - Changed back to assert
>
> server/red-dispatcher.c | 7 ---
> server/red-worker.c | 2 +-
> server/reds-private.h | 1 +
> server/reds.c | 9 +++--
> ser
64 matches
Mail list logo