Re: [Spice-devel] [PATCH spice-gtk 1/3] Update spice-common

2015-12-07 Thread Fabiano Fidêncio
ACK the series! On Mon, Dec 7, 2015 at 6:14 PM, Marc-André Lureau wrote: > ping > > On Mon, Nov 30, 2015 at 11:06 PM, Marc-André Lureau > wrote: >> For new libcacard.h usage >> --- >> spice-common | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/spice-common b/spice-c

Re: [Spice-devel] Full featured (qxl compatible) spice web client released

2015-12-07 Thread Jeremy White
Hi Jose, I have spent a fair amount of time using this client and reviewing it, and I've got a number of comments for you. There are a range of minor technical issues; you've got a hiddeninput in your version that prevents use of a top strip of a window. Removing that fixes that easily. Similar

Re: [Spice-devel] [PATCH spice-gtk 1/3] Update spice-common

2015-12-07 Thread Marc-André Lureau
ping On Mon, Nov 30, 2015 at 11:06 PM, Marc-André Lureau wrote: > For new libcacard.h usage > --- > spice-common | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/spice-common b/spice-common > index 401801b..47122be 16 > --- a/spice-common > +++ b/spice-common > @@ -1

Re: [Spice-devel] RFC: Time functions in Spice

2015-12-07 Thread Francois Gouget
On Mon, 7 Dec 2015, Marc-André Lureau wrote: [...] > > So I propose to rename these functions to spice_nanosecond_time() and > > spice_millisecond_time() and to define both in utils.h. Would that be > > ok? > > Why not use g_get_monotonic_time() everywhere? I don't think spice needs > nanosecond a

Re: [Spice-devel] RFC: Time functions in Spice

2015-12-07 Thread Marc-André Lureau
Hi - Original Message - > > So the Spice server has a red_get_monotonic_time() function which, as is > the tradition, has a very similar name to a regular Glib function, > g_get_monotonic_time(), except that one returns the time in nanoseconds > and the other in microseconds and nothing i

Re: [Spice-devel] RFC: Time functions in Spice

2015-12-07 Thread Jonathon Jongsma
On Sun, 2015-12-06 at 21:00 +0100, Francois Gouget wrote: > So the Spice server has a red_get_monotonic_time() function which, as is > the tradition, has a very similar name to a regular Glib function, > g_get_monotonic_time(), except that one returns the time in nanoseconds > and the other in m