Re: [Spice-devel] [PATCH 00/12] Split patch 03

Hi - Original Message - > I ended up splitting up this patch (03/11) into far more separate patches > than > I thought I would. But as I started reviewing, I realized that there's a lot > of > different things going on in this commit. Hopefully it's easier to review > this > way -- I know

[Spice-devel] [PATCH 3.3/12] Fix warning due to unexpected pipe item type

From: Marc-André Lureau The specific item type that was not being handled was PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor channel, but the analogous item for the display channel is PIPE_ITEM_TYPE_INVAL_PALETTE_CACHE. Use this value instead. The exact warning follows:

[Spice-devel] [PATCH 3.6/12] common_channel_client_create -> common_channel_new_client

From: Marc-André Lureau Rename and re-order the initial arguments to make this function look and act more like a method of the CommonChannel class. Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 18 +- server/red_worker.c | 24 server

[Spice-devel] [PATCH 3.4/12] Remove unused parameter from cursor_channel_new()

From: Marc-André Lureau cursor_channel_new() is only called from one location, and always passes FALSE as the value for the 'migrate' paramater. In addition, this parameter is not used within the function. Remove it. Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 2 +- server/cu

[Spice-devel] [PATCH 3.9/12] Move pipe item enumerations out of red_worker.h

From: Marc-André Lureau Move the cursor-specific pipe item types to cursor-channel.h, and the display-specific types to red_worker.c. Only leave the common definitions in red_worker.h. This prepares for splitting the display channel into a separate file. Signed-off-by: Jonathon Jongsma --- ser

[Spice-devel] [PATCH 3.12/12] Various minor style changes to worker and cursor channel

From: Marc-André Lureau Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 30 +- server/red_worker.c | 7 --- 2 files changed, 21 insertions(+), 16 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index ecb49b2..9935c0

[Spice-devel] [PATCH 3.10/12] Remove a couple single-use static functions

From: Marc-André Lureau red_cursor_marshall_inval(), red_migrate_cursor() and on_new_cursor_channel() were short functions that were each only called from a single location, so there's no need for them to be separate functions. Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 9 +

[Spice-devel] [PATCH 3.1/12] Store QXLInstance in CursorItem

From: Marc-André Lureau Doing so allows us to remove the extra QXLInstance parameter from cursor_item_unref() and makes the code a bit cleaner. Also add cursor_item_ref(). Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 70 +++-- serve

[Spice-devel] [PATCH 3.5/12] Change red_marshall_verb() to accept a VerbItem

From: Marc-André Lureau Instead of passing a verb enumeration value, pass the verb pipe item Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 4 ++-- server/red_worker.c | 4 ++-- server/red_worker.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/

[Spice-devel] [PATCH 3.8/12] CursorChannel* arg in cursor_channel_client_new()

From: Marc-André Lureau Instead of passing a CommonChannel* argument, use CursorChannel* since this function is only valid for CursorChannels. Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 5 ++--- server/cursor-channel.h | 2 +- server/red_worker.c | 2 +- 3 files changed,

[Spice-devel] [PATCH 00/12] Split patch 03

I ended up splitting up this patch (03/11) into far more separate patches than I thought I would. But as I started reviewing, I realized that there's a lot of different things going on in this commit. Hopefully it's easier to review this way -- I know it helped me understand the patch much better.

[Spice-devel] [PATCH 3.2/12] Make cursor_channel_disconnect a CursorChannel method

From: Marc-André Lureau The first argument should be CursorChannel* rather than RedChannel* since it's essentially a CursorChannel method. Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 4 +++- server/cursor-channel.h | 2 +- server/red_worker.c | 2 +- 3 files changed, 5 in

[Spice-devel] [PATCH 3.7/12] __new_channel -> red_worker_new_channel()

From: Marc-André Lureau Rename and lightly refactor the function that creates new common channels for RedWorker (essentially Cursor and Display channels). Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 25 ++--- server/red_worker.c | 59 ++

[Spice-devel] [PATCH 3.11/12] Change some asserts to warnings

From: Marc-André Lureau Various changes in RedWorker and CursorChannel related to error and warning messages. Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 28 server/red_worker.c | 22 ++ server/red_worker.h | 1 - 3 fi

[Spice-devel] UsbDk 1.0.7 released

Hi All, The new version of UsbDk (1.0.7) was released. Most important changes since previous release: 1. Interoperability problems with some USB 2.0/3.0 host controllers fixed 2. 32-bit API DLL added to 64 bit MSI to support 32-bit clients running on 64-bit Windows 3. Binary trace collection sc

Re: [Spice-devel] [PATCH 11/11] worker: remove assertion on alloc_drawable

> > From: Marc-André Lureau > > There is no guarantee in the code that this can't be hit, so we should > cope with it (the condition can be reached easily by running the server > without waiting for blocked clients or pipe size) > > The following commit will attempt to address this. > --- > se

Re: [Spice-devel] [PATCH 07/11] server: move display_channel_client_new()

> > From: Marc-André Lureau > > --- > server/Makefile.am | 1 + > server/display-channel.c | 38 +++ > server/display-channel.h | 52 > +--- > server/red_worker.c | 37 +- >

Re: [Spice-devel] [PATCH 10/11] Replace now() with get_mononotonic_time()

> > From: Marc-André Lureau > > --- > server/Makefile.am | 1 - > server/display-channel.h | 5 + > server/red_channel.c | 16 > server/red_time.h| 32 > server/red_worker.c | 22 +++--- > server/uti

Re: [Spice-devel] [PATCH 09/11] utils: add red_get_monotonic_time()

On Thu, 2015-10-29 at 07:50 -0400, Frediano Ziglio wrote: > > > > From: Marc-André Lureau > > > > --- > > server/Makefile.am | 1 + > > server/red_worker.c | 18 -- > > server/utils.h | 32 > > 3 files changed, 37 insertions(+), 14 deletio

[Spice-devel] red_dispatcher: client disconnect hangs the server

Hi. I often get stucked on client disconnect on blocking read (recent git checkout): #0 0x7fb6049bd3bd in read () at ../sysdeps/unix/syscall-template.S:81 #1 0x7fb604efb1c4 in read (__nbytes=4, __buf=0x7fff4cf978a4, __fd=10) at /usr/include/x86_64-linux-gnu/bits/unistd.h:44 #2 read_sa

Re: [Spice-devel] [PATCH 01/11] FIXME hardcoded 58?

ACK On Thu, 2015-10-29 at 13:32 -0400, Frediano Ziglio wrote: > > > > On Thu, 2015-10-29 at 07:24 -0400, Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > > > --- > > > > server/red_worker.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > >

Re: [Spice-devel] [PATCH 01/11] FIXME hardcoded 58?

> > On Thu, 2015-10-29 at 07:24 -0400, Frediano Ziglio wrote: > > > > > > From: Marc-André Lureau > > > > > > --- > > > server/red_worker.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > > index c027fde..3aa05

Re: [Spice-devel] Full featured (qxl compatible) spice web client released

On 10/29/2015 06:38 AM, j...@eyeos.com wrote: > Hi, > > We are very glad to announce that today we have released under AGPL3 > license our full featured (audio, video, clipboard, qxl advanced > graphics, etc) spice web client. > > The github of the project: > > https://github.com/eyeos/spice-web

[Spice-devel] [PATCH v6 05/10] win-usbredir: Introduce UsbDk wrapper

From: Kirill Moizik Introduce UsbDk API definitions and binding code. Signed-off-by: Kirill Moizik --- src/Makefile.am | 2 + src/usbdk_api.c | 187 src/usbdk_api.h | 34 +++ 3 files changed, 223 insertions(+) create mode 100

[Spice-devel] [PATCH v5 09/13] usbredir: Disconnect USB device asynchronously

From: Kirill Moizik Signed-off-by: Kirill Moizik Signed-off-by: Dmitry Fleytman --- src/channel-usbredir.c | 36 +--- src/map-file | 1 + 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c i

[Spice-devel] [PATCH v5 12/13] UsbDeviceWidget: Use asynchronous disconnect API

From: Kirill Moizik Signed-off-by: Kirill Moizik Signed-off-by: Dmitry Fleytman --- src/usb-device-widget.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c index 29967d1..b807c83 100644 --- a/src/us

[Spice-devel] [PATCH v6 08/10] usbdk: Load hide rules for auto-redirected devices

Hide rules order UsbDk to avoid showing specific USB devices to Windows PnP manager. Spice-gtk loads hide rules for devices that should be automatically redirected on connection to prevent Windows from showing "New Hardware Found" wizard window for USB devices that do not have driver on the local

[Spice-devel] [PATCH v5 01/13] Usbredir channel: Introduce mutex for USB redirection

From: Kirill Moizik This commit introduces channel mutex to allow usage of channel objects in mutithreaded environments. This mutex will be used to protect non thread safe usbredir functions and data structures. Signed-off-by: Kirill Moizik Signed-off-by: Dmitry Fleytman --- src/channel-usbr

[Spice-devel] [PATCH v5 11/13] UsbDeviceWidget: Consider asynchronous redirection flows

From: Kirill Moizik Gray out redirection controls while there are asynchronous redirection flows in progress. Signed-off-by: Kirill Moizik Signed-off-by: Dmitry Fleytman --- src/usb-device-widget.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-

[Spice-devel] [PATCH v5 07/13] UsbDeviceManager: Implement asynchronous disconnect device flow

From: Kirill Moizik This commit introduces functions for asynchronous disconnection flows. Following commits will make use of those. Thread safety is ensured the same way it was done for connection flow in previous commits. Disconnect logic is protected by the same locks that protect connect/usb

[Spice-devel] [PATCH v5 13/13] UsbDeviceManager: Make synchronous disconnect method static

From: Dmitry Fleytman Synchronous disconnection is not a part of public interface anymore. Signed-off-by: Dmitry Fleytman --- src/map-file | 1 - src/usb-device-manager.c | 15 --- src/usb-device-manager.h | 3 --- 3 files changed, 8 insertions(+), 11 deletions(-) di

[Spice-devel] [PATCH v5 02/13] win-usb-dev: Track device redirection operations in progress

From: Kirill Moizik This commit introduces redirecting property of GUdevClient This property indicates when a redirection operation is in progress on a device. It's set back to FALSE once the device is fully redirected to the guest. Signed-off-by: Kirill Moizik Signed-off-by: Dmitry Fleytman

[Spice-devel] [PATCH v5 08/13] UsbDeviceManager: Track device disconnection operations in progress

From: Kirill Moizik During device disconnection, unwanted hotplug events may happen. We need to ignore those therefore we track disconnection operations in progress. See also comment to commit "Do not process USB hotplug events while redirection is in progress" that introduces corresponding filt

[Spice-devel] [PATCH v5 05/13] usbredir: Spawn a different thread for device redirection flow

From: Kirill Moizik On Windows when using usbdk, opening and closing USB device handle, i.e. calling libusb_open()/libusb_unref_device() can block for a few seconds (3-5 second more specifically on patch author's HW). libusb_open() is called by spice_usbredir_channel_open_device(). libusb_unref

[Spice-devel] [PATCH v6 10/10] win-usbredir: Use UsbDk backend when available

Signed-off-by: Dmitry Fleytman --- src/usb-device-manager.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 53820b4..f4e48eb 100644 --- a/src/usb-device-manager.c +++ b/src/usb-device-manager.c @@ -231,7 +231,8 @@ s

[Spice-devel] [PATCH v5 00/13] Make start and stop usb redirection asynchronous

Changes since v4: - changes and simplifications as suggested by Christophe - rebased to the latest master Changes since v3: - changes as suggested by Christophe - minor patch set reordering and beautifications Changes since v2: - remove spice_g_udev_handle_device_change api - cosmetic changes

[Spice-devel] [PATCH v6 03/10] Add SpiceUsbDeviceManager parameter to device comparison functions

From: Christophe Fergeau This additional parameter is currently unused, but this is in preparation for the next commits. --- src/usb-device-manager.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-

[Spice-devel] [PATCH v6 02/10] Simplify spice_usb_device_manager_device_to_libdev()

From: Christophe Fergeau The Windows-specific version duplicates some code from spice_usb_device_equal_libdev(), this commit switches to using that helper instead. --- src/usb-device-manager.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/usb-device-manager.c b/sr

[Spice-devel] [PATCH v6 00/10] Add support for UsbDk backend

Changes since v5: - fixed build without USB redirection - cosmetic changes and beautifications - rebased to the latest master Changes since v4: - minor fixes as suggested by Christophe Changes since v3: -fix commit author -fix "usbdk standalone fix" commit description -fix too long lines in usbdk

[Spice-devel] [PATCH v5 03/13] GUdevClient: Do not process USB hotplug events while redirection is in progress

From: Kirill Moizik USB redirection flow on Windows includes a number of reset requests issued to the port that hosts the device deing redirected. Each port reset emulates device removal and reinsertion and produces corresponding hotplug events and a number of device list updates on different le

[Spice-devel] [PATCH v6 06/10] win-usbredir: Introduce use_usbclerk flag

This flag will be used by future code to distinguish between WinUsb/UsbDk configuations. Currently this flag is not used and always set to TRUE. Future code will set its value properly and use it as needed. Signed-off-by: Dmitry Fleytman --- src/usb-device-manager.c | 4 1 file changed, 4

[Spice-devel] [PATCH v6 04/10] win-usbredir: Move installer interaction logic to separate functions

Signed-off-by: Dmitry Fleytman --- spice-common | 2 +- src/usb-device-manager.c | 108 --- 2 files changed, 66 insertions(+), 44 deletions(-) diff --git a/spice-common b/spice-common index f7ec855..2d054e0 16 --- a/spice-common +++ b

[Spice-devel] [PATCH v5 10/13] UsbDeviceWidget: Show info bar during redirection flows

From: Kirill Moizik Signed-off-by: Kirill Moizik Signed-off-by: Dmitry Fleytman --- src/map-file | 1 + src/usb-device-manager.c | 23 +++ src/usb-device-manager.h | 2 ++ src/usb-device-widget.c | 8 4 files changed, 34 insertions(+) diff --git a/

[Spice-devel] [PATCH v6 07/10] win-usbredir: Only match USB devices by VID:PID when WinUsb used

In other cases match devices by BUS:ADDR. Signed-off-by: Dmitry Fleytman --- src/usb-device-manager.c | 78 +--- 1 file changed, 40 insertions(+), 38 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 55533f9..dd55276

[Spice-devel] [PATCH v5 04/13] usbredir: Protect data accessed by asynchronous redirection flows

From: Kirill Moizik This commit adds locking to ensure thread safety required after start/stop redirection flows moved to separate threads. Signed-off-by: Kirill Moizik Signed-off-by: Dmitry Fleytman --- src/channel-usbredir.c | 6 ++ src/usb-device-manager.c | 12 ++-- 2 files

[Spice-devel] [PATCH v5 06/13] UsbDeviceManager: Track device redirection operations in progress

From: Kirill Moizik During device connection, unwanted hotplug events may happen. We need to ignore those therefore we track redirection operations in progress. See also comment to commit "Do not process USB hotplug events while redirection is in progress" that introduces corresponding filtering

[Spice-devel] [PATCH v6 09/10] win-usbredir: Do not use UsbClerk for non-WinUsb backends

Signed-off-by: Dmitry Fleytman --- src/usb-device-manager.c | 50 ++-- 1 file changed, 31 insertions(+), 19 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index d5fec8f..53820b4 100644 --- a/src/usb-device-manager.c +++ b

[Spice-devel] [PATCH v6 01/10] Simplify spice_usb_device_equal_libdev()

From: Christophe Fergeau The Windows-specific version duplicates some code from spice_usb_device_manager_libdev_match(), this commit switches to using that helper instead. --- src/usb-device-manager.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/usb-devic

Re: [Spice-devel] [PATCH 03/11] server: move some cursor code to cursor-channel.c

Hmm, the summary of this commit is almost identical to one that was just merged: worker: move some cursor code to cursor-channel.c server: move some cursor code to cursor-channel.c it's not clear what significance the difference between "worker" and "server" is, considering both patches are movin

Re: [Spice-devel] [PATCH v4 12/16] usbredir: Disconnect USB device asynchronously

> On 22 Sep 2015, at 19:17 PM, Christophe Fergeau wrote: > > On Sun, Aug 16, 2015 at 03:35:49PM +0300, Dmitry Fleytman wrote: >> From: Kirill Moizik >> >> Signed-off-by: Kirill Moizik >> Signed-off-by: Dmitry Fleytman >> --- >> src/channel-usbredir.c | 43

Re: [Spice-devel] [PATCH v4 11/16] UsbDevicemanager: Track device disconnection operations in progress

> On 23 Sep 2015, at 14:01 PM, Christophe Fergeau wrote: > > Please explain why you want to do that in the commit log (I guess same > explanation as in the commit adding this redirecting state, during > device disconnection, unwanted hotplug events may happen, which we need > to ignore?) Adding

Re: [Spice-devel] [PATCH v4 11/16] UsbDevicemanager: Track device disconnection operations in progress

> On 23 Sep 2015, at 14:01 PM, Christophe Fergeau wrote: > > Please explain why you want to do that in the commit log (I guess same > explanation as in the commit adding this redirecting state, during > device disconnection, unwanted hotplug events may happen, which we need > to ignore?) > > On

Re: [Spice-devel] [PATCH v4 09/16] UsbDeviceManager: Move more redirection specific logic under corresponding ifdef

> On 22 Sep 2015, at 19:14 PM, Christophe Fergeau wrote: > > What's happening if we don't do that ? warnings ? broken compilation ? Compilation problem with USB redirection disabled. This patch fixed an issue which was introduced by UsbDk backend series, I fixed that issue in corresponding pat

Re: [Spice-devel] [PATCH v4 08/16] UsbDevicemanager: Track device redirection operations in progress

> On 22 Sep 2015, at 19:14 PM, Christophe Fergeau wrote: > > On Sun, Aug 16, 2015 at 03:35:45PM +0300, Dmitry Fleytman wrote: >> From: Kirill Moizik >> >> Signed-off-by: Kirill Moizik >> Signed-off-by: Dmitry Fleytman >> --- >> src/usb-device-manager.c | 71 >> ++

Re: [Spice-devel] [PATCH v4 07/16] usbredir: Spawn a different thread for device redirection flow

> On 23 Sep 2015, at 15:08 PM, Christophe Fergeau wrote: > > On Sun, Aug 16, 2015 at 03:35:44PM +0300, Dmitry Fleytman wrote: >> From: Kirill Moizik mailto:kmoi...@redhat.com>> >> >> On Windows when using usbdk, opening and closing USB device handle, >> i.e. calling libusb_open()/libusb_unref_

Re: [Spice-devel] [PATCH v4 05/16] UsbDeviceManager: move existing code to a separate function

> On 22 Sep 2015, at 18:52 PM, Christophe Fergeau wrote: > > On Sun, Aug 16, 2015 at 03:35:42PM +0300, Dmitry Fleytman wrote: >> From: Kirill Moizik >> >> Signed-off-by: Kirill Moizik >> Signed-off-by: Dmitry Fleytman >> --- >> src/usb-device-manager.c | 58 >> +++--

Re: [Spice-devel] [PATCH v4 04/16] GUdevClient: Do not process USB hotplug events while redirection is in progress

--- Daynix Computing LTD Dmitry Fleytman, CTO Email: dmi...@daynix.com Phone: +972-54-2819481 Web: www.daynix.com > On 22 Sep 2015, at 18:52 PM, Christophe Fergeau wrote: > > On Sun, Aug 16, 2015 at 03:35:41PM +0

Re: [Spice-devel] [PATCH v4 01/16] UsbDeviceManager: Fix Windows build without USB redirection

On 22 Sep 2015, at 18:42 PM, Christophe Fergeau wrote: > > Maybe I applied these patches on top of a wrong commit, but I needed Hi Christophe, Not sure why this happened, I verified that the next version of patches (will be sent soon) rebased on master compiles successfully both with and witho

Re: [Spice-devel] [PATCH 01/11] FIXME hardcoded 58?

On Thu, 2015-10-29 at 07:24 -0400, Frediano Ziglio wrote: > > > > From: Marc-André Lureau > > > > --- > > server/red_worker.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > index c027fde..3aa05d8 100644 > > --- a/ser

Re: [Spice-devel] [PATCH 06/11] server: move some cursor code to cursor-channel.c

> > On 10/28/2015 06:07 PM, Frediano Ziglio wrote: > > > >> > >> From: Marc-André Lureau > >> > >> Also fix warning due to unexpected pipe item type > >> > >> The specific item type that was not being handled was > >> PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor > >> chan

Re: [Spice-devel] [PATCH 06/11] server: move some cursor code to cursor-channel.c

On 10/28/2015 06:07 PM, Frediano Ziglio wrote: From: Marc-André Lureau Also fix warning due to unexpected pipe item type The specific item type that was not being handled was PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor channel, but the analogous item for the displa

[Spice-devel] Full featured (qxl compatible) spice web client released

Hi, We are very glad to announce that today we have released under AGPL3 license our full featured (audio, video, clipboard, qxl advanced graphics, etc) spice web client. The github of the project: https://github.com/eyeos/spice-web-client [1] Comments are welcome! Links: -- [1]

Re: [Spice-devel] [PATCH 09/11] utils: add red_get_monotonic_time()

> > From: Marc-André Lureau > > --- > server/Makefile.am | 1 + > server/red_worker.c | 18 -- > server/utils.h | 32 > 3 files changed, 37 insertions(+), 14 deletions(-) > create mode 100644 server/utils.h > > diff --git a/server/Makef

Re: [Spice-devel] [PATCH 02/11] Move red_bitmap_utils.h->tmpl.c

> > From: Marc-André Lureau > > --- > server/Makefile.am | 2 +- > server/red_bitmap_utils.h | 157 > - > server/red_bitmap_utils_tmpl.c | 157 > + > server/red_worker.c| 6 +- >

Re: [Spice-devel] [PATCH 01/11] FIXME hardcoded 58?

> > From: Marc-André Lureau > > --- > server/red_worker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index c027fde..3aa05d8 100644 > --- a/server/red_worker.c > +++ b/server/red_worker.c > @@ -9802,7 +9802,7 @@ static v

[Spice-devel] [PATCH 08/11] tree: move that to a seperate unit

From: Marc-André Lureau --- server/Makefile.am | 2 + server/red_worker.c | 265 ++-- server/tree.c | 182 server/tree.h | 111 ++ 4 files changed, 305 insertions(+), 255 delet

[Spice-devel] [PATCH 11/11] worker: remove assertion on alloc_drawable

From: Marc-André Lureau There is no guarantee in the code that this can't be hit, so we should cope with it (the condition can be reached easily by running the server without waiting for blocked clients or pipe size) The following commit will attempt to address this. --- server/red_worker.c | 3

[Spice-devel] [PATCH 07/11] server: move display_channel_client_new()

From: Marc-André Lureau --- server/Makefile.am | 1 + server/display-channel.c | 38 +++ server/display-channel.h | 52 +--- server/red_worker.c | 37 +- 4 files changed, 89 in

[Spice-devel] [PATCH 09/11] utils: add red_get_monotonic_time()

From: Marc-André Lureau --- server/Makefile.am | 1 + server/red_worker.c | 18 -- server/utils.h | 32 3 files changed, 37 insertions(+), 14 deletions(-) create mode 100644 server/utils.h diff --git a/server/Makefile.am b/server/Makefile

[Spice-devel] [PATCH 06/11] server: make more of cursor private

From: Marc-André Lureau --- server/cursor-channel.c | 78 +++-- server/cursor-channel.h | 51 +++- server/red_channel.h| 2 ++ server/red_worker.c | 20 + server/red_worker.h | 1 + 5 files changed,

[Spice-devel] [PATCH 05/11] server: make cursor channel private

From: Marc-André Lureau --- server/cursor-channel.c | 25 - server/cursor-channel.h | 18 ++--- server/red_channel.c| 12 ++ server/red_channel.h| 6 +++ server/red_worker.c | 98 ++--- server/red_worker.h | 5 +++

[Spice-devel] [PATCH 04/11] server/red_worker: red_draw_qxl_drawable: protect from NULL dereference in case of buggy driver (or recording)

From: Alon Levy --- server/red_worker.c | 5 + 1 file changed, 5 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c index 9748e19..e28a3dc 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -3883,6 +3883,11 @@ static void red_draw_qxl_drawable(RedWorker *worker,

[Spice-devel] [PATCH 03/11] server: move some cursor code to cursor-channel.c

From: Marc-André Lureau Also fix warning due to unexpected pipe item type The specific item type that was not being handled was PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor channel, but the analogous item for the display channel is PIPE_ITEM_TYPE_INVAL_PALETTE_CACHE. Use

[Spice-devel] [PATCH 10/11] Replace now() with get_mononotonic_time()

From: Marc-André Lureau --- server/Makefile.am | 1 - server/display-channel.h | 5 + server/red_channel.c | 16 server/red_time.h| 32 server/red_worker.c | 22 +++--- server/utils.h | 2 ++

[Spice-devel] [PATCH 01/11] FIXME hardcoded 58?

From: Marc-André Lureau --- server/red_worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index c027fde..3aa05d8 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9802,7 +9802,7 @@ static void guest_set_client_capab

[Spice-devel] [PATCH 02/11] Move red_bitmap_utils.h->tmpl.c

From: Marc-André Lureau --- server/Makefile.am | 2 +- server/red_bitmap_utils.h | 157 - server/red_bitmap_utils_tmpl.c | 157 + server/red_worker.c| 6 +- 4 files changed, 161 inser

[Spice-devel] [PATCH 00/11] Backported some patches from refactory branches (29th Oct)

These patches are extracted from a branch intended to refactory spice-server. This patchset supersed last patchset. Changes: - rebased on upstream master; - removed merged patches; - partially merged cursor patches, removed some space changes and did some cleanup; - added some patches to the se

Re: [Spice-devel] [PATCH 05/11] worker: move some cursor code to cursor-channel.c

> > ACK. Two minor comments below. > > > On Tue, 2015-10-27 at 19:19 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Frediano Ziglio > > --- > > server/Makefile.am | 1 + > > server/cursor-channel.c | 464