Signed-off-by: Jeremy White
---
scripts/Xspice | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 52b1b16..a6913a8 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -61,6 +61,7 @@ parser.add_argument('--config', default='spiceqxl.xorg
Signed-off-by: Jeremy White
---
scripts/Xspice | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 33f02d1..644887c 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -90,9 +90,9 @@ parser.add_argument('--streaming
Signed-off-by: Jeremy White
---
scripts/Xspice | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index a6913a8..33f02d1 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -92,6 +92,7 @@ add_boolean('--ipv6-only')
parser.add_argument(
On Thu, 22 Oct 2015, Christophe Fergeau wrote:
> On Wed, Oct 14, 2015 at 05:32:03PM +0200, Francois Gouget wrote:
> > The Spice server administrator can specify the preferred encoder and
> > codec preferences to optimize for CPU or bandwidth usage. Preferences
> > are described in a semi-colon sep
While I fully support the effort to reduce unnecessary monitor config
messages, I have one potential concern about this patch. This patch
compares the current display configuration to the last sent
configuration. However, it's theoretically possible that the last sent
configuration may not have bee
When the guest recieves the monitor configuration message, it replies
(through spice-server) by destroying the primary surface, which makes
the SpiceDisplay disabled if its "resize-guest" property is used.
This change of the display state (disabled/enabled) leads to sending
a new monitor config mes
Hey,
On Mon, Oct 26, 2015 at 05:24:07PM +0200, Yedidyah Bar David wrote:
> On Mon, Oct 26, 2015 at 4:58 PM, Christophe Fergeau
> wrote:
> > On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote:
> >> Allow passing:
> >>
> >> DISPLAYED_VERSION (defaults to $VERSION): what's written t
Hi,
yes, actually it breaks also small checks using replay utility (I should
have caught before). Posted a patch. I think this came from the problem
how to handle worker <-> timeout/watch relationship. In the current code
it uses the queue attached to the worker using the thread identifier
(pthre
Timer queue is attached to current thread when created so it must be
created from the proper thread.
After worker initialization was moved to main thread the queue was
created in the wrong thread causing program to fail saying that
the queue is NULL.
Signed-off-by: Frediano Ziglio
---
server/red
This one has been pushed already, but in general, having more than a
shortlog for non-trivial patches would be nice.
Christophe
On Fri, Oct 23, 2015 at 01:13:31PM +0100, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 8 +++-
> 1 file changed, 3 insertions(
On Mon, 2015-10-26 at 10:47 +0100, Christophe Fergeau wrote:
> Hey,
>
> Is this still happening with latest git? I'm fairly sure I fixed
> these
> warnings a while ago, and that adding subdir-objects was not really
> needed.
Hmm, this actually happened when I attempted to rebuild a rhel6 package
On Mon, Oct 26, 2015 at 4:58 PM, Christophe Fergeau wrote:
> On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote:
>> Allow passing:
>>
>> DISPLAYED_VERSION (defaults to $VERSION): what's written to the
>> registry. This is what is shown to the user e.g. in the control panel.
>>
>> E
On Mon, Oct 26, 2015 at 07:01:11AM -0400, Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Also fix warning due to unexpected pipe item type
> >
> > The specific item type that was not being handled was
> > PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor
>
Hi Eduardo,
On Mon, 2015-10-26 at 10:34 -0200, Eduardo Lima (Etrunko) wrote:
> Hi Pavel,
>
> Couple of comments below.
>
> On 10/23/2015 01:25 PM, Pavel Grunt wrote:
> > When the guest recieves the monitor configuration message, it replies
> > (through spice-server) by destroying the primary sur
On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote:
> Allow passing:
>
> DISPLAYED_VERSION (defaults to $VERSION): what's written to the
> registry. This is what is shown to the user e.g. in the control panel.
>
> EXE_VERSION (defaults to -$VERSION): appended to installer filename
On Mon, Oct 26, 2015 at 10:41:41AM -0400, Lev Veyde wrote:
> We already have the conditional in place to have a different
> code/values for Spice and oVirt, so we see no reason why we can't use
> it in this case as well.
Because it's meant to deal with core differences between the spice and
ovirt
Hi Christophe,
We already have the conditional in place to have a different code/values for
Spice and oVirt, so we see no reason why we can't use it in this case as well.
Thanks in advance,
Lev Veyde.
- Original Message -
From: "Christophe Fergeau"
To: "Yedidyah Bar David"
Cc: "Lev Ve
On Thu, 22 Oct 2015, Christophe Fergeau wrote:
[...]
> > @@ -1136,6 +1157,13 @@ static int gst_encoder_encode_frame(VideoEncoder
> > *video_encoder,
> > if (rc == VIDEO_ENCODER_FRAME_ENCODE_DONE) {
> > rc = pull_compressed_buffer(encoder, video_buffer);
> > #ifdef DO_ZERO_COPY
> > +
On Thu, Oct 22, 2015 at 05:02:54PM +0200, Lukas Venhoda wrote:
> When checking, whether we use alpha channel, we need to compare color
> format with constant with the same byte order.
>
> When clearing alpha channel, we must clear in proper byte order.
Regarding cleanup of alpha channel, there is
On Thu, Oct 22, 2015 at 05:02:49PM +0200, Lukas Venhoda wrote:
> On LE machine, color order will always be ARGB.
> On BE machines color order will sometimes be ARGB and sometimes BGRA.
> (This is because surface is sometimes created using native byte order,
> and sometimes using the network byte or
Hey,
This series looks fine except for a few small questions. Would be great
if you could test these 16bpp code paths though.
Thanks,
Christophe
On Thu, Oct 22, 2015 at 05:02:46PM +0200, Lukas Venhoda wrote:
> When using image compression on BE client, the color order was wrong.
> (BGRA instead
On Mon, Oct 26, 2015 at 2:11 PM, Christophe Fergeau wrote:
> On Mon, Oct 26, 2015 at 10:59:08AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 10/26/2015 10:55 AM, Christophe Fergeau wrote:
>> > On Mon, Oct 26, 2015 at 10:49:47AM -0200, Eduardo Lima (Etrunko) wrote:
>> >> On 10/23/2015 10:19 AM, Chris
On Mon, Oct 26, 2015 at 10:59:08AM -0200, Eduardo Lima (Etrunko) wrote:
> On 10/26/2015 10:55 AM, Christophe Fergeau wrote:
> > On Mon, Oct 26, 2015 at 10:49:47AM -0200, Eduardo Lima (Etrunko) wrote:
> >> On 10/23/2015 10:19 AM, Christophe Fergeau wrote:
> >>> This commit also updates the spice-com
On 10/26/2015 10:55 AM, Christophe Fergeau wrote:
> On Mon, Oct 26, 2015 at 10:49:47AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 10/23/2015 10:19 AM, Christophe Fergeau wrote:
>>> This commit also updates the spice-common submodule
>>>
>>> Christophe Fergeau (7):
>>> Add marshaller test case
On 10/23/2015 11:46 AM, Christophe Fergeau wrote:
> ---
> usbredirparser/usbredirfilter.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/usbredirparser/usbredirfilter.h b/usbredirparser/usbredirfilter.h
> index f03fa7e..9e137b8 100644
> --- a/usbredirparser/usbredirf
On Mon, Oct 26, 2015 at 10:49:47AM -0200, Eduardo Lima (Etrunko) wrote:
> On 10/23/2015 10:19 AM, Christophe Fergeau wrote:
> > This commit also updates the spice-common submodule
> >
> > Christophe Fergeau (7):
> > Add marshaller test case
> > build-sys: Use ${PKG_CONFIG} rather than
On 10/23/2015 10:19 AM, Christophe Fergeau wrote:
> This commit also updates the spice-common submodule
>
> Christophe Fergeau (7):
> Add marshaller test case
> build-sys: Use ${PKG_CONFIG} rather than pkg-config
> build-sys: Rework SPICE_CHECK_* m4 macros
> build-sys: Add
On Thu, Oct 22, 2015 at 05:02:50PM +0200, Lukas Venhoda wrote:
> Fixes color order on PowerPC when using QUIC image compression.
> ---
> Changes since v2:
> Changes since v1:
> - No changes
> ---
> common/canvas_base.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
Hi Pavel,
Couple of comments below.
On 10/23/2015 01:25 PM, Pavel Grunt wrote:
> When the guest recieves the monitor configuration message, it replies
> (through spice-server) by destroying the primary surface, which makes
> the SpiceDisplay disabled if its "resize-guest" property is used.
> This
Hey, this patch breaks starting VMs through virsh for me:
$ virsh start win7-home-pr
erreur :Impossible de démarrer le domaine win7-home-pr
erreur :internal error: early end of file from monitor: possible problem:
((null):27254): Spice-ERROR **:
spice_timer_queue.c:226:spice_timer_queue_get_time
On Mon, Oct 26, 2015 at 06:48:38AM -0400, Frediano Ziglio wrote:
>
> >
> > On Fri, Oct 23, 2015 at 10:29:04AM -0400, Frediano Ziglio wrote:
> > > It would be much better to define a public structure like
> > >
> > > struct CursorChannel {
> > >CommonChannel common;
> > > };
> > >
> > > and
>
> From: Marc-André Lureau
>
> Also fix warning due to unexpected pipe item type
>
> The specific item type that was not being handled was
> PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor
> channel, but the analogous item for the display channel is
> PIPE_ITEM_TYPE_INVA
On Mon, Oct 26, 2015 at 12:39:44PM +0200, Yedidyah Bar David wrote:
> On Mon, Oct 26, 2015 at 10:57 AM, Christophe Fergeau
> wrote:
> > On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote:
> >> If you only object to the aesthetics, and not the principle, can you please
> >> state wh
>
> On Fri, Oct 23, 2015 at 10:29:04AM -0400, Frediano Ziglio wrote:
> > It would be much better to define a public structure like
> >
> > struct CursorChannel {
> >CommonChannel common;
> > };
> >
> > and a private one (in cursor-channel.c) like
> >
> > struct CursorChannel {
> >Commo
From: Lev Veyde
Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a
Signed-off-by: Lev Veyde
---
win-guest-tools.nsis | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
index 3db6ba3..8b52e26 100644
--- a/win-guest-tools.nsis
+++
On Mon, Oct 26, 2015 at 10:57 AM, Christophe Fergeau
wrote:
> On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote:
>> If you only object to the aesthetics, and not the principle, can you please
>> state what should be done to make it nice enough for you? Searching for
>> 'branding'
Allow passing:
DISPLAYED_VERSION (defaults to $VERSION): what's written to the
registry. This is what is shown to the user e.g. in the control panel.
EXE_VERSION (defaults to -$VERSION): appended to installer filename.
Not touching VERSION, which reflects the version of the installer's
source co
Allow 'make dist'.
Allow building the spice installer and building/installing the ovirt
installer.
Move VERSION maintenance from the nsis file to the Makefile.
Allow passing DISPLAYED_VERSION to make.
Allow passing MODE to make to choose between the two installers -
SPICE (default) or OVIRT.
S
On Mon, Oct 26, 2015 at 11:53 AM, Christophe Fergeau
wrote:
> On Sun, Oct 25, 2015 at 05:14:06PM +0200, Yedidyah Bar David wrote:
>> Allow passing:
>>
>> DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry
>>
>> EXE_VERSION (defaults to -$VERSION): appended to installer filena
On Fri, Oct 23, 2015 at 10:29:04AM -0400, Frediano Ziglio wrote:
> It would be much better to define a public structure like
>
> struct CursorChannel {
>CommonChannel common;
> };
>
> and a private one (in cursor-channel.c) like
>
> struct CursorChannel {
>CommonChannel common;
>...
On Sun, Oct 25, 2015 at 05:14:06PM +0200, Yedidyah Bar David wrote:
> Allow passing:
>
> DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry
>
> EXE_VERSION (defaults to -$VERSION): appended to installer filename
This still does not say what do they mean, why 2 different ver
Hey,
Is this still happening with latest git? I'm fairly sure I fixed these
warnings a while ago, and that adding subdir-objects was not really
needed.
On Fri, Oct 23, 2015 at 02:59:32PM -0500, Jonathon Jongsma wrote:
> Without this, newer versions of automake give a warning, and since
> -Werror
On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote:
> If you only object to the aesthetics, and not the principle, can you please
> state what should be done to make it nice enough for you? Searching for
> 'branding' in [1] does find a few tunables.
They seem to be for if you want
On Fri, Oct 23, 2015 at 9:59 PM, Jonathon Jongsma wrote:
> Without this, newer versions of automake give a warning, and since
> -Werror is set, this is treated as an error. This can result in build
> failures such as:
>
> automake: warnings are treated as errors
> common/Makefile.am:4: warning: so
44 matches
Mail list logo
