Signed-off-by: Jeremy White
---
display.js | 60 ++--
enums.js | 11 +++
spiceconn.js | 4
spicemsg.js | 23 +++
4 files changed, 76 insertions(+), 22 deletions(-)
diff --git a/display.js b/display.j
This helps video playback do a slightly better job of keeping up
in the browser. It's not a dramatic effect, but enough to start making
video playback almost tolerable.
Signed-off-by: Jeremy White
---
display.js | 67 ++--
enums.js |
Signed-off-by: Jeremy White
---
display.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/display.js b/display.js
index 814ada6..a749dae 100644
--- a/display.js
+++ b/display.js
@@ -469,11 +469,11 @@ SpiceDisplayConn.prototype.process_channel_message =
function(msg)
If the user prefers a specific compression algorithm, report it when
setting up the display channel.
---
gtk/channel-display.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/gtk/channel-display.c b/gtk/channel-display.c
index efe2259..5dd3f71 100644
--- a/gtk/channel-display.c
++
---
gtk/spice-option.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 958e03c..463a3e3 100644
--- a/gtk/spice-option.c
+++ b/gtk/spice-option.c
@@ -41,6 +41,7 @@ static gint cache_size = 0;
static gint glz_w
On Wed, Jun 03, 2015 at 04:22:35PM +0200, Cédric Bosdonnat wrote:
> Make sure that the password lenght is under the maximum lenght. If not
Nit-pick if you re-post, s/lenght/length/g or someone can fixup when
merging
> report it as an authentication failure with an adapted message.
> ---
> Diff
Make sure that the password lenght is under the maximum lenght. If not
report it as an authentication failure with an adapted message.
---
Diff to v3:
* Removed the checks on the server side and the corresponding code here
* Removed the new error code to reuse SPICE_CLIENT_ERROR_AUTH_NEEDS_
Don't allow setting a too long password.
---
Diff to v1: only kept the admin/user password setting check
server/reds.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index 6d70b68..5579109 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3503,6 +3503,8 @@
On Wed, May 27, 2015 at 03:17:18PM +0200, Christophe Fergeau wrote:
> ---
> Hey,
>
> As suggested by poma, it might be a good time to have a 0.16.0 release of
> spice-vdagent. Let me know what you think :)
Since I haven't heard objections, I'll move forward with this soon.
Christophe
pgpEhP2ai
Ping ?
Christophe
On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote:
> When it's built with gtk3, firefox plugin-container will use some
> LD_PRELOAD hack in order to be able to load the gtk2 flash plugin.
> However, this LD_PRELOAD'ed .so will cause gtk3 remote-viewer to crash
>
On Tue, Jun 02, 2015 at 06:04:57PM +0200, Javier Celaya wrote:
> El Martes, 2 de junio de 2015 14:26:58 Christophe Fergeau escribió:
> > I'd deal with the "preferred_compression >=
> > SPICE_IMAGE_COMPRESS_ENUM_END" case with a g_warn_if_fail() as
> > g_param_spec_enum should guarantee that you won
On Tue, Jun 02, 2015 at 05:54:18PM +0200, Javier Celaya wrote:
> El Martes, 2 de junio de 2015 14:25:23 usted escribió:
> > For what it's worth, once your enum is registered as a GEnum, you can do
> > something like gvir_config_genum_get_value
> > https://libvirt.org/git/?p=libvirt-glib.git;a=blob;
On Tue, Jun 02, 2015 at 06:26:09PM +0200, Javier Celaya wrote:
> El Martes, 2 de junio de 2015 14:33:35 Christophe Fergeau escribió:
> > My last remaining comment about this patch is that now the client can
> > force the server to use a given compression method. This is something
> > the server adm
This function could return a NULL pointer in case of handle not
present and in case of out of memory conditions however caller
function always returned EINVAL error hiding a possible ENOMEM.
This patch change the function to return the error instead to
be able to propagate the error instead of assu
qxl_bo structure has two reference counters, one in the GEM object and
another in the TTM object. The GEM object keep a counter to the TTM object
so when GEM counter reached zero the TTM counter (using qxl_bo_unref) was
decremented. The qxl object is fully freed (both GEM and TTM part are cleaned)
In qxlhw_handle_to_bo we incremented counters twice, one time for release object
and one for reloc_info.
In the main function however reloc_info references was drop much earlier than
release so keeping the pointer only on release is safe and make cleaning
process easier.
Signed-off-by: Frediano Zi
This set of patches mainly contains fix for some memory issues
using quite aggressively surfaces and other minor problems like
images going black after a while.
There are no code change from v1, changes:
- fix path prefix
- rebased on drm-next branch;
- add "drm/qxl" prefix on subject;
- add revie
Enable format string checks for qxl_io_log and remove resulting warnings
which could lead to memory errors on different platform or just printing
wrong information.
Signed-off-by: Frediano Ziglio
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/qxl/qxl_cmd.c | 2 +-
drivers/gpu/drm/qxl/qxl_disp
Free resources correctly if function fails
Signed-off-by: Frediano Ziglio
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/qxl/qxl_release.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_release.c
b/drivers/gpu/drm/qxl/qxl_release.c
index 6fd8
Is we are not able to get source bo object from handle we free
destination bo object and call cleanup code however destination
object was already inserted in reloc_info array (num_relocs was
already incremented) so on cleanup we free destination again.
Signed-off-by: Frediano Ziglio
Reviewed-by:
Only EBUSY error was handled. This could cause code to believe
reserve was successful while it failed.
Signed-off-by: Frediano Ziglio
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/qxl/qxl_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_cm
reloc_info[i] is not still initialized in the print statement.
Signed-off-by: Frediano Ziglio
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/qxl/qxl_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c
index
If the function fails reference counter to the object is not decremented
causing leaks.
This is hard to spot as it happens only on very low memory situations.
Signed-off-by: Frediano Ziglio
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/qxl/qxl_ioctl.c | 4 +++-
1 file changed, 3 insertions(+), 1
This function return handle to allocated release object which is an int.
Signed-off-by: Frediano Ziglio
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/qxl/qxl_release.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_release.c
b/drivers/gpu/drm/qxl/qxl
If objects are moved back from system memory to VRAM (and spice id
created again) memory is already initialized so we need to set flag
to not clear memory.
If you don't do it after a while using desktop many images turns to
black or transparents.
Signed-off-by: Frediano Ziglio
Reviewed-by: Dave A
PipeInputStream and PipeOutputStream should not fail when creating
GPollableStream source as this currently does not work with default
write_all and read_all functions;
In order to avoid creating zombie GSource in create_source of both
PipeInputStream and PipeOutputStream, we track all created GSo
> +if (self->sources == NULL)
> +return;
I forgot to remove this in both functions :(
Oh well..
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
PipeInputStream and PipeOutputStream should not fail when creating
GPollableStream source as this currently does not work with default
write_all and read_all functions;
In order to avoid creating zombie GSource in create_source of both
PipeInputStream and PipeOutputStream, we track all created GSo
Hi,
> > +static GList *
> > +set_all_sources_ready (GList *sources)
> > +{
> > +GList *it = sources;
> > +while (it != NULL) {
> > +GSource *s = it->data;
> > +GList *next = it->next;
> > +
> > +if (s == NULL || g_source_is_destroyed(s)) {
> > +/* remove
29 matches
Mail list logo
