On Tue, Jun 02, 2015 at 06:04:57PM +0200, Javier Celaya wrote: > El Martes, 2 de junio de 2015 14:26:58 Christophe Fergeau escribió: > > I'd deal with the "preferred_compression >= > > SPICE_IMAGE_COMPRESS_ENUM_END" case with a g_warn_if_fail() as > > g_param_spec_enum should guarantee that you won't get a value not > > covered by the registered GEnum. > > > > Christophe > > Then I shouldn't check it at all... After all, there is no check for the > other two properties > in that function (cache-size and glz-window-size). I would rather remove the > "preferred_compression < SPICE_IMAGE_COMPRESS_ENUM_END" condition.--
Sure, fine with me. Christophe
pgpYGL8jHtJMh.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
