Marc-André,
It seems that my mail client butchered my response to you so that it was hard
to see my in-line comments. I thought I would re-post a cleaned-up version:
> It was discussed several time in the past, last I remember the issue is
> mainly with Windows guests,
> There are some hints t
- Original Message -
> PipeInputStream and PipeOutputStream should not fail when creating
> GPollableStream source as this currently does not work with default
> write_all and read_all functions;
>
> In order to avoid creating zombie GSource in create_source of both
> PipeInputStream and
PipeInputStream and PipeOutputStream should not fail when creating
GPollableStream source as this currently does not work with default
write_all and read_all functions;
In order to avoid creating zombie GSource in create_source of both
PipeInputStream and PipeOutputStream, we track all created GSo
- Original Message -
> On Tue, Jun 02, 2015 at 12:32:40PM -0400, Marc-André Lureau wrote:
> > - Original Message -
> > > Hey, thanks for the quick review!
> > >
> > > > > static void
> > > > > +set_all_sources_ready (GList *sources)
> > > > > +{
> > > > > +GList *it;
> > > >
On Tue, Jun 02, 2015 at 12:32:40PM -0400, Marc-André Lureau wrote:
> - Original Message -
> > Hey, thanks for the quick review!
> >
> > > > static void
> > > > +set_all_sources_ready (GList *sources)
> > > > +{
> > > > +GList *it;
> > > > +for (it = sources; it != NULL; it = it->n
- Original Message -
> Hey, thanks for the quick review!
>
> > > static void
> > > +set_all_sources_ready (GList *sources)
> > > +{
> > > +GList *it;
> > > +for (it = sources; it != NULL; it = it->next) {
> > > +GSource *s = it->data;
> > > +if (s != NULL && !g_s
Hey, thanks for the quick review!
> > static void
> > +set_all_sources_ready (GList *sources)
> > +{
> > +GList *it;
> > +for (it = sources; it != NULL; it = it->next) {
> > +GSource *s = it->data;
> > +if (s != NULL && !g_source_is_destroyed(s))
> > +g_source_
El Martes, 2 de junio de 2015 14:33:35 Christophe Fergeau escribió:
> My last remaining comment about this patch is that now the client can
> force the server to use a given compression method. This is something
> the server admin might not want to allow (think "too expensive
> compression methods)
On Tue, Jun 2, 2015 at 6:00 PM, Victor Toso wrote:
> PipeInputStream and PipeOutputStream should not fail when creating
> GPollableStream source as this currently does not work with default
> write_all and read_all functions;
>
> This patch removes the g_return_val_if_fail but keeps a g_debug in
El Martes, 2 de junio de 2015 14:26:58 Christophe Fergeau escribió:
> I'd deal with the "preferred_compression >=
> SPICE_IMAGE_COMPRESS_ENUM_END" case with a g_warn_if_fail() as
> g_param_spec_enum should guarantee that you won't get a value not
> covered by the registered GEnum.
>
> Christophe
hi
- Original Message -
> Disabling the proxy avoids usage of GProxyResolver to determine
> the necessary proxy protocol and to do the proxy negotiation.
> ---
> gtk/spice-session.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gtk/spice-session.c b/gtk/spice-s
Previous: http://lists.freedesktop.org/archives/spice-devel/2015-May/019939.html
changes from v3:
- track all GSource that is created and dispatch them when possible
- add test to check for zombie GSource
Victor Toso (6):
giopipe: don't fail on create_source
webdav: write all buffer to client
Using g_pollable_input_stream_create_source to generage several dummy
GSources in order to check if giopipe sets all of them to be dispatched.
This test check for zombie GSources during a write_all/read_chunk
operation.
---
tests/pipe.c | 106 ++
Both functions are basic the same so let's keep the generic one.
---
tests/pipe.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/tests/pipe.c b/tests/pipe.c
index 841cb77..ec11b6f 100644
--- a/tests/pipe.c
+++ b/tests/pipe.c
@@ -160,26 +160,12 @@ test_pipe_
Concurrent write is not supported and should fail. The GIO error is
G_IO_ERROR_PENDING
---
tests/pipe.c | 45 +
1 file changed, 45 insertions(+)
diff --git a/tests/pipe.c b/tests/pipe.c
index e4757b6..a0ddde4 100644
--- a/tests/pipe.c
+++ b/tests/pipe.c
PipeInputStream and PipeOutputStream should not fail when creating
GPollableStream source as this currently does not work with default
write_all and read_all functions;
This patch removes the g_return_val_if_fail but keeps a g_debug in order
to track problems;
In order to avoid creating zombie GS
---
tests/pipe.c | 75
1 file changed, 75 insertions(+)
diff --git a/tests/pipe.c b/tests/pipe.c
index ec11b6f..e4757b6 100644
--- a/tests/pipe.c
+++ b/tests/pipe.c
@@ -16,6 +16,10 @@ typedef struct _Fixture {
GOutputStream *op2;
Client's webdav can request less data (8192) then the amount sent by
guest's webdav. Using g_output_stream_write_all_async in order to avoid
losing data.
---
gtk/channel-webdav.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/gtk/channel-webdav.c b/
El Martes, 2 de junio de 2015 14:25:23 usted escribió:
> For what it's worth, once your enum is registered as a GEnum, you can do
> something like gvir_config_genum_get_value
> https://libvirt.org/git/?p=libvirt-glib.git;a=blob;f=libvirt-gconfig/libvirt
> -gconfig-
helpers.c;h=0314a72fd5dfcf8e47df3
Disabling the proxy avoids usage of GProxyResolver to determine
the necessary proxy protocol and to do the proxy negotiation.
---
gtk/spice-session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index f85e5c1..778d82a 100644
--- a/gt
My last remaining comment about this patch is that now the client can
force the server to use a given compression method. This is something
the server admin might not want to allow (think "too expensive
compression methods).
Maybe image_compression should default to SPICE_IMAGE_COMPRESS_DEFAULT
rat
On Mon, Jun 01, 2015 at 04:48:48PM +0200, Javier Celaya wrote:
> If the user prefers a specific compression algorithm, report it when
> setting up the display channel.
> ---
> gtk/channel-display.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/gtk/channel-display.c b/gtk/
You could change the "cmdline" in the subject.
On Mon, Jun 01, 2015 at 04:48:47PM +0200, Javier Celaya wrote:
> ---
> gtk/spice-option.c | 37 +
> 1 file changed, 37 insertions(+)
>
> diff --git a/gtk/spice-option.c b/gtk/spice-option.c
> index 958e03c..463a3e
On Tue, 2 Jun 2015, Fabio Fantoni wrote:
[...]
> Video on youtube,
Does it look like the video moves back and forth? Or maybe just the
progress bar area, with some shearing too. That's a known issue caused
by the progress bar popping up and down.
> hd trailer (file) with vlc (without vp8 works
On Thu, May 28, 2015 at 01:24:03PM +0300, Kirill Moizik wrote:
> From: Dmitry Fleytman
>
> add UsbDkDataHider.h UsbDkHelperHider.h usbdk_api.h usbdk_api.c files
> to allow hide devices according auto redirect rule functionality
>
> Signed-off-by: Kirill Moizik
> Signed-off-by: Dmitry Fleytman
On Mon, Jun 01, 2015 at 11:47:40AM -0500, Jonathon Jongsma wrote:
> On Thu, 2015-05-28 at 13:24 +0300, Kirill Moizik wrote:
> > From: Dmitry Fleytman
> >
> > add UsbDkDataHider.h UsbDkHelperHider.h usbdk_api.h usbdk_api.c files
> > to allow hide devices according auto redirect rule functionality
Il 02/06/2015 01:57, Francois Gouget ha scritto:
> On Mon, 1 Jun 2015, Fabio Fantoni wrote:
> [...]
>> I suppose that these warning I saw on client are related:
>> http://pastebin.com/GeTPyscG
>>> 0:00:00.150227452 27501 0x29f98f0 WARNvideodecoder
>>> gstvideodecoder.c:2026:gst_vid
27 matches
Mail list logo
