El Martes, 2 de junio de 2015 14:33:35 Christophe Fergeau escribió: > My last remaining comment about this patch is that now the client can > force the server to use a given compression method. This is something > the server admin might not want to allow (think "too expensive > compression methods). > Maybe image_compression should default to SPICE_IMAGE_COMPRESS_DEFAULT > rather than _AUTO_GLZ, and we should only allow > display_channel_handle_preferred_compression() to override > COMPRESS_DEFAULT, but not other values? > > Christophe
I see. However, currently, QEMU always sets image_compression to the one it gets from command-line or _AUTO_GLZ by default. There is no way to know from within spice-server whether the admin specified an image compression method or not, without patching QEMU too. You may want to delay this patch until we come up with a better solution. [1] [2] *Javier Celaya * /Software Engineer / [3] j[4]_avier.celaya@flexvdi.com_ [5] +34 976 512 433 [6] @j_celaya -------- [1] http://www.flexvdi.com/img/general/logo.flexvdi.png [2] http://flexvdi.com [3] http://flexvdi.com/signature/mail.png [4] mailto:javier.cel...@flexvdi.com [5] http://flexvdi.com/signature/phone.png [6] http://flexvdi.com/signature/skype.png
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
