[Spice-devel] [PATCH v2] Provide support for using the passthru smartcard mode in libcacard.

2015-01-21 Thread Jeremy White
Add an optional args parameter to the --spice-smartcard which will be passed to vcard_emul_options. This allows us to deprecate the --smartcard-db and --smartcard-certificates options as well. Signed-off-by: Jeremy White --- gtk/smartcard-manager.c | 14 ++ gtk/spice-option.c

Re: [Spice-devel] [PATCH 2/2] Fix LZ4 supported image formats.

2015-01-21 Thread Christophe Fergeau
Hey, On Thu, Jan 15, 2015 at 12:50:45PM +0100, Javier Celaya wrote: > - Read the original image format from the LZ4 stream. Only RGB formats > are supported. > - Expand 24bit to 32bit image format. This one would also have deserved to be split in several commits. > --- > common/canvas_base.c

Re: [Spice-devel] [PATCH 1/2] Fix LZ4 output buffer size.

2015-01-21 Thread Christophe Fergeau
ACK. On Thu, Jan 15, 2015 at 12:50:44PM +0100, Javier Celaya wrote: > --- > common/canvas_base.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/common/canvas_base.c b/common/canvas_base.c > index ddcbe32..bb7a424 100644 > --- a/common/canvas_base.c > +++ b/common/

Re: [Spice-devel] [PATCH] Fix LZ4 supported image formats.

2015-01-21 Thread Christophe Fergeau
Hey, Sorry for the late review... On Thu, Jan 15, 2015 at 12:50:21PM +0100, Javier Celaya wrote: > This patch limits the LZ4 algorithm to RGB formats. Other formats are > compressed with LZ. It also sends the top_down flag and the original > format to the client, so that it can create the right k

[Spice-devel] [PATCH spice] reds: increase listening socket backlog

2015-01-21 Thread Marc-André Lureau
With TCP socket, the backlog doesn't seem to be such an important value, perhaps because of latency or underlying protocol behaviour. However, on UNIX socket, it is fairly easy to reach the backlog limit and the client will get an EAGAIN error (not ECONNREFUSED as stated in listen(7)) that is not e

Re: [Spice-devel] [PATCH] Provide support for using the passthru smartcard mode in libcacard.

2015-01-21 Thread Jeremy White
> I would be really tempted to have an alias in libcacard for passthru = > "hw=yes hw_type=passthru" > Also adding an error message for invalid values and reporting that in > spice-gtk. Yeah, that seems like a good idea. > > But since I am not sure what the original design goal of libcacard op

Re: [Spice-devel] problem of endian process of glib

2015-01-21 Thread Christophe Fergeau
Hey, On Wed, Jan 21, 2015 at 02:47:42PM +0800, jiangdahui wrote: > Hi all: > we are trying to run spice client on 32-bit sparc CPU machine > which is big-endian, and the spice server is run on 64-bit x84 CPU > machine which is small-endian, I tried to do some modifying on > client