- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:18 PM
> Subject: [Spice-devel] [PATCH spice-gtk 13/14] usb: do not return GError on
> programmer pre-condition checks
>
> Use regular g_warn/g_return precondition
ACK
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:17 PM
> Subject: [Spice-devel] [PATCH spice-gtk 12/14] win-usb: remove useless
> function
>
> ---
> gtk/win-usb-driver-install.c | 11 ++-
> 1 fi
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:16 PM
> Subject: [Spice-devel] [PATCH spice-gtk 11/14] usb: call
> win_usb_driver_new() during initable_init()
>
> Throw an error when initialization failed.
>
ACK
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:15 PM
> Subject: [Spice-devel] [PATCH spice-gtk 10/14] usb: use SPICE_CLIENT_ERROR_
> prefix
>
> To be consistent with GLib idioms, the code should use a commo
ACK
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:14 PM
> Subject: [Spice-devel] [PATCH spice-gtk 09/14] usb: remove useless assignment
>
> The struct is g_new0() already.
> ---
> gtk/usb-device-manager.c | 3 --
Hm, I agree that the existing code does look very suspicious, but in general I
think that ensuring that a ref is held for the duration of the async operation
is probably a good idea. From a very cursory investigation it looks like the
spice_usb_device_manager_remove_dev() call path could be pro
ACK
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:12 PM
> Subject: [Spice-devel] [PATCH spice-gtk 07/14] win-usb: get rid of status
> code return in async ops
>
> ---
> gtk/usb-device-manager.c | 17 ++-
ACK
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:10 PM
> Subject: [Spice-devel] [PATCH spice-gtk 05/14] usb: use win-usb
> uninstall_finish()
>
> ---
> gtk/usb-device-manager.c | 55
> ++
This patch is so small and doesn't do anything on its own, so I'd prefer to
just fold it into the next one.
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:09 PM
> Subject: [Spice-devel] [PATCH spice-gtk 04/14] win
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:08 PM
> Subject: [Spice-devel] [PATCH spice-gtk 03/14] win-usb: rename async
> functions
>
> ---
> gtk/usb-device-manager.c | 14 ++
> gtk/win-usb
Looks fine, ACK. But can you please use the git commit message to explain
*why* you're making the change. Is it necessary for some future refactoring?
Is it just cleanup? etc. I suppose it'll become more obvious as I review later
patches, but it saves a little headscratching if the justificati
ACK
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:06 PM
> Subject: [Spice-devel] [PATCH spice-gtk 01/14] usb: remove useless
> declaration
>
> ---
> gtk/usb-device-manager.c | 8
> 1 file changed, 8
Throw an error when initialization failed.
---
gtk/spice-client.h | 2 ++
gtk/usb-device-manager.c | 27 ++-
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/gtk/spice-client.h b/gtk/spice-client.h
index e734cca..39765db 100644
--- a/gtk/spice-client.h
Fail early during initialization if the usbclerk service can't be
reached.
---
gtk/usb-device-manager.c | 8 ++
gtk/win-usb-driver-install.c | 66 +++-
gtk/win-usb-driver-install.h | 2 +-
3 files changed, 44 insertions(+), 32 deletions(-)
diff --
Use regular g_warn/g_return precondition checks.
Do not fail on errors that can be ignored, but warn instead.
---
gtk/usb-device-manager.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 81e3c80..ec19564
---
gtk/usb-device-manager.c | 14 ++
gtk/win-usb-driver-install.c | 22 +++---
gtk/win-usb-driver-install.h | 22 ++
3 files changed, 27 insertions(+), 31 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 885a0
A code doing an unref() on an object just before manipulating it looks
horribly suspicious...
---
gtk/usb-device-manager.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index a505c19..af993aa 100644
--- a/gtk/usb-devi
To be consistent with GLib idioms, the code should use a common prefix for
errors.
---
gtk/channel-usbredir.c | 4 ++--
gtk/spice-client.h | 11 +--
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c
index 239fe12..64487b3
---
gtk/win-usb-driver-install.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/gtk/win-usb-driver-install.c b/gtk/win-usb-driver-install.c
index c3a7ace..f28621f 100644
--- a/gtk/win-usb-driver-install.c
+++ b/gtk/win-usb-driver-install.c
@@ -175,6 +175,15 @@ void win_usb_driver_han
The struct is g_new0() already.
---
gtk/usb-device-manager.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index af993aa..c87efd5 100644
--- a/gtk/usb-device-manager.c
+++ b/gtk/usb-device-manager.c
@@ -1565,9 +1565,6 @@ void
spice_usb_d
---
gtk/win-usb-driver-install.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/gtk/win-usb-driver-install.c b/gtk/win-usb-driver-install.c
index 8cca854..bb18ae4 100644
--- a/gtk/win-usb-driver-install.c
+++ b/gtk/win-usb-driver-install.c
@@ -61,20 +61,13 @@ stati
---
gtk/usb-device-manager.c | 17 ++---
gtk/win-usb-driver-install.c | 10 +-
gtk/win-usb-driver-install.h | 8
3 files changed, 11 insertions(+), 24 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 147026c..a505c19 100644
---
---
gtk/win-usb-driver-install.c | 7 +++
gtk/win-usb-driver-install.h | 4
2 files changed, 11 insertions(+)
diff --git a/gtk/win-usb-driver-install.c b/gtk/win-usb-driver-install.c
index bdc2372..c3a7ace 100644
--- a/gtk/win-usb-driver-install.c
+++ b/gtk/win-usb-driver-install.c
@@ -3
---
gtk/usb-device-manager.c | 55 ++--
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index a79bf70..147026c 100644
--- a/gtk/usb-device-manager.c
+++ b/gtk/usb-device-manager.c
@@ -10
---
gtk/usb-device-manager.c | 8
1 file changed, 8 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 1051d10..885a023 100644
--- a/gtk/usb-device-manager.c
+++ b/gtk/usb-device-manager.c
@@ -207,14 +207,6 @@ G_DEFINE_BOXED_TYPE(SpiceUsbDevice, spice_usb
---
gtk/win-usb-driver-install.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/gtk/win-usb-driver-install.c b/gtk/win-usb-driver-install.c
index 928b38f..2e2a48b 100644
--- a/gtk/win-usb-driver-install.c
+++ b/gtk/win-usb-driver-install.c
Hi,
Here is a small series, of little cleanups, and of goal to throw early
an error when the win32 usbclerk can't be reached. In turn, the error
can be catched by client code to show a useful dialog.
Marc-André Lureau (14):
usb: remove useless declaration
win-usb: introduce a spice_win_usb_dr
ACK.
- Mail original -
> If no CA path is given, a default one is set. Use g_build_filename() to
> set a more portable and valid default path.
> ---
> gtk/spice-option.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gtk/spice-option.c b/gtk/spice-option.c
> ind
If no CA path is given, a default one is set. Use g_build_filename() to
set a more portable and valid default path.
---
gtk/spice-option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 1c861e2..2d03912 100644
--- a/gtk/spice-optio
Hi,
- Mail original -
> > Could you give more details about these errors/how you fixed them?
> There were some minor errors related with printf formatting and integer
> overflow.
>
> I can send you a patch if you want to check.
Yes this would be useful so that we can fix them in git mast
On 04/21/2014 01:23 PM, David Mansfield wrote:
On 04/21/2014 12:02 PM, Greg Sheremeta wrote:
In particular, with MATE we get a bunch of:
(remote-viewer:12916): GSpice-WARNING **: FIXME: only support monitor
config with primary surface 0, but given config surface 5
Which seems suspicious to m
Title: Samsung Enterprise Portal mySingle
> Could you give more details about these errors/how you fixed them?
There were some minor errors related with printf formatting and integer overflow.
I can send you a patch if you want to check.
And I have another question. Currently, It seems
32 matches
Mail list logo
