Re: [Spice-devel] oVirt support in aSPICE stalled due to broken network file I/O

2013-09-13 Thread i iordanov
Hi Christophe, If adding a ca-file property to OvirtProxy is not acceptable, would you consider adding (something like) the following function to ovirt-proxy.c? Please note that this is a preliminary variant that I haven't tested much, and may not have enough error checking! void ovirt_proxy_loa

[Spice-devel] [spice-html5] Send the client cache size correctly in little endian order so we don't claim to have an infinitely large cache.

2013-09-13 Thread Jeremy White
Signed-off-by: Jeremy White --- spicedataview.js | 12 spicemsg.js |3 +-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/spicedataview.js b/spicedataview.js index ef9555d..43f0170 100644 --- a/spicedataview.js +++ b/spicedataview.js @@ -93,4 +93,16 @@ Spi

[Spice-devel] [xf86-video-qxl] Provide compatibility for Xorg list code with Xorg < 1.12, for RHEL 6 support (resend)

2013-09-13 Thread Jeremy White
Signed-off-by: Jeremy White --- src/qxl.h | 12 +++- src/qxl_kms.c |2 +- src/qxl_mem.c |2 +- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index c026b63..a3bc7db 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -56,6 +56,16 @@ #include "

Re: [Spice-devel] vdagent protocol question

2013-09-13 Thread Marc-André Lureau
Hi - Original Message - > > > The clipboard message currently include an optional 4bytes enty for > ‘selection’: > > > > typedef struct SPICE_ATTR_PACKED VDAgentClipboardGrab { > > #if 0 /* VD_AGENT_CAP_CLIPBOARD_SELECTION */ > > uint8_t selection; > > uint8_t __reserved[sizeof(ui

Re: [Spice-devel] vdagent protocol question

2013-09-13 Thread Dietmar Maurer
> > This makes it really hard to write nice code. > > I don't think I would have done it if it was "really" hard. But I understand > in your > code it might be difficult for some reason. It is not 'really' hard (but a bit 'ugly') > > I wonder why it does not simply use the ‘opaque’ field of > >

[Spice-devel] vdagent protocol question

2013-09-13 Thread Dietmar Maurer
The clipboard message currently include an optional 4bytes enty for 'selection': typedef struct SPICE_ATTR_PACKED VDAgentClipboardGrab { #if 0 /* VD_AGENT_CAP_CLIPBOARD_SELECTION */ uint8_t selection; uint8_t __reserved[sizeof(uint32_t) - 1 * sizeof(uint8_t)]; #endif uint32_t types[0];

Re: [Spice-devel] oVirt support in aSPICE stalled due to broken network file I/O

2013-09-13 Thread i iordanov
Hi Christophe, I hope this is not too much to ask, but would it be possible for OvirtProxy to have a ca-cert-file property as well as a ca-cert property? This way, supporting the spice-ca-file option as well as the existing aSPICE functionality will be much easier. Thanks! iordan On Fri, Sep 13

[Spice-devel] More on virt-viewer for windows

2013-09-13 Thread Fernando Lozano
Hi there, As the newer windows binaries kindly provided by teuf won't work because of missing DLLs, I returned to the latest binaries provided by spice-space.org. remove-viewer.exe works fine, after I foud where to put TLS certificates. Not that user-friendly though. :-) virt-viewer and virs

Re: [Spice-devel] oVirt support in aSPICE stalled due to broken network file I/O

2013-09-13 Thread i iordanov
Hi Christophe, I read through some govirt code, and I think you're right that gvfs is only used during the fetching of the certificate. If that's the case, I will start by not fetching the CA automatically, but requiring for users to provide it to aSPICE the same way as they have to provide it for

[Spice-devel] [spice-html5] Give the Garbage collector a clue to recycle images; avoids fairly massive memory leaks during video playback.

2013-09-13 Thread Jeremy White
Signed-off-by: Jeremy White --- display.js |4 1 file changed, 4 insertions(+) diff --git a/display.js b/display.js index f9bfe76..d0d0994 100644 --- a/display.js +++ b/display.js @@ -778,6 +778,10 @@ function handle_draw_jpeg_onload() { context.drawImage(this, this.o.base

[Spice-devel] wireshark codegen

2013-09-13 Thread Jonathon Jongsma
Opinions on this? The end goal is to be able to generate a header that has both the enums and descriptions of those enum values (e.g. a mapping from enum to string name) that we can use for the wireshark dissector. Obviously, when a new channel or new message gets added to the protocol, there

Re: [Spice-devel] [PATCH] Abort if mmap of coroutine stack fails

2013-09-13 Thread Marc-André Lureau
ack - Original Message - > From: "Daniel P. Berrange" > > If we fail to mmap the stack, abort the processs rather > than returning an error. This is standard practice in > glib apps, and the caller was not checking the > coroutine_init() return code leading to memory corruption. > > Sig

[Spice-devel] [PATCH] Abort if mmap of coroutine stack fails

2013-09-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If we fail to mmap the stack, abort the processs rather than returning an error. This is standard practice in glib apps, and the caller was not checking the coroutine_init() return code leading to memory corruption. Signed-off-by: Daniel P. Berrange --- gtk/coroutine

Re: [Spice-devel] [PATCH] Free coroutine stack when releasing coroutine

2013-09-13 Thread Marc-André Lureau
ack - Original Message - > From: "Daniel P. Berrange" > > The coroutine_init function mmap's a stack for the > ucontext coroutine, but nothing ever munmaps it. > > Signed-off-by: Daniel P. Berrange > --- > gtk/coroutine_ucontext.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --

[Spice-devel] [PATCH] Free coroutine stack when releasing coroutine

2013-09-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The coroutine_init function mmap's a stack for the ucontext coroutine, but nothing ever munmaps it. Signed-off-by: Daniel P. Berrange --- gtk/coroutine_ucontext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk/coroutine_ucontext.c b/gtk/coroutine_ucontext.