[Spice-devel] (no subject)

2013-01-29 Thread colorfilter06
subscribe SJ@liu80 nodigest___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] usbredir doesn't work

2013-01-29 Thread Rozen Lin
Hi, Could you use them successfully when you start VM/libvirt/qemu as root and use the virtviewer as root? If yes, it's the just the device permission issue in Linux, you may write new udev-rules to enable the use of usbdevices for normal user. On Tue, 2013-01-29 at 23:41 +0800, javaon wrote: >

Re: [Spice-devel] Experimental patch to enable Deferred FPS mode for the qemu qxl driver.

2013-01-29 Thread Jeremy White
> Hmm, this seems like some debugging / wip work left over ? Sorry if I wasn't clear; I had thought that others were interested in trying the dfps stuff in conjunction with qemu. Given my recent experience, I was able to cobble something together that would let people try that use case. I didn't

[Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-29 Thread Jeremy White
This fixes a bug with x-spice where you could not specify a default mode in an xorg.conf modeline that was greater than 1024x768. This also eliminates (and partially reverts) patch c1b537fc. It also fixes bug 894421, where gnome modes flicker and work poorly. Signed-off-by: Jeremy White --- sr

Re: [Spice-devel] qemu qxl driver and default display size questions

2013-01-29 Thread Jeremy White
>> Does anyone have a set of tests, formal or informal, that are 'good >> enough' for testing the qxl driver with qemu? I'd like to feel that I'm >> putting the code through a known set of tests prior to claiming that my >> patch is good enough. > > What I usually do is fire up a Fedora-18 vm, th

Re: [Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Marc-André Lureau
Hi On Tue, Jan 29, 2013 at 6:09 PM, Christophe Fergeau wrote: > On Tue, Jan 29, 2013 at 06:01:34PM +0100, Marc-André Lureau wrote: >> On Tue, Jan 29, 2013 at 5:54 PM, Christophe Fergeau >> wrote: >> > update_proxy(session, NULL); will never unset an already set proxy. >> >> >> If SPICE_PROXY is

Re: [Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Christophe Fergeau
On Tue, Jan 29, 2013 at 06:01:34PM +0100, Marc-André Lureau wrote: > On Tue, Jan 29, 2013 at 5:54 PM, Christophe Fergeau > wrote: > > update_proxy(session, NULL); will never unset an already set proxy. > > > If SPICE_PROXY is set, it will replace it if it's a valid value. > > If SPICE_PROXY is

Re: [Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Marc-André Lureau
On Tue, Jan 29, 2013 at 5:54 PM, Christophe Fergeau wrote: > update_proxy(session, NULL); will never unset an already set proxy. If SPICE_PROXY is set, it will replace it if it's a valid value. If SPICE_PROXY is not set, it won't replace it, keep current proxy. Is that a problem? -- Marc-And

Re: [Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Christophe Fergeau
On Tue, Jan 29, 2013 at 05:45:00PM +0100, Marc-André Lureau wrote: > On Tue, Jan 29, 2013 at 5:10 PM, Christophe Fergeau > wrote: > > The patch seems to have been pushed without addressing this comment? > > Ah sorry, I missed the comments. There is already a > g_clear_object(&s->proxy); or I don

Re: [Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Marc-André Lureau
On Tue, Jan 29, 2013 at 5:10 PM, Christophe Fergeau wrote: > The patch seems to have been pushed without addressing this comment? Ah sorry, I missed the comments. There is already a g_clear_object(&s->proxy); or I don't get what you mean. -- Marc-André Lureau

Re: [Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Christophe Fergeau
On Tue, Jan 29, 2013 at 02:12:57PM +0100, Christophe Fergeau wrote: > On Tue, Jan 29, 2013 at 01:33:43PM +0100, Marc-André Lureau wrote: > > @@ -118,24 +119,29 @@ enum { > > static guint signals[SPICE_SESSION_LAST_SIGNAL]; > > > > > > -static SpiceProxy* get_proxy(void) > > +static void update

Re: [Spice-devel] [PATCH spice-xpi 1/2] xpi: use safer g_environ_setenv()

2013-01-29 Thread Christophe Fergeau
On Tue, Jan 29, 2013 at 12:29:27PM +0100, Marc-André Lureau wrote: > On Tue, Jan 29, 2013 at 10:58 AM, Christophe Fergeau > wrote: > > Did you observe actual issues with that in spice-xpi, or is it just > > theoritical? While the patches looks good, g_environ_setenv was added in > > glib 2.32, whi

Re: [Spice-devel] [PATCH spice-xpi] xpi: add a few g_environ functions from GLib >= 2.28

2013-01-29 Thread Christophe Fergeau
Looks good, ACK, Christophe On Tue, Jan 29, 2013 at 01:22:03PM +0100, Marc-André Lureau wrote: > --- > SpiceXPI/src/plugin/Makefile.am | 2 + > SpiceXPI/src/plugin/glib-compat.c | 188 > ++ > SpiceXPI/src/plugin/glib-compat.h | 49 ++ > SpiceXPI/

Re: [Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Christophe Fergeau
On Tue, Jan 29, 2013 at 01:33:43PM +0100, Marc-André Lureau wrote: > Add a session property to set proxy setting, since it is racy to rely > on setenv(). Also doing so would override system environment, which > will modify other session too sharing the same process. > > v2: > - keep old proxy if u

[Spice-devel] [PATCH spice-gtk] Add SpiceSession:proxy

2013-01-29 Thread Marc-André Lureau
Add a session property to set proxy setting, since it is racy to rely on setenv(). Also doing so would override system environment, which will modify other session too sharing the same process. v2: - keep old proxy if update_proxy() fails - remove strlen() usage - return NULL in spice_proxy_to_str

[Spice-devel] [PATCH spice-xpi] xpi: add a few g_environ functions from GLib >= 2.28

2013-01-29 Thread Marc-André Lureau
--- SpiceXPI/src/plugin/Makefile.am | 2 + SpiceXPI/src/plugin/glib-compat.c | 188 ++ SpiceXPI/src/plugin/glib-compat.h | 49 ++ SpiceXPI/src/plugin/plugin.h | 1 + 4 files changed, 240 insertions(+) create mode 100644 SpiceXPI/src/plugin/g

Re: [Spice-devel] Experimental patch to enable Deferred FPS mode for the qemu qxl driver.

2013-01-29 Thread Hans de Goede
Hi, On 01/28/2013 09:46 PM, Jeremy White wrote: When I decided to try to understand what was going on with Gnome fallback, I hacked the Deferred FPS mode into working with a qemu system. This is not quite ready for prime time, but should make for interesting testing. My rather biased sense is

Re: [Spice-devel] qemu qxl driver and default display size questions

2013-01-29 Thread Hans de Goede
Hi, On 01/28/2013 08:39 PM, Jeremy White wrote: I've spent more time trying to understand X and the qxl driver in a qemu / 4 head environment. It's a bit challenging; there isn't really definitive documentation for what we can expect ScreenInfoRec records to contain (or even exactly what we're

Re: [Spice-devel] usbredir doesn't work

2013-01-29 Thread Hans de Goede
Hi, On 01/29/2013 10:26 AM, javaon wrote: My environment: * Ubuntu 12.04 64bit * qemu 1.3.0 * libvirt 1.0.1 * spice 0.12.2 * spice-gtk 0.15 * virt-viewer 0.5.4 When I connected to the VM (a windows 7) as a normal user, I received an error - access denied. (See the attached screen

Re: [Spice-devel] [PATCH spice-xpi 2/2] xpi: add Proxy member

2013-01-29 Thread Marc-André Lureau
On Tue, Jan 29, 2013 at 11:01 AM, Christophe Fergeau wrote: > Any idea what the 'ing' stands for? At first I thought this was a typo, but > this is present in all other attributes. eheh, no idea either ;) -- Marc-André Lureau ___ Spice-devel mailing

Re: [Spice-devel] [PATCH spice-xpi 1/2] xpi: use safer g_environ_setenv()

2013-01-29 Thread Marc-André Lureau
On Tue, Jan 29, 2013 at 10:58 AM, Christophe Fergeau wrote: > Did you observe actual issues with that in spice-xpi, or is it just > theoritical? While the patches looks good, g_environ_setenv was added in > glib 2.32, which may be too recent. Oops, I didn't notice. I will make the change still wo

Re: [Spice-devel] [PATCH spice-gtk 1/2] proxy: initialize proxy at session construct time

2013-01-29 Thread Christophe Fergeau
Looks good, you moved the code out of a #if GLIB_CHECK_VERSION(2,26,0) block, this seems ok, but I prefer to mention it. Christophe On Mon, Jan 28, 2013 at 09:19:32PM +0100, Marc-André Lureau wrote: > --- > gtk/spice-session-priv.h | 2 ++ > gtk/spice-session.c | 40 +++

Re: [Spice-devel] [PATCH spice-gtk 2/2] Add SpiceSession:proxy

2013-01-29 Thread Christophe Fergeau
On Mon, Jan 28, 2013 at 09:19:33PM +0100, Marc-André Lureau wrote: > Add a session property to set proxy setting, since it is racy to rely > on setenv(). Also doing so would override system environment, which > will modify other session too sharing the same process. > --- > gtk/spice-proxy.c | 1

Re: [Spice-devel] [PATCH spice-gtk 2/2] Add SpiceSession:proxy

2013-01-29 Thread Christophe Fergeau
Hey, On Mon, Jan 28, 2013 at 09:19:33PM +0100, Marc-André Lureau wrote: > Add a session property to set proxy setting, since it is racy to rely > on setenv(). Also doing so would override system environment, which > will modify other session too sharing the same process. > --- > gtk/spice-proxy.c

Re: [Spice-devel] [PATCH spice-xpi 2/2] xpi: add Proxy member

2013-01-29 Thread Christophe Fergeau
On Mon, Jan 28, 2013 at 07:03:57PM +0100, Marc-André Lureau wrote: > Set SPICE_PROXY environment variable accordingly. > --- > SpiceXPI/src/plugin/nsISpicec.idl| 1 + > SpiceXPI/src/plugin/nsScriptablePeer.cpp | 9 - > SpiceXPI/src/plugin/nsScriptablePeer.h | 1 + > SpiceXPI/s

Re: [Spice-devel] [PATCH spice-xpi 1/2] xpi: use safer g_environ_setenv()

2013-01-29 Thread Christophe Fergeau
Hey, On Mon, Jan 28, 2013 at 07:03:56PM +0100, Marc-André Lureau wrote: > Quoting GLib: > > Environment variable handling in UNIX is not thread-safe, and your > program may crash if one thread calls g_setenv() while another thread > is calling getenv(). (And note that many functions, such as gett

Re: [Spice-devel] usbredir doesn't work

2013-01-29 Thread javaon
Sorry.. forgetting the version of usbredir, it's 0.6 the latest one. thanks, On 01/29/2013 05:26 PM, javaon wrote: My environment: * Ubuntu 12.04 64bit * qemu 1.3.0 * libvirt 1.0.1 * spice 0.12.2 * spice-gtk 0.15 * virt-viewer 0.5.4 When I connected to the VM (a windows 7) as a n

[Spice-devel] usbredir doesn't work

2013-01-29 Thread javaon
My environment: * Ubuntu 12.04 64bit * qemu 1.3.0 * libvirt 1.0.1 * spice 0.12.2 * spice-gtk 0.15 * virt-viewer 0.5.4 When I connected to the VM (a windows 7) as a normal user, I received an error - access denied. (See the attached screenshot) Below is the screen message on client end: