Re: [Spice-devel] spice-gtk usb-redirection

2012-08-08 Thread Jackson
> Yes, in the second case qemu is the tcp client, and the ip and port number > are that of the usbredirserver process which is acting as the usbredir-host. that means I have to know the IP address to describe the qemu cmdline before a spice-client connects to spice-server. So, if I can't get IP a

[Spice-devel] [PATCH] Technically, the xorg/ prefix should not be specified. It generally works, because xorg/ is usually hung off /usr/include. This enables compliation that correctly respects a pkg

2012-08-08 Thread Jeremy White
--- src/spiceqxl_inputs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c index 62ef19f..a031b83 100644 --- a/src/spiceqxl_inputs.c +++ b/src/spiceqxl_inputs.c @@ -27,12 +27,12 @@ #include "config.h" #endif -#incl

[Spice-devel] [PATCH] Enable compilation on systems with older render libraries.

2012-08-08 Thread Jeremy White
--- src/uxa/uxa-render.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/uxa/uxa-render.c b/src/uxa/uxa-render.c index ac80c45..b5554e7 100644 --- a/src/uxa/uxa-render.c +++ b/src/uxa/uxa-render.c @@ -137,6 +137,7 @@ op_to_string(CARD8 op) /* * Operators only availabl

Re: [Spice-devel] [PATCH] [spice-html5] Add the top scroll to the cursor offset

2012-08-08 Thread Aric Stewart
There is, however I have not found it materially required of the window is too narrow. -aric On 8/8/12 10:04 AM, Jeremy White wrote: this.x = e.clientX - sc.display.surfaces[sc.display.primary_surface].canvas.offsetLeft; -this.y = e.clientY - sc.display.surfaces[sc.display.

[Spice-devel] [PATCH win-qxl] miniport: fix invalid memory access from previous patch

2012-08-08 Thread Marc-André Lureau
The patch 253b781773190afef313390542f2d68995e302d7 implementing custom display resolution is accessing unowned memory regions. Interestingly, the driver worked fine on Windows XP but BSOD on Win7. --- miniport/qxl.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff

[Spice-devel] [PATCH] spice-common: don't install spice-protocol

2012-08-08 Thread Marc-André Lureau
Revert to usage of DIST_SUBDIRS to avoid make install under spice-protocol. Use an updated version of git.mk that fixes .gitignore generation under DIST_SUBDIRS. --- Makefile.am |3 ++- git.mk | 48 ++-- 2 files changed, 32 insertions(+), 19 d

[Spice-devel] Requesting a rebuild of spice-guest-tools

2012-08-08 Thread Michael Russo
I was recently debugging (as in, looking at log files and using google) an issue where the vdagent wouldn't properly detect/communicate with the virtio-serial driver in Windows 7. That let me to this thread ( http://www.mail-archive.com/spice-devel@lists.freedesktop.org/msg08985.html) where I was

Re: [Spice-devel] Resend spice-protocol - Fix "make gitignore" subdirectory recursion

2012-08-08 Thread Jeremy White
> I am fine with using an updated version of git.mk, but I fail to see what it > really solves. > > git status is clean here after a build of spice-server or spice-gtk. > > (this discussion is very close to the spice-common Makefile.am usage of > SUBDIR vs DIST_SUBDIR. It should probably keep u

Re: [Spice-devel] Resend spice-protocol - Fix "make gitignore" subdirectory recursion

2012-08-08 Thread Marc-André Lureau
- Mensaje original - > This was under the thread Add spice/Makefile to the generated > .gitignore: > > http://lists.freedesktop.org/archives/spice-devel/2012-July/009910.html > > It worked for me and seemed to work for Alon as well. Could I get a > push? I am fine with using an update

[Spice-devel] Resend spice-protocol - Fix "make gitignore" subdirectory recursion

2012-08-08 Thread Jeremy White
This was under the thread Add spice/Makefile to the generated .gitignore: http://lists.freedesktop.org/archives/spice-devel/2012-July/009910.html It worked for me and seemed to work for Alon as well. Could I get a push? Thanks, Jeremy ___ Spice-devel

Re: [Spice-devel] [spice-gtk] build: make spice-controller.pc installation conditional

2012-08-08 Thread Marc-André Lureau
yup, should have been with previous patch, so trivial to me - Mensaje original - > It shouldn't be installed when controller support is disabled. > --- > Makefile.am | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 0d168a8..a8

Re: [Spice-devel] [PATCH] [spice-html5] Add the top scroll to the cursor offset

2012-08-08 Thread Jeremy White
> this.x = e.clientX - > sc.display.surfaces[sc.display.primary_surface].canvas.offsetLeft; > -this.y = e.clientY - > sc.display.surfaces[sc.display.primary_surface].canvas.offsetTop; > +this.y = e.clientY - > sc.display.surfaces[sc.display.primary_surface].canvas.offset

[Spice-devel] [spice-gtk] build: make spice-controller.pc installation conditional

2012-08-08 Thread Christophe Fergeau
It shouldn't be installed when controller support is disabled. --- Makefile.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 0d168a8..a8d585b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -13,9 +13,12 @@ pkgconfigdir = $(libdir)/pkgconfig

[Spice-devel] [PATCH][spice-html5] work to improve keyboard keycode -> scancode processing

2012-08-08 Thread Aric Stewart
Signed-off-by: Aric Stewart --- atKeynames.js | 183 +++ utils.js | 266 +++-- 2 files changed, 327 insertions(+), 122 deletions(-) create mode 100644 atKeynames.js diff --git a/atKeynames.js b/atKeyname

[Spice-devel] [PATCH] [spice-html5] Add the top scroll to the cursor offset

2012-08-08 Thread Aric Stewart
Signed-off-by: Aric Stewart --- spicemsg.js |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spicemsg.js b/spicemsg.js index 41b001d..f4873f1 100644 --- a/spicemsg.js +++ b/spicemsg.js @@ -640,7 +640,7 @@ function SpiceMsgcMousePosition(sc, e) if (e) {

Re: [Spice-devel] Performance of Xspice - some results, and a potential patch

2012-08-08 Thread Jeremy White
> I forgot to ask that you measure CPU consumption on the server: > You could have (manually) enable better compression schemes for the images, > which would have reduced the total bytes sent. > That costs CPU, though. I did perform a crude version of that measurement (jiffies for the Xorg proce

Re: [Spice-devel] [PATCH] spice-ppc: adds powerpc64 mem barriers

2012-08-08 Thread Christophe Fergeau
Hey, On Wed, Aug 08, 2012 at 09:52:33AM -0300, Erlon Cruz wrote: > I'm not shure about what would happen. I grab this from the kernel > definition of mb(). Kernel have to deal with device mem ops. It guess > lwsync, can be used once in this case only system memory is involved. Ok, fine with me.

Re: [Spice-devel] [PATCH] spice-ppc: adds powerpc64 mem barriers

2012-08-08 Thread Erlon Cruz
On Wed, Aug 8, 2012 at 5:02 AM, Christophe Fergeau wrote: > Hey, > > Thanks for looking into this! Just a few random questions below, mostly > because I'm curious ;) > > On Tue, Aug 07, 2012 at 03:46:40PM -0300, sombra...@gmail.com wrote: >> From: Erlon Cruz >> >> >> Signed-off-by: Erlon R. Cruz

Re: [Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice

2012-08-08 Thread Christophe Fergeau
Hey, On Thu, Jun 14, 2012 at 02:17:10PM +0300, Alon Levy wrote: > By adding spice-protocol to SUBDIRS configure and make will be called in it. This patch has an unfortunate side-effect, it's that it causes spice-protocol headers to be installed. In particular, this means running make install in s

Re: [Spice-devel] [PATCH 2/7] spice-ppc: Fixing endianess for channel startup negotiation

2012-08-08 Thread Christophe Fergeau
On Wed, Aug 08, 2012 at 05:26:09AM -0400, Yaniv Kaul wrote: > > static int reds_send_link_ack(RedLinkInfo *link) > > { > > SpiceLinkHeader header; > > @@ -1224,12 +1242,12 @@ static int reds_send_link_ack(RedLinkInfo > > *link) > > RedChannelCapabilities *channel_caps; > > BUF_MEM

Re: [Spice-devel] [PATCH 2/7] spice-ppc: Fixing endianess for channel startup negotiation

2012-08-08 Thread Christophe Fergeau
On Tue, Aug 07, 2012 at 03:43:09PM -0300, Erlon Cruz wrote: > From: Erlon Cruz > > Signed-off-by: Erlon R. Cruz > Signed-off-by: Fabiano Fidêncio > Signed-off-by: Rafael F. Santos > > --- > server/reds.c | 82 > - > 1 files changed,

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-08 Thread Yaniv Kaul
- Original Message - > On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: > > From: Erlon Cruz > > > > Signed-off-by: Erlon R. Cruz > > Signed-off-by: Fabiano Fidêncio > > > > Signed-off-by: Rafael F. Santos > > > > --- > > server/glz_encoder.c |2 +- > > 1 files changed,

Re: [Spice-devel] [PATCH 2/7] spice-ppc: Fixing endianess for channel startup negotiation

2012-08-08 Thread Yaniv Kaul
- Original Message - > Signed-off-by: Erlon R. Cruz > Signed-off-by: Fabiano Fidêncio > > Signed-off-by: Rafael F. Santos > > --- > server/reds.c | 82 > - > 1 files changed, 69 insertions(+), 13 deletions(-) > > diff --git a/

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-08 Thread Yaniv Kaul
On 08/08/2012 12:34 PM, Christophe Fergeau wrote: On Wed, Aug 08, 2012 at 05:24:30AM -0400, Yaniv Kaul wrote: - Original Message - On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: From: Erlon Cruz Signed-off-by: Erlon R. Cruz Signed-off-by: Fabiano Fidêncio Signed-off-by

Re: [Spice-devel] [PATCH 2/7] spice-ppc: Fixing endianess for channel startup negotiation

2012-08-08 Thread Christophe Fergeau
On Wed, Aug 08, 2012 at 08:45:06AM +0200, Gerd Hoffmann wrote: > Hi, > > > header.magic = SPICE_MAGIC; > > header.size = sizeof(ack); > > -header.major_version = SPICE_VERSION_MAJOR; > > -header.minor_version = SPICE_VERSION_MINOR; > > +header.major_version = htole32(SPICE_

Re: [Spice-devel] Port libspice to BE machines

2012-08-08 Thread Christophe Fergeau
On Tue, Aug 07, 2012 at 03:39:11PM -0300, Erlon Cruz wrote: > This series of patches make changes on libspice to support BE archs. > It still doesn't ports spicec client running on BE machines. Please review. This series has been sent twice, hopefully I have looked at the right one... Christophe

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-08 Thread Christophe Fergeau
On Wed, Aug 08, 2012 at 05:24:30AM -0400, Yaniv Kaul wrote: > - Original Message - > > On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: > > > From: Erlon Cruz > > > > > > Signed-off-by: Erlon R. Cruz > > > Signed-off-by: Fabiano Fidêncio > > > > > > Signed-off-by: Rafael F. S

Re: [Spice-devel] [PATCH 1/7] spice-ppc: Adds powerppc compilation support

2012-08-08 Thread Christophe Fergeau
On Tue, Aug 07, 2012 at 03:43:08PM -0300, Erlon Cruz wrote: > From: Erlon Cruz > > Signed-off-by: Erlon R. Cruz > Signed-off-by: Fabiano Fidêncio > Signed-off-by: Rafael F. Santos > > --- > configure.ac | 10 -- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/c

Re: [Spice-devel] [PATCH 5/7] spice-ppc: avoid casts to lessers types!

2012-08-08 Thread Christophe Fergeau
Hey, On Tue, Aug 07, 2012 at 03:43:12PM -0300, Erlon Cruz wrote: > From: Fabiano Fidêncio > > It's breaking PPC's keyboard functionality, once this cast is > getting the first byte (from left to right) on any architecture, > what's wrong when we think in a PPC (we should get the last

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-08 Thread Christophe Fergeau
On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: > From: Erlon Cruz > > Signed-off-by: Erlon R. Cruz > Signed-off-by: Fabiano Fidêncio > Signed-off-by: Rafael F. Santos > --- > server/glz_encoder.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/serv

Re: [Spice-devel] [PATCH 6/7] spice-ppc: GCC, please, shut up!

2012-08-08 Thread Christophe Fergeau
On Tue, Aug 07, 2012 at 03:43:13PM -0300, Erlon Cruz wrote: > From: Fabiano Fidêncio > > Fixing warnings, please, amend this commit to: > 29b543ae6fd4493b930973622e71c6ecafb6f703 This should be squashed in patch 2/7 as indicated by the log. Christophe > > Signed-off-by: Erlon R. Cruz

Re: [Spice-devel] [PATCH 3/7] spice-ppc: Fixing endianess for channel messages

2012-08-08 Thread Christophe Fergeau
Looks good to me, thanks! General question for the list, could these various getters/setters be handled by the generic marshalling code we have? Christophe On Tue, Aug 07, 2012 at 03:43:10PM -0300, Erlon Cruz wrote: > From: Erlon Cruz > > Signed-off-by: Erlon R. Cruz > Signed-off-by: Fabiano F

Re: [Spice-devel] spice-gtk usb-redirection

2012-08-08 Thread Hans de Goede
Hi, On 08/08/2012 05:12 AM, Jackson wrote: examples of the 2 on the qemu cmdline are: -chardev spicevmc,name=usbredir,id=usbredirchardev1 -device usb- redir,chardev=usbredirchardev1 -chardev socket,host=192.168.1.9,port=4000,id=usbredirchardev2 -device usb- redir,chardev=usbredirchardev2 Exc

Re: [Spice-devel] [PATCH] spice-ppc: adds powerpc64 mem barriers

2012-08-08 Thread Christophe Fergeau
Hey, Thanks for looking into this! Just a few random questions below, mostly because I'm curious ;) On Tue, Aug 07, 2012 at 03:46:40PM -0300, sombra...@gmail.com wrote: > From: Erlon Cruz > > > Signed-off-by: Erlon R. Cruz > Signed-off-by: Fabiano Fidêncio > Signed-off-by: Rafael F. Santos

Re: [Spice-devel] [PATCH 2/7] spice-ppc: Fixing endianess for channel startup negotiation

2012-08-08 Thread Gerd Hoffmann
Hi, > header.magic = SPICE_MAGIC; > header.size = sizeof(ack); > -header.major_version = SPICE_VERSION_MAJOR; > -header.minor_version = SPICE_VERSION_MINOR; > +header.major_version = htole32(SPICE_VERSION_MAJOR); > +header.minor_version = htole32(SPICE_VERSION_MINOR);

Re: [Spice-devel] Performance of Xspice - some results, and a potential patch

2012-08-08 Thread Yaniv Kaul
- Original Message - > > I don't know what were the network conditions you tested, but it > > would be great if you could repeat your test with lower bandwidth > > (you can use tc), and also, you can try disabling off-screen > > surfaces in the driver. > > I do have a test network construc