Re: [Spice-devel] chatty qxl vga mode

2012-04-25 Thread Gerd Hoffmann
On 04/25/12 18:14, Jan Kiszka wrote: > Hi, > > just played with qxl and noticed quite a lot of debug output on the > local console: > > do_spice_init: starting 0.10.1 > spice_server_add_interface: SPICE_INTERFACE_QXL > red_worker_main: begin > display_channel_create: create display channel > curs

[Spice-devel] Spice vdagent on Ubuntu 10.04

2012-04-25 Thread t rajan
Hi I'm trying to get Spice vdagent working on Ubuntu 10.04 guest VM. I updated to kernel version 2.6.38 to get virtio console driver. I'm launching the guest from command line qemu -vga qxl -device qxl -global qxl-vga.vram_size=33554432 -device virtio-serial -chardev spicevmc,id=vdagent,debug=0,

Re: [Spice-devel] Audio recording device - Win 7 guest

2012-04-25 Thread David Jaša
Hi Nick, based on your XML and description, I'd blame qemu. You say CentOS was the same, what version of qemu-kvm package is there? Nick Causton píše v St 25. 04. 2012 v 17:38 +0100: > Hello David, > > Currently using Debian 'Wheezy' Host with Win 7 guest. Both on the same > physical machine.

Re: [Spice-devel] Audio recording device - Win 7 guest

2012-04-25 Thread Nick Causton
Hello David, Currently using Debian 'Wheezy' Host with Win 7 guest. Both on the same physical machine. Libvirt xml file attached. I believe I have also tried using CentOS and Arch as alternative hosts, according to my notes not openSUSE as I stated before; the Spice server has errors on open

Re: [Spice-devel] [PATCH spice] Disable -Waggregate-return if building with SLIRP

2012-04-25 Thread Hans de Goede
ACK. On 04/25/2012 04:19 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" The API design of SLIRP means that it is not practical to use the -Waggregate-return warning flag. Disable this flag in the (unlikely) scenario where SLIRP is actually requested at build time --- m4/spice-compil

Re: [Spice-devel] [PATCH spice] Ensure __STDC_FORMAT_MACROS is always defined first

2012-04-25 Thread Hans de Goede
ACK. On 04/25/2012 04:19 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" The client/common.h file defines __STDC_FORMAT_MACROS before including inttypes.h so that the PRI* macros get defined in C++. This is ignoring the possibility that other global includes may have already pulled in

[Spice-devel] [PATCH spice] Disable -Waggregate-return if building with SLIRP

2012-04-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The API design of SLIRP means that it is not practical to use the -Waggregate-return warning flag. Disable this flag in the (unlikely) scenario where SLIRP is actually requested at build time --- m4/spice-compile-warnings.m4 |5 - 1 files changed, 4 insertions(

[Spice-devel] [PATCH spice] Ensure __STDC_FORMAT_MACROS is always defined first

2012-04-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The client/common.h file defines __STDC_FORMAT_MACROS before including inttypes.h so that the PRI* macros get defined in C++. This is ignoring the possibility that other global includes may have already pulled in inttypes.h We need __STDC_FORMAT_MACROS to be defined be

[Spice-devel] [PATCH] Distribution-agnostic XORG_MACROS_VERSION check message

2012-04-25 Thread Christophe Fergeau
--- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index a97f477..691e2c6 100644 --- a/configure.ac +++ b/configure.ac @@ -36,7 +36,7 @@ AC_CONFIG_HEADERS([config.h]) # Require xorg-macros: XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MA

[Spice-devel] [PATCH slirp] Replace () with (void) in public function definitions

2012-04-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Functions with no arguments must use (void) in C --- net_slirp.c | 12 ++-- net_slirp.h |6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/net_slirp.c b/net_slirp.c index e79802d..32b92bb 100644 --- a/net_slirp.c +++ b/net_slirp.c @

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-25 Thread Alon Levy
On Wed, Apr 25, 2012 at 03:05:55PM +0200, Christophe Fergeau wrote: > On Wed, Apr 25, 2012 at 12:59:46PM +0300, Yaniv Kaul wrote: > > It does not harm them in any way, AFAIK - I could not find similar > > named packages in either. So better get the name right on one > > distribution than none. > >

Re: [Spice-devel] [PATCH spice-common] Add missing struct field initializers

2012-04-25 Thread Daniel P. Berrange
On Wed, Apr 25, 2012 at 03:13:26PM +0200, Christophe Fergeau wrote: > On Wed, Apr 25, 2012 at 02:05:14PM +0100, Daniel P. Berrange wrote: > > On Wed, Apr 25, 2012 at 03:01:53PM +0200, Christophe Fergeau wrote: > > > On Wed, Apr 25, 2012 at 10:58:05AM +0100, Daniel P. Berrange wrote: > > > > From: "

Re: [Spice-devel] [PATCH spice-common] Add missing struct field initializers

2012-04-25 Thread Christophe Fergeau
On Wed, Apr 25, 2012 at 02:05:14PM +0100, Daniel P. Berrange wrote: > On Wed, Apr 25, 2012 at 03:01:53PM +0200, Christophe Fergeau wrote: > > On Wed, Apr 25, 2012 at 10:58:05AM +0100, Daniel P. Berrange wrote: > > > From: "Daniel P. Berrange" > > > > Is that causing issues with newer GCCs? Iirc t

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-25 Thread Christophe Fergeau
On Wed, Apr 25, 2012 at 12:59:46PM +0300, Yaniv Kaul wrote: > It does not harm them in any way, AFAIK - I could not find similar > named packages in either. So better get the name right on one > distribution than none. I'd rather we use the name of the upstream tarball to say something like "insta

Re: [Spice-devel] [PATCH spice-common] Add missing struct field initializers

2012-04-25 Thread Daniel P. Berrange
On Wed, Apr 25, 2012 at 03:01:53PM +0200, Christophe Fergeau wrote: > On Wed, Apr 25, 2012 at 10:58:05AM +0100, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > Is that causing issues with newer GCCs? Iirc the rest of the structure is > supposed to be initialized to 0 when it's only p

Re: [Spice-devel] [PATCH spice] Add some more 'noreturn' annotations

2012-04-25 Thread Daniel P. Berrange
On Wed, Apr 25, 2012 at 01:47:26PM +0200, Hans de Goede wrote: > ACK. Thanks, I've pushed this and the others you have ACKd Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: htt

Re: [Spice-devel] [PATCH spice-common] Add missing struct field initializers

2012-04-25 Thread Christophe Fergeau
On Wed, Apr 25, 2012 at 10:58:05AM +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" Is that causing issues with newer GCCs? Iirc the rest of the structure is supposed to be initialized to 0 when it's only partially initialized. Christophe > > Signed-off-by: Daniel P. Berrange > -

Re: [Spice-devel] Audio recording device - Win 7 guest

2012-04-25 Thread David Jaša
Hi Nick, Please could you tell what OS do you use as client, your libvirt XML (or qemu command line), in what role did you use "a number of different Linux distros" etc. It's hard to tell based on info you've posted. David Nick Causton píše v St 25. 04. 2012 v 12:47 +0100: > Hello, > > > >

[Spice-devel] Audio recording device - Win 7 guest

2012-04-25 Thread Nick Causton
Hello, I have encountered a Spice guest driver problem with Audio Recording in Win 7 Guest. This has spice-guest-tools-0.1.exe installed but there is no audio recording device present. The default sound device: ich6 is being used which I have found is the only one which allows audio playba

Re: [Spice-devel] [PATCH spice] Add missing struct field initializers

2012-04-25 Thread Hans de Goede
Hi, On 04/25/2012 02:31 PM, Daniel P. Berrange wrote: On Wed, Apr 25, 2012 at 01:46:20PM +0200, Hans de Goede wrote: Hi, $subject: Why? The C standard guarantees that if any member of a struct (or array) gets initialized all non specifically initialized members will get initalized to a value o

Re: [Spice-devel] [PATCH spice] Add missing struct field initializers

2012-04-25 Thread Daniel P. Berrange
On Wed, Apr 25, 2012 at 01:46:20PM +0200, Hans de Goede wrote: > Hi, > > $subject: Why? The C standard guarantees that if any > member of a struct (or array) gets initialized all non > specifically initialized members will get initalized > to a value of 0. While you are correct that they get init

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-25 Thread Alon Levy
On Wed, Apr 25, 2012 at 01:21:45PM +0100, Daniel P. Berrange wrote: > On Wed, Apr 25, 2012 at 03:15:00PM +0300, Alon Levy wrote: > > On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote: > > > At least in Fedora 17, the correct RPM name is xorg-x11-util-macros > > > > > > > Please fix your

Re: [Spice-devel] [PATCH spice] Fix printf format specifiers for i686 hosts

2012-04-25 Thread Hans de Goede
ACK. On 04/25/2012 12:00 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- client/cache.hpp|6 +++--- client/cursor.cpp |2 +- client/shared_cache.hpp |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-25 Thread Daniel P. Berrange
On Wed, Apr 25, 2012 at 03:15:00PM +0300, Alon Levy wrote: > On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote: > > At least in Fedora 17, the correct RPM name is xorg-x11-util-macros > > > > Please fix your emailer to not split lines, it causes a malformed patch > - see the '-' and '+'

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-25 Thread Alon Levy
On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote: > At least in Fedora 17, the correct RPM name is xorg-x11-util-macros > Please fix your emailer to not split lines, it causes a malformed patch - see the '-' and '+' lines below, there should not be an extra EOL between them. > diff -

Re: [Spice-devel] [PATCH spice] Add missing struct field initializers

2012-04-25 Thread Hans de Goede
Hi, $subject: Why? The C standard guarantees that if any member of a struct (or array) gets initialized all non specifically initialized members will get initalized to a value of 0. Regards, Hans On 04/25/2012 12:00 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Signed-off-by: Dan

Re: [Spice-devel] [PATCH spice-gtk] Fix --spice-debug flag on glib >= 2.31

2012-04-25 Thread Hans de Goede
Hi, Looks good, ack. Regards, Hans On 04/25/2012 01:26 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" With glib>= 2.31 no debug messages are ever printed out by default, which makes the --spice-debug flag useless. This fix explicitly turns on the appropriate log domain when debug

Re: [Spice-devel] [PATCH spice] Add some more 'noreturn' annotations

2012-04-25 Thread Hans de Goede
ACK. On 04/25/2012 12:33 PM, Daniel P. Berrange wrote: Methods which longjump, unconditionally raise an exception, or call _exit() cannot return control to the caller so should be annotated with 'noreturn' Signed-off-by: Daniel P. Berrange --- client/canvas.h |2 +- client/jpeg_

Re: [Spice-devel] [PATCH spice-server] Fix typo in is_equal_brush

2012-04-25 Thread Hans de Goede
Hi, Good one! ACK. Regards, Hans On 04/25/2012 12:23 PM, Daniel P. Berrange wrote: The 3 part of the conditional in the is_equal_brush method compared the b1->u.color field to itself, instead of b2->u.color Signed-off-by: Daniel P. Berrange --- server/red_worker.c |2 +- 1 files chan

[Spice-devel] [PATCH spice-gtk] Fix --spice-debug flag on glib >= 2.31

2012-04-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" With glib >= 2.31 no debug messages are ever printed out by default, which makes the --spice-debug flag useless. This fix explicitly turns on the appropriate log domain when debug is requested. It takes care to preserve the users own existing log domain requests --- gt

[Spice-devel] [PATCH spice] Add some more 'noreturn' annotations

2012-04-25 Thread Daniel P. Berrange
Methods which longjump, unconditionally raise an exception, or call _exit() cannot return control to the caller so should be annotated with 'noreturn' Signed-off-by: Daniel P. Berrange --- client/canvas.h |2 +- client/jpeg_decoder.cpp |3 +-- client/red_client.h |2 +-

[Spice-devel] [PATCH spice-server] Fix typo in is_equal_brush

2012-04-25 Thread Daniel P. Berrange
The 3 part of the conditional in the is_equal_brush method compared the b1->u.color field to itself, instead of b2->u.color Signed-off-by: Daniel P. Berrange --- server/red_worker.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.

Re: [Spice-devel] Vdagent can not run

2012-04-25 Thread Arnon Gilboa
Seems like a virtio-serial driver issue. I have the similar behavior here with new driver. As you can see in your log, vdservice fails to open virtio-serial. Look in qemu for a line such as: qemu-system-x86_64: virtio-serial-bus: Unexpected port id 42456816 for device virtio-serial-bus.0 CC'ed

[Spice-devel] [PATCH spice] Fix printf format specifiers for i686 hosts

2012-04-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- client/cache.hpp|6 +++--- client/cursor.cpp |2 +- client/shared_cache.hpp |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/client/cache.hpp b/client/cache.hpp index 42e6873..e267f42

[Spice-devel] [PATCH spice] Add missing struct field initializers

2012-04-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- client/x11/platform.cpp | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp index f35d537..0669b69 100644 --- a/client/x11/platform.cpp +++ b/client/x

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-25 Thread Yaniv Kaul
On 04/24/2012 07:30 PM, Christophe Fergeau wrote: On Tue, Apr 24, 2012 at 02:28:42PM +0300, Alon Levy wrote: On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote: At least in Fedora 17, the correct RPM name is xorg-x11-util-macros We could use the upstream name too, xorg-util-macros (ki

[Spice-devel] [PATCH spice-common] Add missing struct field initializers

2012-04-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- common/canvas_base.c |4 +++- common/sw_canvas.c |6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 8f5b0c8..4f40306 100644 --- a/common/canvas_bas

Re: [Spice-devel] Vdagent can not run

2012-04-25 Thread wangfeng wangfeng
Thank you very much. Here is vdservice.log: 4048::INFO::2012-04-25 17:16:15,932::VDService::main::***Service started*** 4048::INFO::2012-04-25 17:16:15,932::log_version::1.1.0.1009 4048::INFO::2012-04-25 17:16:15,932::VDService::launch_agent::Wait for vdagent to connect 4048::INFO::2012-04-25 17:1

Re: [Spice-devel] Vdagent can not run

2012-04-25 Thread Arnon Gilboa
Hi, Seems like we are having again some issues with virtio-serial. Can you please send vdservice.log as well? 10x, Arnon wangfeng wangfeng wrote: Hi, I have installed vdservice successfully. But after I restart the windows7 guest, vdagent can not run ,and vdservice stoped. When I start v

Re: [Spice-devel] [PATCH spice 00/12] Add more compiler warnings

2012-04-25 Thread Daniel P. Berrange
On Mon, Apr 16, 2012 at 08:11:23PM +0100, Daniel P. Berrange wrote: > On Mon, Apr 16, 2012 at 09:07:22PM +0200, Marc-André Lureau wrote: > > Hi Daniel, > > > > Did you forgot about your patches? > > Should I take care of doing the small change in 6/12 and push for you? > > Oh I didn't notice they

[Spice-devel] Vdagent can not run

2012-04-25 Thread wangfeng wangfeng
Hi, I have installed vdservice successfully. But after I restart the windows7 guest, vdagent can not run ,and vdservice stoped. When I start vdservice it says "The RHEV Spice Agent on local computer started and then stopped. Some services stop automatically if they are not in use by other

Re: [Spice-devel] Client Graphics Filtering

2012-04-25 Thread Yaniv Kaul
On 04/25/2012 10:41 AM, Yonit Halperin wrote: > On 04/25/2012 08:32 AM, Noel Van Hook wrote: >> If I recall my windows drivers correctly, I don't think the driver >> even knows what application owns the buffer it is drawing into. >> > IIUC, the implementation involves guest components that track do

Re: [Spice-devel] Client Graphics Filtering

2012-04-25 Thread Yonit Halperin
On 04/25/2012 08:32 AM, Noel Van Hook wrote: > If I recall my windows drivers correctly, I don't think the driver > even knows what application owns the buffer it is drawing into. > IIUC, the implementation involves guest components that track down the relevant bitmaps. Yonit. > Noel > > On Tue,