Re: [Spice-devel] [PATCH spice-common 4/6] Update spice-protocol submodule

2012-04-08 Thread Hans de Goede
Hi, On 04/08/2012 08:44 PM, Alon Levy wrote: On Sun, Apr 08, 2012 at 06:42:36PM +0300, Yonit Halperin wrote: For STREAM_DATA_SIZED and QOS_QUERY messages. Signed-off-by: Yonit Halperin --- common/rect.h |2 +- spice-protocol |2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [Spice-devel] [Qemu-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-04-08 Thread Vadim Rozenfeld
On Monday, April 09, 2012 06:00:59 AM Paul Lu-?R-?l wrote: > Hi Vadim, > > The driver works properly on my machine. Is it possible send us the source > code of the driver? We'd like to build it on our environment. Thanks a > ton. > > BR > Paul http://people.redhat.com/vrozenfe/build-2

Re: [Spice-devel] [Qemu-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-04-08 Thread Paul Lu-�R�ブ�-研究�l展部
Hi Vadim, The driver works properly on my machine. Is it possible send us the source code of the driver? We'd like to build it on our environment. Thanks a ton. BR Paul -Original Message- From: Vadim Rozenfeld [mailto:vroze...@redhat.com] Sent: Monday, April 09, 2012 2:33 AM To: Paul Lu

Re: [Spice-devel] [PATCH spice-common 4/6] Update spice-protocol submodule

2012-04-08 Thread Alon Levy
On Sun, Apr 08, 2012 at 06:42:36PM +0300, Yonit Halperin wrote: > For STREAM_DATA_SIZED and QOS_QUERY messages. > > Signed-off-by: Yonit Halperin > --- > common/rect.h |2 +- > spice-protocol |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/rect.h b/com

Re: [Spice-devel] [Qemu-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-04-08 Thread Vadim Rozenfeld
On Monday, March 19, 2012 10:31:16 PM Vadim Rozenfeld wrote: > On Monday, March 19, 2012 02:48:43 PM Paul Lu-???-? wrote: > > Hi Vadim, > > Here is the configuration: > > /usr/local/bin/qemu-system-x86_64 \ > > > > -localtime \ > > -boot order=c,menu=on \ > > -drive file=/var/lib/libvirt/im

Re: [Spice-devel] [PATCH spice-common 2/6] rect: add rect_get_area

2012-04-08 Thread Marc-André Lureau
- Mensaje original - > > Signed-off-by: Yonit Halperin > --- > common/rect.h | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/common/rect.h b/common/rect.h > index 655e9e8..0e4b01e 100644 > --- a/common/rect.h > +++ b/common/rect.h > @@ -80,6 +80

[Spice-devel] [PATCH spice-gtk 3/3] display: debug video streams frames dropping

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- gtk/channel-display-priv.h |5 + gtk/channel-display.c | 19 +++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/gtk/channel-display-priv.h b/gtk/channel-display-priv.h index 1969697..8aac8d8 100644 --- a/gtk/channe

[Spice-devel] [PATCH spice-gtk 2/3] channel: support qos queries

2012-04-08 Thread Yonit Halperin
When a channel receives SPICE_MSG_QOS_QUERY, it responds to the server with SPICE_MSGC_QOS_ACK right after it recieves one more message. Signed-off-by: Yonit Halperin --- gtk/channel-base.c |7 +++ gtk/spice-channel-priv.h |3 +++ gtk/spice-channel.c | 22 +++

[Spice-devel] [PATCH spice-gtk 1/3] display: video streaming: add support for frames of different sizes

2012-04-08 Thread Yonit Halperin
When playing a youtube video on Windows guest, the driver sometimes sends images which contain the videe frames, but also other parts of the screen (e.g., the you tube process bar). In order to prevent glitches, we send these images as part of the stream, using SPICE_MSG_DISPLAY_STREAM_DATA_SIZED.

[Spice-devel] [PATCH spice 11/11] server/red_worker: add stream stats for debugging

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/red_worker.c | 50 ++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 92e1197..ba56e89 100644 --- a/server/red_worker.c +++ b/server/red_work

[Spice-devel] [PATCH spice 10/11] server/video-streams: adjust mjpeg quality and frame rate according to the current bit rate

2012-04-08 Thread Yonit Halperin
Previously, the mjpeg quality was always 70. The frame rate was tuned according to the frames' congestion in the pipe. This patch sets the mjpeg quality and frame rate according to the compressed size of the frames and the currently available bit rate. The compression size is estimated for differen

[Spice-devel] [PATCH spice 09/11] server/mjpeg_encoder: allow varying jpeg quality

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/mjpeg_encoder.c |5 ++--- server/mjpeg_encoder.h |1 + server/red_worker.c|1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c index b3685f8..72d9040 100644 --- a/server/mjpeg

[Spice-devel] [PATCH spice 08/11] server/red_worker: enable periodic network monitoring in the display channel

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/red_worker.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index eec4beb..f876c15 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9719,6 +9719,7 @@ static CommonChanne

[Spice-devel] [PATCH spice 07/11] server/red_worker: assign timer callbacks to worker_core, using spice_timer_queue

2012-04-08 Thread Yonit Halperin
display channel: Supplying timeouts interface to red_channel, in order to allow periodic network monitoring. Signed-off-by: Yonit Halperin --- server/red_worker.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c inde

[Spice-devel] [PATCH spice 06/11] server/red_channel: support network monitoring

2012-04-08 Thread Yonit Halperin
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server channel's can send it SPICE_MSG_QOS_QUERY. The client is supposed to respond by SPICE_MSG_QOS_ACK right after it receives the one message that follows SPICE_MSG_QOS_QUERY. For channels that are characterized mainly by transmissions

[Spice-devel] [PATCH spice 05/11] server: spice_timer_queue

2012-04-08 Thread Yonit Halperin
Each thread can create a spice_timer_queue, for managing its own timers. Signed-off-by: Yonit Halperin --- server/Makefile.am |2 + server/spice_timer_queue.c | 245 server/spice_timer_queue.h | 41 3 files changed, 288 inserti

[Spice-devel] [PATCH spice 04/11] client: handle the new SpiceMsgDisplayStreamData (common/messages.h)

2012-04-08 Thread Yonit Halperin
SpiceMsgDisplayStreamData now contains SpiceStreamDataHeader, which is shared with SpiceMsgDisplayStreamDataSized. Signed-off-by: Yonit Halperin --- client/display_channel.cpp |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/client/display_channel.cpp b/client/displa

[Spice-devel] [PATCH spice 03/11] server: video streaming: add support for frames of different sizes

2012-04-08 Thread Yonit Halperin
When playing a youtube video on Windows guest, the driver sometimes sends images which contain the video frames, but also other parts of the screen (e.g., the youtube process bar). In order to prevent glitches, we send these images as part of the stream, using SPICE_MSG_DISPLAY_STREAM_DATA_SIZED.

[Spice-devel] [PATCH spice 02/11] server/red_worker: dump_bitmap: add surface_id to the bitmap file name

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/red_worker.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5350195..b2fa348 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1014,7 +1014,7 @@ static void c

[Spice-devel] [PATCH spice 01/11] server/red_worker: fix dump_bitmap

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- server/red_worker.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 07782c8..5350195 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -11348,10 +11348,11 @@ static void dum

[Spice-devel] [PATCH spice-common 6/6] Add qos related messages

2012-04-08 Thread Yonit Halperin
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server's channel can send SPICE_MSG_QOS_QUERY to the client. In response, the client is expected to send back SPICE_MSG_QOS_ACK immediately after it receives the message following the query, and before handling the message. The server can

[Spice-devel] [PATCH spice-common 5/6] video streaming: add support for frames of different sizes

2012-04-08 Thread Yonit Halperin
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to clients with SPICE_DISPLAY_CAP_SIZED_STREAM. Signed-off-by: Yonit Halperin --- common/messages.h | 15 ++- spice.p

[Spice-devel] [PATCH spice-common 4/6] Update spice-protocol submodule

2012-04-08 Thread Yonit Halperin
For STREAM_DATA_SIZED and QOS_QUERY messages. Signed-off-by: Yonit Halperin --- common/rect.h |2 +- spice-protocol |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/rect.h b/common/rect.h index 0e4b01e..a9c1b08 100644 --- a/common/rect.h +++ b/common/rect.h @

[Spice-devel] [PATCH spice-common 3/6] ring: add ring_add_tail

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- common/ring.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/common/ring.h b/common/ring.h index 7fba50e..7163aaa 100644 --- a/common/ring.h +++ b/common/ring.h @@ -61,6 +61,16 @@ static inline void ring_add(Ring *ring, RingIt

[Spice-devel] [PATCH spice-common 2/6] rect: add rect_get_area

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- common/rect.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/common/rect.h b/common/rect.h index 655e9e8..0e4b01e 100644 --- a/common/rect.h +++ b/common/rect.h @@ -80,6 +80,11 @@ static INLINE int rect_contains(const SpiceRec

[Spice-devel] [PATCH spice-common 1/6] rect: add rect_contains

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin --- common/rect.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/common/rect.h b/common/rect.h index a63d785..655e9e8 100644 --- a/common/rect.h +++ b/common/rect.h @@ -74,6 +74,12 @@ static INLINE int rect_is_same_size(const Spi

[Spice-devel] [PATCH spice-protocol 2/2] Add qos related messages

2012-04-08 Thread Yonit Halperin
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server's channel can send SPICE_MSG_QOS_QUERY to the client. In response, the client is expected to send back SPICE_MSG_QOS_ACK immediately after it receives the message following the query, and before handling the message. The server can

[Spice-devel] [PATCH spice-protocol 0/2] video streaming enhancements and bandwidth monitoring

2012-04-08 Thread Yonit Halperin
This patch series includes also patches for spice-common, spice, and spice-gtk. Till now, the quality of the mjpeg stream was constant (70). However, when spice used ffmpeg's mjpeg, it had employed its bit rate control, which eventually affected the stream quality. This patch series introduces:

[Spice-devel] [PATCH spice-protocol 1/2] video streaming: add support for frames of different sizes

2012-04-08 Thread Yonit Halperin
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to clients with SPICE_DISPLAY_CAP_SIZED_STREAM. When playing a youtube video on Windows guest, the driver sometimes sends images whic

Re: [Spice-devel] [spice-xpi 1/4] Move secure channel fixup to secure channel setter

2012-04-08 Thread Uri Lublin
On 04/03/2012 07:12 PM, David Jaša wrote: Hi Christophe, Christophe Fergeau píše v Út 03. 04. 2012 v 16:38 +0200: The secure channel names need to be fixed for compatibility with older spice versions. However, it's better to do it directly when m_secure_channels is set rather than waiting until

Re: [Spice-devel] [spice-xpi PATCHv2 1/2] Handle USB-related plugin properties

2012-04-08 Thread Uri Lublin
On 04/04/2012 05:29 PM, Christophe Fergeau wrote: Hey Uri, On Wed, Apr 04, 2012 at 12:33:17PM +0300, Uri Lublin wrote: The default is an empty string. How does the client behave with such a filter string? Refuse redir for all devices ? That's a good question, thanks for pointing this out. The